cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(audit): protect AuditService._ensure_session() with threading.Lock #1224

Closed
brent.edwards wants to merge 4 commits from bugfix/m7-audit-session-race into master
pull from: bugfix/m7-audit-session-race
merge into: cleveragents:master
Conversation 48 Commits 4 Files Changed 3
+22 -8

4 Commits

Author SHA1 Message Date
CleverAgents Bot af12cab9a0 ci: stop master workflow on PR updates
CI / lint (pull_request) Has been cancelled
Details
CI / typecheck (pull_request) Has been cancelled
Details
CI / security (pull_request) Has been cancelled
Details
CI / quality (pull_request) Has been cancelled
Details
CI / unit_tests (pull_request) Has been cancelled
Details
CI / integration_tests (pull_request) Has been cancelled
Details
CI / e2e_tests (pull_request) Has been cancelled
Details
CI / coverage (pull_request) Has been cancelled
Details
CI / build (pull_request) Has been cancelled
Details
CI / docker (pull_request) Has been cancelled
Details
CI / helm (pull_request) Has been cancelled
Details
CI / push-validation (pull_request) Has been cancelled
Details
CI / status-check (pull_request) Has been cancelled
Details 
Remove the stale pull_request trigger from master.yml so PR branch commits do not launch the master workflow.

Maintenance patch for PR #1224.
 2026-06-10 20:25:07 -04:00
controller-ci-rerun f4dc0746f9 chore: re-trigger CI [controller]
CI / lint (pull_request) Successful in 35s
Details
CI / build (pull_request) Successful in 34s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / typecheck (pull_request) Successful in 1m4s
Details
CI / quality (pull_request) Successful in 1m6s
Details
CI / helm (pull_request) Successful in 23s
Details
CI / security (pull_request) Successful in 1m14s
Details
CI / push-validation (pull_request) Successful in 39s
Details
CI / e2e_tests (pull_request) Successful in 3m52s
Details
CI / unit_tests (pull_request) Failing after 6m8s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / integration_tests (pull_request) Failing after 17m37s
Details
CI / status-check (pull_request) Has been cancelled
Details
2026-05-29 14:21:47 -04:00
HAL9000 290e964f46 fix(audit): protect AuditService._ensure_session() with threading.Lock
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / push-validation (pull_request) Successful in 37s
Details
CI / helm (pull_request) Successful in 45s
Details
CI / build (pull_request) Successful in 1m13s
Details
CI / lint (pull_request) Successful in 1m22s
Details
CI / quality (pull_request) Successful in 1m44s
Details
CI / typecheck (pull_request) Successful in 2m9s
Details
CI / security (pull_request) Successful in 2m15s
Details
CI / integration_tests (pull_request) Successful in 5m1s
Details
CI / e2e_tests (pull_request) Successful in 5m59s
Details
CI / unit_tests (pull_request) Failing after 7m32s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 3s
Details 
Document pre-existing type: ignore suppressions in _row_to_entry() with
reference to follow-up tracking issue #10854.

ISSUES CLOSED: #991
 2026-04-29 21:26:34 +00:00
HAL9000 9a3ad6da66 fix(audit): protect AuditService._ensure_session() with threading.Lock 
Rebased onto current master and re-applied the threading.Lock fix to the
updated version of _ensure_session() introduced by the async write-behind
refactor (#1279). The fix is now more critical because the background
audit-writer thread calls _ensure_session() via _write_payload(), making
the TOCTOU race actively exploitable rather than theoretical.

Changes:
- Added self._session_lock = threading.Lock() to __init__()
- Wrapped _ensure_session() session creation with double-checked locking
- Updated step file to use audit_async=False to avoid background thread
  interference with the race test
- Resolved import conflict (kept both import queue and import threading)

ISSUES CLOSED: #991
 2026-04-29 21:26:34 +00:00