cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(invariant): persist standalone invariants to database #1202

Closed
brent.edwards wants to merge 2 commits from bugfix/m4-invariant-persistence into master
pull from: bugfix/m4-invariant-persistence
merge into: cleveragents:master
Conversation 41 Commits 2 Files Changed 19
+538 -146

2 Commits

Author SHA1 Message Date
HAL9000 66a6fb2402 fix(changeset): ensure database commits are persisted in repository methods
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 20s
Details
CI / helm (pull_request) Successful in 22s
Details
CI / lint (pull_request) Successful in 3m19s
Details
CI / quality (pull_request) Successful in 3m43s
Details
CI / typecheck (pull_request) Successful in 3m58s
Details
CI / security (pull_request) Successful in 4m9s
Details
CI / unit_tests (pull_request) Successful in 7m53s
Details
CI / docker (pull_request) Successful in 1m29s
Details
CI / coverage (pull_request) Successful in 7m19s
Details
CI / e2e_tests (pull_request) Successful in 11m26s
Details
CI / integration_tests (pull_request) Successful in 15m5s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / benchmark-regression (pull_request) Successful in 52m13s
Details 
The ChangeSetEntryRepository and ToolInvocationRepository methods were only
calling session.flush() but not session.commit(), which meant changes were
not persisted to the database. This caused the SqliteChangeSetStore round-trip
test to fail because data was not visible across different session instances.

Added session.commit() calls after session.flush() in:
- ChangeSetEntryRepository.save_entry()
- ChangeSetEntryRepository.delete_for_changeset()
- ChangeSetEntryRepository.delete_for_plan()
- ToolInvocationRepository.save_invocation()
- ToolInvocationRepository.delete_for_plan()

This ensures that all database operations are properly committed and visible
to subsequent queries.

ISSUES CLOSED: #1022
 2026-04-14 23:01:19 +00:00
brent.edwards 00e8046f7b fix(invariant): persist standalone invariants to database
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 18s
Details
CI / helm (pull_request) Successful in 21s
Details
CI / quality (pull_request) Successful in 42s
Details
CI / lint (pull_request) Successful in 3m18s
Details
CI / typecheck (pull_request) Successful in 3m55s
Details
CI / security (pull_request) Successful in 4m7s
Details
CI / unit_tests (pull_request) Successful in 4m8s
Details
CI / docker (pull_request) Successful in 23s
Details
CI / e2e_tests (pull_request) Successful in 9m19s
Details
CI / integration_tests (pull_request) Failing after 11m13s
Details
CI / coverage (pull_request) Successful in 8m31s
Details
CI / status-check (pull_request) Failing after 1s
Details
CI / benchmark-regression (pull_request) Successful in 58m44s
Details 
Add a standalone invariants persistence path (ORM model, migration, repository, and UoW wiring) so CLI-added invariants survive process restarts. Refactor InvariantService and invariant CLI service resolution to use DI-backed UnitOfWork persistence while retaining in-memory fallback behavior for compatibility tests.

Update Behave and Robot TDD coverage for cross-invocation add/list/remove semantics, remove the #1022 expected-fail inversion, and align M3 verification helpers with persisted behavior.

ISSUES CLOSED: #1022
 2026-03-30 12:49:35 +00:00