fix(cli): plan correct active-plan resolution in isolated environments #1184

Merged
brent.edwards merged 3 commits from fix/plan-correct-resolve into master 2026-03-31 01:49:16 +00:00

3 Commits

Author SHA1 Message Date
brent.edwards 9dae67737e fix(cli): use container DI override for correction service mock in integration test
CI / benchmark-publish (pull_request) Has been skipped
CI / build (pull_request) Successful in 21s
CI / helm (pull_request) Successful in 23s
CI / typecheck (pull_request) Successful in 47s
CI / lint (pull_request) Successful in 3m20s
CI / quality (pull_request) Successful in 3m55s
CI / security (pull_request) Successful in 4m8s
CI / unit_tests (pull_request) Successful in 6m19s
CI / docker (pull_request) Successful in 12s
CI / integration_tests (pull_request) Successful in 9m11s
CI / coverage (pull_request) Successful in 13m11s
CI / e2e_tests (pull_request) Successful in 20m10s
CI / status-check (pull_request) Successful in 2s
CI / benchmark-regression (pull_request) Successful in 55m31s
The plan_correct_isolated_resolve robot helper patched CorrectionService
at the module level, but correct_decision now resolves the service via
container.correction_service(). The module-level patch had no effect on
the container's already-imported reference, causing the mock to never
intercept the call and the test to fail with exit code 1.

Replace unittest.mock.patch with container.correction_service.override()
which is the idiomatic dependency-injector mechanism and correctly
intercepts the singleton provider.

ISSUES CLOSED: #1025
2026-03-31 01:28:15 +00:00
brent.edwards b00264ed3f Merge branch 'master' into fix/plan-correct-resolve
CI / benchmark-publish (pull_request) Has been skipped
CI / build (pull_request) Successful in 21s
CI / helm (pull_request) Successful in 23s
CI / lint (pull_request) Successful in 3m20s
CI / quality (pull_request) Successful in 3m43s
CI / integration_tests (pull_request) Failing after 3m49s
CI / typecheck (pull_request) Successful in 3m57s
CI / unit_tests (pull_request) Successful in 4m13s
CI / security (pull_request) Successful in 4m18s
CI / docker (pull_request) Successful in 1m21s
CI / coverage (pull_request) Successful in 12m4s
CI / e2e_tests (pull_request) Successful in 20m33s
CI / status-check (pull_request) Failing after 1s
CI / benchmark-regression (pull_request) Has been cancelled
2026-03-31 00:33:38 +00:00
brent.edwards a48410547b fix(cli): plan correct active-plan resolution in isolated environments
CI / lint (pull_request) Successful in 25s
CI / typecheck (pull_request) Successful in 50s
CI / security (pull_request) Successful in 55s
CI / build (pull_request) Successful in 18s
CI / helm (pull_request) Successful in 34s
CI / quality (pull_request) Successful in 3m45s
CI / unit_tests (pull_request) Successful in 4m16s
CI / integration_tests (pull_request) Successful in 4m22s
CI / benchmark-publish (pull_request) Has been skipped
CI / docker (pull_request) Successful in 1m20s
CI / e2e_tests (pull_request) Successful in 9m23s
CI / coverage (pull_request) Successful in 12m32s
CI / status-check (pull_request) Successful in 2s
CI / benchmark-regression (pull_request) Successful in 58m4s
Add a CLEVERAGENTS_HOME fallback in _resolve_active_plan_id() so isolated subprocess invocations can resolve the active non-terminal plan even when CWD differs from persistent storage. This keeps the existing primary lookup path intact, only falling back when needed, and adds a Robot regression helper/suite that reproduces and verifies the isolated environment behavior without requiring --plan.

ISSUES CLOSED: #1025
2026-03-30 00:07:43 +00:00