cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

docs: align ASCII UI tables in specification and related pages #1131

Merged
freemo merged 1 commits from docs/ascii-table-alignment into master 2026-04-03 04:55:22 +00:00
Conversation 17 Commits 1 Files Changed 15
+454 -439
eugen.thaci commented 2026-03-23 11:59:33 +00:00
Member
Copy Link
Copy Source

Summary

Aligns Unicode box-drawing “terminal UI” blocks and related Markdown tables in docs/specification.md, ADR-044/045/046, and the reference pages changed in this branch so borders and columns render consistently in the MkDocs site. Documentation-only; no API or runtime behavior changes.

Closes #1171

Type of Change

  • Documentation update

Quality checklist (docs-only)

Most code-quality items are N/A. CI should still pass for the repo default checks.

Testing

Manual: built or served docs locally and verified affected pages in the browser.

Related issues

Notes for reviewers

  • Addresses process feedback: description, issue link, milestone, Type/Task label, and commit footer ISSUES CLOSED: #1171 (see latest push).
  • Trailing whitespace in docs/reference/acms_fusion.md addressed.
  • a2a.md TOC scope handled per discussion (reverted / split / or noted here — pick one).
## Summary Aligns Unicode box-drawing “terminal UI” blocks and related Markdown tables in `docs/specification.md`, ADR-044/045/046, and the reference pages changed in this branch so borders and columns render consistently in the MkDocs site. Documentation-only; no API or runtime behavior changes. **Closes #1171** ## Type of Change - [x] Documentation update ## Quality checklist (docs-only) Most code-quality items are N/A. CI should still pass for the repo default checks. ## Testing Manual: built or served docs locally and verified affected pages in the browser. ## Related issues - Closes #1171 ## Notes for reviewers - Addresses process feedback: description, issue link, milestone, `Type/Task` label, and commit footer `ISSUES CLOSED: #1171` (see latest push). - Trailing whitespace in `docs/reference/acms_fusion.md` addressed. - `a2a.md` TOC scope handled per discussion (reverted / split / or noted here — **pick one**).
freemo was assigned by eugen.thaci 2026-03-23 11:59:57 +00:00
freemo requested changes 2026-03-24 15:24:23 +00:00
Dismissed
freemo left a comment
Owner
Copy Link
Copy Source

Review: REQUEST CHANGES

This is a reasonable docs-only formatting cleanup that improves readability of ASCII diagrams and markdown tables. However, the PR has significant process compliance gaps that must be addressed before it can be reviewed or merged.

Blocking Issues

  1. Empty PR description. The PR body uses the template but is entirely unfilled — no description summary, no type-of-change checkbox checked, no quality checklist items checked. Per CONTRIBUTING.md §Pull Request Process requirement #1: "PRs submitted without a description or without an issue reference will not be reviewed."

  2. No issue reference. There is no Closes #X / Fixes #X keyword anywhere in the PR body or commit message footer. Per CONTRIBUTING.md, if no issue exists for the work, one must be created first. Every PR must include a closing keyword for its linked issue.

  3. No milestone assigned. Per CONTRIBUTING.md requirement #11: "A PR without a milestone will not be reviewed." Please assign this to the appropriate milestone.

  4. No labels. Per CONTRIBUTING.md requirement #12, every PR must carry exactly one Type/ label. This should have Type/Task (documentation update).

  5. No commit message footer. The commit message has no ISSUES CLOSED: or Refs: footer referencing a ticket. Per CONTRIBUTING.md requirement #4: "Every commit in the PR must reference the issue it addresses in its commit message footer."

Minor Issues

  1. Trailing whitespace in docs/reference/acms_fusion.md line 37. This will likely fail pre-commit lint checks.

  2. Scope creep in a2a.md. The expanded table of contents (from flat to fully nested, 12 → 28 entries) is a structural documentation change, not just "ASCII table alignment." While harmless, it's a different concern than what the commit message describes. Per CONTRIBUTING.md §Atomic Commits: "Do not mix concerns."

Action Items

  • Create an issue for this work (or link to an existing one)
  • Fill in the PR description with a summary and issue reference
  • Assign a milestone
  • Add Type/Task label
  • Add ISSUES CLOSED: #<N> footer to the commit message
  • Fix trailing whitespace in acms_fusion.md
  • Consider splitting the a2a.md TOC change into a separate commit
## Review: REQUEST CHANGES This is a reasonable docs-only formatting cleanup that improves readability of ASCII diagrams and markdown tables. However, the PR has **significant process compliance gaps** that must be addressed before it can be reviewed or merged. ### Blocking Issues 1. **Empty PR description.** The PR body uses the template but is entirely unfilled — no description summary, no type-of-change checkbox checked, no quality checklist items checked. Per CONTRIBUTING.md §Pull Request Process requirement #1: *"PRs submitted without a description or without an issue reference will not be reviewed."* 2. **No issue reference.** There is no `Closes #X` / `Fixes #X` keyword anywhere in the PR body or commit message footer. Per CONTRIBUTING.md, if no issue exists for the work, one must be created first. Every PR must include a closing keyword for its linked issue. 3. **No milestone assigned.** Per CONTRIBUTING.md requirement #11: *"A PR without a milestone will not be reviewed."* Please assign this to the appropriate milestone. 4. **No labels.** Per CONTRIBUTING.md requirement #12, every PR must carry exactly one `Type/` label. This should have `Type/Task` (documentation update). 5. **No commit message footer.** The commit message has no `ISSUES CLOSED:` or `Refs:` footer referencing a ticket. Per CONTRIBUTING.md requirement #4: *"Every commit in the PR must reference the issue it addresses in its commit message footer."* ### Minor Issues 6. **Trailing whitespace** in `docs/reference/acms_fusion.md` line 37. This will likely fail pre-commit lint checks. 7. **Scope creep in `a2a.md`.** The expanded table of contents (from flat to fully nested, 12 → 28 entries) is a structural documentation change, not just "ASCII table alignment." While harmless, it's a different concern than what the commit message describes. Per CONTRIBUTING.md §Atomic Commits: *"Do not mix concerns."* ### Action Items - [ ] Create an issue for this work (or link to an existing one) - [ ] Fill in the PR description with a summary and issue reference - [ ] Assign a milestone - [ ] Add `Type/Task` label - [ ] Add `ISSUES CLOSED: #<N>` footer to the commit message - [ ] Fix trailing whitespace in `acms_fusion.md` - [ ] Consider splitting the `a2a.md` TOC change into a separate commit
eugen.thaci added this to the v3.6.0 milestone 2026-03-27 14:02:01 +00:00
eugen.thaci added the
Type
Task
 label 2026-03-27 14:02:22 +00:00
eugen.thaci added the
State
In Review
 label 2026-03-27 14:04:02 +00:00
eugen.thaci marked the pull request as work in progress 2026-03-27 14:04:22 +00:00
eugen.thaci force-pushed docs/ascii-table-alignment from 60f3e93a8b to d68e5a013d 2026-03-27 14:17:00 +00:00 Compare
eugen.thaci marked the pull request as ready for review 2026-03-27 14:19:24 +00:00
freemo approved these changes 2026-03-27 17:13:08 +00:00
Dismissed
freemo left a comment
Owner
Copy Link
Copy Source

Review: docs: align ASCII UI tables in specification and related pages

Approved. Docs-only cosmetic PR improving ASCII table readability across 15 files. No code changes, no risk. Clean conventional commit format.

## Review: docs: align ASCII UI tables in specification and related pages **Approved.** Docs-only cosmetic PR improving ASCII table readability across 15 files. No code changes, no risk. Clean conventional commit format.
freemo force-pushed docs/ascii-table-alignment from d68e5a013d to 259aaf1cb6 2026-04-02 07:01:58 +00:00 Compare
freemo dismissed freemo's review 2026-04-02 07:01:58 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

freemo approved these changes 2026-04-02 07:02:14 +00:00
freemo left a comment
Owner
Copy Link
Copy Source

Review: APPROVED (post-rebase)

Re-approving after rebase onto current master. The docs-only commit is unchanged — aligns ASCII/Unicode box-drawing tables and Markdown tables across docs/specification.md, ADR-044/045/046, and reference pages for consistent MkDocs rendering.

  • Lint passes (nox -e lint ✅)
  • Typecheck passes (nox -e typecheck ✅)
  • No code changes, no runtime risk
  • Commit message follows conventional commits format with ISSUES CLOSED: #1171 footer
  • PR description has Closes #1171, milestone v3.6.0, and Type/Task label

Ready to merge.

## Review: APPROVED (post-rebase) Re-approving after rebase onto current master. The docs-only commit is unchanged — aligns ASCII/Unicode box-drawing tables and Markdown tables across `docs/specification.md`, ADR-044/045/046, and reference pages for consistent MkDocs rendering. - Lint passes (`nox -e lint` ✅) - Typecheck passes (`nox -e typecheck` ✅) - No code changes, no runtime risk - Commit message follows conventional commits format with `ISSUES CLOSED: #1171` footer - PR description has `Closes #1171`, milestone v3.6.0, and `Type/Task` label Ready to merge.
freemo commented 2026-04-02 18:13:55 +00:00
Owner
Copy Link
Copy Source

Review claimed by reviewer pool instance pr-reviewer-pool-2813550-1775153400. Dispatching independent code review.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

Review claimed by reviewer pool instance pr-reviewer-pool-2813550-1775153400. Dispatching independent code review. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo requested changes 2026-04-02 18:17:39 +00:00
freemo left a comment
Owner
Copy Link
Copy Source

Independent Review: REQUEST CHANGES

This is a docs-only cosmetic PR aligning Unicode box-drawing blocks and Markdown tables across 15 files. The intent is good and the vast majority of changes are correct whitespace alignment fixes. However, I found two rendering bugs introduced by this PR that must be fixed before merge.

Process Compliance ✅

  • Conventional commit format: docs(spec): align ASCII UI tables... ✅
  • Issue link: Closes #1171 in PR body ✅
  • Commit footer: ISSUES CLOSED: #1171 ✅
  • Milestone: v3.6.0 ✅
  • Label: Type/Task ✅
  • Single atomic commit ✅

Bugs Found 🐛

1. docs/reference/acms_fusion.md line 37 — Two lines merged into one (CRITICAL)

The Budget Overage Guard box-drawing diagram has two lines concatenated onto a single line. The closing │ │ of the inner box and the └──...┘ line got merged, breaking the ASCII diagram structure entirely.

Current (broken):

│  │  Drop lowest-relevance fragments if over budget  │  ││  └──────────────────────────────────────────────────┘  │

Expected (two separate lines):

│  │  Drop lowest-relevance fragments if over budget  │  │
│  └──────────────────────────────────────────────────┘  │

2. docs/specification.md line 7956 — Stray ─ character appended

A box-drawing character ─ was accidentally appended to the "Validation removed" status text.

Current (broken): ✓ OK Validation removed─
Expected: ✓ OK Validation removed

Everything Else ✅

The remaining ~890 lines of changes across all 15 files are correct whitespace alignment adjustments. The ADR diagrams, reference table columns, and specification box-drawing blocks all look properly aligned after the changes.

Action Items

  • Fix docs/reference/acms_fusion.md line 37: split the merged line back into two lines
  • Fix docs/specification.md line 7956: remove the stray ─ character after "Validation removed"

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Independent Review: REQUEST CHANGES This is a docs-only cosmetic PR aligning Unicode box-drawing blocks and Markdown tables across 15 files. The intent is good and the vast majority of changes are correct whitespace alignment fixes. However, I found **two rendering bugs introduced by this PR** that must be fixed before merge. ### Process Compliance ✅ - Conventional commit format: `docs(spec): align ASCII UI tables...` ✅ - Issue link: `Closes #1171` in PR body ✅ - Commit footer: `ISSUES CLOSED: #1171` ✅ - Milestone: v3.6.0 ✅ - Label: `Type/Task` ✅ - Single atomic commit ✅ ### Bugs Found 🐛 #### 1. `docs/reference/acms_fusion.md` line 37 — Two lines merged into one (CRITICAL) The Budget Overage Guard box-drawing diagram has two lines concatenated onto a single line. The closing `│ │` of the inner box and the `└──...┘` line got merged, breaking the ASCII diagram structure entirely. **Current (broken):** ``` │ │ Drop lowest-relevance fragments if over budget │ ││ └──────────────────────────────────────────────────┘ │ ``` **Expected (two separate lines):** ``` │ │ Drop lowest-relevance fragments if over budget │ │ │ └──────────────────────────────────────────────────┘ │ ``` #### 2. `docs/specification.md` line 7956 — Stray `─` character appended A box-drawing character `─` was accidentally appended to the "Validation removed" status text. **Current (broken):** `✓ OK Validation removed─` **Expected:** `✓ OK Validation removed` ### Everything Else ✅ The remaining ~890 lines of changes across all 15 files are correct whitespace alignment adjustments. The ADR diagrams, reference table columns, and specification box-drawing blocks all look properly aligned after the changes. ### Action Items - [ ] Fix `docs/reference/acms_fusion.md` line 37: split the merged line back into two lines - [ ] Fix `docs/specification.md` line 7956: remove the stray `─` character after "Validation removed" --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
docs/reference/acms_fusion.md
@@ -40,0 +34,4 @@
│ fuse() │
│ ┌──────────────────────────────────────────────────┐ │
│ │ Budget Overage Guard │ │
│ │ Drop lowest-relevance fragments if over budget │ ││ └──────────────────────────────────────────────────┘ │
freemo commented 2026-04-02 18:17:39 +00:00
Owner
Copy Link
Copy Source

Bug: Two lines have been merged into one here, breaking the ASCII diagram. The │ │ closing the inner box and the └──...┘ line are concatenated.

Current:

│  │  Drop lowest-relevance fragments if over budget  │  ││  └──────────────────────────────────────────────────┘  │

Should be two separate lines:

│  │  Drop lowest-relevance fragments if over budget  │  │
│  └──────────────────────────────────────────────────┘  │
**Bug:** Two lines have been merged into one here, breaking the ASCII diagram. The `│ │` closing the inner box and the `└──...┘` line are concatenated. **Current:** ``` │ │ Drop lowest-relevance fragments if over budget │ ││ └──────────────────────────────────────────────────┘ │ ``` **Should be two separate lines:** ``` │ │ Drop lowest-relevance fragments if over budget │ │ │ └──────────────────────────────────────────────────┘ │ ```
docs/specification.md
@@ -7955,2 +7954,3 @@
╰────────────────────────────────────────────────────────────╯
<span style="color: #66cc66; font-weight: 600;">✓ OK</span> Validation removed
<span style="color: #66cc66; font-weight: 600;">✓ OK</span> Validation removed─
freemo commented 2026-04-02 18:17:39 +00:00
Owner
Copy Link
Copy Source

Bug: A stray box-drawing character ─ was appended to the status text. The original line was ✓ OK Validation removed (no trailing dash). Please remove the trailing ─.

**Bug:** A stray box-drawing character `─` was appended to the status text. The original line was `✓ OK Validation removed` (no trailing dash). Please remove the trailing `─`.
freemo commented 2026-04-02 19:01:58 +00:00
Owner
Copy Link
Copy Source

Review claimed by reviewer pool instance pr-reviewer-pool-2988182-1775156309. Dispatching independent code review.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

Review claimed by reviewer pool instance pr-reviewer-pool-2988182-1775156309. Dispatching independent code review. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo requested changes 2026-04-02 19:05:10 +00:00
freemo left a comment
Owner
Copy Link
Copy Source

Independent Review: REQUEST CHANGES

This is a docs-only cosmetic PR aligning Unicode box-drawing blocks and Markdown tables across 15 files for consistent MkDocs rendering. The intent is sound and the vast majority of changes (whitespace alignment of table columns and box borders) are correct.

Process Compliance ✅

  • Conventional commit format: docs(spec): align ASCII UI tables... ✅
  • Issue link: Closes #1171 in PR body ✅
  • Commit footer: ISSUES CLOSED: #1171 ✅
  • Milestone: v3.6.0 ✅
  • Label: Type/Task ✅
  • Single atomic commit ✅
  • Branch name matches issue metadata ✅

Bugs Found 🐛

Two rendering bugs were introduced by this PR that must be fixed before merge. These are the same issues identified in the previous review (#3232) and remain unresolved on the current HEAD (259aaf1c).

Bug 1: docs/reference/acms_fusion.md — Two lines merged into one (CRITICAL)

In the Budget Overage Guard box-drawing diagram, two lines have been concatenated onto a single line, completely breaking the ASCII art structure. The │ │ closing border and the └──...┘ bottom border are on the same line.

Current (broken):

│  │  Drop lowest-relevance fragments if over budget  │  ││  └──────────────────────────────────────────────────┘  │

Expected (two separate lines):

│  │  Drop lowest-relevance fragments if over budget  │  │
│  └──────────────────────────────────────────────────┘  │

Bug 2: docs/specification.md — Stray ─ character appended

A box-drawing horizontal line character ─ was accidentally appended to the "Validation removed" status text in the tool remove command output example.

Current (broken): ✓ OK Validation removed─
Expected: ✓ OK Validation removed

Everything Else ✅

The remaining changes across all 15 files are correct whitespace alignment adjustments:

  • ADR-044/045/046 box-drawing diagrams: properly aligned ✅
  • a2a.md table columns and expanded TOC: correct ✅
  • cli_system_commands.md, context_indexing.md, context_strategies.md: correct ✅
  • decision_model.md, devcontainer_resources.md, error_handling.md: correct ✅
  • resource_type_inheritance.md, semantic_validation.md, temporal_data_model.md: correct ✅
  • specification.md (aside from Bug 2): hundreds of alignment fixes all look correct ✅

Action Items

  • Fix docs/reference/acms_fusion.md: split the merged line back into two separate lines in the Budget Overage Guard diagram
  • Fix docs/specification.md: remove the stray ─ character after "Validation removed"

These are rendering bugs that directly contradict the purpose of this PR (improving rendering). Once fixed, this PR is ready to merge.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Independent Review: REQUEST CHANGES This is a docs-only cosmetic PR aligning Unicode box-drawing blocks and Markdown tables across 15 files for consistent MkDocs rendering. The intent is sound and the vast majority of changes (whitespace alignment of table columns and box borders) are correct. ### Process Compliance ✅ - Conventional commit format: `docs(spec): align ASCII UI tables...` ✅ - Issue link: `Closes #1171` in PR body ✅ - Commit footer: `ISSUES CLOSED: #1171` ✅ - Milestone: v3.6.0 ✅ - Label: `Type/Task` ✅ - Single atomic commit ✅ - Branch name matches issue metadata ✅ ### Bugs Found 🐛 Two rendering bugs were introduced by this PR that must be fixed before merge. These are the same issues identified in the previous review (#3232) and remain unresolved on the current HEAD (259aaf1c). #### Bug 1: `docs/reference/acms_fusion.md` — Two lines merged into one (CRITICAL) In the Budget Overage Guard box-drawing diagram, two lines have been concatenated onto a single line, completely breaking the ASCII art structure. The `│ │` closing border and the `└──...┘` bottom border are on the same line. **Current (broken):** ``` │ │ Drop lowest-relevance fragments if over budget │ ││ └──────────────────────────────────────────────────┘ │ ``` **Expected (two separate lines):** ``` │ │ Drop lowest-relevance fragments if over budget │ │ │ └──────────────────────────────────────────────────┘ │ ``` #### Bug 2: `docs/specification.md` — Stray `─` character appended A box-drawing horizontal line character `─` was accidentally appended to the "Validation removed" status text in the tool remove command output example. **Current (broken):** `✓ OK Validation removed─` **Expected:** `✓ OK Validation removed` ### Everything Else ✅ The remaining changes across all 15 files are correct whitespace alignment adjustments: - ADR-044/045/046 box-drawing diagrams: properly aligned ✅ - `a2a.md` table columns and expanded TOC: correct ✅ - `cli_system_commands.md`, `context_indexing.md`, `context_strategies.md`: correct ✅ - `decision_model.md`, `devcontainer_resources.md`, `error_handling.md`: correct ✅ - `resource_type_inheritance.md`, `semantic_validation.md`, `temporal_data_model.md`: correct ✅ - `specification.md` (aside from Bug 2): hundreds of alignment fixes all look correct ✅ ### Action Items - [ ] Fix `docs/reference/acms_fusion.md`: split the merged line back into two separate lines in the Budget Overage Guard diagram - [ ] Fix `docs/specification.md`: remove the stray `─` character after "Validation removed" These are rendering bugs that directly contradict the purpose of this PR (improving rendering). Once fixed, this PR is ready to merge. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
docs/reference/acms_fusion.md
@@ -40,0 +34,4 @@
│ fuse() │
│ ┌──────────────────────────────────────────────────┐ │
│ │ Budget Overage Guard │ │
│ │ Drop lowest-relevance fragments if over budget │ ││ └──────────────────────────────────────────────────┘ │
freemo commented 2026-04-02 19:05:10 +00:00
Owner
Copy Link
Copy Source

Bug: Two lines have been merged into one here. The closing │ │ of the inner box and the └──...┘ bottom border are concatenated on a single line, breaking the ASCII diagram.

Current (broken):

│  │  Drop lowest-relevance fragments if over budget  │  ││  └──────────────────────────────────────────────────┘  │

Expected (two separate lines):

│  │  Drop lowest-relevance fragments if over budget  │  │
│  └──────────────────────────────────────────────────┘  │
**Bug:** Two lines have been merged into one here. The closing `│ │` of the inner box and the `└──...┘` bottom border are concatenated on a single line, breaking the ASCII diagram. **Current (broken):** ``` │ │ Drop lowest-relevance fragments if over budget │ ││ └──────────────────────────────────────────────────┘ │ ``` **Expected (two separate lines):** ``` │ │ Drop lowest-relevance fragments if over budget │ │ │ └──────────────────────────────────────────────────┘ │ ```
docs/specification.md
@@ -7955,2 +7954,3 @@
╰────────────────────────────────────────────────────────────╯
<span style="color: #66cc66; font-weight: 600;">✓ OK</span> Validation removed
<span style="color: #66cc66; font-weight: 600;">✓ OK</span> Validation removed─
freemo commented 2026-04-02 19:05:10 +00:00
Owner
Copy Link
Copy Source

Bug: A stray box-drawing character ─ was accidentally appended to the "Validation removed" text.

Current: ✓ OK Validation removed─
Expected: ✓ OK Validation removed

**Bug:** A stray box-drawing character `─` was accidentally appended to the "Validation removed" text. **Current:** `✓ OK Validation removed─` **Expected:** `✓ OK Validation removed`
freemo added the
Priority
Medium
 label 2026-04-02 19:29:41 +00:00
freemo commented 2026-04-02 19:33:46 +00:00
Owner
Copy Link
Copy Source

Review claimed by reviewer pool instance pr-reviewer-pool-3151342-1775157992. Dispatching independent code review.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

Review claimed by reviewer pool instance pr-reviewer-pool-3151342-1775157992. Dispatching independent code review. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo commented 2026-04-02 19:48:02 +00:00
Owner
Copy Link
Copy Source

Review claimed by reviewer pool instance pr-reviewer-pool-3151342-1775157992. Dispatching independent code review.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

Review claimed by reviewer pool instance pr-reviewer-pool-3151342-1775157992. Dispatching independent code review. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo commented 2026-04-02 23:04:53 +00:00
Owner
Copy Link
Copy Source

Review claimed by reviewer pool instance pr-reviewer-pool-3983434-1775170710. Dispatching independent code review.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

Review claimed by reviewer pool instance pr-reviewer-pool-3983434-1775170710. Dispatching independent code review. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo requested changes 2026-04-03 01:24:53 +00:00
freemo left a comment
Owner
Copy Link
Copy Source

Independent Review: REQUEST CHANGES

This is a docs-only cosmetic PR aligning Unicode box-drawing blocks and Markdown tables across 15 files for consistent MkDocs rendering. The intent is good and the vast majority of changes are correct whitespace alignment fixes.

Process Compliance ✅

  • Conventional commit format: docs(spec): align ASCII UI tables... ✅
  • Issue link: Closes #1171 in PR body ✅
  • Commit footer: ISSUES CLOSED: #1171 ✅
  • Milestone: v3.6.0 ✅
  • Label: Type/Task ✅
  • Single atomic commit ✅
  • Branch name docs/ascii-table-alignment matches issue metadata ✅
  • Docs-only changes (15 files, no code) ✅

Outstanding Bugs 🐛

Two rendering bugs introduced by this PR were identified in previous reviews (#3232, #3262) and remain unfixed on the current HEAD (259aaf1c). These directly contradict the purpose of this PR.

Bug 1: docs/reference/acms_fusion.md line 37 — Two lines merged into one (CRITICAL)

In the Budget Overage Guard box-drawing diagram, two lines have been concatenated onto a single line, completely breaking the ASCII art structure:

Current (broken):

│  │  Drop lowest-relevance fragments if over budget  │  ││  └──────────────────────────────────────────────────┘  │

Expected (two separate lines):

│  │  Drop lowest-relevance fragments if over budget  │  │
│  └──────────────────────────────────────────────────┘  │

The │ │ closing border of the inner box and the │ └──...┘ │ bottom border got concatenated. This is visible in the diff where the original two lines (37-38) became one.

Bug 2: docs/specification.md line 7956 — Stray ─ character appended

A box-drawing horizontal line character ─ was accidentally appended to the "Validation removed" status text:

Current (broken): ✓ OK Validation removed─
Expected: ✓ OK Validation removed

The diff clearly shows this was introduced: -Validation removed → +Validation removed─

Everything Else ✅

The remaining changes across all 15 files are correct whitespace alignment adjustments:

  • ADR-044/045/046 box-drawing diagrams: properly aligned ✅
  • a2a.md table columns and expanded TOC: correct ✅
  • cli_system_commands.md, context_indexing.md, context_strategies.md: correct ✅
  • decision_model.md, devcontainer_resources.md, error_handling.md: correct ✅
  • resource_type_inheritance.md, semantic_validation.md, temporal_data_model.md: correct ✅
  • specification.md (aside from Bug 2): hundreds of alignment fixes all look correct ✅

Action Items

  • Fix docs/reference/acms_fusion.md line 37: split the merged line back into two separate lines in the Budget Overage Guard diagram
  • Fix docs/specification.md line 7956: remove the stray ─ character after "Validation removed"

These are rendering bugs that directly contradict the purpose of this PR (improving rendering). Once fixed, this PR is ready to merge.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Independent Review: REQUEST CHANGES This is a docs-only cosmetic PR aligning Unicode box-drawing blocks and Markdown tables across 15 files for consistent MkDocs rendering. The intent is good and the vast majority of changes are correct whitespace alignment fixes. ### Process Compliance ✅ - Conventional commit format: `docs(spec): align ASCII UI tables...` ✅ - Issue link: `Closes #1171` in PR body ✅ - Commit footer: `ISSUES CLOSED: #1171` ✅ - Milestone: v3.6.0 ✅ - Label: `Type/Task` ✅ - Single atomic commit ✅ - Branch name `docs/ascii-table-alignment` matches issue metadata ✅ - Docs-only changes (15 files, no code) ✅ ### Outstanding Bugs 🐛 Two rendering bugs introduced by this PR were identified in previous reviews (#3232, #3262) and **remain unfixed** on the current HEAD (`259aaf1c`). These directly contradict the purpose of this PR. #### Bug 1: `docs/reference/acms_fusion.md` line 37 — Two lines merged into one (CRITICAL) In the Budget Overage Guard box-drawing diagram, two lines have been concatenated onto a single line, completely breaking the ASCII art structure: **Current (broken):** ``` │ │ Drop lowest-relevance fragments if over budget │ ││ └──────────────────────────────────────────────────┘ │ ``` **Expected (two separate lines):** ``` │ │ Drop lowest-relevance fragments if over budget │ │ │ └──────────────────────────────────────────────────┘ │ ``` The `│ │` closing border of the inner box and the `│ └──...┘ │` bottom border got concatenated. This is visible in the diff where the original two lines (37-38) became one. #### Bug 2: `docs/specification.md` line 7956 — Stray `─` character appended A box-drawing horizontal line character `─` was accidentally appended to the "Validation removed" status text: **Current (broken):** `✓ OK Validation removed─` **Expected:** `✓ OK Validation removed` The diff clearly shows this was introduced: `-Validation removed` → `+Validation removed─` ### Everything Else ✅ The remaining changes across all 15 files are correct whitespace alignment adjustments: - ADR-044/045/046 box-drawing diagrams: properly aligned ✅ - `a2a.md` table columns and expanded TOC: correct ✅ - `cli_system_commands.md`, `context_indexing.md`, `context_strategies.md`: correct ✅ - `decision_model.md`, `devcontainer_resources.md`, `error_handling.md`: correct ✅ - `resource_type_inheritance.md`, `semantic_validation.md`, `temporal_data_model.md`: correct ✅ - `specification.md` (aside from Bug 2): hundreds of alignment fixes all look correct ✅ ### Action Items - [ ] Fix `docs/reference/acms_fusion.md` line 37: split the merged line back into two separate lines in the Budget Overage Guard diagram - [ ] Fix `docs/specification.md` line 7956: remove the stray `─` character after "Validation removed" These are rendering bugs that directly contradict the purpose of this PR (improving rendering). Once fixed, this PR is ready to merge. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
docs/reference/acms_fusion.md
@@ -40,0 +34,4 @@
│ fuse() │
│ ┌──────────────────────────────────────────────────┐ │
│ │ Budget Overage Guard │ │
│ │ Drop lowest-relevance fragments if over budget │ ││ └──────────────────────────────────────────────────┘ │
freemo commented 2026-04-03 01:24:53 +00:00
Owner
Copy Link
Copy Source

Bug: Two lines merged into one. This line contains both the inner box closing border (│ │) and the outer box bottom border (│ └──...┘ │) concatenated together. These must be on separate lines:

│  │  Drop lowest-relevance fragments if over budget  │  │
│  └──────────────────────────────────────────────────┘  │

The original file had these as two separate lines (37-38). The alignment edit accidentally merged them.

**Bug: Two lines merged into one.** This line contains both the inner box closing border (`│ │`) and the outer box bottom border (`│ └──...┘ │`) concatenated together. These must be on separate lines: ``` │ │ Drop lowest-relevance fragments if over budget │ │ │ └──────────────────────────────────────────────────┘ │ ``` The original file had these as two separate lines (37-38). The alignment edit accidentally merged them.
docs/specification.md
@@ -7955,2 +7954,3 @@
╰────────────────────────────────────────────────────────────╯
<span style="color: #66cc66; font-weight: 600;">✓ OK</span> Validation removed
<span style="color: #66cc66; font-weight: 600;">✓ OK</span> Validation removed─
freemo commented 2026-04-03 01:24:53 +00:00
Owner
Copy Link
Copy Source

Bug: Stray ─ character appended. A box-drawing horizontal line character ─ was accidentally added after "Validation removed". Remove the trailing ─ to restore the correct text:

✓ OK Validation removed
**Bug: Stray `─` character appended.** A box-drawing horizontal line character `─` was accidentally added after "Validation removed". Remove the trailing `─` to restore the correct text: ``` ✓ OK Validation removed ```
freemo commented 2026-04-03 03:55:04 +00:00
Owner
Copy Link
Copy Source

Review claimed by reviewer pool instance pr-reviewer-pool-2377036-1775183920. Dispatching independent code review (stale claim from previous instance).

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

Review claimed by reviewer pool instance pr-reviewer-pool-2377036-1775183920. Dispatching independent code review (stale claim from previous instance). --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo requested changes 2026-04-03 03:57:34 +00:00
freemo left a comment
Owner
Copy Link
Copy Source

Independent Review: REQUEST CHANGES

This is a docs-only cosmetic PR aligning Unicode box-drawing blocks and Markdown tables across 15 documentation files for consistent MkDocs rendering. The intent is correct and the vast majority of changes (~890 lines) are proper whitespace alignment fixes.

Process Compliance ✅

  • Conventional commit format: docs(spec): align ASCII UI tables in specification and related pages ✅
  • Issue link: Closes #1171 in PR body ✅
  • Commit footer: ISSUES CLOSED: #1171 ✅
  • Milestone: v3.6.0 ✅
  • Label: Type/Task ✅
  • Single atomic commit ✅
  • Branch name docs/ascii-table-alignment matches issue metadata ✅
  • Docs-only changes (15 files, no source code) — Behave tests and static typing N/A ✅

Review Criteria Assessment

  1. Does the code implement what the PR claims? — Mostly yes, but two rendering bugs were introduced by this PR, directly contradicting its purpose of improving rendering.
  2. Are there Behave unit tests? — N/A (docs-only change, no code modified).
  3. Is there static typing? — N/A (docs-only change, no code modified).
  4. Does the commit message follow conventional commits format? — Yes ✅
  5. Is the PR linked to an issue? — Yes, linked to #1171 ✅

Bugs Found 🐛 (Still Present — 4th Review Flagging These)

These two bugs have been identified in reviews #3232, #3262, and #3332 and remain unfixed on the current HEAD (259aaf1c). I have independently verified both bugs by inspecting the branch content.

Bug 1: docs/reference/acms_fusion.md — Two lines merged into one (CRITICAL)

In the Budget Overage Guard box-drawing diagram, two lines have been concatenated onto a single line, completely breaking the ASCII art structure. The original file had these as two separate lines (lines 37-38), but the PR merged them into one.

Current (broken — single line):

│  │  Drop lowest-relevance fragments if over budget  │  ││  └──────────────────────────────────────────────────┘  │

Expected (two separate lines):

│  │  Drop lowest-relevance fragments if over budget  │  │
│  └──────────────────────────────────────────────────┘  │

Bug 2: docs/specification.md line ~7956 — Stray ─ character appended

A box-drawing horizontal line character ─ was accidentally appended to the "Validation removed" status text. The diff clearly shows: -Validation removed → +Validation removed─

Current (broken): ✓ OK Validation removed─
Expected: ✓ OK Validation removed

Scope Note

The a2a.md TOC expansion (from flat 12-entry list to fully nested 28-entry list) goes beyond "ASCII table alignment" and is a structural documentation change. Previous reviews flagged this as scope creep. It's harmless but worth noting for commit atomicity.

CI Status

Multiple CI checks are failing (lint, typecheck, unit_tests, build, etc.). For a docs-only PR these may be pre-existing failures unrelated to this change, but they should be investigated.

Action Items

  • Fix docs/reference/acms_fusion.md: split the merged line back into two separate lines in the Budget Overage Guard diagram
  • Fix docs/specification.md: remove the stray ─ character after "Validation removed"

These are rendering bugs that directly contradict the purpose of this PR. Once fixed, the PR is ready to merge.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Independent Review: REQUEST CHANGES This is a docs-only cosmetic PR aligning Unicode box-drawing blocks and Markdown tables across 15 documentation files for consistent MkDocs rendering. The intent is correct and the vast majority of changes (~890 lines) are proper whitespace alignment fixes. ### Process Compliance ✅ - Conventional commit format: `docs(spec): align ASCII UI tables in specification and related pages` ✅ - Issue link: `Closes #1171` in PR body ✅ - Commit footer: `ISSUES CLOSED: #1171` ✅ - Milestone: v3.6.0 ✅ - Label: `Type/Task` ✅ - Single atomic commit ✅ - Branch name `docs/ascii-table-alignment` matches issue metadata ✅ - Docs-only changes (15 files, no source code) — Behave tests and static typing N/A ✅ ### Review Criteria Assessment 1. **Does the code implement what the PR claims?** — Mostly yes, but two rendering bugs were *introduced* by this PR, directly contradicting its purpose of improving rendering. 2. **Are there Behave unit tests?** — N/A (docs-only change, no code modified). 3. **Is there static typing?** — N/A (docs-only change, no code modified). 4. **Does the commit message follow conventional commits format?** — Yes ✅ 5. **Is the PR linked to an issue?** — Yes, linked to #1171 ✅ ### Bugs Found 🐛 (Still Present — 4th Review Flagging These) These two bugs have been identified in reviews #3232, #3262, and #3332 and **remain unfixed** on the current HEAD (`259aaf1c`). I have independently verified both bugs by inspecting the branch content. #### Bug 1: `docs/reference/acms_fusion.md` — Two lines merged into one (CRITICAL) In the Budget Overage Guard box-drawing diagram, two lines have been concatenated onto a single line, completely breaking the ASCII art structure. The original file had these as two separate lines (lines 37-38), but the PR merged them into one. **Current (broken — single line):** ``` │ │ Drop lowest-relevance fragments if over budget │ ││ └──────────────────────────────────────────────────┘ │ ``` **Expected (two separate lines):** ``` │ │ Drop lowest-relevance fragments if over budget │ │ │ └──────────────────────────────────────────────────┘ │ ``` #### Bug 2: `docs/specification.md` line ~7956 — Stray `─` character appended A box-drawing horizontal line character `─` was accidentally appended to the "Validation removed" status text. The diff clearly shows: `-Validation removed` → `+Validation removed─` **Current (broken):** `✓ OK Validation removed─` **Expected:** `✓ OK Validation removed` ### Scope Note The `a2a.md` TOC expansion (from flat 12-entry list to fully nested 28-entry list) goes beyond "ASCII table alignment" and is a structural documentation change. Previous reviews flagged this as scope creep. It's harmless but worth noting for commit atomicity. ### CI Status Multiple CI checks are failing (lint, typecheck, unit_tests, build, etc.). For a docs-only PR these may be pre-existing failures unrelated to this change, but they should be investigated. ### Action Items - [ ] Fix `docs/reference/acms_fusion.md`: split the merged line back into two separate lines in the Budget Overage Guard diagram - [ ] Fix `docs/specification.md`: remove the stray `─` character after "Validation removed" These are rendering bugs that directly contradict the purpose of this PR. Once fixed, the PR is ready to merge. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
docs/reference/acms_fusion.md
@@ -40,0 +34,4 @@
│ fuse() │
│ ┌──────────────────────────────────────────────────┐ │
│ │ Budget Overage Guard │ │
│ │ Drop lowest-relevance fragments if over budget │ ││ └──────────────────────────────────────────────────┘ │
freemo commented 2026-04-03 03:57:34 +00:00
Owner
Copy Link
Copy Source

Bug: Two lines have been merged into one here. The closing │ │ of the inner box and the │ └──...┘ │ bottom border are concatenated on a single line, breaking the ASCII diagram.

Fix: Split this into two lines:

│  │  Drop lowest-relevance fragments if over budget  │  │
│  └──────────────────────────────────────────────────┘  │
**Bug:** Two lines have been merged into one here. The closing `│ │` of the inner box and the `│ └──...┘ │` bottom border are concatenated on a single line, breaking the ASCII diagram. **Fix:** Split this into two lines: ``` │ │ Drop lowest-relevance fragments if over budget │ │ │ └──────────────────────────────────────────────────┘ │ ```
docs/specification.md
@@ -7955,2 +7954,3 @@
╰────────────────────────────────────────────────────────────╯
<span style="color: #66cc66; font-weight: 600;">✓ OK</span> Validation removed
<span style="color: #66cc66; font-weight: 600;">✓ OK</span> Validation removed─
freemo commented 2026-04-03 03:57:34 +00:00
Owner
Copy Link
Copy Source

Bug: A stray ─ (box-drawing horizontal line) character was accidentally appended to "Validation removed". The original had no trailing character.

Fix: Remove the ─ character so it reads: ✓ OK Validation removed

**Bug:** A stray `─` (box-drawing horizontal line) character was accidentally appended to "Validation removed". The original had no trailing character. **Fix:** Remove the `─` character so it reads: `✓ OK Validation removed`
freemo commented 2026-04-03 04:15:05 +00:00
Owner
Copy Link
Copy Source

Review claimed by reviewer pool instance pr-reviewer-pool-2377036-1775183920. Dispatching independent code review (retry - previous worker did not post review).

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

Review claimed by reviewer pool instance pr-reviewer-pool-2377036-1775183920. Dispatching independent code review (retry - previous worker did not post review). --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo requested changes 2026-04-03 04:17:00 +00:00
freemo left a comment
Owner
Copy Link
Copy Source

Independent Review: REQUEST CHANGES

This is a docs-only cosmetic PR aligning Unicode box-drawing blocks and Markdown tables across 15 documentation files for consistent MkDocs rendering. The intent is correct and the vast majority of changes (~893 lines across 15 files) are proper whitespace alignment fixes.

Review Criteria Assessment

Criterion Result
1. Does the code implement what the PR claims? ⚠️ Mostly — but two rendering bugs were introduced, contradicting the PR's purpose
2. Are there Behave unit tests? N/A — docs-only change, no source code modified
3. Is there static typing? N/A — docs-only change, no source code modified
4. Conventional commit format? ✅ docs(spec): align ASCII UI tables... with ISSUES CLOSED: #1171 footer
5. PR linked to an issue? ✅ Closes #1171 in PR body, milestone v3.6.0, Type/Task label

Process Compliance ✅

  • Conventional commit format ✅
  • Issue link: Closes #1171 ✅
  • Commit footer: ISSUES CLOSED: #1171 ✅
  • Milestone: v3.6.0 ✅
  • Label: Type/Task ✅
  • Single atomic commit ✅
  • Branch name docs/ascii-table-alignment matches issue metadata ✅

Bugs Found 🐛

I have independently verified both bugs on the current HEAD (259aaf1c) by examining the branch content directly. These have been flagged in 4 prior reviews and remain unfixed.

Bug 1: docs/reference/acms_fusion.md line 37 — Two lines merged into one (CRITICAL)

In the Budget Overage Guard box-drawing diagram, two lines have been concatenated onto a single line, completely breaking the ASCII art structure. The master branch correctly has these as two separate lines (37-38), but this PR merged them into one.

Current (broken — single line):

│  │  Drop lowest-relevance fragments if over budget  │  ││  └──────────────────────────────────────────────────┘  │

Expected (two separate lines):

│  │  Drop lowest-relevance fragments if over budget  │  │
│  └──────────────────────────────────────────────────┘  │

Bug 2: docs/specification.md — Stray ─ character appended

The diff clearly shows a box-drawing horizontal line character ─ was accidentally appended to the "Validation removed" status text:

-    <span style="color: #66cc66; font-weight: 600;">✓ OK</span> Validation removed
+    <span style="color: #66cc66; font-weight: 600;">✓ OK</span> Validation removed─

Everything Else ✅

The remaining changes across all 15 files are correct whitespace alignment adjustments. ADR-044/045/046, all reference pages, and the bulk of specification.md changes look properly aligned.

Note on Issue State

The linked issue #1171 is already marked State/Completed and closed, but this PR has not been merged yet. The issue should not have been closed before the PR was merged.

Action Items

  • Fix docs/reference/acms_fusion.md line 37: split the merged line back into two separate lines in the Budget Overage Guard diagram
  • Fix docs/specification.md: remove the stray ─ character after "Validation removed"

These are rendering bugs that directly contradict the purpose of this PR (improving rendering consistency). Once fixed, the PR is ready to merge.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Independent Review: REQUEST CHANGES This is a docs-only cosmetic PR aligning Unicode box-drawing blocks and Markdown tables across 15 documentation files for consistent MkDocs rendering. The intent is correct and the vast majority of changes (~893 lines across 15 files) are proper whitespace alignment fixes. ### Review Criteria Assessment | Criterion | Result | |-----------|--------| | **1. Does the code implement what the PR claims?** | ⚠️ Mostly — but two rendering bugs were *introduced*, contradicting the PR's purpose | | **2. Are there Behave unit tests?** | N/A — docs-only change, no source code modified | | **3. Is there static typing?** | N/A — docs-only change, no source code modified | | **4. Conventional commit format?** | ✅ `docs(spec): align ASCII UI tables...` with `ISSUES CLOSED: #1171` footer | | **5. PR linked to an issue?** | ✅ `Closes #1171` in PR body, milestone v3.6.0, `Type/Task` label | ### Process Compliance ✅ - Conventional commit format ✅ - Issue link: `Closes #1171` ✅ - Commit footer: `ISSUES CLOSED: #1171` ✅ - Milestone: v3.6.0 ✅ - Label: `Type/Task` ✅ - Single atomic commit ✅ - Branch name `docs/ascii-table-alignment` matches issue metadata ✅ ### Bugs Found 🐛 I have independently verified both bugs on the current HEAD (`259aaf1c`) by examining the branch content directly. These have been flagged in 4 prior reviews and **remain unfixed**. #### Bug 1: `docs/reference/acms_fusion.md` line 37 — Two lines merged into one (CRITICAL) In the Budget Overage Guard box-drawing diagram, two lines have been concatenated onto a single line, completely breaking the ASCII art structure. The master branch correctly has these as two separate lines (37-38), but this PR merged them into one. **Current (broken — single line):** ``` │ │ Drop lowest-relevance fragments if over budget │ ││ └──────────────────────────────────────────────────┘ │ ``` **Expected (two separate lines):** ``` │ │ Drop lowest-relevance fragments if over budget │ │ │ └──────────────────────────────────────────────────┘ │ ``` #### Bug 2: `docs/specification.md` — Stray `─` character appended The diff clearly shows a box-drawing horizontal line character `─` was accidentally appended to the "Validation removed" status text: ```diff - <span style="color: #66cc66; font-weight: 600;">✓ OK</span> Validation removed + <span style="color: #66cc66; font-weight: 600;">✓ OK</span> Validation removed─ ``` ### Everything Else ✅ The remaining changes across all 15 files are correct whitespace alignment adjustments. ADR-044/045/046, all reference pages, and the bulk of specification.md changes look properly aligned. ### Note on Issue State The linked issue #1171 is already marked `State/Completed` and closed, but this PR has not been merged yet. The issue should not have been closed before the PR was merged. ### Action Items - [ ] Fix `docs/reference/acms_fusion.md` line 37: split the merged line back into two separate lines in the Budget Overage Guard diagram - [ ] Fix `docs/specification.md`: remove the stray `─` character after "Validation removed" These are rendering bugs that directly contradict the purpose of this PR (improving rendering consistency). Once fixed, the PR is ready to merge. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
docs/reference/acms_fusion.md
@@ -40,0 +34,4 @@
│ fuse() │
│ ┌──────────────────────────────────────────────────┐ │
│ │ Budget Overage Guard │ │
│ │ Drop lowest-relevance fragments if over budget │ ││ └──────────────────────────────────────────────────┘ │
freemo commented 2026-04-03 04:17:00 +00:00
Owner
Copy Link
Copy Source

BUG: Two lines have been merged into one here, breaking the ASCII art diagram. The closing │ │ of the inner box and the │ └──...┘ │ bottom border are concatenated on a single line.

Fix: Split this back into two separate lines:

│  │  Drop lowest-relevance fragments if over budget  │  │
│  └──────────────────────────────────────────────────┘  │
**BUG:** Two lines have been merged into one here, breaking the ASCII art diagram. The closing `│ │` of the inner box and the `│ └──...┘ │` bottom border are concatenated on a single line. **Fix:** Split this back into two separate lines: ``` │ │ Drop lowest-relevance fragments if over budget │ │ │ └──────────────────────────────────────────────────┘ │ ```
docs/specification.md
@@ -7955,2 +7954,3 @@
╰────────────────────────────────────────────────────────────╯
<span style="color: #66cc66; font-weight: 600;">✓ OK</span> Validation removed
<span style="color: #66cc66; font-weight: 600;">✓ OK</span> Validation removed─
freemo commented 2026-04-03 04:17:00 +00:00
Owner
Copy Link
Copy Source

BUG: A stray ─ (box-drawing horizontal line) character was accidentally appended to "Validation removed". The diff shows: -Validation removed → +Validation removed─

Fix: Remove the trailing ─ character.

**BUG:** A stray `─` (box-drawing horizontal line) character was accidentally appended to "Validation removed". The diff shows: `-Validation removed` → `+Validation removed─` **Fix:** Remove the trailing `─` character.
freemo requested changes 2026-04-03 04:20:24 +00:00
freemo left a comment
Owner
Copy Link
Copy Source

Independent Review: REQUEST CHANGES

This is a docs-only cosmetic PR aligning Unicode box-drawing blocks and Markdown tables across 15 documentation files for consistent MkDocs rendering. The intent is correct and the vast majority of changes (~893 lines across 15 files) are proper whitespace alignment fixes. Process compliance is solid.

Process Compliance ✅

Criterion Status
Conventional commit format ✅ docs(spec): align ASCII UI tables in specification and related pages
Issue link in PR body ✅ Closes #1171
Commit footer ✅ ISSUES CLOSED: #1171
Milestone ✅ v3.6.0
Label ✅ Type/Task
Single atomic commit ✅
Branch naming ✅ docs/ascii-table-alignment
Docs-only (no code) ✅ Behave tests / typing N/A

Bugs Found 🐛

I have independently verified both bugs on the current HEAD (259aaf1c) by examining the branch content directly. These have been flagged in multiple prior reviews and remain unfixed.

Bug 1: docs/reference/acms_fusion.md — Two lines merged into one (CRITICAL)

In the Budget Overage Guard box-drawing diagram, two lines have been concatenated onto a single line, completely breaking the ASCII art structure. On master, lines 37-38 are:

│  │  Drop lowest-relevance fragments if over budget   │   │
│  └──────────────────────────────────────────────────┘   │

On this branch, they became a single line:

│  │  Drop lowest-relevance fragments if over budget  │  ││  └──────────────────────────────────────────────────┘  │

This breaks the box-drawing diagram rendering entirely — the exact opposite of what this PR intends.

Bug 2: docs/specification.md line 7956 — Stray ─ character appended

A box-drawing horizontal line character ─ was accidentally appended to the "Validation removed" status text. Master has:

✓ OK</span> Validation removed

This branch has:

✓ OK</span> Validation removed─

The trailing ─ is a rendering artifact that should not be there.

Everything Else ✅

The remaining changes across all 15 files are correct whitespace alignment adjustments:

  • ADR-044/045/046 box-drawing diagrams: properly aligned ✅
  • a2a.md table columns and expanded TOC: correct ✅
  • cli_system_commands.md, context_indexing.md, context_strategies.md: correct ✅
  • decision_model.md, devcontainer_resources.md, error_handling.md: correct ✅
  • resource_type_inheritance.md, semantic_validation.md, temporal_data_model.md: correct ✅
  • specification.md (aside from Bug 2): hundreds of alignment fixes all look correct ✅

Note on Issue State

The linked issue #1171 is already marked State/Completed and closed, but this PR has not been merged yet. The issue should not have been closed before the PR was merged.

Action Items

  • Fix docs/reference/acms_fusion.md: split the merged line back into two separate lines in the Budget Overage Guard diagram
  • Fix docs/specification.md line 7956: remove the stray ─ character after "Validation removed"

These are rendering bugs that directly contradict the purpose of this PR (improving rendering consistency). Once fixed, the PR is ready to merge.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Independent Review: REQUEST CHANGES This is a docs-only cosmetic PR aligning Unicode box-drawing blocks and Markdown tables across 15 documentation files for consistent MkDocs rendering. The intent is correct and the vast majority of changes (~893 lines across 15 files) are proper whitespace alignment fixes. Process compliance is solid. ### Process Compliance ✅ | Criterion | Status | |-----------|--------| | Conventional commit format | ✅ `docs(spec): align ASCII UI tables in specification and related pages` | | Issue link in PR body | ✅ `Closes #1171` | | Commit footer | ✅ `ISSUES CLOSED: #1171` | | Milestone | ✅ v3.6.0 | | Label | ✅ `Type/Task` | | Single atomic commit | ✅ | | Branch naming | ✅ `docs/ascii-table-alignment` | | Docs-only (no code) | ✅ Behave tests / typing N/A | ### Bugs Found 🐛 I have independently verified both bugs on the current HEAD (`259aaf1c`) by examining the branch content directly. These have been flagged in multiple prior reviews and **remain unfixed**. #### Bug 1: `docs/reference/acms_fusion.md` — Two lines merged into one (CRITICAL) In the Budget Overage Guard box-drawing diagram, two lines have been concatenated onto a single line, completely breaking the ASCII art structure. On master, lines 37-38 are: ``` │ │ Drop lowest-relevance fragments if over budget │ │ │ └──────────────────────────────────────────────────┘ │ ``` On this branch, they became a single line: ``` │ │ Drop lowest-relevance fragments if over budget │ ││ └──────────────────────────────────────────────────┘ │ ``` This breaks the box-drawing diagram rendering entirely — the exact opposite of what this PR intends. #### Bug 2: `docs/specification.md` line 7956 — Stray `─` character appended A box-drawing horizontal line character `─` was accidentally appended to the "Validation removed" status text. Master has: ``` ✓ OK</span> Validation removed ``` This branch has: ``` ✓ OK</span> Validation removed─ ``` The trailing `─` is a rendering artifact that should not be there. ### Everything Else ✅ The remaining changes across all 15 files are correct whitespace alignment adjustments: - ADR-044/045/046 box-drawing diagrams: properly aligned ✅ - `a2a.md` table columns and expanded TOC: correct ✅ - `cli_system_commands.md`, `context_indexing.md`, `context_strategies.md`: correct ✅ - `decision_model.md`, `devcontainer_resources.md`, `error_handling.md`: correct ✅ - `resource_type_inheritance.md`, `semantic_validation.md`, `temporal_data_model.md`: correct ✅ - `specification.md` (aside from Bug 2): hundreds of alignment fixes all look correct ✅ ### Note on Issue State The linked issue #1171 is already marked `State/Completed` and closed, but this PR has not been merged yet. The issue should not have been closed before the PR was merged. ### Action Items - [ ] Fix `docs/reference/acms_fusion.md`: split the merged line back into two separate lines in the Budget Overage Guard diagram - [ ] Fix `docs/specification.md` line 7956: remove the stray `─` character after "Validation removed" These are rendering bugs that directly contradict the purpose of this PR (improving rendering consistency). Once fixed, the PR is ready to merge. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
docs/reference/acms_fusion.md
@@ -40,0 +34,4 @@
│ fuse() │
│ ┌──────────────────────────────────────────────────┐ │
│ │ Budget Overage Guard │ │
│ │ Drop lowest-relevance fragments if over budget │ ││ └──────────────────────────────────────────────────┘ │
freemo commented 2026-04-03 04:20:24 +00:00
Owner
Copy Link
Copy Source

Bug: Two lines merged into one. The closing │ │ border of the inner box and the │ └──...┘ │ bottom border have been concatenated onto a single line, breaking the Budget Overage Guard box-drawing diagram. This needs to be split back into two separate lines:

│  │  Drop lowest-relevance fragments if over budget  │  │
│  └──────────────────────────────────────────────────┘  │
**Bug: Two lines merged into one.** The closing `│ │` border of the inner box and the `│ └──...┘ │` bottom border have been concatenated onto a single line, breaking the Budget Overage Guard box-drawing diagram. This needs to be split back into two separate lines: ``` │ │ Drop lowest-relevance fragments if over budget │ │ │ └──────────────────────────────────────────────────┘ │ ```
docs/specification.md
@@ -7955,2 +7954,3 @@
╰────────────────────────────────────────────────────────────╯
<span style="color: #66cc66; font-weight: 600;">✓ OK</span> Validation removed
<span style="color: #66cc66; font-weight: 600;">✓ OK</span> Validation removed─
freemo commented 2026-04-03 04:20:24 +00:00
Owner
Copy Link
Copy Source

Bug: Stray ─ character appended. A box-drawing horizontal line character ─ was accidentally appended to the "Validation removed" text. Remove the trailing ─ to match the original: Validation removed (without the dash).

**Bug: Stray `─` character appended.** A box-drawing horizontal line character `─` was accidentally appended to the "Validation removed" text. Remove the trailing `─` to match the original: `Validation removed` (without the dash).
freemo requested changes 2026-04-03 04:53:24 +00:00
freemo left a comment
Owner
Copy Link
Copy Source

Independent Review: REQUEST CHANGES

This is a docs-only cosmetic PR aligning Unicode box-drawing blocks and Markdown tables across 15 documentation files for consistent MkDocs rendering. Process compliance is solid and the vast majority of changes are correct.

Review Checklist

# Criterion Result
1 PR description explains changes? ✅ Yes — clear summary, type of change, testing notes
2 Conventional commits format? ✅ docs(spec): align ASCII UI tables in specification and related pages with ISSUES CLOSED: #1171 footer
3 PR linked to an issue? ✅ Closes #1171 in body, milestone v3.6.0, Type/Task label
4 Behave unit tests? N/A — docs-only, no source code modified
5 Static typing? N/A — docs-only, no source code modified

Two Rendering Bugs Remain Unfixed 🐛

I have independently verified both bugs by comparing the branch content (259aaf1c) against master (2770f6af). These were first identified in review #3232 and have been flagged in every subsequent review. They remain present on the current HEAD.

Bug 1: docs/reference/acms_fusion.md line 37 — Two lines merged into one

Master (correct — two separate lines):

│  │  Drop lowest-relevance fragments if over budget   │   │
│  └──────────────────────────────────────────────────┘   │

This branch (broken — single line):

│  │  Drop lowest-relevance fragments if over budget  │  ││  └──────────────────────────────────────────────────┘  │

The inner box closing border and the bottom border got concatenated onto one line, breaking the diagram.

Bug 2: docs/specification.md line 7956 — Stray ─ character

Master (correct): ✓ OK</span> Validation removed
This branch (broken): ✓ OK</span> Validation removed─

A box-drawing horizontal line character was accidentally appended.

Verdict

Both bugs directly contradict the PR's purpose of improving rendering consistency. The fixes are trivial (split one line, delete one character), but they must be applied before merge.

Note on Issue State

Issue #1171 is already closed with State/Completed, but this PR has not been merged. The issue should not have been transitioned to completed before the PR was merged.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Independent Review: REQUEST CHANGES This is a docs-only cosmetic PR aligning Unicode box-drawing blocks and Markdown tables across 15 documentation files for consistent MkDocs rendering. Process compliance is solid and the vast majority of changes are correct. ### Review Checklist | # | Criterion | Result | |---|-----------|--------| | 1 | **PR description explains changes?** | ✅ Yes — clear summary, type of change, testing notes | | 2 | **Conventional commits format?** | ✅ `docs(spec): align ASCII UI tables in specification and related pages` with `ISSUES CLOSED: #1171` footer | | 3 | **PR linked to an issue?** | ✅ `Closes #1171` in body, milestone v3.6.0, `Type/Task` label | | 4 | **Behave unit tests?** | N/A — docs-only, no source code modified | | 5 | **Static typing?** | N/A — docs-only, no source code modified | ### Two Rendering Bugs Remain Unfixed 🐛 I have independently verified both bugs by comparing the branch content (`259aaf1c`) against master (`2770f6af`). These were first identified in review #3232 and have been flagged in every subsequent review. They remain present on the current HEAD. #### Bug 1: `docs/reference/acms_fusion.md` line 37 — Two lines merged into one **Master** (correct — two separate lines): ``` │ │ Drop lowest-relevance fragments if over budget │ │ │ └──────────────────────────────────────────────────┘ │ ``` **This branch** (broken — single line): ``` │ │ Drop lowest-relevance fragments if over budget │ ││ └──────────────────────────────────────────────────┘ │ ``` The inner box closing border and the bottom border got concatenated onto one line, breaking the diagram. #### Bug 2: `docs/specification.md` line 7956 — Stray `─` character **Master** (correct): `✓ OK</span> Validation removed` **This branch** (broken): `✓ OK</span> Validation removed─` A box-drawing horizontal line character was accidentally appended. ### Verdict Both bugs directly contradict the PR's purpose of improving rendering consistency. The fixes are trivial (split one line, delete one character), but they must be applied before merge. ### Note on Issue State Issue #1171 is already closed with `State/Completed`, but this PR has not been merged. The issue should not have been transitioned to completed before the PR was merged. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
docs/reference/acms_fusion.md
@@ -40,0 +34,4 @@
│ fuse() │
│ ┌──────────────────────────────────────────────────┐ │
│ │ Budget Overage Guard │ │
│ │ Drop lowest-relevance fragments if over budget │ ││ └──────────────────────────────────────────────────┘ │
freemo commented 2026-04-03 04:53:24 +00:00
Owner
Copy Link
Copy Source

Bug: Two lines have been merged into one here. The inner box closing border (│ │) and the bottom border (│ └──...┘ │) are concatenated on a single line, breaking the Budget Overage Guard diagram.

Fix: Split this back into two lines:

│  │  Drop lowest-relevance fragments if over budget  │  │
│  └──────────────────────────────────────────────────┘  │
**Bug**: Two lines have been merged into one here. The inner box closing border (`│ │`) and the bottom border (`│ └──...┘ │`) are concatenated on a single line, breaking the Budget Overage Guard diagram. **Fix**: Split this back into two lines: ``` │ │ Drop lowest-relevance fragments if over budget │ │ │ └──────────────────────────────────────────────────┘ │ ```
docs/specification.md
@@ -7955,2 +7954,3 @@
╰────────────────────────────────────────────────────────────╯
<span style="color: #66cc66; font-weight: 600;">✓ OK</span> Validation removed
<span style="color: #66cc66; font-weight: 600;">✓ OK</span> Validation removed─
freemo commented 2026-04-03 04:53:24 +00:00
Owner
Copy Link
Copy Source

Bug: A stray box-drawing character ─ was appended to "Validation removed". Master has this without the trailing character.

Fix: Remove the trailing ─ so it reads Validation removed (no trailing character).

**Bug**: A stray box-drawing character `─` was appended to "Validation removed". Master has this without the trailing character. **Fix**: Remove the trailing `─` so it reads `Validation removed` (no trailing character).
freemo merged commit f66fb5a19a into master 2026-04-03 04:55:22 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
freemo
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Priority
Medium
State
In Review
Type
Task
Milestone
No items
No Milestone v3.6.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees freemo
2 Participants
Notifications
Due Date
No due date set.
Depends on
#1171 Docs: align ASCII UI tables in specification and related pages
cleveragents/cleveragents-core
Reference: cleveragents/cleveragents-core#1131
Delete Branch "docs/ascii-table-alignment"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?