test: add TDD bug-capture test for #993 — server_connect non-atomic writes #1128

Merged

brent.edwards merged 7 commits from tdd/m6-server-connect-non-atomic into master 2026-03-26 05:41:47 +00:00

Conversation 1 Commits 7 Files changed 3 +362 -3

brent.edwards commented 2026-03-23 11:51:56 +00:00

Member

Copy link

Summary

Add TDD bug-capture Behave tests that prove bug #993 exists: server_connect() in server.py writes three config values (server.url, server.namespace, server.tls-verify) via sequential set_value() calls with no atomicity guarantee. When a middle call fails, earlier values are already persisted, leaving the config in a half-written state.

Changes

• New feature file: features/tdd_server_connect_atomic_writes.feature — 3 scenarios tagged @tdd_expected_fail @tdd_bug @tdd_bug_993
• New step definitions: features/steps/tdd_server_connect_atomic_writes_steps.py — Uses a _FailingConfigService subclass that raises OSError on a configurable set_value() call to simulate disk/permission failures

Scenarios

1. Config remains unchanged when second set_value fails — Pre-populates config, calls server_connect where set_value fails on the 2nd call (server.namespace). Asserts error was raised and all three values are rolled back. ASSERT FAILS: server.url retains the new value.
2. Config remains unchanged when third set_value fails — Same setup, failure on 3rd call (server.tls-verify). Asserts error was raised and both server.url and server.namespace are rolled back to original values. ASSERT FAILS: both retain new values.
3. No partial server.url persisted when namespace write raises — Starts from empty config. Asserts error was raised and no server.url persisted. ASSERT FAILS: server.url was persisted despite the subsequent failure.

All assertions fail (proving the bug exists), and @tdd_expected_fail inverts these to CI passes.

Review Fixes Applied

• Fixed Gherkin step text contradiction: Changed Scenario 2 step from "rolled back server.namespace to its new value" to "to its original value" — matching the assertion logic and the rollback semantics (feature file + @then decorator in step definitions).
• Moved import tomllib to top-level imports: Was previously buried inside _read_flat_config() function body, violating CONTRIBUTING.md § Import Guidelines. Now at top of file alongside other stdlib imports.
• Added temp directory cleanup: The _cleanup handler in step_fresh_config_dir now calls shutil.rmtree() on the temporary directory to prevent /tmp/tdd993_* accumulation over CI runs.
• Added error-assertion Then step: New @then("an error should have been raised during server_connect") step verifies context.atomic_error is not None before config-checking steps, guarding against silent exception swallowing.

Quality Gates

Gate	Result
nox -s lint	✅ Pass
nox -s typecheck	✅ Pass (0 errors)
nox -s unit_tests	✅ Pass (462 features, 12233 scenarios, 46806 steps)
nox -s integration_tests	⚠️ 7 pre-existing timeout failures (unrelated to this PR)
nox -s coverage_report	✅ Pass (98%, threshold 97%)

Robot Integration Test

N/A — The non-atomic write behavior is internal to server_connect and ConfigService.set_value(). No external system integration is involved.

Closes #1097

## Summary Add TDD bug-capture Behave tests that prove bug #993 exists: `server_connect()` in `server.py` writes three config values (`server.url`, `server.namespace`, `server.tls-verify`) via sequential `set_value()` calls with no atomicity guarantee. When a middle call fails, earlier values are already persisted, leaving the config in a half-written state. ### Changes - **New feature file**: `features/tdd_server_connect_atomic_writes.feature` — 3 scenarios tagged `@tdd_expected_fail @tdd_bug @tdd_bug_993` - **New step definitions**: `features/steps/tdd_server_connect_atomic_writes_steps.py` — Uses a `_FailingConfigService` subclass that raises `OSError` on a configurable `set_value()` call to simulate disk/permission failures ### Scenarios 1. **Config remains unchanged when second set_value fails** — Pre-populates config, calls `server_connect` where `set_value` fails on the 2nd call (`server.namespace`). Asserts error was raised and all three values are rolled back. **ASSERT FAILS**: `server.url` retains the new value. 2. **Config remains unchanged when third set_value fails** — Same setup, failure on 3rd call (`server.tls-verify`). Asserts error was raised and both `server.url` and `server.namespace` are rolled back to original values. **ASSERT FAILS**: both retain new values. 3. **No partial server.url persisted when namespace write raises** — Starts from empty config. Asserts error was raised and no `server.url` persisted. **ASSERT FAILS**: `server.url` was persisted despite the subsequent failure. All assertions fail (proving the bug exists), and `@tdd_expected_fail` inverts these to CI passes. ### Review Fixes Applied - **Fixed Gherkin step text contradiction**: Changed Scenario 2 step from "rolled back server.namespace to its **new** value" to "to its **original** value" — matching the assertion logic and the rollback semantics (feature file + `@then` decorator in step definitions). - **Moved `import tomllib` to top-level imports**: Was previously buried inside `_read_flat_config()` function body, violating CONTRIBUTING.md § Import Guidelines. Now at top of file alongside other stdlib imports. - **Added temp directory cleanup**: The `_cleanup` handler in `step_fresh_config_dir` now calls `shutil.rmtree()` on the temporary directory to prevent `/tmp/tdd993_*` accumulation over CI runs. - **Added error-assertion Then step**: New `@then("an error should have been raised during server_connect")` step verifies `context.atomic_error is not None` before config-checking steps, guarding against silent exception swallowing. ### Quality Gates | Gate | Result | |------|--------| | `nox -s lint` | ✅ Pass | | `nox -s typecheck` | ✅ Pass (0 errors) | | `nox -s unit_tests` | ✅ Pass (462 features, 12233 scenarios, 46806 steps) | | `nox -s integration_tests` | ⚠️ 7 pre-existing timeout failures (unrelated to this PR) | | `nox -s coverage_report` | ✅ Pass (98%, threshold 97%) | ### Robot Integration Test N/A — The non-atomic write behavior is internal to `server_connect` and `ConfigService.set_value()`. No external system integration is involved. Closes #1097

brent.edwards added this to the v3.6.0 milestone 2026-03-23 11:52:02 +00:00

brent.edwards added the

Type

Testing

label 2026-03-23 11:52:04 +00:00

brent.edwards referenced this pull request 2026-03-23 11:55:53 +00:00

TDD: Write failing test for #993 — server_connect writes three config values non-atomically #1097

brent.edwards force-pushed tdd/m6-server-connect-non-atomic from 8ec20837c0 to 231ed59ad2 2026-03-23 16:49:12 +00:00 Compare

freemo approved these changes 2026-03-24 15:28:36 +00:00

Dismissed

freemo left a comment

Copy link

Review: APPROVED

TDD tags correct (@tdd_bug @tdd_bug_993 @tdd_expected_fail). Behave steps fully implemented for server_connect non-atomic writes bug.

Note

Missing Robot Framework integration tests. For consistency with other TDD PRs, consider adding a .robot file + helper script in a follow-up.

## Review: APPROVED TDD tags correct (`@tdd_bug @tdd_bug_993 @tdd_expected_fail`). Behave steps fully implemented for server_connect non-atomic writes bug. ### Note Missing Robot Framework integration tests. For consistency with other TDD PRs, consider adding a `.robot` file + helper script in a follow-up.

brent.edwards added 1 commit 2026-03-25 20:45:10 +00:00

Merge remote-tracking branch 'origin/master' into tdd/m6-server-connect-non-atomic 3dee9441a1

brent.edwards added 1 commit 2026-03-26 00:13:30 +00:00

Merge branch 'master' into tdd/m6-server-connect-non-atomic 2802af13d0

brent.edwards added 1 commit 2026-03-26 01:06:59 +00:00

Merge remote-tracking branch 'origin/master' into merge-master-tmp 498dca8137

brent.edwards added 1 commit 2026-03-26 01:44:08 +00:00

fix(test): increase container resolve regression timeouts to 120s 822f999ebb

brent.edwards dismissed freemo's review 2026-03-26 01:44:09 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

brent.edwards added 1 commit 2026-03-26 02:09:57 +00:00

Merge remote-tracking branch 'origin/master' into merge-master-tmp 8ccda647a8

brent.edwards added 1 commit 2026-03-26 02:58:58 +00:00

Merge remote-tracking branch 'origin/master' into merge-master-tmp 52511533b5

brent.edwards merged commit ee01e2b826 into master 2026-03-26 05:41:47 +00:00

brent.edwards deleted branch tdd/m6-server-connect-non-atomic 2026-03-26 05:41:47 +00:00

brent.edwards referenced this pull request from a commit 2026-03-26 05:41:48 +00:00

Merge pull request 'test: add TDD bug-capture test for #993 — server_connect non-atomic writes' (#1128) from tdd/m6-server-connect-non-atomic into master

freemo referenced this pull request 2026-03-28 21:28:28 +00:00

bug(cli): server_connect writes three config values non-atomically — partial update on failure #993

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

auto/needs-reevaluation

Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  

controller-managed

Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  

auto/claimed-implementer

Currently being processed by an implementer worker.

  

auto/claimed-merge

Currently being processed by the merge driver.

  

auto/claimed-reviewer

Currently being processed by a reviewer worker.

  

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

  

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

  

auto/needs-implementer

Failing CI needs implementer attention.

  

auto/postmortem

Documenting a driver incident or rollback.

  

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Automation

Any edits or discussion about the AI automated coding system.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Refactor

A code change that restructures existing code without changing its external behavior.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

auto/needs-reevaluation

controller-managed

auto/blocked-by-deps

auto/ci-timeout

auto/claimed-implementer

auto/claimed-merge

auto/claimed-reviewer

auto/driver-down

auto/invariant-violation

auto/last-attempt-tier-0

auto/last-attempt-tier-1

auto/last-attempt-tier-2

auto/last-attempt-tier-min

Automation Tracking

auto/needs-conflict-resolution

auto/needs-implementer

auto/postmortem

auto/ready-to-merge

auto/restart-throttled

auto/revert

auto/sentinel

auto/stale-inactivity

auto/unstable

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs Feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

CI Blocker

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Automation

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Refactor

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

v3.6.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cleveragents/cleveragents-core!1128

No description provided.