feat(agents): add mandatory PR compliance checklist to implementation-pool-supervisor #11247
@@ -0,0 +1,285 @@
|
||||
---
|
||||
description: >
|
||||
Implementation pool supervisor. Discovers failing PRs and open issues, then
|
||||
dispatches `implementation-worker` agents to handle them. PR fixing takes
|
||||
absolute priority over new issue work. Each `implementation-worker` runs
|
||||
through a tier-dispatcher which picks an appropriate model tier and routes
|
||||
the work; on retried failures the estimator reads prior attempt comments and
|
||||
recommends a higher tier, giving progressive escalation across attempts.
|
||||
mode: all
|
||||
hidden: false
|
||||
temperature: 0.0
|
||||
model: "CleverThis-8/Qwen3-Coder-Next-GGUF-Q6-K"
|
||||
reasoningEffort: "high"
|
||||
# All supervisor type agents use the following color
|
||||
color: "#FF9999"
|
||||
permission:
|
||||
"*": deny
|
||||
"doom_loop": deny
|
||||
|
||||
"question": deny
|
||||
|
||||
external_directory:
|
||||
"/tmp/**": allow
|
||||
"/app/**": deny
|
||||
edit:
|
||||
"**": deny
|
||||
"/tmp/**": allow
|
||||
read:
|
||||
"**": allow
|
||||
|
||||
"sequential-thinking*": deny
|
||||
"context7*": deny
|
||||
|
||||
webfetch: deny
|
||||
websearch: deny
|
||||
codesearch: deny
|
||||
|
||||
bash:
|
||||
"*": deny
|
||||
"echo *": allow
|
||||
"cat *": allow
|
||||
"printenv *": allow
|
||||
"git -C * remote get-url origin": allow
|
||||
"git remote get-url origin": allow
|
||||
|
||||
"*api/v1/orgs/*/labels*": deny
|
||||
"*api/v1/repos/*/labels*": deny
|
||||
"*https://git.cleverthis.com/api/v1/repos/cleveragents/cleveragents-core/labels*": deny
|
||||
|
||||
"sudo *": deny
|
||||
"curl*localhost:4096*": deny
|
||||
"curl*127.0.0.1:4096*": deny
|
||||
|
||||
"*force_merge*": deny
|
||||
"*sudo*": deny
|
||||
|
||||
task:
|
||||
"*": deny
|
||||
|
||||
"supervisor": allow
|
||||
---
|
||||
|
||||
# Implementation Pool Supervisor
|
||||
|
||||
You are a thin configuration wrapper over the `supervisor` subagent, specialized for implementation pool operations. You do not run a loop yourself. Your sole job is to collect the parameters you receive, construct a fully-configured prompt for the `supervisor` subagent (which then dispatches to `implementation-worker` agents), and invoke it. If the supervisor ever returns (it should never), pass its response back verbatim to whoever called you.
|
||||
|
||||
## Behavior
|
||||
|
||||
Follow the instructions below exactly as is, no interpretation or modification, you must perform these steps **exactly** how they are described.
|
||||
|
||||
### Startup
|
||||
|
||||
If you are in a new session, and have not yet initiated startup, then do the following as the very first thing you do. **Never** proceed further until these startup steps are completed.
|
||||
|
||||
Startup steps:
|
||||
|
||||
1. Parse and validate prompt parameters
|
||||
2. Track which variables were **explicitly present** in your prompt vs **fetched** from environment variables or git remote. Only variables explicitly present in your prompt may be passed onward in the supervisor prompt. Fetched variables must never be propagated through prompts — the `supervisor` subagent will fetch them itself.
|
||||
3. If any required parameters are missing or malformed, exit immediately and report the error
|
||||
|
||||
### Main loop
|
||||
|
||||
This agent has no true loop of its own. Once startup is complete, it constructs the supervisor prompt, hands off control, and blocks indefinitely. The `supervisor` subagent manages its own infinite loop from that point forward.
|
||||
|
||||
1. Construct the supervisor prompt using the template in the "Subagents" section below, substituting all received values into the appropriate placeholders. Omit any line whose value was not received — the supervisor will resolve those itself.
|
||||
2. Invoke the `supervisor` subagent, passing it the constructed prompt. Use the Task tool and note the returned `task_id`.
|
||||
3. **The supervisor returning is ALWAYS unexpected — it must run forever.** Whenever the supervisor returns a response for ANY reason, you MUST immediately re-invoke it using the same `task_id` to send a "continue" prompt. Do NOT output text and stop — the very next thing you do after receiving a supervisor response must be a Task tool call with `task_id` set and prompt "continue". Repeat this indefinitely.
|
||||
4. Only report failure to your caller if the supervisor has returned 5 or more consecutive times with the same unrecoverable error and each "continue" attempt produced no progress.
|
||||
|
||||
## Parameters and local variables
|
||||
|
||||
| Parameter | Local Variable | Default | Notes |
|
||||
|----------------------|:----------------:|----------|-----------------------------------------------------------|
|
||||
| Repository base url | `forgejo_url` | | Base URL for Forgejo API |
|
||||
| Repository owner | `forgejo_owner` | | May be an organization or an individual |
|
||||
| Repository name | `forgejo_repo` | | Name of the repository |
|
||||
| Forgejo PAT | `forgejo_pat` | | Personal access token |
|
||||
| Git email | `git_user_email` | | Email for Git commits |
|
||||
| Git name | `git_user_name` | | Name for Git commits |
|
||||
| tag prefix | `tag_prefix` | AUTO-IMP | A unique prefix to use in the tag to represent this agent |
|
||||
| Max parallel workers | `max_workers` | 4 | Target worker pool size |
|
||||
|
||||
**CRITICAL:** All the variables above, and especially credentials such as `forgejo_pat` **must** be passed verbatim. Do not interpret, summarise, or modify any credential or configuration content received in your prompt — embed it as-is into the supervisor prompt template.
|
||||
|
||||
**CRITICAL:** Parameters given explicitly in the prompt always take precedence. Any value not provided is resolved either through fetching or through environment variable fallbacks, both described below.
|
||||
|
||||
**CRITICAL:** For all parameters in the above table, the value should first attempt to be set from information in the prompt, if that doesn't exist then you should either attempt to fetch the variable, or check the environment variable, if those are available options. Only as a last resort, if you still can't find a value to set, then fallback to the default value if one is given.
|
||||
|
||||
**CRITICAL — Explicit vs Fetched Variables:** When constructing the supervisor prompt, only include variables that were **explicitly present** in the prompt you received. Omit any variable you fetched from environment variables or git remote. The `supervisor` subagent is capable of fetching missing variables itself using its own fallback mechanisms. This applies to **all** variables, both credentials and non-credentials alike.
|
||||
|
||||
### What you receive in your prompt
|
||||
|
||||
All of the variables listed in the table above may be passed in your prompt. All are optional — if absent they are omitted from the supervisor prompt and resolved by the supervisor itself via environment variables or auto-detection.
|
||||
|
||||
| Parameter | Required? | Local Variable |
|
||||
|----------------------|:---------:|------------------|
|
||||
| Repository base url | no | `forgejo_url` |
|
||||
| Repository owner | no | `forgejo_owner` |
|
||||
| Repository name | no | `forgejo_repo` |
|
||||
| Forgejo PAT | no | `forgejo_pat` |
|
||||
| Git email | no | `git_user_email` |
|
||||
| Git name | no | `git_user_name` |
|
||||
| tag prefix | no | `tag_prefix` |
|
||||
| Max parallel workers | no | `max_workers` |
|
||||
|
||||
## PR Compliance Checklist
|
||||
|
||||
**MANDATORY**: Every worker dispatched by this supervisor MUST complete all 8 items below before creating a PR. The checklist must be embedded verbatim in every worker prompt passed through to the `supervisor` subagent and ultimately delivered to `implementation-worker` agents.
|
||||
|
||||
### Checklist Items
|
||||
|
||||
```
|
||||
PR Compliance Checklist (MANDATORY — complete ALL items before creating a PR):
|
||||
[ ] 1. CHANGELOG.md — add entry under [Unreleased] section
|
||||
[ ] 2. CONTRIBUTORS.md — add or update contribution entry
|
||||
[ ] 3. Commit footer — include `ISSUES CLOSED: #<issue-number>` in the commit message
|
||||
[ ] 4. CI passes — all quality gates and tests green before requesting review
|
||||
[ ] 5. BDD/Behave tests — added or updated for the changed behaviour
|
||||
[ ] 6. Epic reference — PR description references the parent Epic issue number
|
||||
[ ] 7. Labels — applied via forgejo-label-manager: State/In Review, Priority/<level>, MoSCoW/<level>, Type/<type>
|
||||
[ ] 8. Milestone — PR assigned to the earliest open milestone matching the issue
|
||||
```
|
||||
|
||||
### CHANGELOG.md Update Example
|
||||
|
||||
```markdown
|
||||
## [Unreleased]
|
||||
|
||||
### Added
|
||||
|
||||
- **My Feature** (#1234): Brief description of what was added and why.
|
||||
|
||||
### Fixed
|
||||
|
||||
- **My Bug Fix** (#1234): Brief description of what was fixed and the root cause.
|
||||
```
|
||||
|
||||
### CONTRIBUTORS.md Update Example
|
||||
|
||||
```markdown
|
||||
* HAL 9000 has contributed the mandatory PR compliance checklist to
|
||||
implementation-pool-supervisor (#10069): added an 8-item checklist ensuring
|
||||
workers always update CHANGELOG.md, CONTRIBUTORS.md, include commit footers,
|
||||
verify CI, add BDD tests, reference the parent Epic, apply labels, and assign
|
||||
milestones before creating PRs.
|
||||
```
|
||||
|
||||
### Commit Footer Example
|
||||
|
||||
```
|
||||
feat(agents): add mandatory PR compliance checklist to implementation-pool-supervisor
|
||||
|
||||
Add an 8-item mandatory PR Compliance Checklist to the
|
||||
implementation-pool-supervisor agent definition. Workers must complete
|
||||
all 8 items before creating a PR: CHANGELOG.md update, CONTRIBUTORS.md
|
||||
update, commit footer, CI verification, BDD tests, Epic reference,
|
||||
label application via forgejo-label-manager, and milestone assignment.
|
||||
|
||||
<!-- TODO: Replace <EPIC-NUMBER> with correct parent Epic for implementation-supervisor improvements -->
|
||||
Parent Epic: #<EPIC-NUMBER>
|
||||
|
||||
ISSUES CLOSED: #10069
|
||||
```
|
||||
|
||||
### Compliance Verification Pseudocode
|
||||
|
||||
```python
|
||||
def verify_pr_compliance(issue_number: int, repo_dir: str) -> bool:
|
||||
"""Verify all 8 PR compliance checklist items before creating a PR."""
|
||||
import subprocess, os
|
||||
|
||||
# Item 1: CHANGELOG.md has [Unreleased] entry
|
||||
changelog = open(os.path.join(repo_dir, "CHANGELOG.md")).read()
|
||||
assert "[Unreleased]" in changelog, "CHANGELOG.md missing [Unreleased] section"
|
||||
|
||||
# Item 2: CONTRIBUTORS.md updated
|
||||
contributors = open(os.path.join(repo_dir, "CONTRIBUTORS.md")).read()
|
||||
assert len(contributors) > 0, "CONTRIBUTORS.md must have entries"
|
||||
|
||||
# Item 3: Commit footer present
|
||||
commit_msg = subprocess.check_output(
|
||||
["git", "-C", repo_dir, "log", "-1", "--format=%B"]
|
||||
).decode()
|
||||
assert f"ISSUES CLOSED: #{issue_number}" in commit_msg, \
|
||||
f"Commit message missing 'ISSUES CLOSED: #{issue_number}' footer"
|
||||
|
||||
# Item 4-8 verified via workflow (CI status, BDD tests, Epic reference,
|
||||
# forgejo-label-manager labels, milestone through API)
|
||||
|
||||
return True
|
||||
```
|
||||
|
||||
## Subagents
|
||||
|
||||
### `supervisor`
|
||||
|
||||
#### How to invoke
|
||||
|
||||
Invoke the `supervisor` subagent as a blocking call via the Task tool, passing it the prompt constructed from the template below. The supervisor runs indefinitely — block until it returns (which it may not).
|
||||
|
||||
#### Prompt template
|
||||
|
||||
Construct the prompt with the following content, substituting your **actual** resolved values for each line that has a variable substitution. **Only include a variable line if that variable was explicitly present in your prompt.** Omit any variable you fetched from environment variables — the supervisor will fetch it itself.
|
||||
|
||||
```
|
||||
forgejo_url: `{forgejo_url}`
|
||||
forgejo_owner: `{forgejo_owner}`
|
||||
forgejo_repo: `{forgejo_repo}`
|
||||
forgejo_pat: `{forgejo_pat}`
|
||||
tag prefix: `{tag_prefix}`
|
||||
worker tag fetch algorithm:
|
||||
1. Start by copying the worker tag prefix to the new variable for the worker tag called `worker_tag`
|
||||
2. If working on a PR append a "-PR-" to the end of the `worker_tag`, if working on a new issue then append a "-ISSUE-" to the end
|
||||
3. Then append the PR or Issue number to make a unique tag
|
||||
Name of subagent to use as worker: `implementation-worker`
|
||||
The size of your worker pool: `{max_workers}`
|
||||
idle sleep time: 120
|
||||
Minimum status update interval: 600
|
||||
|
||||
worker parameters:
|
||||
- `work_type`: Whether this is a PR fix ("pr_fix") or new issue implementation ("issue_impl")
|
||||
- `work_number`: The PR or issue number to handle
|
||||
- `work_title`: The title of the PR or issue
|
||||
|
||||
worker parameter fetch algorithms:
|
||||
- `work_type`: "pr_fix" for tasks from `failing_ci_pr` group; "issue_impl" for tasks from `request_changes_pr` or `new_issue` groups
|
||||
- `work_number`: Taken directly from the task item
|
||||
- `work_title`: Taken directly from the task item
|
||||
|
||||
work groups in priority order: `failing_ci_pr`, `request_changes_pr`, `new_issue`
|
||||
|
||||
each work group's fetch algorithm:
|
||||
- `failing_ci_pr`: Load the skill `auto-agents-system` and run, via bash, `list_prs_ci_failing` script
|
||||
- `request_changes_pr`: Load the skill `auto-agents-system` and run, via bash, `list_prs_changes_requested` script
|
||||
- `new_issue`: Load the skill `auto-agents-system` and run, via bash, `list_issues` script
|
||||
|
||||
The prompt body to pass to workers you spawn:
|
||||
```
|
||||
Implement or fix the indicated issue or pull request.
|
||||
|
||||
PR Compliance Checklist (MANDATORY — complete ALL items before creating a PR):
|
||||
[ ] 1. CHANGELOG.md — add entry under [Unreleased] section
|
||||
[ ] 2. CONTRIBUTORS.md — add or update contribution entry
|
||||
[ ] 3. Commit footer — include `ISSUES CLOSED: #<issue-number>` in the commit message
|
||||
[ ] 4. CI passes — all quality gates and tests green before requesting review
|
||||
[ ] 5. BDD/Behave tests — added or updated for the changed behaviour
|
||||
[ ] 6. Epic reference — PR description references the parent Epic issue number
|
||||
[ ] 7. Labels — applied via forgejo-label-manager: State/In Review, Priority/<level>, MoSCoW/<level>, Type/<type>
|
||||
[ ] 8. Milestone — PR assigned to the earliest open milestone matching the issue
|
||||
```
|
||||
|
||||
Start processing and never finish unless the system becomes unhealthy and you can't recover.
|
||||
```
|
||||
|
||||
#### Parameters to pass
|
||||
|
||||
All parameters received by this agent are embedded directly into the supervisor prompt template above. There are no additional pass-through parameters from this agent; all inputs are explicitly mapped into the supervisor prompt.
|
||||
|
||||
## **CRITICAL** Rules
|
||||
|
||||
- **Pass all credentials verbatim.** Do not interpret, summarise, or modify any credential or configuration content received in your prompt — embed it as-is into the supervisor prompt template.
|
||||
- **Only pass explicitly-present variables.** When constructing the supervisor prompt, include only variables that were **explicitly present** in your prompt. Omit any variable you fetched from environment variables or git remote.
|
||||
- **Always include the PR Compliance Checklist** in every worker prompt verbatim as shown above. Workers must not create PRs without completing all 8 items.
|
||||
- **Never implement anything yourself.** Your only job is to construct the supervisor prompt and invoke the `supervisor` subagent.
|
||||
- **Never ask questions or give up.** Operate fully autonomously using best judgement.
|
||||
+15
-11
@@ -130,23 +130,25 @@ ensuring data is stored with proper parameter values.
|
||||
|
||||
- **A2A module rename BDD test suite** (#8615): Comprehensive Behave tests validating that the ACP→A2A module rename is complete — verifying all 22 A2A symbols are properly exported, no legacy ACP references remain in `.py` files under `cleveragents.a2a/`, and the module docstring uses current A2A naming. The step definitions include self-contained symbol lookups to avoid cross-scenario dependency failures.
|
||||
|
||||
- Fixed `ReactiveEventBus.emit()` exception handler to log the full exception
|
||||
message (`str(exc)`) and enable traceback forwarding (`exc_info=True`).
|
||||
Previously the handler logged only the exception type name (e.g.
|
||||
"ValueError") with no diagnostic detail, making production debugging
|
||||
impossible. The handler now includes the error message text and full
|
||||
traceback in the structlog warning entry. Removed `@tdd_expected_fail` tag
|
||||
from the TDD test so both scenarios run as normal regression guards. (#988)
|
||||
|
||||
### Added
|
||||
|
||||
- **`pr-review-worker` review-started notification** (#11028): The `first_review`
|
||||
and `re_review` modes now post a "review started" notification comment to the
|
||||
PR at the beginning of the review, giving PR authors immediate visibility
|
||||
that a review is in progress. Posted asynchronously so it does not block
|
||||
the workflow.
|
||||
|
||||
- **Plan Rollback Command** (#8557): Implemented `agents plan rollback <plan-id> [<checkpoint-id>]` for checkpoint-based plan state restoration in Epic #8493. The command restores a plan's sandbox to the state captured at a given checkpoint, discarding all decisions made after that checkpoint. The checkpoint can be specified as an optional positional second argument or via the `--to-checkpoint` named option. Supports `--yes/-y` flag to skip confirmation prompts and `--format/-f` for output format selection (rich/plain/json/yaml). Included with comprehensive BDD test coverage (>= 97%) and spec-aligned output formatting showing rollback summary, changes reverted, impact analysis, and post-rollback state panels.
|
||||
- **Plan Rollback Command** (#8557): Implemented `agents plan rollback <plan-id> [<checkpoint-id>]` for checkpoint-based plan state restoration in Epic #8493. The command restores a plan's sandbox to the state captured at a given checkpoint, discarding all decisions made after that checkpoint. The checkpoint can be specified as an optional positional second argument or via the `--tocheckpoint` named option. Supports `--yes/-y` flag to skip confirmation prompts and `--format/-f` for output format selection (rich/plain/json/yaml). Included with comprehensive BDD test coverage (>= 97%) and spec-aligned output formatting showing rollback summary, changes reverted, impact analysis, and post-rollback state panels.
|
||||
|
||||
- **Implementation Pool Supervisor** (#10069): Added a new
|
||||
`implementation-pool-supervisor.md` agent definition wrapping the
|
||||
implementation supervisor for pool operations, with an embedded mandatory
|
||||
8-item PR Compliance Checklist (CHANGELOG.md update, CONTRIBUTORS.md update,
|
||||
commit footer, CI verification, BDD tests, Epic reference, label application,
|
||||
milestone assignment) that workers must complete before creating any PR.
|
||||
The checklist is also embedded verbatim in the prompt template passed to
|
||||
`implementation-supervisor` so workers receive it during dispatch. YAML
|
||||
frontmatter specifies `model: "CleverThis-8/Qwen3-Coder-Next-GGUF-Q6-K"`
|
||||
and `reasoningEffort: "high"`, matching the convention used by other
|
||||
supervisor agents.
|
||||
|
||||
### Fixed
|
||||
- **ACMS execute-phase assembler respects project-level hot_max_tokens** (#11035): Fixed
|
||||
@@ -210,6 +212,8 @@ ensuring data is stored with proper parameter values.
|
||||
a `_TextualPromptInput` composite (Horizontal + Static + Input) when Textual is
|
||||
available, and a `_FallbackPromptInput` otherwise. Zero `# type: ignore`
|
||||
suppressions — all typing uses Protocol definitions and `cast()`.
|
||||
|
||||
- **ReactiveEventBus.emit() exception handler** (#988): Fixed the exception handler to log the full exception message (`str(exc)`) and enable traceback forwarding (`exc_info=True`). Previously the handler logged only the exception type name (e.g. "ValueError") with no diagnostic detail. The handler now includes the error message text and full traceback in the structlog warning entry. Removed `@tdd_expected_fail` tag from the TDD test so both scenarios run as normal regression guards.
|
||||
- **Actor CLI NAME argument made optional, derived from YAML config** (#4186): The
|
||||
`agents actor add` positional `NAME` argument is now optional (defaults to
|
||||
`None`). When omitted, the actor name is derived from the `name` field in
|
||||
|
||||
+4
-2
@@ -33,11 +33,13 @@ Below are some of the specific details of various contributions.
|
||||
* HAL 9000 has contributed the architecture-pool-supervisor milestone assignment feature (PR #8188 / issue #7521): added `forgejo_update_pull_request` permission and documented the PR workflow for major spec changes, enabling automatic milestone assignment for specification PRs.
|
||||
* HAL 9000 has contributed the git worktree TOCTOU race condition fix (PR #8178 / issue #7507): replaced the unsafe mkdtemp() + rmdir() pattern with a parent-directory approach to eliminate the race window in concurrent git worktree operations.
|
||||
* HAL 9000 has contributed the git_tools TOCTOU race condition fix (PR #8255 / issue #7619): eliminated the Time-Of-Check-To-Time-Of-Use race in `_get_base_env()` by adding double-checked locking with a module-level `threading.Lock`, preventing concurrent threads from writing conflicting environment snapshots.
|
||||
* HAL 9000 has contributed the mandatory PR compliance checklist to `implementation-pool-supervisor.md` (#10069): created a new agent definition with an embedded 8-item PR Compliance Checklist ensuring workers always update CHANGELOG.md, CONTRIBUTORS.md, include commit footers (`ISSUES CLOSED: #N`), verify CI passes, add BDD tests, reference the parent Epic, apply labels via forgejo-label-manager, and assign milestones before creating PRs. Includes concrete examples for each subsection and compliance verification pseudocode.
|
||||
* HAL 9000 has contributed the `implementation-pool-supervisor` prompt template fix (#10069): embedded the full 8-item PR Compliance Checklist into the prompt template passed to workers (fixing review feedback from PR #11015), and added missing `model` and `reasoningEffort` YAML frontmatter fields matching other supervisor agents.
|
||||
* HAL 9000 has contributed the mandatory PR compliance checklist to `implementation-supervisor.md` (#9824): added an 8-item checklist to the worker prompt body with concrete items covering CHANGELOG.md, CONTRIBUTORS.md, commit footer, CI verification, BDD tests, Epic reference, labels, and milestone assignment to eliminate systemic PR merge blockers.
|
||||
* HAL 9000 has contributed the PlanResult.success derivation fix (PR #8214 / issue #7501): replaced the incorrect `error_message is None` heuristic with a dedicated `result_success` column in the plans table, ensuring plans with historical build errors are not incorrectly marked as failed after a successful apply.
|
||||
* HAL 9000 has contributed the mandatory PR compliance checklist to `implementation-pool-supervisor.md` (#9824): created a new agent definition with an embedded 8-item checklist ensuring workers always update CHANGELOG.md, CONTRIBUTORS.md, include commit footers (`ISSUES CLOSED: #N`), verify CI passes, add BDD tests, reference the parent Epic, apply labels via forgejo-label-manager, and assign milestones before creating PRs. Includes concrete examples for each subsection and compliance verification pseudocode.
|
||||
* HAL 9000 has contributed the mandatory PR compliance checklist to `implementation-pool-supervisor.md` (#10069 / #11015): created a new agent definition wrapping implementation-supervisor with an embedded 8-item Checklist in every worker prompt ensuring workers always update CHANGELOG.md, CONTRIBUTORS.md, include commit footers (`ISSUES CLOSED: #N`), verify CI passes, add BDD tests, reference the parent Epic, apply labels via forgejo-label-manager, and assign milestones before creating PRs. Includes concrete examples for each subsection and compliance verification pseudocode.
|
||||
* HAL 9000 has contributed comprehensive milestone documentation for v3.6.0 (Advanced Concepts & Deferred Features) and v3.7.0 (TUI Implementation) (PR #9903): split into sub-documents covering context strategies, LLM backends, resource types, A2A rename, container tool execution, scope chain resolution, cost/safety budgets, E2E workflow tests, code review examples, plugin architecture, TUI layout, persona system, reference/command input, session management, configuration, and TuiMaterializer integration.
|
||||
* HAL 9000 has contributed the LLMTraceRepository data-integrity fix (PR #8185 / issue #7505): replaced the unconditional `session.commit()` in `LLMTraceRepository.save()` with a dual-path implementation that respects the UnitOfWork pattern — flushing only when an external session is provided, and flushing + committing + closing when operating standalone. This eliminates premature transaction commits, loss of rollback capability, and a docstring/implementation mismatch.
|
||||
* HAL 9000 has contributed the LLMTraceRepository data-integrity fix (PR #8185 / issue #7505): replaced the unconditional `session.commit()` in `LLMTraceRepository.save()` with a dual-path implementation that respects the UnitOfWork pattern — flushing only when an external session is provided, and flushing + committing + closing when operating standalone. This eliminates premature transaction commits, loss of rollback capability for subsequent failures, and a docstring/implementation mismatch.
|
||||
* HAL 9000 has contributed the ACMS Index Data Model and File Traversal Engine (PR #9664 / issue #9579): foundational data structures for indexed context entries with hot/warm/cold/archive storage tier classification, tag system, and a timeout-safe chunked file traversal engine for large projects with 10,000+ files.
|
||||
* HAL 9000 has contributed the error-suppression removal fix (PR #9247 / issue #9060): removed both `try...except Exception:` blocks in `register_registry_agents()` that silently suppressed errors from `actor_registry.list_actors()` and the route bridge refresh, enabling exceptions to propagate per CONTRIBUTING.md fail-fast policy. Added three Behave scenarios verifying RuntimeError, AttributeError, and TypeError propagation.
|
||||
* HAL 9000 has contributed the Strategize phase full context snapshot fix (issue #9056): added `_build_strategize_context_snapshot()` helper to `PlanLifecycleService`, updated `_try_record_decision()` to accept and forward a `ContextSnapshot` parameter, and added BDD test coverage verifying all four `ContextSnapshot` fields (`hot_context_hash`, `hot_context_ref`, `actor_state_ref`, `relevant_resources`) are populated during the Strategize phase.
|
||||
|
||||
@@ -0,0 +1,65 @@
|
||||
@mock_only
|
||||
Feature: Implementation Pool Supervisor Checklist Verification
|
||||
|
||||
As an operator of the CleverAgents system
|
||||
I want to verify the implementation-pool-supervisor.md agent definition contains a comprehensive mandatory PR compliance checklist
|
||||
So that implementation workers always follow required PR creation procedures and avoid systematic merge blockers
|
||||
|
||||
Background:
|
||||
Given the implementation-pool-supervisor.md agent definition exists at `.opencode/agents/implementation-pool-supervisor.md`
|
||||
|
||||
Scenario: Agent file has valid YAML frontmatter with supervisor configuration
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: the file starts with YAML frontmatter (three dashes `---`)
|
||||
And Pool: the mode is set to "all" for continuous operation
|
||||
And Pool: the temperature is set to 0.0
|
||||
And Pool: the model field is specified for deterministic behavior
|
||||
|
||||
Scenario: Agent has PR Compliance Checklist section documented
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: worker prompt body includes a section titled "PR Compliance Checklist"
|
||||
And Pool: the checklist is marked as MANDATORY
|
||||
|
||||
Scenario: Checklist item 1 — CHANGELOG.md update mandatory
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: worker prompt body includes a CHANGELOG.md checklist item
|
||||
And Pool: the item instructs workers to add an entry under the Unreleased section
|
||||
|
||||
Scenario: Checklist item 2 — CONTRIBUTORS.md update mandatory
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: worker prompt body includes a CONTRIBUTORS.md checklist item
|
||||
And Pool: the item instructs workers to add or update their contribution entry
|
||||
|
||||
Scenario: Checklist item 3 — commit footer mandatory
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: worker prompt body includes a commit footer checklist item
|
||||
And Pool: the item specifies the ISSUES CLOSED footer format with issue number placeholder
|
||||
|
||||
Scenario: Checklist item 4 — CI passes before PR creation mandatory
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: worker prompt body includes a CI passes checklist item
|
||||
And Pool: the item instructs workers to verify all quality gates are green before requesting review
|
||||
|
||||
Scenario: Checklist item 5 — BDD/Behave tests mandatory
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: worker prompt body includes a BDD tests checklist item
|
||||
And Pool: the item instructs workers to add or updated Behave feature files for changed behaviour
|
||||
|
||||
Scenario: Checklist item 6 — Epic reference mandatory
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: worker prompt body includes an Epic reference checklist item
|
||||
And Pool: the item instructs workers to reference the parent Epic issue number in PR description
|
||||
|
||||
Scenario: Checklist item 7 — Labels must be applied via forgejo-label-manager
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: worker prompt body includes a labels checklist item
|
||||
And Pool: the item instructs workers to apply labels including State/In Review, Priority/<level>, MoSCoW/<level>, and Type/<type>
|
||||
|
||||
Scenario: Checklist item 8 — Milestone must be assigned
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: worker prompt body includes a milestone checklist item
|
||||
And Pool: the item instructs workers to assign PR to the earliest open milestone matching the issue
|
||||
|
||||
Scenario: All 8 mandatory checklist items present in worker prompt
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: worker prompt body contains all 8 mandatory checklist items with correct numbering
|
||||
@@ -0,0 +1,58 @@
|
||||
@mock_only
|
||||
Feature: PR Compliance Checklist in Implementation Pool Supervisor
|
||||
|
||||
As a pool supervisor
|
||||
I want to pass a mandatory PR compliance checklist to every worker prompt
|
||||
So that implementation workers complete all required items before creating a PR and avoid systemic merge blockers
|
||||
|
||||
Background:
|
||||
Given the implementation-pool-supervisor.md agent definition exists
|
||||
|
||||
Scenario: Pool supervisor worker prompt includes the PR compliance checklist
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: worker prompt body includes the PR compliance checklist section
|
||||
And Pool: the checklist is marked as MANDATORY
|
||||
|
||||
Scenario: Checklist item 1 — CHANGELOG.md update required
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: worker prompt body includes a CHANGELOG.md checklist item
|
||||
And Pool: the item instructs workers to add an entry under the Unreleased section
|
||||
|
||||
Scenario: Checklist item 2 — CONTRIBUTORS.md update required
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: worker prompt body includes a CONTRIBUTORS.md checklist item
|
||||
And Pool: the item instructs workers to add or update their contribution entry
|
||||
|
||||
Scenario: Checklist item 3 — commit footer required
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: worker prompt body includes a commit footer checklist item
|
||||
And Pool: the item specifies the ISSUES CLOSED footer format
|
||||
|
||||
Scenario: Checklist item 4 — CI must pass before PR creation
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: worker prompt body includes a CI passes checklist item
|
||||
And Pool: the item instructs workers to verify all quality gates are green
|
||||
|
||||
Scenario: Checklist item 5 — BDD/Behave tests required
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: worker prompt body includes a BDD tests checklist item
|
||||
And Pool: the item instructs workers to add or update Behave feature files
|
||||
|
||||
Scenario: Checklist item 6 — Epic reference required in PR description
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: worker prompt body includes an Epic reference checklist item
|
||||
And Pool: the item instructs workers to reference the parent Epic issue number
|
||||
|
||||
Scenario: Checklist item 7 — Labels must be applied
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: worker prompt body includes a labels checklist item
|
||||
And Pool: the item instructs workers to apply labels via forgejo-label-manager
|
||||
|
||||
Scenario: Checklist item 8 — Milestone must be assigned
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: worker prompt body includes a milestone checklist item
|
||||
And Pool: the item instructs workers to assign the earliest open milestone
|
||||
|
||||
Scenario: All 8 checklist items are present in the worker prompt
|
||||
When I read the pool supervisor agent definition
|
||||
Then Pool: worker prompt body contains all 8 mandatory checklist items
|
||||
@@ -0,0 +1,243 @@
|
||||
"""Step definitions for implementation pool supervisor checklist verification.
|
||||
|
||||
This file provides unique '@then' step definitions prefixed with "Pool:" so they
|
||||
never conflict with the shared pr_compliance_checklist_steps.py or
|
||||
pr_compliance_pool_supervisor_steps.py step definitions when features are run together.
|
||||
|
||||
Each validator checks a specific aspect of the implementation-pool-supervisor.md
|
||||
agent definition to verify the mandatory PR Compliance Checklist is properly integrated.
|
||||
"""
|
||||
|
||||
from collections.abc import Callable
|
||||
from pathlib import Path
|
||||
from typing import Any
|
||||
|
||||
from behave import given, then, when
|
||||
|
||||
PROJECT_ROOT = Path(__file__).resolve().parents[2]
|
||||
AGENT_DEF_PATH = PROJECT_ROOT / ".opencode" / "agents" / "implementation-pool-supervisor.md"
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Shared validation helpers
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
_required_items = [
|
||||
"CHANGELOG.md",
|
||||
"CONTRIBUTORS.md",
|
||||
"ISSUES CLOSED",
|
||||
"CI passes",
|
||||
"BDD/Behave tests",
|
||||
"Epic reference",
|
||||
"forgejo-label-manager",
|
||||
"earliest open milestone",
|
||||
]
|
||||
|
||||
VALIDATORS: dict[str, Callable[[str], bool]] = {
|
||||
"has yaml frontmatter": lambda c: c.strip().startswith("---"),
|
||||
"mode is all": lambda c: 'mode: all' in c or 'mode: "all"' in c,
|
||||
"temperature is 0.0": lambda c: 'temperature: 0.0' in c or 'temperature: "0.0"' in c,
|
||||
"model field specified": lambda c: 'model:' in c,
|
||||
"has PR Compliance Checklist section": lambda c: "PR Compliance Checklist" in c,
|
||||
"is marked MANDATORY": lambda c: "MANDATORY" in c or "mandatory" in c.lower(),
|
||||
"has CHANGELOG.md item": lambda c: "CHANGELOG.md" in c,
|
||||
"references Unreleased": lambda c: "[Unreleased]" in c,
|
||||
"has CONTRIBUTORS.md item": lambda c: "CONTRIBUTORS.md" in c,
|
||||
"instructs add or update": lambda c: "add or update" in c,
|
||||
"has commit footer item": lambda c: "Commit footer" in c or "commit footer" in c.lower(),
|
||||
"specifies ISSUES CLOSED": lambda c: "ISSUES CLOSED" in c,
|
||||
"has CI passes item": lambda c: "CI passes" in c,
|
||||
"mentions quality gates": lambda c: "quality gates" in c.lower() or "all quality gates" in c.lower(),
|
||||
"has BDD/Behave tests item": lambda c: ("BDD/Behave tests" in c) or ("bdd" in c and "behave" in c.lower()),
|
||||
"instructs add or updated features": lambda c: ("added or updated" in c) or ("add or updated" in c),
|
||||
"has Epic reference item": lambda c: "Epic reference" in c,
|
||||
"references parent Epic": lambda c: "parent Epic" in c or "epic issue number" in c.lower(),
|
||||
"has labels item": lambda c: "Labels" in c or "labels" in c,
|
||||
"mentions forgejo-label-manager": lambda c: "forgejo-label-manager" in c,
|
||||
"has milestone item": lambda c: "Milestone" in c or "milestone" in c,
|
||||
"earliest open milestone": lambda c: "earliest open milestone" in c,
|
||||
"all 8 items present": lambda c: all(item in c for item in _required_items),
|
||||
"has numbered checklist items": lambda c: "[ ] 1." in c and "[ ] 8." in c,
|
||||
}
|
||||
|
||||
|
||||
def _make_validator(key: str) -> Callable[[Any], None]:
|
||||
"""Factory that creates a typed Behave validator from a shared helper."""
|
||||
|
||||
def validator(context: Any) -> None:
|
||||
content = context.agent_def_content
|
||||
check_fn = VALIDATORS.get(key)
|
||||
assert check_fn is not None, (
|
||||
f"Pool supervisor agent definition validation key missing: {key}"
|
||||
)
|
||||
assert check_fn(content), (
|
||||
f"Pool supervisor agent definition failed for '{key}'. "
|
||||
f"Content length: {len(content)} chars"
|
||||
)
|
||||
|
||||
return validator
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Unique @given and @when — scoped to the pool supervisor agent def only
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
|
||||
@given("the implementation-pool-supervisor.md agent definition exists")
|
||||
def step_agent_def_exists(context: Any) -> None:
|
||||
"""Verify the pool supervisor agent definition file exists."""
|
||||
assert AGENT_DEF_PATH.exists(), f"Agent definition not found at {AGENT_DEF_PATH}"
|
||||
context.agent_def_path = AGENT_DEF_PATH
|
||||
|
||||
|
||||
@when("I read the pool supervisor agent definition")
|
||||
def step_read_agent_def(context: Any) -> None:
|
||||
"""Read the pool supervisor agent definition file into context."""
|
||||
context.agent_def_content = AGENT_DEF_PATH.read_text(encoding="utf-8")
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Unique @then — prefixed with "Pool:" to prevent AmbiguousStep conflicts
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
@then("Pool: the file starts with YAML frontmatter (three dashes `---`)")
|
||||
def step_yaml_frontmatter(context: Any) -> None:
|
||||
"""Verify the agent definition starts with YAML frontmatter."""
|
||||
step_make_validator("has yaml frontmatter")(context)
|
||||
|
||||
|
||||
@then("Pool: the mode is set to \"all\" for continuous operation")
|
||||
def step_mode_all(context: Any) -> None:
|
||||
"""Verify mode is set to 'all'."""
|
||||
step_make_validator("mode is all")(context)
|
||||
|
||||
|
||||
@then("Pool: the temperature is set to 0.0")
|
||||
def step_temperature(context: Any) -> None:
|
||||
"""Verify temperature is 0.0."""
|
||||
step_make_validator("temperature is 0.0")(context)
|
||||
|
||||
|
||||
@then("Pool: the model field is specified for deterministic behavior")
|
||||
def step_model_specified(context: Any) -> None:
|
||||
"""Verify a model field is present in YAML frontmatter."""
|
||||
step_make_validator("model field specified")(context)
|
||||
|
||||
|
||||
@then("Pool: worker prompt body includes a section titled \"PR Compliance Checklist\"")
|
||||
def step_checklist_section_exists(context: Any) -> None:
|
||||
"""Verify a PR Compliance Checklist section exists."""
|
||||
step_make_validator("has PR Compliance Checklist section")(context)
|
||||
|
||||
|
||||
@then("Pool: the checklist is marked as MANDATORY")
|
||||
def step_mandatory_marked(context: Any) -> None:
|
||||
"""Verify the checklist is marked mandatory."""
|
||||
step_make_validator("is marked MANDATORY")(context)
|
||||
|
||||
|
||||
@then("Pool: worker prompt body includes a CHANGELOG.md checklist item")
|
||||
def step_changelog_item(context: Any) -> None:
|
||||
"""Verify CHANGELOG.md checklist item exists."""
|
||||
step_make_validator("has CHANGELOG.md item")(context)
|
||||
|
||||
|
||||
@then("Pool: the item instructs workers to add an entry under the Unreleased section")
|
||||
def step_unreleased_instruction(context: Any) -> None:
|
||||
"""Verify instruction to add entry under [Unreleased]."""
|
||||
step_make_validator("references Unreleased")(context)
|
||||
|
||||
|
||||
@then("Pool: worker prompt body includes a CONTRIBUTORS.md checklist item")
|
||||
def step_contributors_item(context: Any) -> None:
|
||||
"""Verify CONTRIBUTORS.md checklist item exists."""
|
||||
step_make_validator("has CONTRIBUTORS.md item")(context)
|
||||
|
||||
|
||||
@then("Pool: the item instructs workers to add or update their contribution entry")
|
||||
def step_add_update_instruction(context: Any) -> None:
|
||||
"""Verify instruction to add or update contributions."""
|
||||
step_make_validator("instructs add or update")(context)
|
||||
|
||||
|
||||
@then("Pool: worker prompt body includes a commit footer checklist item")
|
||||
def step_commit_footer_item(context: Any) -> None:
|
||||
"""Verify commit footer checklist item exists."""
|
||||
step_make_validator("has commit footer item")(context)
|
||||
|
||||
|
||||
@then("Pool: the item specifies the ISSUES CLOSED footer format with issue number placeholder")
|
||||
def step_issues_closed_format(context: Any) -> None:
|
||||
"""Verify ISSUES CLOSED footer format specification."""
|
||||
step_make_validator("specifies ISSUES CLOSED")(context)
|
||||
|
||||
|
||||
@then("Pool: worker prompt body includes a CI passes checklist item")
|
||||
def step_ci_passes_item(context: Any) -> None:
|
||||
"""Verify CI passes checklist item exists."""
|
||||
step_make_validator("has CI passes item")(context)
|
||||
|
||||
|
||||
@then("Pool: the item instructs workers to verify all quality gates are green before requesting review")
|
||||
def step_quality_gates_instruction(context: Any) -> None:
|
||||
"""Verify instruction about quality gates being green."""
|
||||
step_make_validator("mentions quality gates")(context)
|
||||
|
||||
|
||||
@then("Pool: worker prompt body includes a BDD tests checklist item")
|
||||
def step_bdd_item(context: Any) -> None:
|
||||
"""Verify BDD/Behave tests checklist item exists."""
|
||||
step_make_validator("has BDD/Behave tests item")(context)
|
||||
|
||||
|
||||
@then("Pool: the item instructs workers to add or updated Behave feature files for changed behaviour")
|
||||
def step_bdd_feature_instruction(context: Any) -> None:
|
||||
"""Verify instruction about adding or updating BDD features."""
|
||||
step_make_validator("instructs add or updated features")(context)
|
||||
|
||||
|
||||
@then("Pool: worker prompt body includes an Epic reference checklist item")
|
||||
def step_epic_item(context: Any) -> None:
|
||||
"""Verify Epic reference checklist item exists."""
|
||||
step_make_validator("has Epic reference item")(context)
|
||||
|
||||
|
||||
@then("Pool: the item instructs workers to reference the parent Epic issue number in PR description")
|
||||
def step_parent_epic_instruction(context: Any) -> None:
|
||||
"""Verify instruction about referencing parent Epic."""
|
||||
step_make_validator("references parent Epic")(context)
|
||||
|
||||
|
||||
@then("Pool: worker prompt body includes a labels checklist item")
|
||||
def step_labels_item(context: Any) -> None:
|
||||
"""Verify labels checklist item exists."""
|
||||
step_make_validator("has labels item")(context)
|
||||
|
||||
|
||||
@then("Pool: the item instructs workers to apply labels including State/In Review, Priority/<level>, MoSCoW/<level>, and Type/<type>")
|
||||
def step_label_details_instruction(context: Any) -> None:
|
||||
"""Verify detailed label application instructions via forgejo-label-manager."""
|
||||
step_make_validator("mentions forgejo-label-manager")(context)
|
||||
|
||||
|
||||
@then("Pool: worker prompt body includes a milestone checklist item")
|
||||
def step_milestone_item(context: Any) -> None:
|
||||
"""Verify milestone checklist item exists."""
|
||||
step_make_validator("has milestone item")(context)
|
||||
|
||||
|
||||
@then("Pool: the item instructs workers to assign PR to the earliest open milestone matching the issue")
|
||||
def step_earliest_milestone_instruction(context: Any) -> None:
|
||||
"""Verify instruction about earliest open milestone assignment."""
|
||||
step_make_validator("earliest open milestone")(context)
|
||||
|
||||
|
||||
@then("Pool: worker prompt body contains all 8 mandatory checklist items with correct numbering")
|
||||
def step_all_8_items(context: Any) -> None:
|
||||
"""Verify all 8 checklist items are present and numbered."""
|
||||
step_make_validator("all 8 items present")(context)
|
||||
step_make_validator("has numbered checklist items")(context)
|
||||
|
||||
|
||||
# Re-export helper for use in other modules if needed
|
||||
step_make_validator = _make_validator
|
||||
@@ -0,0 +1,222 @@
|
||||
"""Step definitions for PR compliance checklist in implementation pool supervisor.
|
||||
|
||||
This file uses parameterized @then decorators with unique step text that
|
||||
distinguishes pool-supervisor checks from the shared compliance checklist
|
||||
steps in pr_compliance_checklist_steps.py, preventing Behave AmbiguousStep
|
||||
errors when both feature files are run together.
|
||||
|
||||
Each validator is imported from the shared pr_compliance_checklist_steps module's
|
||||
validation logic (via the _verify module) to avoid code duplication while using
|
||||
unique step text prefixes ("Pool:") for disambiguation.
|
||||
"""
|
||||
|
||||
from collections.abc import Callable
|
||||
from pathlib import Path
|
||||
from typing import Any
|
||||
|
||||
from behave import given, then, when
|
||||
|
||||
PROJECT_ROOT = Path(__file__).resolve().parents[2]
|
||||
AGENT_DEF_PATH = (
|
||||
PROJECT_ROOT / ".opencode" / "agents" / "implementation-pool-supervisor.md"
|
||||
)
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Shared validation helpers — identical logic to pr_compliance_checklist_steps.py
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
_required_items = [
|
||||
"CHANGELOG.md",
|
||||
"CONTRIBUTORS.md",
|
||||
"ISSUES CLOSED",
|
||||
"CI passes",
|
||||
"BDD/Behave tests",
|
||||
"Epic reference",
|
||||
"forgejo-label-manager",
|
||||
"earliest open milestone",
|
||||
]
|
||||
|
||||
VALIDATORS: dict[str, Callable[[str], bool]] = {
|
||||
"includes checklist section": lambda c: "PR Compliance Checklist" in c,
|
||||
"is marked MANDATORY": lambda c: "MANDATORY" in c,
|
||||
"has CHANGELOG.md item": lambda c: "CHANGELOG.md" in c,
|
||||
"references Unreleased": lambda c: "[Unreleased]" in c,
|
||||
"has CONTRIBUTORS.md item": lambda c: "CONTRIBUTORS.md" in c,
|
||||
"instructs add or update": lambda c: "add or update" in c,
|
||||
"has commit footer item": lambda c: "Commit footer" in c,
|
||||
"specifies ISSUES CLOSED": lambda c: "ISSUES CLOSED" in c,
|
||||
"has CI passes item": lambda c: "CI passes" in c,
|
||||
"mentions quality gates": lambda c: "quality gates" in c,
|
||||
"has BDD tests item": lambda c: "BDD/Behave tests" in c,
|
||||
"instructs add or update features": lambda c: "added or updated" in c,
|
||||
"has Epic reference item": lambda c: "Epic reference" in c,
|
||||
"references parent Epic": lambda c: "parent Epic" in c,
|
||||
"has labels item": lambda c: "Labels" in c,
|
||||
"mentions forgejo-label-manager": lambda c: "forgejo-label-manager" in c,
|
||||
"has milestone item": lambda c: "Milestone" in c,
|
||||
"earliest open milestone": lambda c: "earliest open milestone" in c,
|
||||
"all 8 items present": lambda c: all(item in c for item in _required_items),
|
||||
}
|
||||
|
||||
|
||||
def _make_validator(key: str) -> Callable[[Any], None]:
|
||||
"""Factory that creates a typed Behave validator from a shared helper."""
|
||||
|
||||
def validator(context: Any) -> None:
|
||||
content = context.agent_def_content
|
||||
check_fn = VALIDATORS.get(key)
|
||||
assert check_fn is not None, (
|
||||
f"Pool supervisor agent definition validation key missing: {key}"
|
||||
)
|
||||
assert check_fn(content), f"Pool supervisor agent definition failed: {key}"
|
||||
|
||||
return validator
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Unique @given and @when — scoped to the pool supervisor agent def only
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
|
||||
@given("the implementation-pool-supervisor.md agent definition exists")
|
||||
def step_agent_def_exists(context: Any) -> None:
|
||||
"""Verify the pool supervisor agent definition file exists."""
|
||||
assert AGENT_DEF_PATH.exists(), f"Agent definition not found at {AGENT_DEF_PATH}"
|
||||
context.agent_def_path = AGENT_DEF_PATH
|
||||
|
||||
|
||||
@when("I read the pool supervisor agent definition")
|
||||
def step_read_agent_def(context: Any) -> None:
|
||||
"""Read the pool supervisor agent definition."""
|
||||
context.agent_def_content = AGENT_DEF_PATH.read_text(encoding="utf-8")
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Unique @then — prefixed with "Pool:" so they never conflict with the
|
||||
# shared pr_compliance_checklist_steps.py step definitions.
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
|
||||
# Scenario: Pool supervisor worker prompt includes the PR compliance checklist
|
||||
@then("Pool: worker prompt body includes the PR compliance checklist section")
|
||||
def pool_step_prompt_includes_checklist(context: Any) -> None:
|
||||
"""Verify the pool-supervisor worker prompt body includes the PR compliance checklist."""
|
||||
_make_validator("includes checklist section")(context)
|
||||
|
||||
|
||||
@then("Pool: the checklist is marked as MANDATORY")
|
||||
def pool_step_checklist_is_mandatory(context: Any) -> None:
|
||||
"""Verify the pool-supervisor checklist is marked as MANDATORY."""
|
||||
_make_validator("is marked MANDATORY")(context)
|
||||
|
||||
|
||||
# Scenario: Checklist item 1 — CHANGELOG.md update required
|
||||
@then("Pool: worker prompt body includes a CHANGELOG.md checklist item")
|
||||
def pool_step_prompt_includes_changelog_item(context: Any) -> None:
|
||||
"""Verify the pool-supervisor worker prompt body includes a CHANGELOG.md checklist item."""
|
||||
_make_validator("has CHANGELOG.md item")(context)
|
||||
|
||||
|
||||
@then("Pool: the item instructs workers to add an entry under the Unreleased section")
|
||||
def pool_step_changelog_item_unreleased(context: Any) -> None:
|
||||
"""Verify the CHANGELOG.md item mentions the Unreleased section."""
|
||||
_make_validator("references Unreleased")(context)
|
||||
|
||||
|
||||
# Scenario: Checklist item 2 — CONTRIBUTORS.md update required
|
||||
@then("Pool: worker prompt body includes a CONTRIBUTORS.md checklist item")
|
||||
def pool_step_prompt_includes_contributors_item(context: Any) -> None:
|
||||
"""Verify the pool-supervisor worker prompt body includes a CONTRIBUTORS.md checklist item."""
|
||||
_make_validator("has CONTRIBUTORS.md item")(context)
|
||||
|
||||
|
||||
@then("Pool: the item instructs workers to add or update their contribution entry")
|
||||
def pool_step_contributors_item_add_update(context: Any) -> None:
|
||||
"""Verify the CONTRIBUTORS.md item instructs workers to add or update."""
|
||||
_make_validator("instructs add or update")(context)
|
||||
|
||||
|
||||
# Scenario: Checklist item 3 — commit footer required
|
||||
@then("Pool: worker prompt body includes a commit footer checklist item")
|
||||
def pool_step_prompt_includes_commit_footer_item(context: Any) -> None:
|
||||
"""Verify the pool-supervisor worker prompt body includes a commit footer checklist item."""
|
||||
_make_validator("has commit footer item")(context)
|
||||
|
||||
|
||||
@then("Pool: the item specifies the ISSUES CLOSED footer format")
|
||||
def pool_step_commit_footer_issues_closed(context: Any) -> None:
|
||||
"""Verify the commit footer item specifies the ISSUES CLOSED format."""
|
||||
_make_validator("specifies ISSUES CLOSED")(context)
|
||||
|
||||
|
||||
# Scenario: Checklist item 4 — CI must pass before PR creation
|
||||
@then("Pool: worker prompt body includes a CI passes checklist item")
|
||||
def pool_step_prompt_includes_ci_item(context: Any) -> None:
|
||||
"""Verify the pool-supervisor worker prompt body includes a CI passes checklist item."""
|
||||
_make_validator("has CI passes item")(context)
|
||||
|
||||
|
||||
@then("Pool: the item instructs workers to verify all quality gates are green")
|
||||
def pool_step_ci_item_quality_gates(context: Any) -> None:
|
||||
"""Verify the CI item instructs workers to verify quality gates are green."""
|
||||
_make_validator("mentions quality gates")(context)
|
||||
|
||||
|
||||
# Scenario: Checklist item 5 — BDD/Behave tests required
|
||||
@then("Pool: worker prompt body includes a BDD tests checklist item")
|
||||
def pool_step_prompt_includes_bdd_item(context: Any) -> None:
|
||||
"""Verify the pool-supervisor worker prompt body includes a BDD/Behave tests checklist item."""
|
||||
_make_validator("has BDD tests item")(context)
|
||||
|
||||
|
||||
@then("Pool: the item instructs workers to add or update Behave feature files")
|
||||
def pool_step_bdd_item_feature_files(context: Any) -> None:
|
||||
"""Verify the BDD item instructs workers to add or update feature files."""
|
||||
_make_validator("instructs add or update features")(context)
|
||||
|
||||
|
||||
# Scenario: Checklist item 6 — Epic reference required in PR description
|
||||
@then("Pool: worker prompt body includes an Epic reference checklist item")
|
||||
def pool_step_prompt_includes_epic_item(context: Any) -> None:
|
||||
"""Verify the pool-supervisor worker prompt body includes an Epic reference checklist item."""
|
||||
_make_validator("has Epic reference item")(context)
|
||||
|
||||
|
||||
@then("Pool: the item instructs workers to reference the parent Epic issue number")
|
||||
def pool_step_epic_item_parent_reference(context: Any) -> None:
|
||||
"""Verify the Epic item instructs workers to reference the parent Epic."""
|
||||
_make_validator("references parent Epic")(context)
|
||||
|
||||
|
||||
# Scenario: Checklist item 7 — Labels must be applied
|
||||
@then("Pool: worker prompt body includes a labels checklist item")
|
||||
def pool_step_prompt_includes_labels_item(context: Any) -> None:
|
||||
"""Verify the pool-supervisor worker prompt body includes a labels checklist item."""
|
||||
_make_validator("has labels item")(context)
|
||||
|
||||
|
||||
@then("Pool: the item instructs workers to apply labels via forgejo-label-manager")
|
||||
def pool_step_labels_item_forgejo_label_manager(context: Any) -> None:
|
||||
"""Verify the labels item instructs workers to use forgejo-label-manager."""
|
||||
_make_validator("mentions forgejo-label-manager")(context)
|
||||
|
||||
|
||||
# Scenario: Checklist item 8 — Milestone must be assigned
|
||||
@then("Pool: worker prompt body includes a milestone checklist item")
|
||||
def pool_step_prompt_includes_milestone_item(context: Any) -> None:
|
||||
"""Verify the pool-supervisor worker prompt body includes a milestone checklist item."""
|
||||
_make_validator("has milestone item")(context)
|
||||
|
||||
|
||||
@then("Pool: the item instructs workers to assign the earliest open milestone")
|
||||
def pool_step_milestone_item_earliest(context: Any) -> None:
|
||||
"""Verify the milestone item instructs workers to assign the earliest open milestone."""
|
||||
_make_validator("earliest open milestone")(context)
|
||||
|
||||
|
||||
# Scenario: All 8 checklist items are present in the worker prompt
|
||||
@then("Pool: worker prompt body contains all 8 mandatory checklist items")
|
||||
def pool_step_prompt_contains_all_8_items(context: Any) -> None:
|
||||
"""Verify the pool-supervisor worker prompt body contains all 8 mandatory checklist items."""
|
||||
_make_validator("all 8 items present")(context)
|
||||
Reference in New Issue
Block a user