Fix actor add --config crash with combined-format config.actor (#11189) #11232
Merged
HAL9000
merged 5 commits from 2026-05-29 02:14:12 +00:00
fix/issue-11189-config-actor-format into master
Labels
Clear labels
auto/needs-reevaluation
controller-managed
overdue
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Needs Feedback
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
Currently being processed by an implementer worker.
Currently being processed by the merge driver.
Currently being processed by a reviewer worker.
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
Tracking issues used by the AI Automation system for agents to communicate and report.
Rebase conflict needs LLM conflict-resolver.
Failing CI needs implementer attention.
Documenting a driver incident or rollback.
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
Projects
Clear projects
No project
Assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
Clear assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cleveragents/cleveragents-core#11232
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "fix/issue-11189-config-actor-format"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes actor registration crash when using the spec-compliant combined
config.actorformat.Problem
Users running
agents actor add --config ./actor.yamlwith a YAML file using combined-format config.actor crashed with "Invalid value: 'provider' is required" because the parser never flattened the nested structure.Solution (three-layer defense)
schema.py::_detect_nested_config_actor): Recognizes both compact string form and nested dict ofconfig.actor.actor.py: add()): Merges config["actor"] fields into the top-level blob before downstream processing.config.py::from_blob()+_extract_v3_actor()): Flattens at the model level with priority: (1) config-actor, (2) top-level type, (3) actors map fallback.Changes
src/cleveragents/actor/schema.py: Added 3 new functions, extended is_v3_yaml()src/cleveragents/actor/config.py: Reworked from_blob() and _extract_v3_actor()src/cleveragents/cli/commands/actor.py: Added flattening steptests/actor/test_config_actor_combined_format.py: 20 test casesfeatures/actor_add_combined_config_format.feature: BDD scenariosCloses: #11189
Closes #11189
When users register actors via `agents actor add --config` using the spec-compliant combined config.actor YAML format — either as a compact string (config:\n actor: "<provider>/<model>") or as a nested dict (config:\n actor:\n type: llm\n provider: aws) — the CLI crashed with click.BadParameter: "Invalid value: 'provider' is required" because the parser did not detect or flatten the nested structure. Added: - _detect_nested_config_actor() in schema.py to recognise both compact-string and nested-dict forms of config-actor format. - _flatten_config_actor() in schema.py to merge config["actor"] fields into the dict top-level (removing the wrapper). - Flattening logic in ActorConfiguration.from_blob() to handle both string ("<provider>/<model>") and nested-dict forms of config.actor. - CLI flattening step at the start of `agents actor add` command. - New BDD scenarios for combined-format registration. - Unit tests for detection, flattening, schema-v3 detection, and full from_blob() flow. ISSUES CLOSED: #11189CI Checks Required
No CI checks have been reported as passing for this PR. Per company policy, all CI gates (lint, typecheck, security_scan, unit_tests, coverage_report) must pass before a PR can be approved and merged.
Please ensure the following CI checks are configured and passing before resubmission for review:
lint— ruff linting + format checktypecheck— Pyright strict type checking (zero # type: ignore tolerated)security_scan— bandit + semgrep + vultureunit_tests— Behave BDD tests in features/coverage_report— Slipcover coverage measurement (must be >= 97%)Note: A full code review will be conducted once CI checks are in place. This PR is currently blocked by CI gate failure.
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
ca7668befato728b68f034728b68f034to32a23f32a6Lint (ruff): - schema.py: import `cast`, replace non-breaking hyphens, inline SIM103 return, wrap long is_nested_v3 line - config.py: replace `if k in d: del d[k]` with `pop`, collapse nested ifs (SIM102) - format both reformatted-only files (ruff format) Typecheck (pyright): - config.py: guard `actor_type.lower()` calls with isinstance checks so the None branch is type-safe Unit tests (behave): - Remove duplicate `@then('v3actor the command ...')` and `@then('the actor should be registered with type ...')` registrations that crashed step-registry with AmbiguousStep — shared versions live in actor_add_v3_schema_validation_steps.py - Add missing Actor import; drop unused ActorConfiguration / is_v3_yaml imports and unused provider/model locals - Populate `context.registered_actor_type` from the upsert call args so the shared assertion step works for combined-format scenarios - Add a `@when("I run the actor add command without a name argument")` step that exercises the CLI's "Actor name is required" validation path (the previously-active step always supplied a name, masking the scenario's intent) ISSUES CLOSED: #11189Coverage (96.5% threshold) was failing because the prior implementation of `_extract_v3_actor` and `_extract_config_actor` contained unreachable code that the test suite could not exercise. schema.py — remove `_extract_config_actor()`. The function was defined but never called. `_detect_nested_config_actor` + `_flatten_config_actor` (both used by `cli/commands/actor.py`) cover all real call sites. config.py — remove the `if isinstance(config_block, dict):` branch in `_extract_v3_actor`. `from_blob` already flattens `config.actor` and pops the `config` key BEFORE calling `_extract_v3_actor` (lines 207-221), so `data.get("config")` always returns None and the branch is dead. Net: -88 LoC, no semantic change (the dead code never executed). The existing BDD scenarios in `features/actor_add_combined_config_format.feature` continue to pass unchanged. ISSUES CLOSED: #11189Claimed by
merge_drive.py(pid 1264876) until2026-05-29T03:44:06.129786+00:00.This claim is advisory and will be released when the cycle ends, or after the TTL by a sibling driver's expired-claim sweep.
Approved by the controller reviewer stage (workflow 23).
event occurred 2026-05-28T21:28:31.976830+00:00
📋 Estimate: tier 1.
All six CI failures cascade from a single IndentationError in config.py:76 (@classmethod decorator at wrong indentation level), plus a missing
castimport in schema.py. Secondary issues include Ruff violations (non-breaking hyphens, SIM103 inline condition, E501 line length), Pyright errors (reportOptionalMemberAccess,from_blobunknown attribute), and type annotation gaps. The feature itself spans 4 source files (+837/-51 LOC): schema.py (3 new functions + extended is_v3_yaml), config.py (reworked from_blob + _extract_v3_actor), CLI actor.py (flattening step), plus 20-case test file and BDD scenarios. Multi-file scope, type-checking requirements, and need to understand the three-layer flattening architecture place this squarely at tier 1.(attempt #2, tier 1)
event occurred 2026-05-28T21:30:59.964175+00:00
🔧 Implementer attempt —
rebase-failed.Blockers:
(attempt #12, tier 2)
event occurred 2026-05-29T00:25:40.566033+00:00
🔧 Implementer attempt —
rebased.Pushed 1 commit:
32a23f3.(attempt #13, tier 2)
event occurred 2026-05-29T00:48:33.882591+00:00
🔧 Implementer attempt —
resolved.Pushed 1 commit:
aecbaa0.Files touched:
features/actor_add_combined_config_format.feature,features/steps/actor_add_combined_config_format_steps.py,src/cleveragents/actor/config.py,src/cleveragents/actor/schema.py,tests/actor/test_config_actor_combined_format.py.(attempt #14, tier 2)
event occurred 2026-05-29T01:31:38.702976+00:00
🔧 Implementer attempt —
resolved.Pushed 1 commit:
7f30f4f.Files touched:
src/cleveragents/actor/config.py,src/cleveragents/actor/schema.py.event occurred 2026-05-29T02:05:36.789737+00:00
✅ Approved
Reviewed at commit
7f30f4f.Confidence: medium.