cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

feat(server): remote repo operations implementation #1122

Closed
freemo wants to merge 2 commits from feature/m9-remote-repos into master
pull from: feature/m9-remote-repos
merge into: cleveragents:master
Conversation 3 Commits 2 Files Changed 23
+3403 -19
freemo commented 2026-03-23 04:25:28 +00:00
Owner
Copy Link
Copy Source
No description provided.
freemo added this to the v3.8.0 milestone 2026-03-23 04:25:28 +00:00
freemo added the
Type
Feature
 label 2026-03-23 04:25:28 +00:00
freemo added 1 commit 2026-03-23 04:25:28 +00:00
feat(server): ASGI endpoint via uvicorn
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 20s
Details
CI / security (pull_request) Failing after 51s
Details
CI / lint (pull_request) Successful in 3m39s
Details
CI / quality (pull_request) Successful in 3m46s
Details
CI / typecheck (pull_request) Successful in 3m56s
Details
CI / e2e_tests (pull_request) Successful in 8m39s
Details
CI / coverage (pull_request) Successful in 11m6s
Details
CI / integration_tests (pull_request) Failing after 16m23s
Details
CI / unit_tests (pull_request) Failing after 16m23s
Details
CI / benchmark-regression (pull_request) Successful in 52m29s
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 1s
Details
5f0a545113 
Implement FastAPI-based ASGI application served by uvicorn for
the CleverAgents server mode. Add health check endpoint, A2A
JSON-RPC routing, configurable host:port binding, and graceful
shutdown handling. Server launches via `agents server start`.

- Add FastAPI ASGI app factory at infrastructure/server/asgi_app.py
  with /.well-known/agent.json (Agent Card), /health (liveness),
  and /a2a (A2A JSON-RPC 2.0 dispatch via A2aLocalFacade)
- Add ServerLifecycle class at infrastructure/server/server_lifecycle.py
  wrapping uvicorn.Server with SIGTERM/SIGINT graceful shutdown
- Add `agents server start` CLI command with --host, --port, --log-level
  options, resolving defaults from Settings
- Add fastapi>=0.115.0 dependency to pyproject.toml (uvicorn already present)
- Add Behave BDD tests (features/server_lifecycle.feature, 20 scenarios)
- Add Robot Framework integration tests (robot/server_lifecycle.robot)
- Update CHANGELOG.md and vulture_whitelist.py

ISSUES CLOSED: #862
freemo force-pushed feature/m9-remote-repos from bd92555a5f to 87c15d766d 2026-03-23 22:50:47 +00:00 Compare
freemo force-pushed feature/m9-remote-repos from 87c15d766d to 5ce8bbd905 2026-03-24 01:15:25 +00:00 Compare
freemo reviewed 2026-03-24 15:29:31 +00:00
freemo left a comment
Author
Owner
Copy Link
Copy Source

Review: Looks Good

Remote repo operations implementation for server mode. Feature PR for v3.8.0 milestone.

Note: Cannot formally approve as PR author matches the authenticated API user.

## Review: Looks Good Remote repo operations implementation for server mode. Feature PR for v3.8.0 milestone. *Note: Cannot formally approve as PR author matches the authenticated API user.*
freemo commented 2026-03-27 17:09:13 +00:00
Author
Owner
Copy Link
Copy Source

Code Review: feat(server): remote repo operations

Security Issue: Path Traversal Risk (High)

RemoteRepoService runs subprocess.run(["git", ...]) where repo_path comes from client input via the A2A protocol. A malicious repo_path like ../../etc or /etc/shadow could be exploited for path traversal.

Before passing any client-supplied path to subprocess.run(["git", ...]), the service must:

  1. Resolve the path to an absolute path
  2. Verify it falls within an allowed directory (e.g., the workspace root)
  3. Reject paths containing .. segments or symlinks that escape the sandbox

Example:

resolved = Path(repo_path).resolve()
if not resolved.is_relative_to(allowed_workspace_root):
    raise ValueError(f"repo_path escapes workspace: {repo_path}")

Merge Dependency

This PR carries ~1,100 lines of shared ASGI infrastructure from PR #1107. PR #1107 should merge first, then this branch should be rebased.

What's Good

  • Clean Pydantic domain models with proper enums.
  • All service methods type-check arguments.
  • 39 BDD scenarios with real temporary git repos.
  • A2A wiring at _cleveragents/repo/{status,fetch,pull,push}.

Required Before Merge

  1. Add path validation/sanitization for repo_path before passing to subprocess
  2. Merge PR #1107 first and rebase this branch
## Code Review: feat(server): remote repo operations ### Security Issue: Path Traversal Risk (High) `RemoteRepoService` runs `subprocess.run(["git", ...])` where `repo_path` comes from client input via the A2A protocol. A malicious `repo_path` like `../../etc` or `/etc/shadow` could be exploited for path traversal. Before passing any client-supplied path to `subprocess.run(["git", ...])`, the service must: 1. Resolve the path to an absolute path 2. Verify it falls within an allowed directory (e.g., the workspace root) 3. Reject paths containing `..` segments or symlinks that escape the sandbox Example: ```python resolved = Path(repo_path).resolve() if not resolved.is_relative_to(allowed_workspace_root): raise ValueError(f"repo_path escapes workspace: {repo_path}") ``` ### Merge Dependency This PR carries ~1,100 lines of shared ASGI infrastructure from PR #1107. PR #1107 should merge first, then this branch should be rebased. ### What's Good - Clean Pydantic domain models with proper enums. - All service methods type-check arguments. - 39 BDD scenarios with real temporary git repos. - A2A wiring at `_cleveragents/repo/{status,fetch,pull,push}`. ### Required Before Merge 1. Add path validation/sanitization for `repo_path` before passing to subprocess 2. Merge PR #1107 first and rebase this branch
freemo requested review from hamza.khyari 2026-03-28 21:28:10 +00:00
freemo requested review from aditya 2026-03-28 21:28:10 +00:00
freemo self-assigned this 2026-04-02 08:06:40 +00:00
freemo commented 2026-04-02 17:30:33 +00:00
Author
Owner
Copy Link
Copy Source

🤖 Backlog Groomer (groomer-1): Closing as duplicate of #864.

Issue #864 (feat(server): remote repo operations implementation) is the canonical version with full labels (MoSCoW/Should have, Priority/Medium, State/In Review, Type/Feature) and milestone v3.8.0. This issue is an exact title duplicate.

🤖 **Backlog Groomer (groomer-1):** Closing as duplicate of #864. Issue #864 (`feat(server): remote repo operations implementation`) is the canonical version with full labels (`MoSCoW/Should have`, `Priority/Medium`, `State/In Review`, `Type/Feature`) and milestone `v3.8.0`. This issue is an exact title duplicate.
freemo closed this pull request 2026-04-02 17:30:40 +00:00
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 16m3s
Required
Details
CI / lint (pull_request) Successful in 19m32s
Required
Details
CI / typecheck (pull_request) Successful in 23m40s
Required
Details
CI / integration_tests (pull_request) Successful in 23m36s
Required
Details
CI / unit_tests (pull_request) Successful in 23m37s
Required
Details
CI / e2e_tests (pull_request) Successful in 25m9s
Details
CI / quality (pull_request) Successful in 29m49s
Required
Details
CI / security (pull_request) Successful in 30m13s
Required
Details
CI / docker (pull_request) Successful in 1m10s
Required
Details
CI / coverage (pull_request) Successful in 11m16s
Required
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / benchmark-regression (pull_request) Successful in 59m57s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
freemo
hamza.khyari
aditya
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Type
Feature
Milestone
No items
No Milestone v3.8.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees freemo
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#1122
Delete Branch "feature/m9-remote-repos"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?