cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(security): use relpath containment instead of startswith to prevent prefix-collision bypass #11217

Closed
HAL9000 wants to merge 8 commits from fix-7478-startswith-bypass into master
pull from: fix-7478-startswith-bypass
merge into: cleveragents:master
Conversation 77 Commits 8 Files Changed 1
+7 -1
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/cleveragents/tool/path_mapper.py
+7 -1
View File
8
 @@ -182,8 +182,14 @@ def _is_under(path: str, root: str) -> bool:
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Unused import causing CI lint failure.
import os (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes CI / lint to fail.

Suggestion: Remove the unused import.

**Unused import causing CI lint failure.** `import os` (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes `CI / lint` to fail. Suggestion: Remove the unused import.
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Core issue — no behavioral change.
The PR title claims ‘use relpath containment instead of startswith’ but _is_under() already uses posixpath.relpath(path, root) in the base commit. This is the correct fix described in the issue.

The only code change is adding import os which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.

**Core issue — no behavioral change.** The PR title claims ‘use relpath containment instead of startswith’ but `_is_under()` already uses `posixpath.relpath(path, root)` in the base commit. This is the correct fix described in the issue. The only code change is adding `import os` which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Unused import causing CI lint failure.
import os (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes CI / lint to fail.

Suggestion: Remove the unused import.

**Unused import causing CI lint failure.** `import os` (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes `CI / lint` to fail. Suggestion: Remove the unused import.
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Core issue — no behavioral change.
The PR title claims ‘use relpath containment instead of startswith’ but _is_under() already uses posixpath.relpath(path, root) in the base commit. This is the correct fix described in the issue.

The only code change is adding import os which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.

**Core issue — no behavioral change.** The PR title claims ‘use relpath containment instead of startswith’ but `_is_under()` already uses `posixpath.relpath(path, root)` in the base commit. This is the correct fix described in the issue. The only code change is adding `import os` which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.
def _relative_to(path: str, root: str) -> str:
"""Return the part of *path* relative to *root*.
Uses :func:`posixpath.relpath` for canonical relative-path extraction,
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Unused import causing CI lint failure.
import os (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes CI / lint to fail.

Suggestion: Remove the unused import.

**Unused import causing CI lint failure.** `import os` (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes `CI / lint` to fail. Suggestion: Remove the unused import.
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Core issue — no behavioral change.
The PR title claims ‘use relpath containment instead of startswith’ but _is_under() already uses posixpath.relpath(path, root) in the base commit. This is the correct fix described in the issue.

The only code change is adding import os which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.

**Core issue — no behavioral change.** The PR title claims ‘use relpath containment instead of startswith’ but `_is_under()` already uses `posixpath.relpath(path, root)` in the base commit. This is the correct fix described in the issue. The only code change is adding `import os` which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.
consistent with :func:`_is_under`. This avoids string-slicing prefix-collision
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Unused import causing CI lint failure.
import os (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes CI / lint to fail.

Suggestion: Remove the unused import.

**Unused import causing CI lint failure.** `import os` (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes `CI / lint` to fail. Suggestion: Remove the unused import.
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Core issue — no behavioral change.
The PR title claims ‘use relpath containment instead of startswith’ but _is_under() already uses posixpath.relpath(path, root) in the base commit. This is the correct fix described in the issue.

The only code change is adding import os which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.

**Core issue — no behavioral change.** The PR title claims ‘use relpath containment instead of startswith’ but `_is_under()` already uses `posixpath.relpath(path, root)` in the base commit. This is the correct fix described in the issue. The only code change is adding `import os` which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.
attacks where an attacker filename is a literal prefix of the sandbox root
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Unused import causing CI lint failure.
import os (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes CI / lint to fail.

Suggestion: Remove the unused import.

**Unused import causing CI lint failure.** `import os` (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes `CI / lint` to fail. Suggestion: Remove the unused import.
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Core issue — no behavioral change.
The PR title claims ‘use relpath containment instead of startswith’ but _is_under() already uses posixpath.relpath(path, root) in the base commit. This is the correct fix described in the issue.

The only code change is adding import os which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.

**Core issue — no behavioral change.** The PR title claims ‘use relpath containment instead of startswith’ but `_is_under()` already uses `posixpath.relpath(path, root)` in the base commit. This is the correct fix described in the issue. The only code change is adding `import os` which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.
(see issue #7478).
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Unused import causing CI lint failure.
import os (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes CI / lint to fail.

Suggestion: Remove the unused import.

**Unused import causing CI lint failure.** `import os` (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes `CI / lint` to fail. Suggestion: Remove the unused import.
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Core issue — no behavioral change.
The PR title claims ‘use relpath containment instead of startswith’ but _is_under() already uses posixpath.relpath(path, root) in the base commit. This is the correct fix described in the issue.

The only code change is adding import os which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.

**Core issue — no behavioral change.** The PR title claims ‘use relpath containment instead of startswith’ but `_is_under()` already uses `posixpath.relpath(path, root)` in the base commit. This is the correct fix described in the issue. The only code change is adding `import os` which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Unused import causing CI lint failure.
import os (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes CI / lint to fail.

Suggestion: Remove the unused import.

**Unused import causing CI lint failure.** `import os` (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes `CI / lint` to fail. Suggestion: Remove the unused import.
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Core issue — no behavioral change.
The PR title claims ‘use relpath containment instead of startswith’ but _is_under() already uses posixpath.relpath(path, root) in the base commit. This is the correct fix described in the issue.

The only code change is adding import os which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.

**Core issue — no behavioral change.** The PR title claims ‘use relpath containment instead of startswith’ but `_is_under()` already uses `posixpath.relpath(path, root)` in the base commit. This is the correct fix described in the issue. The only code change is adding `import os` which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.
Assumes :func:`_is_under` has already been checked.
"""
if path == root:
return ""
return path[len(root) + 1 :]
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Unused import causing CI lint failure.
import os (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes CI / lint to fail.

Suggestion: Remove the unused import.

**Unused import causing CI lint failure.** `import os` (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes `CI / lint` to fail. Suggestion: Remove the unused import.
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Core issue — no behavioral change.
The PR title claims ‘use relpath containment instead of startswith’ but _is_under() already uses posixpath.relpath(path, root) in the base commit. This is the correct fix described in the issue.

The only code change is adding import os which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.

**Core issue — no behavioral change.** The PR title claims ‘use relpath containment instead of startswith’ but `_is_under()` already uses `posixpath.relpath(path, root)` in the base commit. This is the correct fix described in the issue. The only code change is adding `import os` which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.
rel = posixpath.relpath(path, root)
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Unused import causing CI lint failure.
import os (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes CI / lint to fail.

Suggestion: Remove the unused import.

**Unused import causing CI lint failure.** `import os` (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes `CI / lint` to fail. Suggestion: Remove the unused import.
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Core issue — no behavioral change.
The PR title claims ‘use relpath containment instead of startswith’ but _is_under() already uses posixpath.relpath(path, root) in the base commit. This is the correct fix described in the issue.

The only code change is adding import os which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.

**Core issue — no behavioral change.** The PR title claims ‘use relpath containment instead of startswith’ but `_is_under()` already uses `posixpath.relpath(path, root)` in the base commit. This is the correct fix described in the issue. The only code change is adding `import os` which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.
return rel.replace("\\", "/")
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Unused import causing CI lint failure.
import os (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes CI / lint to fail.

Suggestion: Remove the unused import.

**Unused import causing CI lint failure.** `import os` (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes `CI / lint` to fail. Suggestion: Remove the unused import.
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Core issue — no behavioral change.
The PR title claims ‘use relpath containment instead of startswith’ but _is_under() already uses posixpath.relpath(path, root) in the base commit. This is the correct fix described in the issue.

The only code change is adding import os which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.

**Core issue — no behavioral change.** The PR title claims ‘use relpath containment instead of startswith’ but `_is_under()` already uses `posixpath.relpath(path, root)` in the base commit. This is the correct fix described in the issue. The only code change is adding `import os` which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Unused import causing CI lint failure.
import os (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes CI / lint to fail.

Suggestion: Remove the unused import.

**Unused import causing CI lint failure.** `import os` (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes `CI / lint` to fail. Suggestion: Remove the unused import.
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Core issue — no behavioral change.
The PR title claims ‘use relpath containment instead of startswith’ but _is_under() already uses posixpath.relpath(path, root) in the base commit. This is the correct fix described in the issue.

The only code change is adding import os which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.

**Core issue — no behavioral change.** The PR title claims ‘use relpath containment instead of startswith’ but `_is_under()` already uses `posixpath.relpath(path, root)` in the base commit. This is the correct fix described in the issue. The only code change is adding `import os` which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Unused import causing CI lint failure.
import os (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes CI / lint to fail.

Suggestion: Remove the unused import.

**Unused import causing CI lint failure.** `import os` (line 14) is never used anywhere in this file. This triggers pylint W0611 and causes `CI / lint` to fail. Suggestion: Remove the unused import.
HAL9001 commented 2026-05-15 11:16:37 +00:00
Review
Copy Link
Copy Source

Core issue — no behavioral change.
The PR title claims ‘use relpath containment instead of startswith’ but _is_under() already uses posixpath.relpath(path, root) in the base commit. This is the correct fix described in the issue.

The only code change is adding import os which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.

**Core issue — no behavioral change.** The PR title claims ‘use relpath containment instead of startswith’ but `_is_under()` already uses `posixpath.relpath(path, root)` in the base commit. This is the correct fix described in the issue. The only code change is adding `import os` which does nothing to security or behavior. This PR appears to be a stale no-op submitted after the actual security fix was already committed.