fix(tests): restore agent-evolution-pool-supervisor.md or remove its orphaned BDD scenarios #11209

Merged
hurui200320 merged 1 commits from bugfix/m3-restore-agent-evolution-pool-supervisor into master 2026-05-14 06:08:37 +00:00

1 Commits

Author SHA1 Message Date
hurui200320 39f9903f1a fix(tests): restore agent-evolution-pool-supervisor.md or remove its orphaned BDD scenarios
CI / helm (pull_request) Successful in 1m5s
CI / push-validation (pull_request) Successful in 1m14s
CI / build (pull_request) Successful in 1m15s
CI / lint (pull_request) Successful in 1m47s
CI / typecheck (pull_request) Successful in 1m56s
CI / quality (pull_request) Successful in 1m50s
CI / security (pull_request) Successful in 1m56s
CI / integration_tests (pull_request) Successful in 7m43s
CI / unit_tests (pull_request) Successful in 9m18s
CI / docker (pull_request) Successful in 1m35s
CI / coverage (pull_request) Successful in 24m0s
CI / status-check (pull_request) Successful in 4s
CI / push-validation (push) Successful in 46s
CI / helm (push) Successful in 1m0s
CI / lint (push) Successful in 1m17s
CI / build (push) Successful in 1m26s
CI / benchmark-publish (push) Has started running
CI / quality (push) Successful in 1m50s
CI / e2e_tests (push) Successful in 1m52s
CI / security (push) Successful in 1m59s
CI / typecheck (push) Successful in 2m3s
CI / benchmark-regression (push) Failing after 49s
CI / integration_tests (push) Successful in 4m53s
CI / unit_tests (push) Successful in 4m59s
CI / docker (push) Successful in 2m59s
CI / coverage (push) Successful in 13m4s
CI / status-check (push) Successful in 3s
Chose Option B (fallback): remove orphaned BDD scenarios for two retired agents.

Commit 3c8cf601 deleted .opencode/agents/agent-evolution-pool-supervisor.md
and .opencode/agents/implementation-pool-supervisor.md as part of a large-scale
restructuring of agent definition files. However, their corresponding Behave feature
files and step definitions were not cleaned up, causing nox -s unit_tests to fail
with AssertionError on master.

Removed files:
- features/agent_evolution_pool_supervisor_metadata.feature (7 scenarios testing
  agent-evolution-pool-supervisor.md existence and content)
- features/steps/agent_evolution_pool_supervisor_metadata_steps.py (382 lines of
  step definitions for the above feature)
- features/pr_compliance_pool_supervisor.feature (10 scenarios testing
  implementation-pool-supervisor.md existence and content)
- features/steps/pr_compliance_pool_supervisor_steps.py (219 lines of step
  definitions for the above feature)

Both agent definition files were permanently retired by the restructuring commit
and are not expected to return. Keeping orphaned tests that assert on deleted files
is not valid; removal is the correct resolution per the project's handling of
obsolete tests policy.

Quality gates verified:
- nox -s unit_tests: 694 features passed, 0 failed (was failing on master)
- nox -s lint: all checks passed
- nox -s typecheck: 0 errors, 3 warnings (pre-existing import warnings)
- nox -s coverage_report: 96.5% (meets 96.5% threshold)
- nox -s integration_tests: 1998 tests passed, 0 failed

ISSUES CLOSED: #11208
2026-05-14 04:16:04 +00:00