cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(tui): rename ActorSelectionOverlay._render to _refresh_display #11201

Closed
HAL9000 wants to merge 1 commits from fix/tui-actor-selection-overlay into master
pull from: fix/tui-actor-selection-overlay
merge into: cleveragents:master
Conversation 22 Commits 1 Files Changed 5
+171 -5

1 Commits

Author SHA1 Message Date
HAL9000 27af4c4c42 fix(tui): rename ActorSelectionOverlay._render to avoid shadowing Textual Widget._render
CI / push-validation (pull_request) Successful in 43s
Details
CI / helm (pull_request) Successful in 46s
Details
CI / build (pull_request) Successful in 1m4s
Details
CI / lint (pull_request) Failing after 1m21s
Details
CI / quality (pull_request) Successful in 1m50s
Details
CI / typecheck (pull_request) Successful in 1m56s
Details
CI / security (pull_request) Successful in 1m54s
Details
CI / integration_tests (pull_request) Successful in 4m35s
Details
CI / unit_tests (pull_request) Failing after 8m37s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 3s
Details 
Renamed ActorSelectionOverlay._render() to _refresh_display() to avoid
shadowing the Textual Widgets internal _render method. The overlay class
inherits from textual.widgets.Static which has its own _render for rendering
widget content. Shadowing this caused incorrect repaint behavior and
interfered with Textual layout pass, resulting in
AttributeError: 'NoneType' object has no attribute 'get_height'.

Also added a TDD regression test (tdd_actor_selection_render_rename.feature)
and fixed CHANGELOG.md by moving the ActorSelectionOverlay entry under the
### Fixed subsection within [Unreleased].

ISSUES CLOSED: #11039
 2026-05-13 20:48:17 +00:00