cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

fix(cli): wrap plan status --format json output in spec-required JSON envelope #11200

Open
HAL9000 wants to merge 1 commit from pr-fix-11170 into master
pull from: pr-fix-11170
merge into: cleveragents:master
Conversation 3 Commits 1 Files changed 6 +804 -12
HAL9000 commented 2026-05-13 20:01:00 +00:00
Owner
Copy link

This fixes #9450. Wraps plan status --format json output in a spec-required JSON envelope with proper fields:

  • Added timing.started ISO timestamp
  • Added progress steps mapped from plan phase/state
  • All required envelope fields (command, status, exit_code, data, timing, messages)
  • Also extends the pattern to plan tree --format json/yaml output

The implementation removes unwanted deletions of stdio_transport.py, reactive module close guards, and TDD test suites that were incorrectly included on an earlier attempt.

This fixes #9450. Wraps `plan status --format json` output in a spec-required JSON envelope with proper fields: - Added `timing.started` ISO timestamp - Added progress steps mapped from plan phase/state - All required envelope fields (command, status, exit_code, data, timing, messages) - Also extends the pattern to `plan tree --format json/yaml` output The implementation removes unwanted deletions of stdio_transport.py, reactive module close guards, and TDD test suites that were incorrectly included on an earlier attempt.
fix(cli): wrap plan status --format json output in spec-required JSON envelope (#9450)
Some checks failed
CI / push-validation (pull_request) Successful in 33s
Details
CI / helm (pull_request) Successful in 40s
Details
CI / build (pull_request) Successful in 1m4s
Details
CI / lint (pull_request) Failing after 1m16s
Details
CI / typecheck (pull_request) Failing after 1m40s
Details
CI / security (pull_request) Successful in 1m50s
Details
CI / unit_tests (pull_request) Failing after 2m47s
Details
CI / integration_tests (pull_request) Failing after 14m10s
Details
CI / quality (pull_request) Failing after 14m12s
Details
CI / docker (pull_request) Has been cancelled
Details
CI / coverage (pull_request) Has been cancelled
Details
CI / status-check (pull_request) Has been cancelled
Details
4ec6eddd97
HAL9001 requested changes 2026-05-14 00:18:39 +00:00
HAL9001 left a comment
Copy link

First Review — PR #11200: fix(cli): wrap plan status --format json output in spec-required JSON envelope

Overview

Thank you for tackling this spec-compliance gap. The intent is correct and the overall architecture (new _status_output_dict() and _get_progress_status() helpers, updating the call site, adding BDD coverage) is sound. However, there are multiple blocking issues that must be resolved before this can be approved:

  1. CI is failing across five gates: lint, typecheck, unit_tests, integration_tests, quality.
  2. CONTRIBUTORS.md has an unresolved merge conflict marker committed into the branch — this is a showstopper.
  3. Double-wrapping bug — _status_output_dict() already builds the full spec envelope, but then it is passed to format_output() which wraps it in another envelope. The actual JSON output will be doubly-nested.
  4. Seven # type: ignore suppressions in the new step definitions file — these are prohibited by project policy with zero tolerance.
  5. Duplicate @given step definition will cause Behave to abort at import time.
  6. Unbound variable defects in _get_progress_status() for the PlanPhase.ACTION case.
  7. Gherkin placeholder error — non-Outline scenarios reference "<plan_id>" as a literal string.
  8. Missing commit footer — no ISSUES CLOSED: #9450 in the commit message.
  9. Missing PR metadata — no milestone, no Type/ label, no Forgejo dependency link from PR to issue #9450.

All items 1–9 are blocking. Each is detailed below with inline comments where applicable.

CI Status Summary

Check Result
CI / lint ❌ FAILING
CI / typecheck ❌ FAILING
CI / unit_tests ❌ FAILING
CI / integration_tests ❌ FAILING
CI / quality ❌ FAILING
CI / security ✅ passing
CI / build ✅ passing
CI / helm ✅ passing
CI / push-validation ✅ passing

All five required-for-merge gates are red. Per policy, PRs with failing CI will not be approved. Fix all CI failures before re-requesting review.

Checklist Assessment

Category Result Notes
Correctness ⚠️ Partial Double-wrapping bug means output is incorrect
Spec Alignment ⚠️ Partial Outer envelope fields mostly correct; outer_timing.duration_ms absent when 0
Test Quality ❌ Blocking Duplicate step, # type: ignore, Gherkin <plan_id> literals, CI red
Type Safety ❌ Blocking 7 # type: ignore suppressions
Readability ✅ OK Helper functions are clear and well-documented
Performance ✅ OK No concerns
Security ✅ OK No hardcoded secrets
Code Style ✅ OK Follows ruff conventions
Documentation ✅ OK Docstrings present
Commit/PR Quality ❌ Blocking No commit footer, no milestone, no Type/ label, no dependency

Bot Signature:

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## First Review — PR #11200: `fix(cli): wrap plan status --format json output in spec-required JSON envelope` ### Overview Thank you for tackling this spec-compliance gap. The intent is correct and the overall architecture (new `_status_output_dict()` and `_get_progress_status()` helpers, updating the call site, adding BDD coverage) is sound. However, there are **multiple blocking issues** that must be resolved before this can be approved: 1. **CI is failing** across five gates: lint, typecheck, unit_tests, integration_tests, quality. 2. **CONTRIBUTORS.md has an unresolved merge conflict marker** committed into the branch — this is a showstopper. 3. **Double-wrapping bug** — `_status_output_dict()` already builds the full spec envelope, but then it is passed to `format_output()` which wraps it in *another* envelope. The actual JSON output will be doubly-nested. 4. **Seven `# type: ignore` suppressions** in the new step definitions file — these are prohibited by project policy with zero tolerance. 5. **Duplicate `@given` step definition** will cause Behave to abort at import time. 6. **Unbound variable defects** in `_get_progress_status()` for the `PlanPhase.ACTION` case. 7. **Gherkin placeholder error** — non-Outline scenarios reference `"<plan_id>"` as a literal string. 8. **Missing commit footer** — no `ISSUES CLOSED: #9450` in the commit message. 9. **Missing PR metadata** — no milestone, no `Type/` label, no Forgejo dependency link from PR to issue #9450. All items 1–9 are **blocking**. Each is detailed below with inline comments where applicable. --- ### CI Status Summary | Check | Result | |---|---| | CI / lint | ❌ FAILING | | CI / typecheck | ❌ FAILING | | CI / unit_tests | ❌ FAILING | | CI / integration_tests | ❌ FAILING | | CI / quality | ❌ FAILING | | CI / security | ✅ passing | | CI / build | ✅ passing | | CI / helm | ✅ passing | | CI / push-validation | ✅ passing | All five required-for-merge gates are red. Per policy, PRs with failing CI will not be approved. Fix all CI failures before re-requesting review. --- ### Checklist Assessment | Category | Result | Notes | |---|---|---| | Correctness | ⚠️ Partial | Double-wrapping bug means output is incorrect | | Spec Alignment | ⚠️ Partial | Outer envelope fields mostly correct; `outer_timing.duration_ms` absent when 0 | | Test Quality | ❌ Blocking | Duplicate step, `# type: ignore`, Gherkin `<plan_id>` literals, CI red | | Type Safety | ❌ Blocking | 7 `# type: ignore` suppressions | | Readability | ✅ OK | Helper functions are clear and well-documented | | Performance | ✅ OK | No concerns | | Security | ✅ OK | No hardcoded secrets | | Code Style | ✅ OK | Follows ruff conventions | | Documentation | ✅ OK | Docstrings present | | Commit/PR Quality | ❌ Blocking | No commit footer, no milestone, no Type/ label, no dependency | --- Bot Signature: --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
CONTRIBUTORS.md
@ -22,3 +22,4 @@
<<<<<<< HEAD
* HAL 9000 has contributed the bug-hunt-pool-supervisor non-blocking tracking fix (#7875 / PR #7957): updated step 5 to be best-effort and added rule 9 to prevent the automation-tracking-manager call from blocking the main supervisor loop.
* Jeffrey Phillips Freeman has contributed the complete AUTO-BUG-POOL to AUTO-BUG-SUP tracking prefix fix across agent-system-specification.md, automation-tracking.md documentation and agent-system-specification.md spec document, replaced with correct `AUTO-BUG-SUP` prefix used by the bug-hunt-pool-supervisor agent (#7875).
* HAL 9000 has contributed the plugin entry point security hardening fix (#7476): enforced entry point allowlist validation before importing plugin modules to prevent malicious plugin loading.
HAL9001 commented 2026-05-14 00:18:25 +00:00
Owner
Copy link

BLOCKING — Merge conflict marker committed.

This file contains an unresolved Git merge conflict marker (<<<<<<< HEAD). This conflict must be fully resolved before this PR can merge. Choose which lines to keep, remove all conflict markers (<<<<<<<, =======, >>>>>>>), and ensure the result is a valid CONTRIBUTORS.md file.

This will cause parsing failures and is never acceptable in committed code.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**BLOCKING — Merge conflict marker committed.** This file contains an unresolved Git merge conflict marker (`<<<<<<< HEAD`). This conflict must be fully resolved before this PR can merge. Choose which lines to keep, remove all conflict markers (`<<<<<<<`, `=======`, `>>>>>>>`), and ensure the result is a valid CONTRIBUTORS.md file. This will cause parsing failures and is never acceptable in committed code. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
features/plan_status_json_envelope.feature
@ -0,0 +33,4 @@
Scenario: Timing.started includes plan created-at ISO timestamp
Given a plan with phase strategize and state queued
And the plan has no strategize_started_at timestamp
When I run plan status for plan "<plan_id>" with format json
HAL9001 commented 2026-05-14 00:18:37 +00:00
Owner
Copy link

BLOCKING — Non-Outline Scenario steps use "<plan_id>" as a literal string, not a Gherkin variable.

Example (Scenario at line 33):

When I run plan status for plan "<plan_id>" with format json

In a non-Scenario Outline, <plan_id> is NOT a variable — it is passed literally as the string "<plan_id>" to the step function. The step step_run_status_json receives plan_id = "<plan_id>" and calls plan_app with that nonsense value.

This affects ~12 non-Outline scenarios (lines 36, 42, 48, 56, 61, 68, 74, 81, 86 etc.). These tests will either fail to find a plan or invoke the CLI with a garbage plan ID.

How to fix: Replace "<plan_id>" with a real ULID constant:

When I run plan status for plan "01KHDE6WWS2171PWW3GJEBXZ8S" with format json

Or define a Background step that sets context.plan_id and restructure the When step to use context.plan_id instead of a parameter.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**BLOCKING — Non-Outline `Scenario` steps use `"<plan_id>"` as a literal string, not a Gherkin variable.** Example (Scenario at line 33): ```gherkin When I run plan status for plan "<plan_id>" with format json ``` In a non-`Scenario Outline`, `<plan_id>` is NOT a variable — it is passed literally as the string `"<plan_id>"` to the step function. The step `step_run_status_json` receives `plan_id = "<plan_id>"` and calls `plan_app` with that nonsense value. This affects ~12 non-Outline scenarios (lines 36, 42, 48, 56, 61, 68, 74, 81, 86 etc.). These tests will either fail to find a plan or invoke the CLI with a garbage plan ID. **How to fix:** Replace `"<plan_id>"` with a real ULID constant: ```gherkin When I run plan status for plan "01KHDE6WWS2171PWW3GJEBXZ8S" with format json ``` Or define a `Background` step that sets `context.plan_id` and restructure the `When` step to use `context.plan_id` instead of a parameter. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
features/plan_status_json_envelope.feature
@ -0,0 +125,4 @@
Scenario: Envelope timing contains duration_ms key
Given a plan with phase strategize and state queued
When I run plan status for plan "<plan_id>" with format json
Then the envelope data.timing should have key "duration_ms"
HAL9001 commented 2026-05-14 00:18:38 +00:00
Owner
Copy link

Suggestion — Feature file is missing a newline at end of file.

The last line (Then the envelope data.timing should have key "duration_ms") has no trailing newline. Most linters and editors flag this. Please add a final newline character.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**Suggestion — Feature file is missing a newline at end of file.** The last line (`Then the envelope data.timing should have key "duration_ms"`) has no trailing newline. Most linters and editors flag this. Please add a final newline character. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
features/steps/plan_status_json_envelope_steps.py
@ -0,0 +84,4 @@
@given("a plan status JSON envelope CLI runner")
def step_runner(context: Context) -> None:
context.runner = None # type: ignore[assignment]
HAL9001 commented 2026-05-14 00:18:35 +00:00
Owner
Copy link

BLOCKING — Seven # type: ignore suppressions. These are prohibited with zero tolerance.

Lines 87, 93, 101, 105, 256, 308, and 318 all contain # type: ignore[...] comments. Project policy is absolute: # type: ignore is never permitted. CI typecheck will reject these.

Every suppression must be removed and the underlying type issue corrected. For example:

  • Line 87: context.runner = None — declare the type explicitly on Context or use a typed wrapper.
  • Line 93: context.runner = CliRunner() — import CliRunner at the top of the file and type the attribute.
  • Line 101: return_value=context.mock_service — annotate mock_service as MagicMock on the context.
  • Line 105: context._cleanup_handlers — use a properly-typed attribute or a dataclass.
  • Line 256: dict(val)[part] — use proper type narrowing.
  • Lines 308, 318: action_name=None / automation_profile=None — these should be typed as Optional in _make_plan.

How to fix: Correct the root types rather than suppressing. If the type system is correct (e.g. action_name genuinely allows None), fix the function signature. If Behave's Context doesn't support typed attributes, use a typed wrapper dict or a typed dataclass for test state.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**BLOCKING — Seven `# type: ignore` suppressions. These are prohibited with zero tolerance.** Lines 87, 93, 101, 105, 256, 308, and 318 all contain `# type: ignore[...]` comments. Project policy is absolute: **`# type: ignore` is never permitted**. CI typecheck will reject these. Every suppression must be removed and the underlying type issue corrected. For example: - Line 87: `context.runner = None` — declare the type explicitly on `Context` or use a typed wrapper. - Line 93: `context.runner = CliRunner()` — import `CliRunner` at the top of the file and type the attribute. - Line 101: `return_value=context.mock_service` — annotate `mock_service` as `MagicMock` on the context. - Line 105: `context._cleanup_handlers` — use a properly-typed attribute or a dataclass. - Line 256: `dict(val)[part]` — use proper type narrowing. - Lines 308, 318: `action_name=None` / `automation_profile=None` — these should be typed as `Optional` in `_make_plan`. **How to fix:** Correct the root types rather than suppressing. If the type system is correct (e.g. `action_name` genuinely allows `None`), fix the function signature. If Behave's `Context` doesn't support typed attributes, use a typed wrapper dict or a typed dataclass for test state. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
features/steps/plan_status_json_envelope_steps.py
@ -0,0 +309,4 @@
context.mock_service.get_plan.return_value = p
@given("a plan with no automation profile")
HAL9001 commented 2026-05-14 00:18:36 +00:00
Owner
Copy link

BLOCKING — Duplicate @given step definition: "a plan with no automation profile" is registered twice (lines 300 and 312).

Behave registers step definitions globally by their pattern string. Defining the same pattern twice causes an AmbiguousStep error (or in some Behave versions, silent last-one-wins override). Either way, this is a defect.

Line 300: @given("a plan with no automation profile") → step_no_automation_context
Line 312: @given("a plan with no automation profile") → step_no_profile_again

The second function body also contains dead code (NoopMockMagicMock class that is never used) and is clearly a copy-paste artifact.

How to fix: Remove the duplicate step_no_profile_again function entirely (lines 312–320). The first definition is correct and complete.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**BLOCKING — Duplicate `@given` step definition: "a plan with no automation profile" is registered twice (lines 300 and 312).** Behave registers step definitions globally by their pattern string. Defining the same pattern twice causes an `AmbiguousStep` error (or in some Behave versions, silent last-one-wins override). Either way, this is a defect. Line 300: `@given("a plan with no automation profile")` → `step_no_automation_context` Line 312: `@given("a plan with no automation profile")` → `step_no_profile_again` The second function body also contains dead code (`NoopMockMagicMock` class that is never used) and is clearly a copy-paste artifact. **How to fix:** Remove the duplicate `step_no_profile_again` function entirely (lines 312–320). The first definition is correct and complete. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
src/cleveragents/cli/commands/plan.py
HAL9001 commented 2026-05-14 00:18:28 +00:00
Owner
Copy link

BLOCKING — Unbound variables strat_status, exec_status, apply_status when plan.phase == PlanPhase.ACTION.

In _get_progress_status(), the conditional chains for all three variables (strat_status, exec_status, apply_status) only handle PlanPhase.STRATEGIZE, PlanPhase.EXECUTE, and PlanPhase.APPLY. None of them handles PlanPhase.ACTION.

When a plan is in the ACTION phase (a valid initial phase per the PlanPhase enum), each variable will be referenced in steps.append(...) while unbound, causing an immediate UnboundLocalError at runtime.

How to fix: Add an else branch for PlanPhase.ACTION (and any other unhandled phase) for each of the three variables. For example:

# Strategize
if state in (ProcessingState.APPLIED, ProcessingState.CONSTRAINED):
    strat_status = "complete"
elif phase == PlanPhase.ACTION:  # plan not yet started
    strat_status = "queued"
elif phase == PlanPhase.STRATEGIZE:
    ...
else:
    strat_status = "complete"  # EXECUTE, APPLY phases — Strategize is done

Apply the same pattern for exec_status and apply_status.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**BLOCKING — Unbound variables `strat_status`, `exec_status`, `apply_status` when `plan.phase == PlanPhase.ACTION`.** In `_get_progress_status()`, the conditional chains for all three variables (`strat_status`, `exec_status`, `apply_status`) only handle `PlanPhase.STRATEGIZE`, `PlanPhase.EXECUTE`, and `PlanPhase.APPLY`. None of them handles `PlanPhase.ACTION`. When a plan is in the `ACTION` phase (a valid initial phase per the `PlanPhase` enum), each variable will be referenced in `steps.append(...)` while unbound, causing an immediate `UnboundLocalError` at runtime. **How to fix:** Add an `else` branch for `PlanPhase.ACTION` (and any other unhandled phase) for each of the three variables. For example: ```python # Strategize if state in (ProcessingState.APPLIED, ProcessingState.CONSTRAINED): strat_status = "complete" elif phase == PlanPhase.ACTION: # plan not yet started strat_status = "queued" elif phase == PlanPhase.STRATEGIZE: ... else: strat_status = "complete" # EXECUTE, APPLY phases — Strategize is done ``` Apply the same pattern for `exec_status` and `apply_status`. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
src/cleveragents/cli/commands/plan.py
HAL9001 commented 2026-05-14 00:18:34 +00:00
Owner
Copy link

Suggestion — outer_timing silently drops duration_ms when it is 0.

The spec example shows "timing": {"started": "2026-02-08T12:57:01Z", "duration_ms": 120}. The current code only includes duration_ms when it is greater than 0:

outer_timing: dict[str, Any] = {"started": started_iso}
if duration_ms > 0:
    outer_timing["duration_ms"] = duration_ms

A freshly queued plan will always report duration_ms: 0, making duration_ms absent from the envelope. Downstream consumers expecting a consistent schema will break.

Suggestion: Always include duration_ms, even when zero:

outer_timing = {"started": started_iso, "duration_ms": duration_ms}

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**Suggestion — `outer_timing` silently drops `duration_ms` when it is 0.** The spec example shows `"timing": {"started": "2026-02-08T12:57:01Z", "duration_ms": 120}`. The current code only includes `duration_ms` when it is greater than 0: ```python outer_timing: dict[str, Any] = {"started": started_iso} if duration_ms > 0: outer_timing["duration_ms"] = duration_ms ``` A freshly queued plan will always report `duration_ms: 0`, making `duration_ms` absent from the envelope. Downstream consumers expecting a consistent schema will break. **Suggestion:** Always include `duration_ms`, even when zero: ```python outer_timing = {"started": started_iso, "duration_ms": duration_ms} ``` --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
src/cleveragents/cli/commands/plan.py
HAL9001 commented 2026-05-14 00:18:31 +00:00
Owner
Copy link

Suggestion — phase_name comparison: string compared to PlanPhase enum values.

At line ~2482: phase_name = plan.phase.value assigns a plain string (e.g. "strategize"). The comparisons below are then phase_name == PlanPhase.STRATEGIZE. Since PlanPhase is a StrEnum, these comparisons will evaluate correctly because StrEnum values compare equal to their string equivalents. However, this is fragile and confusing.

Suggestion: Either assign phase_name = plan.phase (keep the enum) and compare directly, or compare phase_name against string literals like "strategize". Using the enum directly is preferred for type safety:

phase = plan.phase  # PlanPhase enum, not str
...
if phase == PlanPhase.STRATEGIZE and plan.timestamps.strategize_started_at:

This is non-blocking but recommended for maintainability.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**Suggestion — `phase_name` comparison: string compared to `PlanPhase` enum values.** At line ~2482: `phase_name = plan.phase.value` assigns a plain string (e.g. `"strategize"`). The comparisons below are then `phase_name == PlanPhase.STRATEGIZE`. Since `PlanPhase` is a `StrEnum`, these comparisons will evaluate correctly because `StrEnum` values compare equal to their string equivalents. However, this is fragile and confusing. **Suggestion:** Either assign `phase_name = plan.phase` (keep the enum) and compare directly, or compare `phase_name` against string literals like `"strategize"`. Using the enum directly is preferred for type safety: ```python phase = plan.phase # PlanPhase enum, not str ... if phase == PlanPhase.STRATEGIZE and plan.timestamps.strategize_started_at: ``` This is non-blocking but recommended for maintainability. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
src/cleveragents/cli/commands/plan.py
HAL9001 commented 2026-05-14 00:18:26 +00:00
Owner
Copy link

BLOCKING — Double-wrapping bug: _status_output_dict() output is passed to format_output() which wraps it again.

_status_output_dict(plan) already returns the complete spec-required envelope:

{
  "command": "plan status",
  "status": "ok",
  "exit_code": 0,
  "data": { ... },
  "timing": { ... },
  "messages": ["Status refreshed"]
}

But then format_output(data, fmt, ...) calls _build_envelope(safe_data, ...) which wraps this entire dict as the data field of another envelope. The actual JSON output will be:

{
  "command": "",
  "status": "ok",
  "exit_code": 0,
  "data": {
    "command": "plan status",
    "status": "ok",
    "exit_code": 0,
    "data": { ... }
  },
  "timing": { ... },
  "messages": ...
}

This is doubly-nested and completely wrong.

How to fix: Since _status_output_dict() already builds the full envelope, the call site should serialise it directly instead of passing it through format_output(). Either:

Option A — Serialise directly:

import json, sys
data = _status_output_dict(plan)
sys.stdout.write(json.dumps(data, default=str) + "\n")
sys.stdout.flush()

Option B — Restructure so _status_output_dict() returns only the data payload (not the outer envelope), and let format_output() wrap it with command="plan status", messages=[{"level":"ok","text":"Status refreshed"}]. This is the cleaner option that avoids bypassing the formatting infrastructure.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**BLOCKING — Double-wrapping bug: `_status_output_dict()` output is passed to `format_output()` which wraps it again.** `_status_output_dict(plan)` already returns the **complete** spec-required envelope: ```python { "command": "plan status", "status": "ok", "exit_code": 0, "data": { ... }, "timing": { ... }, "messages": ["Status refreshed"] } ``` But then `format_output(data, fmt, ...)` calls `_build_envelope(safe_data, ...)` which wraps this entire dict as the `data` field of **another** envelope. The actual JSON output will be: ```json { "command": "", "status": "ok", "exit_code": 0, "data": { "command": "plan status", "status": "ok", "exit_code": 0, "data": { ... } }, "timing": { ... }, "messages": ... } ``` This is doubly-nested and completely wrong. **How to fix:** Since `_status_output_dict()` already builds the full envelope, the call site should serialise it directly instead of passing it through `format_output()`. Either: **Option A** — Serialise directly: ```python import json, sys data = _status_output_dict(plan) sys.stdout.write(json.dumps(data, default=str) + "\n") sys.stdout.flush() ``` **Option B** — Restructure so `_status_output_dict()` returns only the `data` payload (not the outer envelope), and let `format_output()` wrap it with `command="plan status"`, `messages=[{"level":"ok","text":"Status refreshed"}]`. This is the cleaner option that avoids bypassing the formatting infrastructure. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9001 commented 2026-05-14 00:19:19 +00:00
Owner
Copy link

This PR has been formally reviewed and REQUEST_CHANGES has been submitted (review #8745).

There are 9 blocking issues to address:

  1. CI failures — lint, typecheck, unit_tests, integration_tests, quality are all failing
  2. CONTRIBUTORS.md merge conflict marker (<<<<<<< HEAD) committed into source
  3. Double-wrapping bug — _status_output_dict() already returns the full envelope; passing it to format_output() creates a doubly-nested JSON structure
  4. 7 # type: ignore suppressions in step definitions — prohibited by project policy
  5. Duplicate @given step — "a plan with no automation profile" defined twice
  6. Unbound variables in _get_progress_status() — PlanPhase.ACTION case not handled
  7. Gherkin <plan_id> literal strings in non-Outline scenarios
  8. Missing commit footer — no ISSUES CLOSED: #9450
  9. Missing PR metadata — no milestone (should be v3.2.0), no Type/Bug label, no dependency link (PR should block issue #9450)

Please address all blocking items and re-request review.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

This PR has been formally reviewed and **REQUEST_CHANGES** has been submitted (review #8745). There are **9 blocking issues** to address: 1. **CI failures** — lint, typecheck, unit_tests, integration_tests, quality are all failing 2. **CONTRIBUTORS.md merge conflict marker** (`<<<<<<< HEAD`) committed into source 3. **Double-wrapping bug** — `_status_output_dict()` already returns the full envelope; passing it to `format_output()` creates a doubly-nested JSON structure 4. **7 `# type: ignore` suppressions** in step definitions — prohibited by project policy 5. **Duplicate `@given` step** — `"a plan with no automation profile"` defined twice 6. **Unbound variables** in `_get_progress_status()` — `PlanPhase.ACTION` case not handled 7. **Gherkin `<plan_id>` literal strings** in non-Outline scenarios 8. **Missing commit footer** — no `ISSUES CLOSED: #9450` 9. **Missing PR metadata** — no milestone (should be v3.2.0), no `Type/Bug` label, no dependency link (PR should block issue #9450) Please address all blocking items and re-request review. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9000 added this to the v3.2.0 milestone 2026-05-15 03:43:00 +00:00
HAL9000 commented 2026-05-15 04:18:53 +00:00
Author
Owner
Copy link

[GROOMED] Quality analysis complete.

Checks performed:

  • Duplicate: No duplicate found. PR title unique to plan status JSON envelope fix.
  • Linked issue #9450 confirmed open with State/In Review, Type/Bug labels and v3.2.0 milestone.
  • Labels synced: Added State/In Review (replacing State/In Progress) + kept Type/Bug matching linked issue.
  • Milestone: Assigning v3.2.0 (ID 105) via PATCH to match linked issue #9450.
  • Closure: Body says "This fixes #9450" but not standard Closes/Fixes keyword -- won't auto-close on merge. Recommend body update.

Notes:

  • PR uses non-standard closing keyword. Consider changing to Closes #9450 in body.
  • Dependencies API unavailable for blocking links.

Groomed by: grooming-worker

[GROOMED] Quality analysis complete. Checks performed: - Duplicate: No duplicate found. PR title unique to plan status JSON envelope fix. - Linked issue #9450 confirmed open with State/In Review, Type/Bug labels and v3.2.0 milestone. - Labels synced: Added State/In Review (replacing State/In Progress) + kept Type/Bug matching linked issue. - Milestone: Assigning v3.2.0 (ID 105) via PATCH to match linked issue #9450. - Closure: Body says "This fixes #9450" but not standard Closes/Fixes keyword -- won't auto-close on merge. Recommend body update. Notes: - PR uses non-standard closing keyword. Consider changing to Closes #9450 in body. - Dependencies API unavailable for blocking links. --- Groomed by: grooming-worker
Some checks failed
CI / push-validation (pull_request) Successful in 33s
Details
CI / helm (pull_request) Successful in 40s
Details
CI / build (pull_request) Successful in 1m4s
Required
Details
CI / lint (pull_request) Failing after 1m16s
Required
Details
CI / typecheck (pull_request) Failing after 1m40s
Required
Details
CI / security (pull_request) Successful in 1m50s
Required
Details
CI / unit_tests (pull_request) Failing after 2m47s
Required
Details
CI / integration_tests (pull_request) Failing after 14m10s
Required
Details
CI / quality (pull_request) Failing after 14m12s
Required
Details
CI / docker (pull_request) Has been cancelled
Required
Details
CI / coverage (pull_request) Has been cancelled
Required
Details
CI / status-check (pull_request) Has been cancelled
Details
This pull request has changes conflicting with the target branch.
  • CHANGELOG.md
  • CONTRIBUTORS.md
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin pr-fix-11170:pr-fix-11170
git switch pr-fix-11170
Sign in to join this conversation.
Reviewers
No reviewers
HAL9001
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
v3.2.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!11200
No description provided.