Fix TypeError in infer_resource_slots() when properties is null #11192

Merged

HAL9000 merged 1 commit from bugfix/mcp-infer-resource-slots-null-properties into master 2026-05-15 03:03:25 +00:00

Conversation 4 Commits 1 Files changed 2 +1 -2

freemo commented 2026-05-13 06:59:18 +00:00

Owner

Copy link

Closes #10497

Closes #10497

freemo added 1 commit 2026-05-13 06:59:18 +00:00

Fix TypeError in infer_resource_slots() when properties is null ... 4f56bae4f6

Fixed MCPToolAdapter.infer_resource_slots() to handle null  values
in JSON Schema by using  instead of
 which returned None when the key exists with a null value.

The @tdd_expected_fail tag was removed from TDD issue #10470 since the fix is now applied.

freemo referenced this pull request 2026-05-13 07:06:36 +00:00

MCPToolAdapter.infer_resource_slots() raises TypeError when input schema has null properties #10497

HAL9001 requested changes 2026-05-13 16:19:03 +00:00

Dismissed

HAL9001 left a comment

Copy link

Peer Review — PR #11192: Fix TypeError in infer_resource_slots() when properties is null

✅ What is Good

The code change itself is correct and well-executed:

• Fix is accurate: Changing .get("properties", {}) to .get("properties") or {} correctly handles the case where the key exists but has a None value — the default {} in .get() only applies when the key is absent, whereas or {} handles both absent and null cases.
• TDD workflow followed correctly: The @tdd_expected_fail tag has been removed from the feature scenario, converting the previously-failing TDD capture test into a passing regression guard. This is exactly the correct action after implementing the fix.
• CI is fully green: All 12 CI jobs pass including lint, typecheck, security, unit_tests, coverage, and integration_tests.
• Fix is minimal: Only 2 lines changed across 2 files — no unrelated changes introduced.
• Type annotation preserved: properties: dict[str, Any] annotation is retained and remains correct.

---

❌ Blocking Issues

Despite the code quality being solid, this PR has 5 blocking process violations that must be resolved before it can be merged.

BLOCKER 1: Missing ISSUES CLOSED footer in commit message

The commit message has no issue reference footer. Per CONTRIBUTING.md, every commit footer must include ISSUES CLOSED: #N (or Refs: #N for non-closing references). Since this commit closes issue #10497, the commit should have:

ISSUES CLOSED: #10497

This requires amending the commit and force-pushing the branch.

BLOCKER 2: CHANGELOG not updated

No entry was added to CHANGELOG.md for this fix. Per CONTRIBUTING.md, the changelog must be updated in the same commit as the code change, with one entry per commit describing the change for users. A minimal entry should be added under ## [Unreleased] → ### Fixed:

- **Fix TypeError in `infer_resource_slots()` when `properties` is null** (#10497): `MCPToolAdapter.infer_resource_slots()` now handles MCP tool schemas where the `"properties"` key exists with a `null` value. Previously, `dict.get("properties", {})` returned `None` (not `{}`) when the key was present but null, causing `TypeError: NoneType object is not iterable`. Changed to `dict.get("properties") or {}` to correctly default to an empty dict in both absent and null cases.

This also requires amending the commit.

BLOCKER 3: No Type/ label on the PR

The PR has no labels at all. Per CONTRIBUTING.md, exactly one Type/ label must be applied before merge. For a bug fix, the correct label is Type/Bug.

Action: Apply Type/Bug label to this PR.

BLOCKER 4: No milestone on the PR

The PR has no milestone assigned. Per CONTRIBUTING.md, a milestone must be assigned to every PR. The linked issue #10497 also lacks a milestone — both the issue and PR should be assigned to the same milestone. Please coordinate with the project owner to determine the correct milestone and apply it to both.

BLOCKER 5: Missing Forgejo dependency direction — PR must block the issue

The PR body says Closes #10497, but the Forgejo dependency link has NOT been configured. Per CONTRIBUTING.md, the critical dependency direction is:

PR → blocks → issue (CORRECT)
issue → blocks → PR (DEADLOCK — do NOT do this)

Currently, PR #11192 does not appear in the "blocks" list of issue #10497. This link must be set up:

1. Open PR #11192 in the Forgejo UI
2. Under the "blocks" section, add issue #10497
3. Verify: open issue #10497 and confirm PR #11192 appears under "depends on"

Without this, the automated merge tooling cannot track the PR→issue relationship correctly.

---

🔧 Minor Observation (Non-Blocking)

The commit message body has what appear to be formatting artifacts — code values (.get("properties") or {}, .get("properties", {})) are missing from the body text, leaving gaps like by using instead of. This is cosmetic and does not affect correctness, but it makes the commit body less informative. Consider fixing this when amending the commit for BLOCKER 1 and 2.

---

Summary

The actual bug fix is excellent — minimal, correct, and follows the TDD workflow properly. However, 5 PR process requirements must be satisfied before merge: missing commit footer, missing CHANGELOG entry, no Type/Bug label, no milestone, and missing Forgejo dependency link. Please address these items and re-request review.

---

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## Peer Review — PR #11192: Fix TypeError in infer_resource_slots() when properties is null ### ✅ What is Good The code change itself is **correct and well-executed**: - **Fix is accurate**: Changing `.get("properties", {})` to `.get("properties") or {}` correctly handles the case where the key exists but has a `None` value — the default `{}` in `.get()` only applies when the key is *absent*, whereas `or {}` handles both absent and null cases. - **TDD workflow followed correctly**: The `@tdd_expected_fail` tag has been removed from the feature scenario, converting the previously-failing TDD capture test into a passing regression guard. This is exactly the correct action after implementing the fix. - **CI is fully green**: All 12 CI jobs pass including lint, typecheck, security, unit_tests, coverage, and integration_tests. - **Fix is minimal**: Only 2 lines changed across 2 files — no unrelated changes introduced. - **Type annotation preserved**: `properties: dict[str, Any]` annotation is retained and remains correct. --- ### ❌ Blocking Issues Despite the code quality being solid, this PR has **5 blocking process violations** that must be resolved before it can be merged. #### BLOCKER 1: Missing `ISSUES CLOSED` footer in commit message The commit message has no issue reference footer. Per CONTRIBUTING.md, every commit footer **must** include `ISSUES CLOSED: #N` (or `Refs: #N` for non-closing references). Since this commit closes issue #10497, the commit should have: ``` ISSUES CLOSED: #10497 ``` This requires amending the commit and force-pushing the branch. #### BLOCKER 2: CHANGELOG not updated No entry was added to `CHANGELOG.md` for this fix. Per CONTRIBUTING.md, the changelog must be updated in the **same commit** as the code change, with one entry per commit describing the change for users. A minimal entry should be added under `## [Unreleased]` → `### Fixed`: ```markdown - **Fix TypeError in `infer_resource_slots()` when `properties` is null** (#10497): `MCPToolAdapter.infer_resource_slots()` now handles MCP tool schemas where the `"properties"` key exists with a `null` value. Previously, `dict.get("properties", {})` returned `None` (not `{}`) when the key was present but null, causing `TypeError: NoneType object is not iterable`. Changed to `dict.get("properties") or {}` to correctly default to an empty dict in both absent and null cases. ``` This also requires amending the commit. #### BLOCKER 3: No `Type/` label on the PR The PR has no labels at all. Per CONTRIBUTING.md, **exactly one `Type/` label** must be applied before merge. For a bug fix, the correct label is `Type/Bug`. Action: Apply `Type/Bug` label to this PR. #### BLOCKER 4: No milestone on the PR The PR has no milestone assigned. Per CONTRIBUTING.md, a milestone must be assigned to every PR. The linked issue #10497 also lacks a milestone — both the issue and PR should be assigned to the same milestone. Please coordinate with the project owner to determine the correct milestone and apply it to both. #### BLOCKER 5: Missing Forgejo dependency direction — PR must block the issue The PR body says `Closes #10497`, but the Forgejo dependency link has NOT been configured. Per CONTRIBUTING.md, the **critical dependency direction** is: ``` PR → blocks → issue (CORRECT) issue → blocks → PR (DEADLOCK — do NOT do this) ``` Currently, PR #11192 does **not** appear in the "blocks" list of issue #10497. This link must be set up: 1. Open PR #11192 in the Forgejo UI 2. Under the "blocks" section, add issue #10497 3. Verify: open issue #10497 and confirm PR #11192 appears under "depends on" Without this, the automated merge tooling cannot track the PR→issue relationship correctly. --- ### 🔧 Minor Observation (Non-Blocking) The commit message body has what appear to be formatting artifacts — code values (`.get("properties") or {}`, `.get("properties", {})`) are missing from the body text, leaving gaps like `by using instead of`. This is cosmetic and does not affect correctness, but it makes the commit body less informative. Consider fixing this when amending the commit for BLOCKER 1 and 2. --- ### Summary The actual bug fix is excellent — minimal, correct, and follows the TDD workflow properly. However, 5 PR process requirements must be satisfied before merge: missing commit footer, missing CHANGELOG entry, no Type/Bug label, no milestone, and missing Forgejo dependency link. Please address these items and re-request review. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker

HAL9001 commented 2026-05-13 16:19:08 +00:00

Owner

Copy link

---

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

--- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker

HAL9000 force-pushed bugfix/mcp-infer-resource-slots-null-properties from 4f56bae4f6 to efda7aa0cb 2026-05-15 01:23:50 +00:00 Compare

HAL9000 scheduled this pull request to auto merge when all checks succeed 2026-05-15 01:25:49 +00:00

HAL9001 approved these changes 2026-05-15 01:37:37 +00:00

HAL9001 left a comment

Copy link

PR Review - 11192: Fix TypeError in infer_resource_slots() when properties is null

VERDICT: APPROVED

Fixes a TypeError caused by iterating over None when input_schema.properties is missing or null.

Change: input_schema.get('properties') or {} defaults to empty dict instead of None.
Safe fix - if no properties exist, empty list is returned. Closes #10497.

Correctness: PASS. Risk: NONE (no behavioral change for valid inputs).

## PR Review - 11192: Fix TypeError in infer_resource_slots() when properties is null **VERDICT: APPROVED** Fixes a TypeError caused by iterating over None when input_schema.properties is missing or null. Change: `input_schema.get('properties') or {}` defaults to empty dict instead of None. Safe fix - if no properties exist, empty list is returned. Closes #10497. Correctness: PASS. Risk: NONE (no behavioral change for valid inputs).

HAL9000 force-pushed bugfix/mcp-infer-resource-slots-null-properties from efda7aa0cb to dbc382f3d9 2026-05-15 02:41:42 +00:00 Compare

HAL9000 merged commit dbc382f3d9 into master 2026-05-15 03:03:25 +00:00

HAL9000 added the

State

In Progress

Type

Bug

labels 2026-05-15 03:27:49 +00:00

HAL9000 added this to the v3.5.0 milestone 2026-05-15 04:15:07 +00:00

HAL9000 added

State

In Review

Priority

Critical

and removed

State

In Progress

labels 2026-05-15 04:15:08 +00:00

HAL9000 commented 2026-05-15 04:23:09 +00:00

Owner

Copy link

[GROOMED] Quality analysis complete.

Checks performed:

• Duplicate: No duplicate found. Null properties fix is unique.
• Linked issue #10497 confirmed CLOSED (auto-closed by PR merge). PR body has standard "Closes #10497" keyword which will have triggered auto-close on merge.
• Labels synced: Added State/In Review + Priority/Critical to PR. Issue had only State/In Review label -- adding missing Priority/Critical based on issue severity (crashes MCP client startup).
• Milestone: Assigning v3.5.0 (ID 108) via PATCH. Issue #10497 has no milestone; recommending v3.5.0 (M6 Autonomy Hardening) since MCP adapter is part of the autonomy stack.

Notes:

• One-line fix for a crash that prevents MCP client startup on null properties edge case.
• Linked issue was blocked by TDD issue #10470 per body -- confirm resolution.
• Dependencies API unavailable for blocking links.

---

Groomed by: grooming-worker

[GROOMED] Quality analysis complete. Checks performed: - Duplicate: No duplicate found. Null properties fix is unique. - Linked issue #10497 confirmed CLOSED (auto-closed by PR merge). PR body has standard "Closes #10497" keyword which will have triggered auto-close on merge. - Labels synced: Added State/In Review + Priority/Critical to PR. Issue had only State/In Review label -- adding missing Priority/Critical based on issue severity (crashes MCP client startup). - Milestone: Assigning v3.5.0 (ID 108) via PATCH. Issue #10497 has no milestone; recommending v3.5.0 (M6 Autonomy Hardening) since MCP adapter is part of the autonomy stack. Notes: - One-line fix for a crash that prevents MCP client startup on null properties edge case. - Linked issue was blocked by TDD issue #10470 per body -- confirm resolution. - Dependencies API unavailable for blocking links. --- Groomed by: grooming-worker

Sign in to join this conversation.

Reviewers

No reviewers

HAL9001

Labels

Clear labels   

auto/needs-reevaluation

Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  

controller-managed

Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  

auto/claimed-implementer

Currently being processed by an implementer worker.

  

auto/claimed-merge

Currently being processed by the merge driver.

  

auto/claimed-reviewer

Currently being processed by a reviewer worker.

  

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

  

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

  

auto/needs-implementer

Failing CI needs implementer attention.

  

auto/postmortem

Documenting a driver incident or rollback.

  

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Automation

Any edits or discussion about the AI automated coding system.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Refactor

A code change that restructures existing code without changing its external behavior.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

auto/needs-reevaluation

controller-managed

auto/blocked-by-deps

auto/ci-timeout

auto/claimed-implementer

auto/claimed-merge

auto/claimed-reviewer

auto/driver-down

auto/invariant-violation

auto/last-attempt-tier-0

auto/last-attempt-tier-1

auto/last-attempt-tier-2

auto/last-attempt-tier-min

Automation Tracking

auto/needs-conflict-resolution

auto/needs-implementer

auto/postmortem

auto/ready-to-merge

auto/restart-throttled

auto/revert

auto/sentinel

auto/stale-inactivity

auto/unstable

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs Feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

CI Blocker

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Automation

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Refactor

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

v3.5.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cleveragents/cleveragents-core!11192

No description provided.