cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(lsp): cleanup subprocess on failed initialization in StdioTransport.start() #11185

Open
HAL9000 wants to merge 3 commits from fix/stdlib-transport-cleanup into master
pull from: fix/stdlib-transport-cleanup
merge into: cleveragents:master
Conversation 11 Commits 3 Files Changed 5
+146 -1

3 Commits

Author SHA1 Message Date
HAL9000 10e8167ef7 fix(lsp): address reviewer blockers — remove duplicate step, move LspError import, fix metadata
CI / lint (pull_request) Successful in 53s
Details
CI / typecheck (pull_request) Successful in 1m2s
Details
CI / security (pull_request) Successful in 1m5s
Details
CI / quality (pull_request) Successful in 1m1s
Details
CI / build (pull_request) Successful in 50s
Details
CI / helm (pull_request) Successful in 51s
Details
CI / push-validation (pull_request) Successful in 35s
Details
CI / unit_tests (pull_request) Successful in 5m11s
Details
CI / docker (pull_request) Successful in 1m37s
Details
CI / integration_tests (pull_request) Successful in 8m57s
Details
CI / coverage (pull_request) Failing after 19m24s
Details
CI / status-check (pull_request) Has been cancelled
Details 
- Remove duplicate @then("ltcov the transport should be alive") in
  features/steps/lsp_transport_coverage_steps.py; the same step is
  already defined at features/steps/lsp_transport_post_spawn_cleanup_steps.py:92
  for issue #7044. The duplicate caused AmbiguousStep at behave load
  time, erroring every BDD feature in the suite (root cause of the
  CI unit_tests + coverage gate failures).
- Remove redundant inline `from cleveragents.lsp.errors import LspError`
  inside StdioTransport.start(); the module-level import at line 30
  is sufficient and inline imports violate the project import rule.
- Update CONTRIBUTORS.md: correct the PR number from #11160 (the
  linked issue) to #11185 (this PR).
- features/lsp_transport_subprocess_cleanup.feature: add the required
  `@tdd_issue @tdd_issue_11160` tags per the TDD bug-fix workflow,
  fix the `returnscode` typo in a scenario name, and rename the
  `dye_on_start` command label to `die_on_start`.

ISSUES CLOSED: #11160
 2026-06-15 00:41:18 -04:00
controller-ci-rerun 007fd66b90 chore: re-trigger CI [controller] 2026-06-15 00:41:18 -04:00
HAL9000 8e41165223 fix(lsp): cleanup subprocess on failed initialization in StdioTransport.start() 
After Popen() succeeds, verify the spawned process is still alive via poll().
If it died immediately during initialization (binary corrupted, missing shared
libraries, etc.), call stop() to release the handle and raise LspError with exit code.
This prevents resource leaks where _process was left pointing to a terminated Popen object.

ISSUES CLOSED: #11160
 2026-06-15 00:41:18 -04:00