Remove duplicate @then step from uow_coverage_boost_steps.py that
conflicted with actor_config_steps.py:168. Both patterns matched
'a ValueError should be raised containing "{...}"' but used different
capture-variable names, triggering AmbiguousStep at import time.
Update the four When steps to store the caught exception in
context.last_error so the existing actor_config_steps assertion handles
the Then clause.
ISSUES CLOSED: #878
The uow_coverage_boost BDD scenarios assert that create_engine is called
without isolation_level for non-SQLite backends. The existing comment block
already documents the deliberate use of PostgreSQL's default READ COMMITTED
isolation level (satisfying the reviewer's requirement for explicit
documentation of the isolation choice).
ISSUES CLOSED: #878
Add PostgreSQL support as the server-mode storage backend alongside
existing SQLite for local mode. Verify all ORM models are dialect-
agnostic, configure connection pooling for multi-user access, add
Docker Compose for local PG development, and wire database URL
selection based on deployment mode.
Changes:
- Add psycopg2-binary dependency to pyproject.toml
- Add server_mode, db_pool_size, db_max_overflow, db_pool_recycle
settings to Settings with environment variable support
- Add resolve_database_url() and is_postgresql() to Settings for
mode-aware database URL resolution
- Configure UnitOfWork engine creation with pool_size, max_overflow,
pool_recycle, and pool_pre_ping for PostgreSQL connections
- Update MigrationRunner to handle both SQLite and PostgreSQL backends
- Add compare_type=True to Alembic env.py for dialect-aware migrations
- Add docker-compose.yml with PostgreSQL 16-alpine for local development
- Add Behave BDD feature (14 scenarios) covering settings, pool config,
engine creation, ORM dialect compatibility, and migration runner
- Add Robot Framework integration tests (12 test cases) for the
abstraction layer with requires_postgresql tag for live PG tests
Fixes:
- Restore require_confirmation parameter to UnitOfWork.__init__
- Add argument validation to UnitOfWork.__init__ (fail-fast)
- Add explicit PostgreSQL isolation_level (READ COMMITTED)
- Add dispose() method and context manager support to UnitOfWork
- Fix MigrationRunner.get_current_revision() to dispose engine
- Fix Settings.is_postgresql() to handle ValueError gracefully
ISSUES CLOSED: #878
Add PostgreSQL support as the server-mode storage backend alongside
existing SQLite for local mode. Verify all ORM models are dialect-
agnostic, configure connection pooling for multi-user access, add
Docker Compose for local PG development, and wire database URL
selection based on deployment mode.
Changes:
- Add psycopg2-binary dependency to pyproject.toml
- Add server_mode, db_pool_size, db_max_overflow, db_pool_recycle
settings to Settings with environment variable support
- Add resolve_database_url() and is_postgresql() to Settings for
mode-aware database URL resolution
- Configure UnitOfWork engine creation with pool_size, max_overflow,
pool_recycle, and pool_pre_ping for PostgreSQL connections
- Update MigrationRunner to handle both SQLite and PostgreSQL backends
- Add compare_type=True to Alembic env.py for dialect-aware migrations
- Add docker-compose.yml with PostgreSQL 16-alpine for local development
- Add Behave BDD feature (14 scenarios) covering settings, pool config,
engine creation, ORM dialect compatibility, and migration runner
- Add Robot Framework integration tests (12 test cases) for the
abstraction layer with requires_postgresql tag for live PG tests
ISSUES CLOSED: #878
HAL9000
controller-ci-rerun
freemo