cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(data-integrity): remove silent argument swap in ValidationAttachmentRepository.attach #11171

Closed
HAL9000 wants to merge 1 commits from fix-arg-swap-validation-attachment-8177 into master
pull from: fix-arg-swap-validation-attachment-8177
merge into: cleveragents:master
Conversation 1 Commits 1 Files Changed 7
+310 -14

1 Commits

Author SHA1 Message Date
CleverThis 406fa93ce5 fix(data-integrity): remove silent argument swap in ValidationAttachmentRepository.attach
CI / lint (pull_request) Failing after 3s
Details
CI / typecheck (pull_request) Failing after 3s
Details
CI / security (pull_request) Failing after 3s
Details
CI / integration_tests (pull_request) Failing after 3s
Details
CI / unit_tests (pull_request) Failing after 3s
Details
CI / quality (pull_request) Failing after 3s
Details
CI / helm (pull_request) Failing after 3s
Details
CI / build (pull_request) Failing after 2s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / push-validation (pull_request) Failing after 3s
Details
CI / status-check (pull_request) Failing after 4s
Details 
Remove the fragile heuristic ("//" in resource_id") from
ValidationAttachmentRepository.attach() that silently swapped
validation_name and resource_id, causing silent data corruption
when resource IDs contained slashes. Arguments now flow directly
from caller to the persistence layer in their correct positional order.

Added comprehensive BDD regression suite (validation_argument_order_integrity.feature)
with 12 scenarios covering: simple IDs, slash-containing IDs, dual-slash IDs,
project/plan overrides, mode/args overrides, and edge cases.

Also updated repositories_uncovered_branches.feature existing swap test
to verify preservation instead of swapping.

ISSUES CLOSED: #7492
 2026-05-12 19:39:40 +00:00