cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(lsp): cleanup subprocess on failed initialization in StdioTransport.start() #11163

Closed
HAL9000 wants to merge 2 commits from fix/pr-11011-subprocess-cleanup into master
pull from: fix/pr-11011-subprocess-cleanup
merge into: cleveragents:master
Conversation 14 Commits 2 Files Changed 5
+616 -144

2 Commits

Author SHA1 Message Date
HAL9000 c3e89fc341 fix(lsp): restore explicit _process cleanup in OSError handler
CI / helm (pull_request) Successful in 47s
Details
CI / push-validation (pull_request) Successful in 38s
Details
CI / build (pull_request) Successful in 1m12s
Details
CI / quality (pull_request) Successful in 1m25s
Details
CI / lint (pull_request) Failing after 1m26s
Details
CI / typecheck (pull_request) Successful in 1m39s
Details
CI / security (pull_request) Successful in 2m2s
Details
CI / integration_tests (pull_request) Successful in 4m43s
Details
CI / unit_tests (pull_request) Failing after 6m18s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 3s
Details 
PR branch HEAD was using try-except-pass around stop() without an
explicit self._process = None assignment in the OSError exception
handler.  This corrected it to match master and the FileNotFoundError
pattern: direct stop() followed by explicit _process = None.

Closes #10597
 2026-05-15 14:10:51 +00:00
HAL9000 71ec58b232 fix(lsp): cleanup subprocess on failed initialization in StdioTransport.start() 
When Popen() succeeds but then raises OSError (e.g., exec failure in forked
child), the process reference isn't cleaned up, potentially leaking zombie/orphan
language-server processes.

Fix sets _process = None before Popen() call and calls stop() on any partially-
started process in the OSError handler to prevent leaks. Added BDD + pytest
test coverage for regression guard.

Closes #10597
 2026-05-15 14:10:51 +00:00