cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(agents/graphs/plan_generation): BDD tests and docs for validation bypass #10480 #11149

Open
freemo wants to merge 2 commits from fix/10480-validation-bypass-fix into master
pull from: fix/10480-validation-bypass-fix
merge into: cleveragents:master
Conversation 6 Commits 2 Files Changed 4
+284

2 Commits

Author SHA1 Message Date
HAL9000 e5cf1a4528 test(agents/plan_generation): fix BDD step ambiguity and add tdd_bug tag (#10480)
CI / push-validation (pull_request) Successful in 19s
Details
CI / helm (pull_request) Successful in 28s
Details
CI / build (pull_request) Successful in 42s
Details
CI / lint (pull_request) Successful in 48s
Details
CI / quality (pull_request) Successful in 49s
Details
CI / tdd_quality_gate (pull_request) Failing after 59s
Details
CI / typecheck (pull_request) Successful in 1m14s
Details
CI / security (pull_request) Successful in 1m15s
Details
CI / e2e_tests (pull_request) Successful in 4m2s
Details
CI / integration_tests (pull_request) Failing after 4m8s
Details
CI / unit_tests (pull_request) Failing after 4m56s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 3s
Details 
The compliance tests added in 80fa1329 had three issues that broke
multiple CI gates:

1. unit_tests (Behave): the new
   features/steps/validation_bypass_issue_10480_steps.py redefined
   `@given("the plan generation coverage module is imported")`, which
   was already defined in plan_generation_coverage_boost_steps.py.
   Behave raised AmbiguousStep and 32 scenarios errored on import.
   The duplicate has been removed; the feature reuses the existing
   step via behave's global step discovery.

2. unit_tests (Behave): three `@then` decorators included a literal
   "and " prefix (e.g. `@then("and no artificial length threshold ...")`),
   which never matches because Behave normalises "And" into the
   preceding step's keyword and strips it from the match text. The
   prefixes have been removed so the three previously-undefined steps
   now resolve.

3. tdd_quality_gate: scenarios lacked the `@tdd_bug_10480` tag that
   scripts/tdd_quality_gate.py requires to recognise the regression
   guard for the bug. All 5 scenarios now carry the tag.

Also fixes a grammatical error in the CHANGELOG entry
("responsible for determine" → "responsible for determining") noted
by the reviewer.

Refs #10480
 2026-06-15 00:51:20 -04:00
CleverThis Agent 80fa132921 fix(agents/plan_generation): BDD tests and docs for validation bypass fix #10480. Code fix already merged to master, this adds compliance: Behave scenarios for PASS/FAIL at any code length, CHANGELOG entry, contribution credit.
CI / lint (pull_request) Successful in 1m19s
Details
CI / typecheck (pull_request) Successful in 57s
Details
CI / helm (pull_request) Successful in 44s
Details
CI / push-validation (pull_request) Successful in 44s
Details
CI / build (pull_request) Successful in 1m1s
Details
CI / quality (pull_request) Successful in 1m36s
Details
CI / security (pull_request) Successful in 1m41s
Details
CI / tdd_quality_gate (pull_request) Failing after 1m38s
Details
CI / e2e_tests (pull_request) Successful in 3m58s
Details
CI / integration_tests (pull_request) Failing after 5m35s
Details
CI / unit_tests (pull_request) Failing after 6m4s
Details
CI / docker (pull_request) Has been skipped
Details
CI / coverage (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 2s
Details 
ISSUES CLOSED: #10480
 2026-05-12 08:15:50 +00:00