cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

test(plan): add tdd issue-capture test for cleanup_stale destroying execute output before apply #11123

Closed
hurui200320 wants to merge 1 commits from tdd/m3-cleanup-stale-destroys-execute-output into master
pull from: tdd/m3-cleanup-stale-destroys-execute-output
merge into: cleveragents:master
Conversation 8 Commits 1 Files Changed 10
+467 -77

1 Commits

Author SHA1 Message Date
hurui200320 e23126b8a1 test(plan): add tdd issue-capture test for cleanup_stale destroying execute output before apply
CI / helm (pull_request) Successful in 42s
Details
CI / push-validation (pull_request) Successful in 41s
Details
CI / build (pull_request) Successful in 1m9s
Details
CI / quality (pull_request) Successful in 1m19s
Details
CI / lint (pull_request) Successful in 1m21s
Details
CI / typecheck (pull_request) Successful in 1m25s
Details
CI / tdd_quality_gate (pull_request) Successful in 1m25s
Details
CI / security (pull_request) Successful in 1m39s
Details
CI / e2e_tests (pull_request) Successful in 3m46s
Details
CI / integration_tests (pull_request) Successful in 4m0s
Details
CI / unit_tests (pull_request) Successful in 6m22s
Details
CI / docker (pull_request) Successful in 1m24s
Details
CI / coverage (pull_request) Successful in 9m47s
Details
CI / status-check (pull_request) Successful in 2s
Details 
Add two Behave scenarios tagged @tdd_issue, @tdd_issue_11121, and @tdd_expected_fail
that capture bug #11121: _create_sandbox_for_plan() calls
GitWorktreeSandbox.cleanup_stale() unconditionally on every execute invocation,
including when the plan is already in execute/complete state awaiting apply.

Scenario 1 asserts that the cleveragents/plan-<id> branch survives a second call
to _create_sandbox_for_plan() on an execute/complete plan. This assertion fails
because cleanup_stale deletes the branch regardless of plan state.

Scenario 2 asserts that plan apply would find at least one artifact after a
re-invoked execute on an execute/complete plan. This assertion fails because the
branch (holding execute output) was destroyed by cleanup_stale.

Both scenarios use @tdd_expected_fail so CI passes while the bug is unfixed.
The @mock_only tag ensures no database is created for these git-only tests.
The companion fix is tracked in issue #11121.

Additional CI fixes bundled in this commit:

- Fixed PlanGenerationGraph recursion bug: _should_retry() was mutating state
  in-place but LangGraph conditional edge functions cannot persist state
  mutations. Replaced with a proper _handle_retry() node that increments
  retry_count via state returns, resolving the GraphRecursionError that was
  crashing the integration tests. Updated the graph to include handle_retry
  as the 5th node, routing validate→should_retry→handle_retry→analyze.

- Fixed TDD quality gate (scripts/tdd_quality_gate.py): Renamed @tdd_bug_N
  tags to @tdd_issue_N to match the CONTRIBUTING.md specification. Added
  _diff_is_tdd_issue_capture() detection so that TDD issue-capture PRs
  (which add @tdd_expected_fail rather than remove it) pass the quality gate
  correctly. Updated all related tests (Behave unit tests, Robot integration
  tests, and test helpers) to use the new tag naming.

ISSUES CLOSED: #11120
 2026-05-12 04:53:56 +00:00