cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(tui): wire ShellSafetyService into run_shell_command replacing legacy looks_dangerous #11112

Open
HAL9000 wants to merge 3 commits from fix/pr-10890-shell-safety-integration into master
pull from: fix/pr-10890-shell-safety-integration
merge into: cleveragents:master
Conversation 3 Commits 3 Files Changed 4
+535 -19

3 Commits

Author SHA1 Message Date
controller-ci-rerun 5b6584cb7e chore: re-trigger CI [controller]
CI / lint (pull_request) Failing after 35s
Details
CI / security (pull_request) Successful in 1m10s
Details
CI / typecheck (pull_request) Successful in 1m18s
Details
CI / quality (pull_request) Successful in 1m19s
Details
CI / push-validation (pull_request) Successful in 24s
Details
CI / helm (pull_request) Successful in 35s
Details
CI / build (pull_request) Successful in 40s
Details
CI / integration_tests (pull_request) Failing after 2m48s
Details
CI / e2e_tests (pull_request) Successful in 3m20s
Details
CI / unit_tests (pull_request) Failing after 17m24s
Details
CI / coverage (pull_request) Has been cancelled
Details
CI / docker (pull_request) Has been cancelled
Details
CI / status-check (pull_request) Has been cancelled
Details
2026-06-12 15:42:14 -04:00
CleverAgents Bot 95a8c4ba9b ci: stop master workflow on PR updates
CI / push-validation (pull_request) Successful in 32s
Details
CI / lint (pull_request) Failing after 49s
Details
CI / helm (pull_request) Successful in 48s
Details
CI / build (pull_request) Successful in 49s
Details
CI / quality (pull_request) Successful in 1m9s
Details
CI / typecheck (pull_request) Successful in 1m14s
Details
CI / security (pull_request) Successful in 1m50s
Details
CI / integration_tests (pull_request) Failing after 3m11s
Details
CI / e2e_tests (pull_request) Successful in 4m15s
Details
CI / unit_tests (pull_request) Failing after 6m32s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 3s
Details 
Remove the stale pull_request trigger from master.yml so PR branch commits do not launch the master workflow.

Maintenance patch for PR #11112.
 2026-06-10 20:17:42 -04:00
HAL9000 641527ac56 fix(tui): wire ShellSafetyService into run_shell_command replacing legacy looks_dangerous
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / push-validation (pull_request) Successful in 38s
Details
CI / helm (pull_request) Successful in 45s
Details
CI / build (pull_request) Successful in 57s
Details
CI / lint (pull_request) Failing after 1m30s
Details
CI / quality (pull_request) Successful in 1m31s
Details
CI / typecheck (pull_request) Successful in 1m49s
Details
CI / security (pull_request) Successful in 1m50s
Details
CI / benchmark-regression (pull_request) Failing after 1m18s
Details
CI / integration_tests (pull_request) Successful in 4m8s
Details
CI / e2e_tests (pull_request) Failing after 4m33s
Details
CI / unit_tests (pull_request) Failing after 5m27s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 3s
Details 
Replace the simple substring-based looks_dangerous() function in run_shell_command
with comprehensive pattern matching via ShellSafetyService. The new implementation
checks commands against 15 regex-based patterns across four severity levels
(LOW, MEDIUM, HIGH, CRITICAL) before executing shell commands.

Key changes:
- Module-level ShellSafetyService instance used for safety gating
- looks_dangerous() preserved as backward-compatible function delegating to service
- Legacy confirm_dangerous(callback) parameter adapted via wrapper
- New warn_callback(warning) parameter for rich warning context
- Comprehensive BDD test scenarios for the integration
 2026-05-11 02:00:09 +00:00