.forgejo/workflows/master.yml

@@ -3,8 +3,6 @@ name: CI
 on:
     push:
         branches: [master, develop]
-    pull_request:
-        branches: [master, develop]
 
 vars:
     docker_prefix: "http://harbor.cleverthis.com/docker/"

CHANGELOG.md

@@ -14,6 +14,14 @@ The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
   from the TDD test so both scenarios run as normal regression guards. (#988)
 
 ### Fixed
+  
+- **Cost budget service warns after reconfiguring session** (#8284): Added 
+`self._warned_sessions.discard(session_id)` in `configure_session_budget()` so that
+reconfiguring a session's budget clears its warning history and allows fresh
+BUDGET_WARNING events for the updated configuration. Prior to this fix, once a
+session emitted a BUDGET_WARNING it was permanently suppressed even if the budget
+was reconfigured with new limits.
+
 - **TUI Prompt Symbol Mode Awareness** (#6431): The prompt widget now displays a
   mode-dependent symbol (`❯` normal, `/` command, `$` shell, `☰` multi-line),
   implemented via `_PromptSymbolMixin` and `InputMode.MULTILINE`. The widget uses

CONTRIBUTORS.md

@@ -23,7 +23,10 @@ Below are some of the specific details of various contributions.
 * HAL 9000 has contributed the plugin entry point security hardening fix (#7476): enforced entry point allowlist validation before importing plugin modules to prevent malicious plugin loading.
 * HAL 9000 has contributed the benchmark workflow separation (#9040): moved the benchmark-regression job out of the default PR workflow into a dedicated scheduled workflow, reducing median PR CI turnaround time from 99-132 minutes to under 30 minutes.
 * HAL 9000 has contributed the plan tree JSON/YAML command envelope fix (#9163): wrapped `agents plan tree --format json/yaml` output in the spec-required command envelope structure, added summary statistics, decision_ids mapping, child_plans list, and accurate timing measurement.
-* This project was made possible thanks to considerable donation of time, money, and resources by CleverThis, Inc.
+* HAL 9000 has contributed the cost budget service `warned_sessions` reset fix (#8284): reconfiguring a session's budget now clears its warning history to allow fresh BUDGET_WARNING events for the updated configuration.
+
+
+This project was made possible thanks to considerable donation of time, money, and resources by CleverThis, Inc.
 * HAL 9000 has contributed automated bug fixes, CLI output formatting improvements, and ongoing maintenance as part of the CleverAgents automation system.
 * HAL 9000 has contributed the file edit encoding parameter fix (PR #8258 / issue #7559).
 * HAL 9000 has contributed the architecture-pool-supervisor milestone assignment feature (PR #8188 / issue #7521): added `forgejo_update_pull_request` permission and documented the PR workflow for major spec changes, enabling automatic milestone assignment for specification PRs.

features/cost_budgets.feature

@@ -476,6 +476,23 @@ Feature: Per-Session and Per-Org Cost Budgets
     And I check budget hierarchy for session "once1" with plan_cost 1.0
     Then the mock event bus should have received exactly 1 BUDGET_WARNING event
 
-  Scenario: BudgetCheckResult model is frozen
+  
+  Scenario: Service resets warned sessions on reconfigure budget config
+    Given a cost budget service with mock event bus and warning threshold 0.5
+    And session "rw1" configured with max_cost_usd 100.0
+    When I record plan cost 60.0 for session "rw1"
+    Then the mock event bus should have received exactly 1 BUDGET_WARNING event
+
+  Scenario: Service reconfigures budget permits fresh warning after discard
+    Given a cost budget service with mock event bus and warning threshold 0.5
+    And session "rw2" configured with max_cost_usd 100.0
+    When I record plan cost 60.0 for session "rw2"
+    And I check budget hierarchy for session "rw2" with plan_cost 1.0
+    Then the mock event bus should have received exactly 1 BUDGET_WARNING event
+    And I reconfigure session "rw2" with max_cost_usd 70.0 and org_id "org-reset"
+    And I check budget hierarchy for session "rw2" with plan_cost 15.0
+    Then the mock event bus should have received exactly 2 BUDGET_WARNING events
+
+    Scenario: BudgetCheckResult model is frozen
     When I create a budget check result allowed=true
     Then modifying the budget check result should raise an error

features/steps/cost_budgets_steps.py

@@ -1018,3 +1018,22 @@ def step_try_record_guardrail_cost_empty(context: Context, cost: float) -> None:
         context.budget_error = None
     except (ValueError, Exception) as exc:
         context.budget_error = exc
+
+
+# Reconfigure session with org_id (for testing warn-reset after reconfigure)
+@when('I reconfigure session "{sid}" with max_cost_usd {value:g} and org_id "{oid}"')
+def step_reconfigure_session_org(context: Context, sid: str, value: float, oid: str) -> None:
+    context.budget_service.configure_session_budget(
+        sid,
+        max_cost_usd=value,
+        org_id=oid,
+    )
+
+
+@when('I check budget hierarchy for session "{sid}" with plan_cost {cost:g} again')
+def step_check_hierarchy_again(context: Context, sid: str, cost: float) -> None:
+    context.budget_result = context.budget_service.check_budget_hierarchy(
+        session_id=sid,
+        plan_cost=cost,
+    )
+

src/cleveragents/application/services/cost_budget_service.py

@@ -106,6 +106,7 @@ class CostBudgetService:
             )
             if org_id is not None:
                 self._session_org[session_id] = org_id
+            self._warned_sessions.discard(session_id)
 
     def get_session_budget(self, session_id: str) -> SessionCostBudget | None:
         """Return the budget for *session_id*, or ``None``.