cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(lsp): cleanup subprocess on failed initialization in StdioTransport.start() #11093

Closed
HAL9000 wants to merge 2 commits from fix-lsp-subprocess-cleanup-10597 into master
pull from: fix-lsp-subprocess-cleanup-10597
merge into: cleveragents:master
Conversation 3 Commits 2 Files Changed 6
+130 -7

2 Commits

Author SHA1 Message Date
CleverAgents Bot 6e49814c78 ci: stop master workflow on PR updates
CI / lint (pull_request) Failing after 39s
Details
CI / helm (pull_request) Successful in 31s
Details
CI / push-validation (pull_request) Successful in 25s
Details
CI / build (pull_request) Successful in 1m0s
Details
CI / typecheck (pull_request) Successful in 1m12s
Details
CI / security (pull_request) Successful in 1m12s
Details
CI / quality (pull_request) Successful in 1m31s
Details
CI / integration_tests (pull_request) Failing after 4m2s
Details
CI / e2e_tests (pull_request) Successful in 4m43s
Details
CI / unit_tests (pull_request) Failing after 5m52s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 3s
Details 
Remove the stale pull_request trigger from master.yml so PR branch commits do not launch the master workflow.

Maintenance patch for PR #11093.
 2026-06-10 20:18:31 -04:00
HAL9000 038839c950 fix(lsp): cleanup subprocess on failed initialization in StdioTransport.start()
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Failing after 1m9s
Details
CI / build (pull_request) Successful in 1m9s
Details
CI / quality (pull_request) Successful in 1m29s
Details
CI / helm (pull_request) Successful in 41s
Details
CI / typecheck (pull_request) Successful in 1m44s
Details
CI / push-validation (pull_request) Successful in 38s
Details
CI / security (pull_request) Successful in 1m46s
Details
CI / benchmark-regression (pull_request) Failing after 1m9s
Details
CI / integration_tests (pull_request) Successful in 4m33s
Details
CI / e2e_tests (pull_request) Successful in 5m42s
Details
CI / unit_tests (pull_request) Failing after 6m40s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 7s
Details 
Guard post-Popen code in StdioTransport.start() with try/finally so that if
any exception occurs after spawning the server process (e.g. immediate exit,
future post-spawn validation failures), the orphaned subprocess is terminated
before the error propagates. This prevents leaked child processes when callers
use Transport.start() directly without wrapping it in their own cleanup logic.

Also added a liveness check immediately after Popen -- if the server was spawned
and exited before poll() returned, we raise LspError and clean up the dead process
so callers never receive a dead-process transport instance.

ISSUES CLOSED: #10597
 2026-05-09 13:26:45 +00:00