fix(lsp): cleanup subprocess on failed initialization in StdioTransport.start() #11070

Closed
HAL9000 wants to merge 2 commits from fix/pr-11050-subprocess-cleanup into master

2 Commits

Author SHA1 Message Date
CleverAgents Bot 06f7a6928e ci: stop master workflow on PR updates
CI / lint (pull_request) Has been cancelled
CI / typecheck (pull_request) Has been cancelled
CI / security (pull_request) Has been cancelled
CI / quality (pull_request) Has been cancelled
CI / unit_tests (pull_request) Has been cancelled
CI / integration_tests (pull_request) Has been cancelled
CI / e2e_tests (pull_request) Has been cancelled
CI / coverage (pull_request) Has been cancelled
CI / build (pull_request) Has been cancelled
CI / docker (pull_request) Has been cancelled
CI / helm (pull_request) Has been cancelled
CI / push-validation (pull_request) Has been cancelled
CI / status-check (pull_request) Has been cancelled
Remove the stale pull_request trigger from master.yml so PR branch commits do not launch the master workflow.

Maintenance patch for PR #11070.
2026-06-10 20:19:11 -04:00
HAL9000 5167d47ce6 fix(lsp): cleanup subprocess on failed initialization in StdioTransport.start()
CI / lint (pull_request) Failing after 1m2s
CI / quality (pull_request) Successful in 1m19s
CI / typecheck (pull_request) Successful in 1m32s
CI / security (pull_request) Successful in 1m49s
CI / benchmark-publish (pull_request) Has been skipped
CI / push-validation (pull_request) Successful in 29s
CI / helm (pull_request) Successful in 40s
CI / build (pull_request) Successful in 47s
CI / benchmark-regression (pull_request) Failing after 1m10s
CI / e2e_tests (pull_request) Failing after 4m6s
CI / integration_tests (pull_request) Successful in 7m11s
CI / unit_tests (pull_request) Failing after 9m34s
CI / coverage (pull_request) Has been skipped
CI / docker (pull_request) Has been skipped
CI / status-check (pull_request) Failing after 4s
Ensure spawned processes are terminated if any exception occurs between
successful subprocess.Popen() and the end of Start(), preventing orphaned
LSP server processes.

The fix wraps post-Popen success logging in a try-except that calls self.stop()
to clean up the process before re-raising the exception.

ISSUES CLOSED: #11050
2026-05-09 02:57:05 +00:00