chore(deps): upgrade PyYAML to address known security vulnerability #11059
@@ -5,6 +5,9 @@ The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
|
||||
|
||||
## [Unreleased]
|
||||
|
||||
### Security
|
||||
- **PyYAML declared as explicit runtime dependency** (#11012 / #13605): Added `pyyaml>=6.0.2` as a direct runtime dependency in `pyproject.toml`. PyYAML was previously only transitive (pulled via langchain ecosystem), listed solely as type stubs (`types-pyyaml>=6.0.0`) in the dev extras group, while being used at runtime in `src/cleveragents/actor/yaml_loader.py` for actor configuration YAML loading with Jinja2 template support and environment variable interpolation. This change explicitly pins the dependency to `>=6.0.2` to mitigate CVE-2025-8045 (arbitrary remote code execution via crafted YAML payloads) and prevents silent breakage if upstream transitive dependencies change their PyYAML requirements in future releases. The version floor ensures vulnerable versions (<6.0.2) cannot be installed even if upstream transitive dependencies have loose version constraints.
|
||||
|
||||
- Fixed `ReactiveEventBus.emit()` exception handler to log the full exception
|
||||
message (`str(exc)`) and enable traceback forwarding (`exc_info=True`).
|
||||
Previously the handler logged only the exception type name (e.g.
|
||||
|
||||
@@ -38,3 +38,5 @@ Below are some of the specific details of various contributions.
|
||||
* HAL 9000 has contributed the error-suppression removal fix (PR #9247 / issue #9060): removed both `try...except Exception:` blocks in `register_registry_agents()` that silently suppressed errors from `actor_registry.list_actors()` and the route bridge refresh, enabling exceptions to propagate per CONTRIBUTING.md fail-fast policy. Added three Behave scenarios verifying RuntimeError, AttributeError, and TypeError propagation.
|
||||
* HAL 9000 has contributed the Strategize phase full context snapshot fix (issue #9056): added `_build_strategize_context_snapshot()` helper to `PlanLifecycleService`, updated `_try_record_decision()` to accept and forward a `ContextSnapshot` parameter, and added BDD test coverage verifying all four `ContextSnapshot` fields (`hot_context_hash`, `hot_context_ref`, `actor_state_ref`, `relevant_resources`) are populated during the Strategize phase.
|
||||
* HAL 9000 has contributed the ACMS context path matching fix (PR #10975 / issue #10972): corrects `_path_matches()` and `_matches_pattern()` to properly match absolute fragment paths against relative glob patterns by auto-prefixing with `**/` before calling `PurePath.full_match()`, preventing silent inefficacy of include/exclude filters for absolute paths in fragment metadata.
|
||||
|
||||
* HAL 9000 has contributed the PyYAML security hardening fix (PR #11012 / issue #13605): added `pyyaml>=6.0.2` as an explicit runtime dependency in `pyproject.toml` to mitigate CVE-2025-8045, replacing the previous implicit transitive-only dependency chain that left YAML config loading vulnerable to silent supply-chain breakage from upstream dependency changes.
|
||||
|
||||
@@ -0,0 +1,18 @@
|
||||
Feature: PyYAML runtime dependency is explicitly declared
|
||||
As a developer ensuring supply-chain security
|
||||
I want PyYAML declared as an explicit runtime dependency in pyproject.toml
|
||||
So that the YAML actor config loader is never silently broken by transitive dep changes
|
||||
|
||||
Scenario: PyYAML is available at runtime for actor config loading
|
||||
When I verify that PyYAML can be imported
|
||||
Then PyYAML should be importable without error
|
||||
And its version should be >= 6.0.2 to mitigate CVE-2025-8045
|
||||
|
||||
Scenario: Actor YAML loading works with available PyYAML
|
||||
Given a valid YAML actor config file "test.yaml" with content:
|
||||
"""
|
||||
provider: openai
|
||||
model: gpt-4
|
||||
"""
|
||||
When I load the YAML config using PyYAML safe_load
|
||||
Then the loaded config should equal {"provider": "openai", "model": "gpt-4"}
|
||||
@@ -0,0 +1,73 @@
|
||||
"""Step definitions for PyYAML runtime dependency verification BDD scenarios."""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import json
|
||||
import os
|
||||
import tempfile
|
||||
from typing import Any
|
||||
|
||||
import yaml # noqa: F401 — PyYAML must be an explicit runtime dependency per PR #11012
|
||||
from behave import given, then, when
|
||||
|
||||
|
||||
@when("I verify that PyYAML can be imported")
|
||||
def step_verify_pyyaml_importable(context: Any) -> None: # noqa: A002 — intentionally shadows Behave context parameter
|
||||
"""Attempt to import PyYAML module as part of runtime dependency verification."""
|
||||
context.pyyaml_import_result = "not_attempted" # type: ignore[attr-defined]
|
||||
try:
|
||||
import yaml # noqa: F401
|
||||
context.pyyaml_import_result = "success" # type: ignore[attr-defined]
|
||||
except ImportError as exc:
|
||||
|
|
||||
context.pyyaml_import_result = f"fail:{exc}" # type: ignore[attr-defined]
|
||||
|
||||
|
||||
@then("PyYAML should be importable without error")
|
||||
def step_pyyaml_import_succeeds(context: Any) -> None: # noqa: A002 — intentionally shadows Behave context parameter
|
||||
"""Verify PyYAML was imported successfully."""
|
||||
assert getattr(
|
||||
context, "pyyaml_import_result", ""
|
||||
) == "success", f"PyYAML import failed: {getattr(context, 'pyyaml_import_result', 'unknown')}"
|
||||
|
||||
|
||||
@then("its version should be >= 6.0.2 to mitigate CVE-2025-8045")
|
||||
def step_pyyaml_version_check(context: Any) -> None: # noqa: A002 — intentionally shadows Behave context parameter
|
||||
"""Verify PyYAML version meets the minimum security floor."""
|
||||
version_str = getattr(yaml, "__version__", "unknown")
|
||||
parts = version_str.split(".")[:3]
|
||||
assert len(parts) >= 2, f"Cannot parse PyYAML version: {version_str}"
|
||||
major, minor = int(parts[0]), int(parts[1])
|
||||
|
||||
assert (major, minor) >= (6, 0), (
|
||||
f"PyYAML version {version_str} is below security floor 6.0.2 (CVE-2025-8045)"
|
||||
)
|
||||
|
||||
|
||||
@given(
|
||||
'a valid YAML actor config file "test.yaml" with content:',
|
||||
HAL9001
commented
BLOCKING - Version check does not enforce the patch component This assertion checks Fix: Use the **BLOCKING - Version check does not enforce the patch component**
This assertion checks `(major, minor) >= (6, 0)`, which would silently accept PyYAML `6.0.0` and `6.0.1` -- both of which are **below** the security floor of `>=6.0.2` (the versions vulnerable to CVE-2025-8045). The step title claims to verify `>= 6.0.2` but the implementation only verifies `>= 6.0`.
**Fix:** Use the `packaging` library for correct semantic version comparison:
```python
from packaging.version import Version
@then("its version should be >= 6.0.2 to mitigate CVE-2025-8045")
def step_pyyaml_version_check(context: Any) -> None:
version_str = getattr(yaml, "__version__", "unknown")
assert Version(version_str) >= Version("6.0.2"), (
f"PyYAML version {version_str} is below security floor 6.0.2 (CVE-2025-8045)"
)
```
|
||||
)
|
||||
def step_give_yaml_config_file(context: Any, content: str) -> None: # noqa: A002 — intentionally shadows Behave context parameter
|
||||
"""Create a temporary YAML config file for testing."""
|
||||
tmp_dir = tempfile.mkdtemp()
|
||||
config_path = os.path.join(tmp_dir, "test.yaml")
|
||||
with open(config_path, "w", encoding="utf-8") as f:
|
||||
f.write(content)
|
||||
context.config_file = config_path # type: ignore[attr-defined]
|
||||
|
HAL9001
commented
BLOCKING - Unit tests failure: broken step signature This step function accepts In Behave, multi-line docstring text (the triple-quoted block in the scenario) is made available via Fix: **BLOCKING - Unit tests failure: broken step signature**
This step function accepts `content: str` as a positional parameter, but the `@given` decorator `'a valid YAML actor config file "test.yaml" with content:'` contains **no capture group** that would bind `content`. Behave cannot populate this extra argument and will fail at runtime when it tries to call this step.
In Behave, multi-line docstring text (the triple-quoted block in the scenario) is made available via `context.text`, **not** as a positional argument.
**Fix:**
```python
@given('a valid YAML actor config file "test.yaml" with content:')
def step_give_yaml_config_file(context: Any) -> None:
content = context.text # type: ignore[attr-defined]
tmp_dir = tempfile.mkdtemp()
config_path = os.path.join(tmp_dir, "test.yaml")
with open(config_path, "w", encoding="utf-8") as f:
f.write(content)
context.config_file = config_path # type: ignore[attr-defined]
```
|
||||
|
||||
|
||||
@when("I load the YAML config using PyYAML safe_load")
|
||||
def step_load_yaml_safe_load(context: Any) -> None: # noqa: A002 — intentionally shadows Behave context parameter
|
||||
"""Load the YAML config file using yaml.safe_load."""
|
||||
with open(context.config_file, "r", encoding="utf-8") as f: # type: ignore[attr-defined]
|
||||
context.loaded_config = yaml.safe_load(f) # type: ignore[attr-defined]
|
||||
|
||||
|
||||
@then("the loaded config should equal {expected}")
|
||||
def step_config_matches_expected(
|
||||
context: Any, expected: str # noqa: A002 — intentionally shadows Behave context parameter
|
||||
) -> None:
|
||||
"""Verify the loaded YAML config matches the expected dictionary."""
|
||||
expected_dict = json.loads(expected)
|
||||
assert (
|
||||
getattr(context, "loaded_config", {}) == expected_dict
|
||||
), f"Expected {expected_dict}, got {getattr(context, 'loaded_config', {})}"
|
||||
@@ -48,6 +48,7 @@ dependencies = [
|
||||
"tenacity>=8.2.0", # Retry framework for service layer resilience
|
||||
"aiohttp>=3.13.4", # CVE-2026-34515 mitigation: open redirect vulnerability
|
||||
"a2a-sdk>=0.3.0,<1.0.0", # A2A Python SDK — required transport for local (stdio) and server (HTTP) modes (ADR-047); pinned <1.0.0 (removed legacy A2AClient)
|
||||
"pyyaml>=6.0.2", # explicit runtime dep for YAML actor config loading; mitigates CVE-2025-8045 vulnerability in PyYAML <6.0.2
|
||||
]
|
||||
|
||||
[project.optional-dependencies]
|
||||
|
||||
@@ -446,6 +446,7 @@ dependencies = [
|
||||
{ name = "pydantic" },
|
||||
{ name = "pydantic-settings" },
|
||||
{ name = "python-ulid" },
|
||||
{ name = "pyyaml" },
|
||||
{ name = "restrictedpython" },
|
||||
{ name = "rx" },
|
||||
{ name = "structlog" },
|
||||
@@ -486,6 +487,7 @@ docs = [
|
||||
tests = [
|
||||
{ name = "asv" },
|
||||
{ name = "behave" },
|
||||
{ name = "faker" },
|
||||
{ name = "robotframework" },
|
||||
{ name = "robotframework-pabot" },
|
||||
{ name = "slipcover" },
|
||||
@@ -496,7 +498,7 @@ tui = [
|
||||
|
||||
[package.metadata]
|
||||
requires-dist = [
|
||||
{ name = "a2a-sdk", specifier = ">=0.3.0" },
|
||||
{ name = "a2a-sdk", specifier = ">=0.3.0,<1.0.0" },
|
||||
{ name = "aiohttp", specifier = ">=3.13.4" },
|
||||
{ name = "alembic", specifier = ">=1.13.1" },
|
||||
{ name = "asv", marker = "extra == 'tests'", specifier = ">=0.6.5" },
|
||||
@@ -505,6 +507,7 @@ requires-dist = [
|
||||
{ name = "behave", marker = "extra == 'tests'", specifier = "==1.3.3" },
|
||||
{ name = "dependency-injector", specifier = ">=4.41.0" },
|
||||
{ name = "faiss-cpu", specifier = ">=1.7.4" },
|
||||
{ name = "faker", marker = "extra == 'tests'", specifier = ">=20.0.0" },
|
||||
{ name = "griffe-pydantic", marker = "extra == 'docs'", specifier = ">=1.0.0" },
|
||||
{ name = "jinja2", specifier = ">=3.1.0" },
|
||||
{ name = "jsonschema", specifier = ">=4.20.0" },
|
||||
@@ -529,6 +532,7 @@ requires-dist = [
|
||||
{ name = "pytest-asyncio", marker = "extra == 'dev'", specifier = ">=0.23.0" },
|
||||
{ name = "pytest-cov", marker = "extra == 'dev'", specifier = ">=4.1.0" },
|
||||
{ name = "python-ulid", specifier = ">=2.7.0" },
|
||||
{ name = "pyyaml", specifier = ">=6.0.2" },
|
||||
{ name = "radon", marker = "extra == 'dev'", specifier = ">=6.0.1" },
|
||||
{ name = "restrictedpython", specifier = ">=7.0" },
|
||||
{ name = "robotframework", marker = "extra == 'tests'", specifier = ">=7.3.2" },
|
||||
@@ -830,6 +834,18 @@ wheels = [
|
||||
{ url = "https://files.pythonhosted.org/packages/06/6f/5eaf3e249c636e616ebb52e369a4a2f1d32b1caf9a611b4f917b3dd21423/faiss_cpu-1.13.2-cp314-cp314-win_arm64.whl", hash = "sha256:8113a2a80b59fe5653cf66f5c0f18be0a691825601a52a614c30beb1fca9bc7c", size = 8556374, upload-time = "2025-12-24T10:27:36.653Z" },
|
||||
]
|
||||
|
||||
[[package]]
|
||||
name = "faker"
|
||||
version = "40.15.0"
|
||||
source = { registry = "https://pypi.org/simple" }
|
||||
dependencies = [
|
||||
{ name = "tzdata", marker = "sys_platform == 'win32'" },
|
||||
]
|
||||
sdist = { url = "https://files.pythonhosted.org/packages/7f/13/6741787bd91c4109c7bed047d68273965cd52ce8a5f773c471b949334b6d/faker-40.15.0.tar.gz", hash = "sha256:20f3a6ec8c266b74d4c554e34118b21c3c2056c0b4a519d15c8decb3a4e6e795", size = 1967447, upload-time = "2026-04-17T20:05:27.555Z" }
|
||||
wheels = [
|
||||
{ url = "https://files.pythonhosted.org/packages/a7/a7/a600f8f30d4505e89166de51dd121bd540ab8e560e8cf0901de00a81de8c/faker-40.15.0-py3-none-any.whl", hash = "sha256:71ab3c3370da9d2205ab74ffb0fd51273063ad562b3a3bb69d0026a20923e318", size = 2004447, upload-time = "2026-04-17T20:05:25.437Z" },
|
||||
]
|
||||
|
||||
[[package]]
|
||||
name = "filelock"
|
||||
version = "3.25.2"
|
||||
@@ -3410,6 +3426,15 @@ wheels = [
|
||||
{ url = "https://files.pythonhosted.org/packages/dc/9b/47798a6c91d8bdb567fe2698fe81e0c6b7cb7ef4d13da4114b41d239f65d/typing_inspection-0.4.2-py3-none-any.whl", hash = "sha256:4ed1cacbdc298c220f1bd249ed5287caa16f34d44ef4e9c3d0cbad5b521545e7", size = 14611, upload-time = "2025-10-01T02:14:40.154Z" },
|
||||
]
|
||||
|
||||
[[package]]
|
||||
name = "tzdata"
|
||||
version = "2026.2"
|
||||
source = { registry = "https://pypi.org/simple" }
|
||||
sdist = { url = "https://files.pythonhosted.org/packages/ba/19/1b9b0e29f30c6d35cb345486df41110984ea67ae69dddbc0e8a100999493/tzdata-2026.2.tar.gz", hash = "sha256:9173fde7d80d9018e02a662e168e5a2d04f87c41ea174b139fbef642eda62d10", size = 198254, upload-time = "2026-04-24T15:22:08.651Z" }
|
||||
wheels = [
|
||||
{ url = "https://files.pythonhosted.org/packages/ce/e4/dccd7f47c4b64213ac01ef921a1337ee6e30e8c6466046018326977efd95/tzdata-2026.2-py2.py3-none-any.whl", hash = "sha256:bbe9af844f658da81a5f95019480da3a89415801f6cc966806612cc7169bffe7", size = 349321, upload-time = "2026-04-24T15:22:05.876Z" },
|
||||
]
|
||||
|
||||
[[package]]
|
||||
name = "uc-micro-py"
|
||||
version = "2.0.0"
|
||||
|
||||
Reference in New Issue
Block a user
BLOCKING - Lint failure (RUF100): unused noqa directive
The
# noqa: A002comment suppresses ruff rule A002 (flake8-builtins), but theAruleset is not in the project's ruffselectlist (which is["E", "F", "W", "B", "UP", "I", "SIM", "RUF"]). Suppressing a rule that is not active triggersRUF100("unused noqa directive"), which IS in the selected ruleset. This is causing the CI lint failure.Fix: Remove all
# noqa: A002comments from this file. The parameter namecontextis fine -- it is a Behave convention, andA002(which only flags names shadowing Python builtins) does not apply here sincecontextis not a Python builtin.