cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(a2a): validate session_id at entry of _handle_session_close before devcontainer cleanup #11057

Closed
HAL9000 wants to merge 2 commits from fix/9250-session-id-validation-handle-session-close into master
pull from: fix/9250-session-id-validation-handle-session-close
merge into: cleveragents:master
Conversation 3 Commits 2 Files Changed 6
+30 -8

2 Commits

Author SHA1 Message Date
CleverAgents Bot 6d541898e5 ci: stop master workflow on PR updates
CI / lint (pull_request) Has been cancelled
Details
CI / typecheck (pull_request) Has been cancelled
Details
CI / security (pull_request) Has been cancelled
Details
CI / quality (pull_request) Has been cancelled
Details
CI / unit_tests (pull_request) Has been cancelled
Details
CI / integration_tests (pull_request) Has been cancelled
Details
CI / e2e_tests (pull_request) Has been cancelled
Details
CI / coverage (pull_request) Has been cancelled
Details
CI / build (pull_request) Has been cancelled
Details
CI / docker (pull_request) Has been cancelled
Details
CI / helm (pull_request) Has been cancelled
Details
CI / push-validation (pull_request) Has been cancelled
Details
CI / status-check (pull_request) Has been cancelled
Details 
Remove the stale pull_request trigger from master.yml so PR branch commits do not launch the master workflow.

Maintenance patch for PR #11057.
 2026-06-10 20:19:32 -04:00
HAL9000 8a19a04b08 fix(a2a): validate session_id at entry of _handle_session_close before devcontainer cleanup
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / push-validation (pull_request) Successful in 38s
Details
CI / helm (pull_request) Successful in 47s
Details
CI / build (pull_request) Successful in 1m0s
Details
CI / lint (pull_request) Successful in 1m31s
Details
CI / typecheck (pull_request) Successful in 1m39s
Details
CI / security (pull_request) Successful in 1m36s
Details
CI / quality (pull_request) Successful in 1m34s
Details
CI / benchmark-regression (pull_request) Failing after 1m17s
Details
CI / e2e_tests (pull_request) Successful in 3m43s
Details
CI / integration_tests (pull_request) Failing after 4m53s
Details
CI / unit_tests (pull_request) Failing after 6m15s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 4s
Details 
R9-F1 — Move session_id validation to the entry of _handle_session_close()
so that a ValueError("session_id is required") is raised before any
devcontainer cleanup runs, even when session_service is None (local/test mode).

Previously the no-service fallback path bypassed this check entirely, allowing
cleanup with an empty session identifier. This fix ensures fail-fast semantics
for session_id validation across all code paths.

Changes:
- src/cleveragents/a2a/facade.py: validate session_id at entry of _handle_session_close
- features/a2a_facade_coverage.feature: update empty-sess-id-no-service test to expect error; add missing-session-id-no-service scenario
- features/steps/a2a_facade_coverage_steps.py: update line coverage docstring table
- CHANGELOG.md: document the fix under [Unreleased] > ### Fixed
- CONTRIBUTORS.md: add contribution entry for this fix

ISSUES CLOSED: #9250
 2026-05-08 20:30:51 +00:00