fix(a2a): validate session_id at entry of _handle_session_close before devcontainer cleanup #11053

Closed
HAL9000 wants to merge 2 commits from bugfix/9250-a2a-session-id-validation-before-cleanup into master

2 Commits

Author SHA1 Message Date
HAL9000 6453dfb626 fix(a2a): validate session_id at entry of _handle_session_close before devcontainer cleanup
CI / lint (pull_request) Failing after 1m21s
CI / quality (pull_request) Successful in 1m19s
CI / typecheck (pull_request) Successful in 1m33s
CI / unit_tests (pull_request) Failing after 2m5s
CI / push-validation (pull_request) Successful in 37s
CI / helm (pull_request) Successful in 38s
CI / build (pull_request) Successful in 46s
CI / security (pull_request) Successful in 2m56s
CI / coverage (pull_request) Has been skipped
CI / docker (pull_request) Has been skipped
CI / integration_tests (pull_request) Failing after 7m7s
CI / status-check (pull_request) Failing after 5s
2026-05-16 18:04:51 +00:00
HAL9000 b99d1bc7e9 fix(a2a): validate session_id at entry of _handle_session_close before devcontainer cleanup
CI / build (pull_request) Successful in 1m14s
CI / lint (pull_request) Failing after 1m35s
CI / quality (pull_request) Successful in 1m38s
CI / helm (pull_request) Successful in 29s
CI / typecheck (pull_request) Successful in 2m16s
CI / security (pull_request) Successful in 2m21s
CI / unit_tests (pull_request) Failing after 2m23s
CI / coverage (pull_request) Has been skipped
CI / docker (pull_request) Has been skipped
CI / push-validation (pull_request) Successful in 21s
CI / integration_tests (pull_request) Failing after 4m35s
CI / status-check (pull_request) Failing after 6s
Move the session_id validation check to the very top of _handle_session_close in A2aLocalFacade so that callers cannot bypass input validation by omitting the session_service dependency.

Key changes:
- Core fix: Moved if not session_id check above service null check in facade.py
- BDD tests: Added error response scenarios for empty and missing session_id
- Step definitions: Rewrote dispatch step to properly handle error responses
- Robot Framework: Added integration test for session_id validation
- Metadata: Updated CHANGELOG.md issue ref from #9250 to #9094, updated CONTRIBUTORS.md

ISSUES CLOSED: #9094
2026-05-16 04:44:04 +00:00