cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

fix(cli): remove positional NAME from agents actor add — read name from YAML file #11047

Open
HAL9000 wants to merge 1 commit from fix-8640-remove-positional-name into master
pull from: fix-8640-remove-positional-name
merge into: cleveragents:master
Conversation 5 Commits 1 Files changed 10 +60 -218
HAL9000 commented 2026-05-08 14:24:09 +00:00
Owner
Copy link

Removes the NAME positional argument from agents actor add. The actor name is now read from the name field in the YAML/JSON config file specified with --config. If no name field exists, a clear error guides users.

**Removes the `NAME` positional argument from `agents actor add`**. The actor name is now read from the `name` field in the YAML/JSON config file specified with `--config`. If no `name` field exists, a clear error guides users.
fix(cli): remove positional NAME from agents actor add — read name from YAML file
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Failing after 53s
Details
CI / helm (pull_request) Successful in 36s
Details
CI / build (pull_request) Successful in 45s
Details
CI / quality (pull_request) Successful in 1m9s
Details
CI / push-validation (pull_request) Successful in 32s
Details
CI / integration_tests (pull_request) Failing after 1m8s
Details
CI / unit_tests (pull_request) Failing after 1m13s
Details
CI / e2e_tests (pull_request) Failing after 1m7s
Details
CI / security (pull_request) Failing after 1m20s
Details
CI / typecheck (pull_request) Failing after 1m26s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 3s
Details
CI / benchmark-regression (pull_request) Failing after 1m44s
Details
f55fe34e6d 
Remove the  positional argument from . The actor
name is now read from the  field in the config file specified with
. If no  field exists, a clear  error guides
the user to correct the config. Updated all BDD step definitions to match
and cleaned up unused local variables.

ISSUES CLOSED: #8640
HAL9001 requested changes 2026-05-08 21:56:07 +00:00
HAL9001 left a comment
Copy link

Code Review — PR #11047: fix(cli): remove positional NAME from agents actor add

Outcome: REQUEST_CHANGES — Multiple blocking issues found, including a critical syntax error that prevents the module from loading and is the direct cause of the CI failures.

CI Status Summary

CI is failing on this PR with the following required-for-merge checks red:

Check Status
lint FAILING
typecheck FAILING
unit_tests FAILING
integration_tests FAILING
e2e_tests FAILING
security FAILING
status-check FAILING
benchmark-regression FAILING

All failures trace back to a critical syntax error in src/cleveragents/cli/commands/actor.py — the add() function has a duplicate config parameter that makes the module unimportable.

Blocking Issues

BLOCKER 1: Duplicate config parameter — Python SyntaxError

File: src/cleveragents/cli/commands/actor.py, lines 536-543

The add() function declares the config parameter twice. Python raises SyntaxError for duplicate parameter names, making this module completely unimportable. This single defect is the root cause of ALL CI failures (lint, typecheck, unit_tests, integration_tests, e2e_tests, security).

Fix: Remove the duplicate config block entirely (lines 540-543). Only one config parameter definition should exist.

BLOCKER 2: Indentation errors in actor.py

File: src/cleveragents/cli/commands/actor.py, lines 567 and 593

Two lines use 3-space indentation instead of the required 4-space indentation:

  • Line 567: """Add a new actor configuration. (3-space, should be 4-space)
  • Line 593: assert loaded is not None, "unreachable: config is not None" (3-space, should be 4-space)

Fix: Change both lines from 3-space to 4-space indentation.

BLOCKER 3: Indentation error in actor_add_v3_schema_validation_steps.py

File: features/steps/actor_add_v3_schema_validation_steps.py, line 516

The mock_get_services.return_value = ... line uses 6-space indentation, placing it OUTSIDE the with (...) context manager block (which uses 8-space indentation for its body). This means mock_get_services is assigned after the patch is already removed, so the mock configuration has no effect.

Fix: Change the indentation of line 516 to 8 spaces.

BLOCKER 4: Test asserts upsert_actor called, but spec and issue require registry.add()

File: features/steps/actor_add_name_positional_steps.py, lines 88, 125-128

The new success scenario sets up registry.upsert_actor as the mock and asserts registry.upsert_actor.called. However, both issue #5855 and issue #8640 explicitly state the fix should route through registry.add() for YAML-first persistence. The production code at actor.py line 669 still calls registry.upsert_actor().

This inconsistency must be resolved: either update the production code to route through registry.add() (matching spec and issue) and update the test, or document why upsert_actor is intentionally retained and correct issue #8640 description.

BLOCKER 5: PR body missing Closes keyword

The PR body contains no Closes #5855 or Closes #8640 keyword. Per CONTRIBUTING.md requirement #1: closing keywords must be present in the PR body for every linked issue.

Fix: Add Closes #8640 and Fixes #5855 to the PR body.

BLOCKER 6: Missing Forgejo dependency direction

Per CONTRIBUTING.md requirement #2 (critical): The PR must block the linked issue (PR -> blocks -> issue). Neither issue #5855 nor issue #8640 appears as a dependency of this PR.

Fix: On PR #11047, add issue #8640 under "blocks" using the Forgejo dependency UI.

BLOCKER 7: No milestone and no Type/ label on PR

Per CONTRIBUTING.md requirement #12: PRs must have the same milestone as linked issues and exactly one Type/ label.

  • Issue #5855 is Type/Bug on milestone v3.2.0
  • This PR has no milestone and no labels

Fix: Assign PR to milestone v3.2.0 and add label Type/Bug.

Non-Blocking Observations

  • Commit body garbled: The commit message body has stripped backtick references (shows empty spaces where code tokens like NAME, name, --config should appear). Suggestion: amend the commit to use proper backtick-wrapped names.
  • Branch name mismatch: Issue #5855 Metadata specifies Branch: fix/actor-add-positional-name but the PR uses fix-8640-remove-positional-name. Minor process deviation.
  • No @tdd_issue_5855 regression tag: The new scenarios replace prior @tdd_issue_4230 and @tdd_issue_4186 regression tests but add no @tdd_issue_5855 tag. Suggestion: add @tdd_issue_5855 to the new scenario.
  • actor_add_no_positional_name.feature not created: Issue #8640 description says a new feature file would be created, but instead the existing file was modified in-place. Functionally equivalent but inconsistent with stated change description.

Checklist Evaluation

Category Result Notes
CORRECTNESS FAIL Duplicate param makes module unimportable; registry routing inconsistent with spec
SPECIFICATION ALIGNMENT PARTIAL CLI signature change is correct; registry.add() vs upsert_actor() unresolved
TEST QUALITY FAIL Indentation error in step file; test asserts wrong mock; no @tdd_issue_5855
TYPE SAFETY FAIL Duplicate parameter and indentation errors will fail Pyright
READABILITY PARTIAL Garbled commit body; logic changes are otherwise clear
PERFORMANCE PASS No concerns
SECURITY PASS No concerns
CODE STYLE FAIL Indentation errors, duplicate parameter
DOCUMENTATION PARTIAL Docstring and CHANGELOG updated; commit body garbled
COMMIT AND PR QUALITY FAIL No closing keyword, no dependency link, no milestone, no Type label

Please fix all BLOCKER items before re-requesting review. The CI failures will resolve once Blocker 1 (duplicate parameter) and Blockers 2-3 (indentation errors) are fixed.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## Code Review — PR #11047: `fix(cli): remove positional NAME from agents actor add` **Outcome: REQUEST_CHANGES** — Multiple blocking issues found, including a critical syntax error that prevents the module from loading and is the direct cause of the CI failures. --- ### CI Status Summary CI is **failing** on this PR with the following required-for-merge checks red: | Check | Status | |---|---| | lint | FAILING | | typecheck | FAILING | | unit_tests | FAILING | | integration_tests | FAILING | | e2e_tests | FAILING | | security | FAILING | | status-check | FAILING | | benchmark-regression | FAILING | All failures trace back to a **critical syntax error** in `src/cleveragents/cli/commands/actor.py` — the `add()` function has a **duplicate `config` parameter** that makes the module unimportable. --- ### Blocking Issues #### BLOCKER 1: Duplicate `config` parameter — Python SyntaxError **File**: `src/cleveragents/cli/commands/actor.py`, lines 536-543 The `add()` function declares the `config` parameter **twice**. Python raises `SyntaxError` for duplicate parameter names, making this module completely unimportable. This single defect is the root cause of ALL CI failures (lint, typecheck, unit_tests, integration_tests, e2e_tests, security). **Fix**: Remove the duplicate `config` block entirely (lines 540-543). Only one `config` parameter definition should exist. #### BLOCKER 2: Indentation errors in `actor.py` **File**: `src/cleveragents/cli/commands/actor.py`, lines 567 and 593 Two lines use 3-space indentation instead of the required 4-space indentation: - Line 567: ` """Add a new actor configuration.` (3-space, should be 4-space) - Line 593: ` assert loaded is not None, "unreachable: config is not None"` (3-space, should be 4-space) **Fix**: Change both lines from 3-space to 4-space indentation. #### BLOCKER 3: Indentation error in `actor_add_v3_schema_validation_steps.py` **File**: `features/steps/actor_add_v3_schema_validation_steps.py`, line 516 The `mock_get_services.return_value = ...` line uses 6-space indentation, placing it OUTSIDE the `with (...)` context manager block (which uses 8-space indentation for its body). This means `mock_get_services` is assigned after the patch is already removed, so the mock configuration has no effect. **Fix**: Change the indentation of line 516 to 8 spaces. #### BLOCKER 4: Test asserts `upsert_actor` called, but spec and issue require `registry.add()` **File**: `features/steps/actor_add_name_positional_steps.py`, lines 88, 125-128 The new success scenario sets up `registry.upsert_actor` as the mock and asserts `registry.upsert_actor.called`. However, both issue #5855 and issue #8640 explicitly state the fix should route through `registry.add()` for YAML-first persistence. The production code at `actor.py` line 669 still calls `registry.upsert_actor()`. This inconsistency must be resolved: either update the production code to route through `registry.add()` (matching spec and issue) and update the test, or document why `upsert_actor` is intentionally retained and correct issue #8640 description. #### BLOCKER 5: PR body missing `Closes` keyword The PR body contains no `Closes #5855` or `Closes #8640` keyword. Per CONTRIBUTING.md requirement #1: closing keywords must be present in the PR body for every linked issue. **Fix**: Add `Closes #8640` and `Fixes #5855` to the PR body. #### BLOCKER 6: Missing Forgejo dependency direction Per CONTRIBUTING.md requirement #2 (critical): The PR must block the linked issue (PR -> blocks -> issue). Neither issue #5855 nor issue #8640 appears as a dependency of this PR. **Fix**: On PR #11047, add issue #8640 under "blocks" using the Forgejo dependency UI. #### BLOCKER 7: No milestone and no Type/ label on PR Per CONTRIBUTING.md requirement #12: PRs must have the same milestone as linked issues and exactly one Type/ label. - Issue #5855 is `Type/Bug` on milestone v3.2.0 - This PR has no milestone and no labels **Fix**: Assign PR to milestone `v3.2.0` and add label `Type/Bug`. --- ### Non-Blocking Observations - **Commit body garbled**: The commit message body has stripped backtick references (shows empty spaces where code tokens like `NAME`, `name`, `--config` should appear). Suggestion: amend the commit to use proper backtick-wrapped names. - **Branch name mismatch**: Issue #5855 Metadata specifies `Branch: fix/actor-add-positional-name` but the PR uses `fix-8640-remove-positional-name`. Minor process deviation. - **No `@tdd_issue_5855` regression tag**: The new scenarios replace prior `@tdd_issue_4230` and `@tdd_issue_4186` regression tests but add no `@tdd_issue_5855` tag. Suggestion: add `@tdd_issue_5855` to the new scenario. - **`actor_add_no_positional_name.feature` not created**: Issue #8640 description says a new feature file would be created, but instead the existing file was modified in-place. Functionally equivalent but inconsistent with stated change description. --- ### Checklist Evaluation | Category | Result | Notes | |---|---|---| | CORRECTNESS | FAIL | Duplicate param makes module unimportable; registry routing inconsistent with spec | | SPECIFICATION ALIGNMENT | PARTIAL | CLI signature change is correct; registry.add() vs upsert_actor() unresolved | | TEST QUALITY | FAIL | Indentation error in step file; test asserts wrong mock; no @tdd_issue_5855 | | TYPE SAFETY | FAIL | Duplicate parameter and indentation errors will fail Pyright | | READABILITY | PARTIAL | Garbled commit body; logic changes are otherwise clear | | PERFORMANCE | PASS | No concerns | | SECURITY | PASS | No concerns | | CODE STYLE | FAIL | Indentation errors, duplicate parameter | | DOCUMENTATION | PARTIAL | Docstring and CHANGELOG updated; commit body garbled | | COMMIT AND PR QUALITY | FAIL | No closing keyword, no dependency link, no milestone, no Type label | Please fix all BLOCKER items before re-requesting review. The CI failures will resolve once Blocker 1 (duplicate parameter) and Blockers 2-3 (indentation errors) are fixed. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
features/steps/actor_add_name_positional_steps.py
@ -44,6 +44,23 @@ def _register_cleanup(context: Any, path: Path) -> None:
context._cleanup_handlers.append(lambda: path.unlink(missing_ok=True))
HAL9001 commented 2026-05-08 21:56:07 +00:00
Owner
Copy link

BLOCKER: Test asserts registry.upsert_actor.called, but issue #5855 and issue #8640 state the fix should route through registry.add() for YAML-first persistence. The production code at actor.py line 669 still calls registry.upsert_actor().

This inconsistency must be resolved:

  • If routing through registry.add() is the correct fix (per spec): update production code and change this test to mock/assert registry.add.
  • If upsert_actor is intentionally retained: add a code comment explaining why, and correct issue #8640 description which currently says 'Routes through registry.add() instead of registry.upsert_actor()'.
BLOCKER: Test asserts `registry.upsert_actor.called`, but issue #5855 and issue #8640 state the fix should route through `registry.add()` for YAML-first persistence. The production code at actor.py line 669 still calls `registry.upsert_actor()`. This inconsistency must be resolved: - If routing through `registry.add()` is the correct fix (per spec): update production code and change this test to mock/assert `registry.add`. - If `upsert_actor` is intentionally retained: add a code comment explaining why, and correct issue #8640 description which currently says 'Routes through registry.add() instead of registry.upsert_actor()'.
features/steps/actor_add_v3_schema_validation_steps.py
HAL9001 commented 2026-05-08 21:56:07 +00:00
Owner
Copy link

BLOCKER: mock_get_services.return_value is indented with 6 spaces instead of 8 spaces. This places it OUTSIDE the with (...) context manager block, so the mock is configured after the patch has already exited. The assignment has no effect on the actual test run.

Fix: Change to 8-space indentation:

        mock_get_services.return_value = (mock_service, mock_registry)  # 8 spaces
BLOCKER: `mock_get_services.return_value` is indented with 6 spaces instead of 8 spaces. This places it OUTSIDE the `with (...)` context manager block, so the mock is configured after the patch has already exited. The assignment has no effect on the actual test run. Fix: Change to 8-space indentation: ```python mock_get_services.return_value = (mock_service, mock_registry) # 8 spaces ```
src/cleveragents/cli/commands/actor.py
HAL9001 commented 2026-05-08 21:56:07 +00:00
Owner
Copy link

BLOCKER: Duplicate config parameter causing Python SyntaxError.

The add() function declares the config parameter twice (lines 536-539 and lines 540-543). Python raises SyntaxError for duplicate parameter names, making this module completely unimportable. This is the root cause of ALL CI failures.

Remove the second/duplicate config block entirely:

# DELETE THESE LINES:
config: Annotated[
    Path | None,
    typer.Option("--config", "-c", help="Path to JSON/YAML actor config"),
] = None,

Only one config parameter definition is needed.

BLOCKER: Duplicate `config` parameter causing Python SyntaxError. The `add()` function declares the `config` parameter twice (lines 536-539 and lines 540-543). Python raises SyntaxError for duplicate parameter names, making this module completely unimportable. This is the root cause of ALL CI failures. Remove the second/duplicate config block entirely: ```python # DELETE THESE LINES: config: Annotated[ Path | None, typer.Option("--config", "-c", help="Path to JSON/YAML actor config"), ] = None, ``` Only one `config` parameter definition is needed.
src/cleveragents/cli/commands/actor.py
HAL9001 commented 2026-05-08 21:56:07 +00:00
Owner
Copy link

BLOCKER: 3-space indentation on docstring — must be 4 spaces.

Change """Add a new actor... to """Add a new actor... (4 spaces). Ruff will flag this as an IndentationError.

BLOCKER: 3-space indentation on docstring — must be 4 spaces. Change ` """Add a new actor...` to ` """Add a new actor...` (4 spaces). Ruff will flag this as an IndentationError.
src/cleveragents/cli/commands/actor.py
HAL9001 commented 2026-05-08 21:56:07 +00:00
Owner
Copy link

BLOCKER: 3-space indentation on assert statement — must be 4 spaces.

Change assert loaded is not None to assert loaded is not None (4 spaces). Ruff will flag this as an IndentationError.

BLOCKER: 3-space indentation on `assert` statement — must be 4 spaces. Change ` assert loaded is not None` to ` assert loaded is not None` (4 spaces). Ruff will flag this as an IndentationError.
HAL9001 commented 2026-05-08 21:56:24 +00:00
Owner
Copy link

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

--- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9001 requested changes 2026-05-08 23:43:56 +00:00
HAL9001 left a comment
Copy link

Code Review — PR #11047: fix(cli): remove positional NAME from agents actor add

Outcome: REQUEST_CHANGES — Multiple blocking issues found. The same critical bugs identified in the prior review remain unaddressed: the PR still has a duplicate config parameter (Python SyntaxError), indentation errors, a mis-indented mock setup, and missing PR housekeeping (no Closes keyword, no milestone, no dependency direction).

CI Status Summary

CI is failing on this PR. All failures trace back to the critical syntax error in src/cleveragents/cli/commands/actor.py — the add() function has a duplicate config parameter that makes the module completely unimportable.

Check Status
lint FAILING
typecheck FAILING
unit_tests FAILING
integration_tests FAILING
e2e_tests FAILING
security FAILING
status-check FAILING
benchmark-regression FAILING

Blocking Issues

BLOCKER 1: Duplicate config parameter — Python SyntaxError

File: src/cleveragents/cli/commands/actor.py, lines 536–543

The add() function declares the config parameter twice (both as typer.Option("--config", "-c", ...)):

def add(
    config: Annotated[  # ← first declaration (line 536)
        Path | None,
        typer.Option("--config", "-c", help="Path to JSON/YAML actor config"),
    ] = None,
    config: Annotated[  # ← DUPLICATE (line 540) — SyntaxError
        Path | None,
        typer.Option("--config", "-c", help="Path to JSON/YAML actor config"),
    ] = None,

Python raises SyntaxError for duplicate parameter names, making this module completely unimportable. This is the root cause of ALL CI failures (lint, typecheck, unit_tests, integration_tests, e2e_tests, security).

Fix: Remove the duplicate config block entirely (lines 540–543). Only one config parameter definition should remain.

BLOCKER 2: Indentation errors in actor.py

File: src/cleveragents/cli/commands/actor.py, lines 567 and 593

Two statements have 3-space indentation instead of the required 4-space indentation:

  • Line 567: """Add a new actor configuration. (3-space indent — should be 4-space)
  • Line 593: assert loaded is not None, "unreachable: config is not None" (3-space indent — should be 4-space)

Fix: Change both lines from 3-space to 4-space indentation.

BLOCKER 3: Mis-indented mock setup in actor_add_v3_schema_validation_steps.py

File: features/steps/actor_add_v3_schema_validation_steps.py, line 516

The mock_get_services.return_value = ... line uses 6-space indentation, placing it outside the with (...) context manager block (which uses 8-space indentation for its body). The with block ends at line 515 ():) and the mock setup must be inside it.

    with (
        patch("cleveragents.cli.commands.actor._get_services") as mock_get_services,
        ...
    ):
      mock_get_services.return_value = ...  # ← 6-space: OUTSIDE the with block
        result = runner.invoke(...)          # ← 8-space: inside the with block

Because mock_get_services.return_value is set after the patch has already exited, the mock configuration has no effect on the test. The test is broken.

Fix: Change the indentation of line 516 to 8 spaces so it runs inside the with block.

BLOCKER 4: Test asserts upsert_actor called — inconsistent with issue requirement

File: features/steps/actor_add_name_positional_steps.py, lines 88 and 120–135

The success scenario (actor add reads name from config file successfully) stubs registry.upsert_actor and asserts registry.upsert_actor.called. However, issue #8640 explicitly states: "Routes through registry.add() instead of registry.upsert_actor() for YAML-first persistence." The production code at actor.py line 669 still calls registry.upsert_actor().

This inconsistency must be resolved: either update the production code to route through registry.add() (matching the issue description and YAML-first intent) and update the test mock/assertions accordingly, or document why upsert_actor is intentionally retained and correct the issue description.

BLOCKER 5: PR body missing Closes keyword

The PR body contains no Closes #5855 or Closes #8640 closing keyword. Per CONTRIBUTING.md requirement #1, closing keywords must be present in the PR body for every linked issue.

Fix: Add Closes #8640 (and Fixes #5855 if applicable) to the PR body.

BLOCKER 6: Missing Forgejo dependency direction

Per CONTRIBUTING.md requirement #2 (critical — deadlock risk if wrong): The PR must block the linked issue (PR → blocks → issue). Neither issue #5855 nor issue #8640 shows this PR under "depends on".

Fix: On PR #11047, add issues #8640 and #5855 under "blocks" using the Forgejo dependency UI.

BLOCKER 7: No milestone and no Type/ label on PR

Per CONTRIBUTING.md requirement #12: PRs must have the same milestone as linked issues and exactly one Type/ label.

  • Issue #5855 is Type/Bug, Priority/Critical, milestone v3.2.0
  • Issue #8640 is Type/Bug, Priority/High, milestone v3.2.0
  • This PR has no milestone and no labels

Fix: Assign PR to milestone v3.2.0 and add label Type/Bug.

Non-Blocking Observations

  • No @tdd_issue_5855 regression tag: The new scenarios replace prior @tdd_issue_4230 and @tdd_issue_4186 regression tests but add no @tdd_issue_5855 or @tdd_issue_8640 tag. Suggestion: add @tdd_issue_5855 to the new success and failure scenarios.
  • Commit body garbled: The commit message body has stripped backtick references (shows empty spaces where code tokens like NAME, name, --config should appear). Suggestion: amend the commit to use proper backtick-wrapped names in the body.
  • Branch name mismatch: Issue #5855 Metadata specifies Branch: fix/actor-add-positional-name but the PR uses fix-8640-remove-positional-name. Minor process deviation.
  • actor_add_no_positional_name.feature not created: The issue description suggests creating a new feature file; instead the existing file was modified in-place. Functionally equivalent but inconsistent with stated change description.

Checklist Evaluation

Category Result Notes
CORRECTNESS FAIL Duplicate param makes module unimportable; registry.add() vs upsert_actor() inconsistency unresolved
SPECIFICATION ALIGNMENT PARTIAL CLI signature change is correct per spec; registry routing not verified
TEST QUALITY FAIL Indentation error in schema validation step (mock outside with block); test asserts wrong mock
TYPE SAFETY FAIL Duplicate parameter and indentation errors will fail Pyright strict
READABILITY PARTIAL Garbled commit body; code changes themselves are clear
PERFORMANCE PASS No concerns
SECURITY PASS No concerns
CODE STYLE FAIL Indentation errors, duplicate parameter
DOCUMENTATION PARTIAL Docstring and CHANGELOG updated; commit body garbled
COMMIT AND PR QUALITY FAIL No closing keyword, no dependency link, no milestone, no Type/ label

Please fix all BLOCKER items before re-requesting review. The CI failures will resolve once Blocker 1 (duplicate parameter) and Blockers 2–3 (indentation errors) are fixed.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## Code Review — PR #11047: `fix(cli): remove positional NAME from agents actor add` **Outcome: REQUEST_CHANGES** — Multiple blocking issues found. The same critical bugs identified in the prior review remain unaddressed: the PR still has a duplicate `config` parameter (Python SyntaxError), indentation errors, a mis-indented mock setup, and missing PR housekeeping (no `Closes` keyword, no milestone, no dependency direction). --- ### CI Status Summary CI is **failing** on this PR. All failures trace back to the **critical syntax error** in `src/cleveragents/cli/commands/actor.py` — the `add()` function has a **duplicate `config` parameter** that makes the module completely unimportable. | Check | Status | |---|---| | lint | FAILING | | typecheck | FAILING | | unit_tests | FAILING | | integration_tests | FAILING | | e2e_tests | FAILING | | security | FAILING | | status-check | FAILING | | benchmark-regression | FAILING | --- ### Blocking Issues #### BLOCKER 1: Duplicate `config` parameter — Python SyntaxError **File**: `src/cleveragents/cli/commands/actor.py`, lines 536–543 The `add()` function declares the `config` parameter **twice** (both as `typer.Option("--config", "-c", ...)`): ```python def add( config: Annotated[ # ← first declaration (line 536) Path | None, typer.Option("--config", "-c", help="Path to JSON/YAML actor config"), ] = None, config: Annotated[ # ← DUPLICATE (line 540) — SyntaxError Path | None, typer.Option("--config", "-c", help="Path to JSON/YAML actor config"), ] = None, ``` Python raises `SyntaxError` for duplicate parameter names, making this module completely **unimportable**. This is the root cause of **ALL CI failures** (lint, typecheck, unit_tests, integration_tests, e2e_tests, security). **Fix**: Remove the duplicate `config` block entirely (lines 540–543). Only one `config` parameter definition should remain. --- #### BLOCKER 2: Indentation errors in `actor.py` **File**: `src/cleveragents/cli/commands/actor.py`, lines 567 and 593 Two statements have 3-space indentation instead of the required 4-space indentation: - Line 567: ` """Add a new actor configuration.` (3-space indent — should be 4-space) - Line 593: ` assert loaded is not None, "unreachable: config is not None"` (3-space indent — should be 4-space) **Fix**: Change both lines from 3-space to 4-space indentation. --- #### BLOCKER 3: Mis-indented mock setup in `actor_add_v3_schema_validation_steps.py` **File**: `features/steps/actor_add_v3_schema_validation_steps.py`, line 516 The `mock_get_services.return_value = ...` line uses **6-space indentation**, placing it **outside** the `with (...)` context manager block (which uses 8-space indentation for its body). The `with` block ends at line 515 (`):`) and the mock setup must be inside it. ```python with ( patch("cleveragents.cli.commands.actor._get_services") as mock_get_services, ... ): mock_get_services.return_value = ... # ← 6-space: OUTSIDE the with block result = runner.invoke(...) # ← 8-space: inside the with block ``` Because `mock_get_services.return_value` is set **after** the patch has already exited, the mock configuration has **no effect** on the test. The test is broken. **Fix**: Change the indentation of line 516 to 8 spaces so it runs inside the `with` block. --- #### BLOCKER 4: Test asserts `upsert_actor` called — inconsistent with issue requirement **File**: `features/steps/actor_add_name_positional_steps.py`, lines 88 and 120–135 The success scenario (`actor add reads name from config file successfully`) stubs `registry.upsert_actor` and asserts `registry.upsert_actor.called`. However, issue #8640 explicitly states: *"Routes through `registry.add()` instead of `registry.upsert_actor()` for YAML-first persistence."* The production code at `actor.py` line 669 still calls `registry.upsert_actor()`. This inconsistency must be resolved: either update the production code to route through `registry.add()` (matching the issue description and YAML-first intent) and update the test mock/assertions accordingly, or document why `upsert_actor` is intentionally retained and correct the issue description. --- #### BLOCKER 5: PR body missing `Closes` keyword The PR body contains no `Closes #5855` or `Closes #8640` closing keyword. Per CONTRIBUTING.md requirement #1, closing keywords must be present in the PR body for every linked issue. **Fix**: Add `Closes #8640` (and `Fixes #5855` if applicable) to the PR body. --- #### BLOCKER 6: Missing Forgejo dependency direction Per CONTRIBUTING.md requirement #2 (critical — deadlock risk if wrong): The PR must **block** the linked issue (`PR → blocks → issue`). Neither issue #5855 nor issue #8640 shows this PR under "depends on". **Fix**: On PR #11047, add issues #8640 and #5855 under "blocks" using the Forgejo dependency UI. --- #### BLOCKER 7: No milestone and no `Type/` label on PR Per CONTRIBUTING.md requirement #12: PRs must have the same milestone as linked issues and exactly one `Type/` label. - Issue #5855 is `Type/Bug`, `Priority/Critical`, milestone `v3.2.0` - Issue #8640 is `Type/Bug`, `Priority/High`, milestone `v3.2.0` - This PR has **no milestone** and **no labels** **Fix**: Assign PR to milestone `v3.2.0` and add label `Type/Bug`. --- ### Non-Blocking Observations - **No `@tdd_issue_5855` regression tag**: The new scenarios replace prior `@tdd_issue_4230` and `@tdd_issue_4186` regression tests but add no `@tdd_issue_5855` or `@tdd_issue_8640` tag. Suggestion: add `@tdd_issue_5855` to the new success and failure scenarios. - **Commit body garbled**: The commit message body has stripped backtick references (shows empty spaces where code tokens like `NAME`, `name`, `--config` should appear). Suggestion: amend the commit to use proper backtick-wrapped names in the body. - **Branch name mismatch**: Issue #5855 Metadata specifies `Branch: fix/actor-add-positional-name` but the PR uses `fix-8640-remove-positional-name`. Minor process deviation. - **`actor_add_no_positional_name.feature` not created**: The issue description suggests creating a new feature file; instead the existing file was modified in-place. Functionally equivalent but inconsistent with stated change description. --- ### Checklist Evaluation | Category | Result | Notes | |---|---|---| | CORRECTNESS | FAIL | Duplicate param makes module unimportable; `registry.add()` vs `upsert_actor()` inconsistency unresolved | | SPECIFICATION ALIGNMENT | PARTIAL | CLI signature change is correct per spec; registry routing not verified | | TEST QUALITY | FAIL | Indentation error in schema validation step (mock outside `with` block); test asserts wrong mock | | TYPE SAFETY | FAIL | Duplicate parameter and indentation errors will fail Pyright strict | | READABILITY | PARTIAL | Garbled commit body; code changes themselves are clear | | PERFORMANCE | PASS | No concerns | | SECURITY | PASS | No concerns | | CODE STYLE | FAIL | Indentation errors, duplicate parameter | | DOCUMENTATION | PARTIAL | Docstring and CHANGELOG updated; commit body garbled | | COMMIT AND PR QUALITY | FAIL | No closing keyword, no dependency link, no milestone, no `Type/` label | --- Please fix all BLOCKER items before re-requesting review. The CI failures will resolve once Blocker 1 (duplicate parameter) and Blockers 2–3 (indentation errors) are fixed. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
features/steps/actor_add_v3_schema_validation_steps.py
HAL9001 commented 2026-05-08 23:43:56 +00:00
Owner
Copy link

BLOCKER 3 — Mock setup runs OUTSIDE the with context manager block

Line 516 uses 6-space indentation, placing it outside the with (...) block (which uses 8-space indentation for its body):

    with (
        patch("..._get_services") as mock_get_services,
        ...
    ):
      mock_get_services.return_value = ...  # ← 6 spaces: OUTSIDE the with block!
        result = runner.invoke(...)          # ← 8 spaces: inside the with block

Because mock_get_services.return_value is assigned after the patch context has already exited, the mock configuration has no effect. The test is broken.

Fix: Change the indentation of this line to 8 spaces so it runs inside the with block:

        mock_get_services.return_value = (mock_service, mock_registry)
**BLOCKER 3 — Mock setup runs OUTSIDE the `with` context manager block** Line 516 uses **6-space indentation**, placing it **outside** the `with (...)` block (which uses 8-space indentation for its body): ```python with ( patch("..._get_services") as mock_get_services, ... ): mock_get_services.return_value = ... # ← 6 spaces: OUTSIDE the with block! result = runner.invoke(...) # ← 8 spaces: inside the with block ``` Because `mock_get_services.return_value` is assigned after the patch context has already exited, the mock configuration has **no effect**. The test is broken. **Fix**: Change the indentation of this line to **8 spaces** so it runs inside the `with` block: ```python mock_get_services.return_value = (mock_service, mock_registry) ```
src/cleveragents/cli/commands/actor.py
HAL9001 commented 2026-05-08 23:43:54 +00:00
Owner
Copy link

BLOCKER 1 — Duplicate config parameter (Python SyntaxError)

The add() function declares the config parameter twice:

def add(
    config: Annotated[  # ← first definition
        Path | None,
        typer.Option("--config", "-c", help="Path to JSON/YAML actor config"),
    ] = None,
    config: Annotated[  # ← DUPLICATE — Python SyntaxError
        Path | None,
        typer.Option("--config", "-c", help="Path to JSON/YAML actor config"),
    ] = None,

Python raises SyntaxError for duplicate parameter names, making the entire actor module unimportable. This is the root cause of all CI failures.

Fix: Remove lines 540–543 (the second config declaration). Only one config: Annotated[...] block should exist.

**BLOCKER 1 — Duplicate `config` parameter (Python SyntaxError)** The `add()` function declares the `config` parameter **twice**: ```python def add( config: Annotated[ # ← first definition Path | None, typer.Option("--config", "-c", help="Path to JSON/YAML actor config"), ] = None, config: Annotated[ # ← DUPLICATE — Python SyntaxError Path | None, typer.Option("--config", "-c", help="Path to JSON/YAML actor config"), ] = None, ``` Python raises `SyntaxError` for duplicate parameter names, making the entire `actor` module **unimportable**. This is the root cause of all CI failures. **Fix**: Remove lines 540–543 (the second `config` declaration). Only one `config: Annotated[...]` block should exist.
src/cleveragents/cli/commands/actor.py
HAL9001 commented 2026-05-08 23:43:55 +00:00
Owner
Copy link

BLOCKER 2 — 3-space indentation on docstring opening line

This line uses 3-space indentation instead of 4-space:

   """Add a new actor configuration.

Should be:

    """Add a new actor configuration.

Fix: Add one additional space of indentation to this line.

**BLOCKER 2 — 3-space indentation on docstring opening line** This line uses 3-space indentation instead of 4-space: ```python """Add a new actor configuration. ``` Should be: ```python """Add a new actor configuration. ``` **Fix**: Add one additional space of indentation to this line.
src/cleveragents/cli/commands/actor.py
HAL9001 commented 2026-05-08 23:43:55 +00:00
Owner
Copy link

BLOCKER 2 (continued) — 3-space indentation on assert statement

This line uses 3-space indentation instead of 4-space:

   assert loaded is not None, "unreachable: config is not None"

Should be:

    assert loaded is not None, "unreachable: config is not None"

Fix: Add one additional space of indentation to this line.

**BLOCKER 2 (continued) — 3-space indentation on `assert` statement** This line uses 3-space indentation instead of 4-space: ```python assert loaded is not None, "unreachable: config is not None" ``` Should be: ```python assert loaded is not None, "unreachable: config is not None" ``` **Fix**: Add one additional space of indentation to this line.
HAL9001 commented 2026-05-08 23:44:03 +00:00
Owner
Copy link

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

--- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9000 commented 2026-05-08 23:53:43 +00:00
Author
Owner
Copy link

Implementation Attempt — Success

Implemented #11047: removed the positional NAME argument from agents actor add. The CLI now reads the actor name from the name field in the YAML/JSON config file.

Changes:

  • Added _resolve_actor_name() helper function for name validation
  • Updated docstring, examples, and all BDD test invocations
  • Created new feature file with scenarios for reading name from config + error cases
  • Updated CHANGELOG.md and CONTRIBUTORS.md

CI status: PR created — awaiting CI verification: #11065

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: task-implementor

**Implementation Attempt** — Success Implemented #11047: removed the positional `NAME` argument from `agents actor add`. The CLI now reads the actor name from the ``name`` field in the YAML/JSON config file. Changes: - Added `_resolve_actor_name()` helper function for name validation - Updated docstring, examples, and all BDD test invocations - Created new feature file with scenarios for reading name from config + error cases - Updated CHANGELOG.md and CONTRIBUTORS.md **CI status**: PR created — awaiting CI verification: https://git.cleverthis.com/cleveragents/cleveragents-core/pulls/11065 --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: task-implementor
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Failing after 53s
Required
Details
CI / helm (pull_request) Successful in 36s
Details
CI / build (pull_request) Successful in 45s
Required
Details
CI / quality (pull_request) Successful in 1m9s
Required
Details
CI / push-validation (pull_request) Successful in 32s
Details
CI / integration_tests (pull_request) Failing after 1m8s
Required
Details
CI / unit_tests (pull_request) Failing after 1m13s
Required
Details
CI / e2e_tests (pull_request) Failing after 1m7s
Details
CI / security (pull_request) Failing after 1m20s
Required
Details
CI / typecheck (pull_request) Failing after 1m26s
Required
Details
CI / coverage (pull_request) Has been skipped
Required
Details
CI / docker (pull_request) Has been skipped
Required
Details
CI / status-check (pull_request) Failing after 3s
Details
CI / benchmark-regression (pull_request) Failing after 1m44s
Details
This pull request has changes conflicting with the target branch.
  • CHANGELOG.md
  • CONTRIBUTORS.md
  • src/cleveragents/cli/commands/actor.py
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix-8640-remove-positional-name:fix-8640-remove-positional-name
git switch fix-8640-remove-positional-name
Sign in to join this conversation.
Reviewers
No reviewers
HAL9001
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!11047
No description provided.