cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(a2a/events): guard A2aEventQueue with threading.Lock to prevent concurrent iteration crash #11043

Closed
HAL9000 wants to merge 3 commits from pr_fix_8256 into master
pull from: pr_fix_8256
merge into: cleveragents:master
Conversation 8 Commits 3 Files Changed 6
+213 -34

3 Commits

Author SHA1 Message Date
CleverAgents Bot ac9f74bdd6 ci: stop master workflow on PR updates
CI / lint (pull_request) Has been cancelled
Details
CI / typecheck (pull_request) Has been cancelled
Details
CI / security (pull_request) Has been cancelled
Details
CI / quality (pull_request) Has been cancelled
Details
CI / unit_tests (pull_request) Has been cancelled
Details
CI / integration_tests (pull_request) Has been cancelled
Details
CI / e2e_tests (pull_request) Has been cancelled
Details
CI / coverage (pull_request) Has been cancelled
Details
CI / build (pull_request) Has been cancelled
Details
CI / docker (pull_request) Has been cancelled
Details
CI / helm (pull_request) Has been cancelled
Details
CI / push-validation (pull_request) Has been cancelled
Details
CI / status-check (pull_request) Has been cancelled
Details 
Remove the stale pull_request trigger from master.yml so PR branch commits do not launch the master workflow.

Maintenance patch for PR #11043.
 2026-06-10 20:19:54 -04:00
HAL9000 14f51b48b7 fix(a2a/events): add PR compliance checklist items for A2aEventQueue thread-safety fix (#8256)
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / push-validation (pull_request) Successful in 31s
Details
CI / lint (pull_request) Failing after 1m35s
Details
CI / build (pull_request) Successful in 1m19s
Details
CI / helm (pull_request) Successful in 56s
Details
CI / benchmark-regression (pull_request) Failing after 1m38s
Details
CI / quality (pull_request) Successful in 2m4s
Details
CI / security (pull_request) Successful in 2m11s
Details
CI / typecheck (pull_request) Successful in 2m14s
Details
CI / integration_tests (pull_request) Successful in 4m34s
Details
CI / e2e_tests (pull_request) Successful in 6m7s
Details
CI / unit_tests (pull_request) Successful in 6m53s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 4s
Details 
This commit adds the mandatory compliance items from the PR checklist that were
missing on the original threading.Lock implementation:

- CHANGELOG.md entry under [Unreleased]/Fixed documenting the A2aEventQueue
  lock-guarding fix (issue #7604 / PR #8256)
- CONTRIBUTORS.md entry for HAL 9000's concurrency safety contribution
- BDD test scenarios verifying concurrent publish+unsubscribe and
  subscribe-while-publishing complete without RuntimeError crashes

ISSUES CLOSED: #7604
 2026-05-09 00:07:32 +00:00
HAL9000 04de283262 fix(a2a/events): guard A2aEventQueue with threading.Lock to prevent concurrent iteration crash
CI / status-check (pull_request) Blocked by required conditions
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / push-validation (pull_request) Successful in 40s
Details
CI / helm (pull_request) Successful in 49s
Details
CI / build (pull_request) Successful in 55s
Details
CI / lint (pull_request) Successful in 1m9s
Details
CI / quality (pull_request) Successful in 1m20s
Details
CI / typecheck (pull_request) Successful in 1m35s
Details
CI / security (pull_request) Successful in 1m47s
Details
CI / integration_tests (pull_request) Successful in 3m8s
Details
CI / unit_tests (pull_request) Successful in 4m38s
Details
CI / e2e_tests (pull_request) Successful in 5m10s
Details
CI / docker (pull_request) Successful in 1m35s
Details
CI / benchmark-regression (pull_request) Failing after 1m22s
Details
CI / coverage (pull_request) Failing after 22m56s
Details 
The A2aEventQueue class had no thread-safety guarantees for its internal
shared mutable state (_events, _subscriptions, _is_closed). When multiple
threads accessed the queue concurrently — e.g. one thread publishing events
while another iterated over subscriptions or read event lists — the lack of
locking could cause RuntimeError: dictionary changed size during iteration
and similar crashes.

This fix adds a threading.RLock to A2aEventQueue that guards all mutating
and reading operations (__init__, is_closed, publish, subscribe_local,
unsubscribe, get_events, close). The EventBusBridge class also receives
its own RLock for thread-safe start/stop operations.

Signed-off-by: CleverThis <hal9000@cleverthis.com>
 2026-05-08 12:15:42 +00:00