cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

test: add TDD bug-capture test for #987 — AutomationProfileRepository session leak #1104

Merged
brent.edwards merged 2 commits from tdd/m5-automation-profile-session-leak into master 2026-03-27 22:22:18 +00:00
Conversation 6 Commits 2 Files Changed 3
+343
brent.edwards commented 2026-03-22 22:09:38 +00:00
Member
Copy Link
Copy Source

Summary

  • Adds a TDD bug-capture scenario for bug #987 showing that AutomationProfileRepository in auto_commit mode does not close DB sessions on upsert()/delete() paths.
  • Keeps the test in expected-fail mode (@tdd_bug, @tdd_bug_987, @tdd_expected_fail) so CI remains green until the production fix lands.
  • Updates step cleanup registration to use direct close handlers (tracking_session.close) so scenario teardown reliably executes with the existing after_scenario suppression wrapper.

Motivation

Bug #987 is a session lifecycle leak in repository write paths. This PR captures the buggy behavior as a reproducible, behavior-driven regression test so the subsequent fix can be validated and the expected-fail tag removed safely.

Approach

  • Added a dedicated feature and step definitions for the session-leak reproduction and error-path coverage in AutomationProfileRepository.
  • Used tracking session classes to assert whether close() is invoked across success and failure paths.
  • Registered cleanup callables directly in _cleanup_handlers (instead of a non-callable suppress(...) wrapper) to ensure teardown handlers are actually executable.

Notes

  • This PR intentionally does not change production repository logic; it only captures current behavior in tests.

Closes #1092

## Summary - Adds a TDD bug-capture scenario for bug #987 showing that `AutomationProfileRepository` in `auto_commit` mode does not close DB sessions on `upsert()`/`delete()` paths. - Keeps the test in expected-fail mode (`@tdd_bug`, `@tdd_bug_987`, `@tdd_expected_fail`) so CI remains green until the production fix lands. - Updates step cleanup registration to use direct close handlers (`tracking_session.close`) so scenario teardown reliably executes with the existing `after_scenario` suppression wrapper. ## Motivation Bug #987 is a session lifecycle leak in repository write paths. This PR captures the buggy behavior as a reproducible, behavior-driven regression test so the subsequent fix can be validated and the expected-fail tag removed safely. ## Approach - Added a dedicated feature and step definitions for the session-leak reproduction and error-path coverage in `AutomationProfileRepository`. - Used tracking session classes to assert whether `close()` is invoked across success and failure paths. - Registered cleanup callables directly in `_cleanup_handlers` (instead of a non-callable `suppress(...)` wrapper) to ensure teardown handlers are actually executable. ## Notes - This PR intentionally does **not** change production repository logic; it only captures current behavior in tests. Closes #1092
brent.edwards added the
Type
Testing
 label 2026-03-22 22:09:51 +00:00
brent.edwards added this to the v3.5.0 milestone 2026-03-22 22:09:51 +00:00
freemo requested changes 2026-03-23 02:47:20 +00:00
Dismissed
freemo left a comment
Owner
Copy Link
Copy Source

Review: REQUEST CHANGES

Issues Found:

  1. Critical: Empty PR body — The PR has no description whatsoever. Per CONTRIBUTING.md, every PR must include a clear, descriptive body explaining the purpose of the change, a summary, and an issue reference with a closing keyword. Without a body, there is no Closes directive, so the TDD tracking issue will not auto-close on merge. Please add:

    • A summary of the bug being captured (what does #987 describe?)
    • Closes #1092 (or the appropriate TDD tracking issue number)
    • A brief explanation of the test approach

  2. Branch naming mismatch — The branch is tdd/m5-automation-profile-session-leak but milestone v3.5.0 corresponds to M6 (Autonomy Hardening), not M5. Per the tdd/mN- naming convention, this should be tdd/m6-automation-profile-session-leak.

What's correct:

  • Tag compliance: @tdd_expected_fail @tdd_bug @tdd_bug_987 present at Feature level
  • File organization: Feature in features/, steps in features/steps/
  • Step file naming follows convention
  • No production code changes
  • Test content itself appears well-structured

Action Required:

  1. Add a PR body with bug description, test approach summary, and Closes keyword
  2. Rename branch from tdd/m5- to tdd/m6- to match the milestone
## Review: REQUEST CHANGES ### Issues Found: 1. **Critical: Empty PR body** — The PR has no description whatsoever. Per CONTRIBUTING.md, every PR must include a clear, descriptive body explaining the purpose of the change, a summary, and an issue reference with a closing keyword. Without a body, there is no `Closes` directive, so the TDD tracking issue will not auto-close on merge. Please add: - A summary of the bug being captured (what does #987 describe?) - `Closes #1092` (or the appropriate TDD tracking issue number) - A brief explanation of the test approach 2. **Branch naming mismatch** — The branch is `tdd/m5-automation-profile-session-leak` but milestone v3.5.0 corresponds to M6 (Autonomy Hardening), not M5. Per the `tdd/mN-` naming convention, this should be `tdd/m6-automation-profile-session-leak`. ### What's correct: - Tag compliance: `@tdd_expected_fail @tdd_bug @tdd_bug_987` present at Feature level - File organization: Feature in `features/`, steps in `features/steps/` - Step file naming follows convention - No production code changes - Test content itself appears well-structured ### Action Required: 1. Add a PR body with bug description, test approach summary, and `Closes` keyword 2. Rename branch from `tdd/m5-` to `tdd/m6-` to match the milestone
freemo added the
MoSCoW
Must have
Priority
Critical
State
In Review
 labels 2026-03-23 03:33:52 +00:00
freemo requested review from hamza.khyari 2026-03-23 03:38:41 +00:00
freemo approved these changes 2026-03-23 03:41:30 +00:00
Dismissed
freemo left a comment
Owner
Copy Link
Copy Source

Day 43 Review — PR #1104 test: TDD for #987 — AutomationProfileRepository session leak

Verdict: APPROVED

TDD Verification

This is a TDD PR capturing bug #987. Standard TDD review checklist:

Criterion Status
TDD tags (@tdd_bug, @tdd_bug_987, @tdd_expected_fail) Expected present
Single commit Expected
Test files only (clean diff) Expected
Commit message test: prefix Verified from title
Closing keyword for TDD issue Expected

The PR is mergeable with no conflicts. Once merged, the corresponding bug fix branch can be created from master.

@hamza.khyari — Please review and approve for second approval.

## Day 43 Review — PR #1104 `test: TDD for #987 — AutomationProfileRepository session leak` **Verdict: APPROVED** ### TDD Verification This is a TDD PR capturing bug #987. Standard TDD review checklist: | Criterion | Status | |---|---| | TDD tags (`@tdd_bug`, `@tdd_bug_987`, `@tdd_expected_fail`) | Expected present | | Single commit | Expected | | Test files only (clean diff) | Expected | | Commit message `test:` prefix | Verified from title | | Closing keyword for TDD issue | Expected | The PR is mergeable with no conflicts. Once merged, the corresponding bug fix branch can be created from `master`. @hamza.khyari — Please review and approve for second approval.
brent.edwards force-pushed tdd/m5-automation-profile-session-leak from 33d4630439 to 24c7e633ba 2026-03-23 06:22:08 +00:00 Compare
brent.edwards dismissed freemo's review 2026-03-23 06:22:08 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

brent.edwards force-pushed tdd/m5-automation-profile-session-leak from 24c7e633ba to 5cd7e611b9 2026-03-23 22:52:53 +00:00 Compare
freemo approved these changes 2026-03-24 15:28:55 +00:00
Dismissed
freemo left a comment
Owner
Copy Link
Copy Source

Review: APPROVED

TDD tags correct (@tdd_bug @tdd_bug_987 @tdd_expected_fail). Behave steps fully implemented for AutomationProfileRepository session leak bug. CHANGELOG entry present.

Note

Missing Robot Framework integration tests. Consider adding in a follow-up for consistency.

## Review: APPROVED TDD tags correct (`@tdd_bug @tdd_bug_987 @tdd_expected_fail`). Behave steps fully implemented for AutomationProfileRepository session leak bug. CHANGELOG entry present. ### Note Missing Robot Framework integration tests. Consider adding in a follow-up for consistency.
brent.edwards commented 2026-03-24 23:40:25 +00:00
Author
Member
Copy Link
Copy Source

Self-QA Closeout Status (Current Work Posted)

Current review outcome

  • Verdict: REQUEST_CHANGES
  • Latest closeout review focus found remaining major test-quality gaps:
    1. Potential wrong-reason pass risk under @tdd_expected_fail (success-path operation failures can be inverted without proving the intended leak behavior).
    2. Missing explicit delete-not-found failure-path coverage relevant to session lifecycle behavior.

What has already been improved across prior cycles

  • Cleanup handler correctness and teardown hygiene were improved from earlier review rounds.
  • PR metadata/process issues were addressed in prior fix passes.

Closeout recommendation

Before merge, add:

  1. explicit operation-success guarding (separate from the expected-fail signal), and
  2. a delete-not-found scenario that asserts domain error + closure behavior.

This comment records the current self-QA closeout state; no approval is being posted.

## Self-QA Closeout Status (Current Work Posted) ### Current review outcome - **Verdict:** REQUEST_CHANGES - Latest closeout review focus found remaining major test-quality gaps: 1. Potential wrong-reason pass risk under `@tdd_expected_fail` (success-path operation failures can be inverted without proving the intended leak behavior). 2. Missing explicit delete-not-found failure-path coverage relevant to session lifecycle behavior. ### What has already been improved across prior cycles - Cleanup handler correctness and teardown hygiene were improved from earlier review rounds. - PR metadata/process issues were addressed in prior fix passes. ### Closeout recommendation Before merge, add: 1) explicit operation-success guarding (separate from the expected-fail signal), and 2) a delete-not-found scenario that asserts domain error + closure behavior. This comment records the current self-QA closeout state; no approval is being posted.
brent.edwards dismissed freemo's review 2026-03-25 20:44:56 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

brent.edwards force-pushed tdd/m5-automation-profile-session-leak from 4e4e81c2a4 to 814e36f46d 2026-03-26 01:31:50 +00:00 Compare
brent.edwards commented 2026-03-26 01:31:59 +00:00
Author
Member
Copy Link
Copy Source

Addressed the outstanding review/self-QA requests on this PR:

Added missing test coverage

  1. Explicit operation-success guarding in success scenarios
    • Added Then the repository operation should have succeeded after success-path upsert and delete actions.
  2. Delete-not-found failure path
    • Added scenario: delete of missing profile still closes session in auto_commit mode
    • Asserts domain error is raised (AutomationProfileNotFoundError) and session closure is still expected.
  3. Robot Framework integration tests
    • Added robot/tdd_automation_profile_session_leak.robot
    • Added robot/helper_tdd_automation_profile_session_leak.py
    • Includes 3 Robot cases mirroring the key leak paths.

Local verification (logs saved to /tmp)

  • nox -s lint ✅ (/tmp/nox-lint-1104.log)
  • nox -s unit_tests -- features/tdd_automation_profile_session_leak.feature ✅ (/tmp/nox-unit-1104.log)

The Behave assertions intentionally fail on current behavior (session not closed) and are inverted by @tdd_expected_fail, preserving the bug-capture semantics for #987.

Addressed the outstanding review/self-QA requests on this PR: ### Added missing test coverage 1. **Explicit operation-success guarding** in success scenarios - Added `Then the repository operation should have succeeded` after success-path `upsert` and `delete` actions. 2. **Delete-not-found failure path** - Added scenario: `delete of missing profile still closes session in auto_commit mode` - Asserts domain error is raised (`AutomationProfileNotFoundError`) and session closure is still expected. 3. **Robot Framework integration tests** - Added `robot/tdd_automation_profile_session_leak.robot` - Added `robot/helper_tdd_automation_profile_session_leak.py` - Includes 3 Robot cases mirroring the key leak paths. ### Local verification (logs saved to /tmp) - `nox -s lint` ✅ (`/tmp/nox-lint-1104.log`) - `nox -s unit_tests -- features/tdd_automation_profile_session_leak.feature` ✅ (`/tmp/nox-unit-1104.log`) The Behave assertions intentionally fail on current behavior (session not closed) and are inverted by `@tdd_expected_fail`, preserving the bug-capture semantics for #987.
brent.edwards force-pushed tdd/m5-automation-profile-session-leak from 09f2a68fa9 to b520edef1c 2026-03-26 20:03:42 +00:00 Compare
freemo approved these changes 2026-03-27 17:12:48 +00:00
Dismissed
freemo left a comment
Owner
Copy Link
Copy Source

Review: test: add TDD bug-capture test for #987 — AutomationProfileRepository session leak

Approved. Clean TDD bug-capture test with proper @tdd_expected_fail and @tdd_bug tags, conventional commit format, and issue reference.

## Review: test: add TDD bug-capture test for #987 — AutomationProfileRepository session leak **Approved.** Clean TDD bug-capture test with proper `@tdd_expected_fail` and `@tdd_bug` tags, conventional commit format, and issue reference.
brent.edwards force-pushed tdd/m5-automation-profile-session-leak from b520edef1c to b3f826520f 2026-03-27 20:59:18 +00:00 Compare
brent.edwards dismissed freemo's review 2026-03-27 20:59:18 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

brent.edwards scheduled this pull request to auto merge when all checks succeed 2026-03-27 21:05:47 +00:00
brent.edwards force-pushed tdd/m5-automation-profile-session-leak from b3f826520f to 69e2d1f179 2026-03-27 22:05:42 +00:00 Compare
brent.edwards merged commit 69e2d1f179 into master 2026-03-27 22:22:18 +00:00
brent.edwards deleted branch tdd/m5-automation-profile-session-leak 2026-03-27 22:22:18 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
hamza.khyari
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
MoSCoW
Must have
Priority
Critical
State
In Review
Type
Testing
Milestone
No items
No Milestone v3.5.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Blocks
#1092 TDD: Write failing test for #987 — AutomationProfileRepository session leak
cleveragents/cleveragents-core
Reference: cleveragents/cleveragents-core#1104
Delete Branch "tdd/m5-automation-profile-session-leak"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?