feat(agents): add mandatory PR compliance checklist to implementation-pool-supervisor #11015

Closed
HAL9000 wants to merge 7 commits from AUTO-IMP/PR-10069-checklist into master

7 Commits

Author SHA1 Message Date
HAL9000 07caf65be8 fix(agents): replace Epic placeholder with actual note in pool supervisor
CI / push-validation (pull_request) Successful in 1m0s
CI / lint (pull_request) Successful in 3m46s
CI / build (pull_request) Successful in 2m45s
CI / helm (pull_request) Successful in 1m12s
CI / typecheck (pull_request) Successful in 4m3s
CI / quality (pull_request) Successful in 3m37s
CI / security (pull_request) Successful in 3m50s
CI / integration_tests (pull_request) Successful in 6m21s
CI / unit_tests (pull_request) Failing after 8m30s
CI / coverage (pull_request) Has been skipped
CI / docker (pull_request) Has been skipped
CI / status-check (pull_request) Failing after 4s
2026-05-17 09:25:39 +00:00
HAL9000 9b60f66b46 fix(changelog): merge duplicate ### Fixed and ### Added sections in [Unreleased]
Per Keep a Changelog specification, each version block must have exactly
one instance of each sub-header type (Added/Changed/Fixed/Security). Multiple
duplicate ### Fixed (5 instances) and ### Added (4 instances) within the
[Unreleased] section were consolidated into single headers. All content is
preserved — only duplicate header lines are removed.

ISSUES CLOSED: #11015
2026-05-17 09:25:39 +00:00
HAL9000 a836edd3e6 fix(changelog): merge duplicate # Added sub-header in [Unreleased] section
The [Unreleased] block had two ### Added sub-headers, violating
Keep a Changelog format which allows exactly one of each sub-header
type per release block. Consolidated into single ### Added.
2026-05-17 09:25:39 +00:00
HAL9000 85401f34b2 fix(agents): remove review-cycle details from CHANGELOG.md [Unreleased] section
Consolidate the ### Fixed entries describing internal PR #11015
review cycle details into a single expanded ### Added entry for
Implementation Pool Supervisor. This follows Keep a Changelog
format where changelog entries describe user/operator-facing
changes, not code review back-and-forth.

- Merged two duplicate ### Fixed sub-headers (review cycle entries)
  into the existing ### Added section
- Removed: 'PR Compliance Checklist now embedded...' entry
- Removed: 'YAML frontmatter fields added...' entry
- Expanded Implementation Pool Supervisor entry to mention that
  workers receive checklist via prompt template and that model/
  reasoningEffort frontmatter are specified

ISSUES CLOSED: #11015
2026-05-17 09:25:39 +00:00
HAL9000 65e20b16ed fix(agents): correct CHANGELOG structure and parent epic reference in pool supervisor
Consolidate duplicate ### Fixed sub-headers under [Unreleased] section
in CHANGELOG.md into a single section per Keep a Changelog format.
Add all pre-existing entries under one ### Fixed header for cleanliness.

Replace incorrect Parent Epic: #9779 (an automated announcement post)
with placeholder in implementation-pool-supervisor agent definition
examples, since #9779 is not an Epic.
2026-05-17 09:25:39 +00:00
HAL9000 11add58ee6 fix(agents): embed PR compliance checklist in pool supervisor prompt and add model fields
Embed the full 8-item PR Compliance Checklist into the `implementation-pool-supervisor`
prompt template so workers always receive it during dispatch (fixes review feedback from
PR #11015). Add missing `model` and `reasoningEffort` YAML frontmatter fields matching
other supervisor agent conventions. Updated CHANGELOG.md and CONTRIBUTORS.md accordingly.

ISSUES CLOSED: #10069
2026-05-17 09:25:39 +00:00
HAL9000 bd654811c6 feat(agents): add mandatory PR compliance checklist to implementation-pool-supervisor
Add a new implementation-pool-supervisor.md agent definition wrapping the
implementation supervisor for pool operations, with an embedded mandatory
8-item PR Compliance Checklist. Workers must complete all 8 items before
creating a PR: CHANGELOG.md update, CONTRIBUTORS.md update, commit footer,
CI verification, BDD tests, Epic reference, label application, and milestone
assignment. Includes concrete markdown examples for each subsection and
compliance verification pseudocode to ensure reproducible adherence.

Parent Epic: #9779

ISSUES CLOSED: #10069
2026-05-17 09:25:39 +00:00