Fix JSON syntax errors in .devcontainer/devcontainer.json (removed
invalid JS-style // comments) and .devcontainer/opencode.json (removed
90+ trailing commas). Apply auto-fixes for end-of-file and trailing
whitespace issues across 100+ files. Fix SIM105 ruff violations in
benchmarks/core_circuit_breaker_bench.py (use contextlib.suppress).
Note: The security fix from issue #7478 (validate_path startswith bypass)
was already delivered to master in commit e18ac5f2. This PR as currently
structured is non-atomic (35 commits across 10+ issues) and needs
significant restructure before merge. This commit only addresses the
CI/pre-commit failures.
ISSUES CLOSED: #7478
The posixpath.relpath() call in _is_under could raise ValueError or
TypeError on certain edge cases (e.g., Windows cross-drive paths).
Added try/except with fallback to False, consistent with the same
guard already present in llm_actors.py _write_to_sandbox().
Also tightened the parent-directory check to use posixpath.sep
separation for explicit sibling-path detection.
Fixes: #7478
ISSUES CLOSED: #7478
- Remove all # type: ignore[attr-defined] suppressions from step definitions
by using getattr() with explicit type annotations instead of direct
context attribute access
- Fix undefined reference to context.sibling_escape_path by storing the
escape_path value during the prefix collision check
- Remove duplicate 'import os' statements in path_mapper.py
- All quality gates passing (lint, typecheck, unit_tests, integration_tests, e2e_tests)
ISSUES CLOSED: #7478
Remove all # noqa: ANN205 suppressions from container_tool_exec_steps.py
that were applied to already-annotated (-> None) functions, which caused
RUF100 (Unused noqa directive) lint failures. Add the missing Behave step
definitions required by path_containment_security.feature:
- Given a temporary sandbox directory "{path}"
- When I map the host path "{path}" to container
- Then the mapped path should be "{expected}"
Also rename ambiguous "the result should be true/false" steps to
"the host containment result should be true/false" to avoid AmbiguousStep
conflicts with the parametrized step in cli_steps.py.
ISSUES CLOSED: #7478
Replaced insecure str.startswith(root + "/") path containment checks in
tool/path_mapper.py (_is_under) and application/services/llm_actors.py
(_write_to_sandbox) with semantic os.path.relpath comparisons to prevent
sibling-directory prefix-collision path traversal attacks.
The string-prefix approach was vulnerable: a sandbox root of /tmp/sandbox
would incorrectly allow access to /tmp/sandboxmalicious/file.txt because
"/tmp/sandboxmalicious/file" starts with "/tmp/sandbox".
Security specification mandates all path containment checks use
Path.is_relative_to() or equivalent semantic comparison.
Added BDD test coverage in features/path_containment_security.feature
with @tdd_issue_7478 tags for the prefix-collision attack scenarios.
ISSUES CLOSED: #7478
controller-ci-rerun
HAL9000
OpenCode AI