test-infra: Harden BDD scenario tagging rules (strict @a2a/@session/@cli enforcement) #10992

Open
HAL9000 wants to merge 4 commits from pr/9234-hardening-bdd-tags into master

4 Commits

Author SHA1 Message Date
controller-ci-rerun 9965daf031 chore: re-trigger CI [controller]
CI / typecheck (pull_request) Has been cancelled
CI / security (pull_request) Has been cancelled
CI / quality (pull_request) Has been cancelled
CI / unit_tests (pull_request) Has been cancelled
CI / integration_tests (pull_request) Has been cancelled
CI / e2e_tests (pull_request) Has been cancelled
CI / build (pull_request) Has been cancelled
CI / helm (pull_request) Has been cancelled
CI / push-validation (pull_request) Has been cancelled
CI / lint (pull_request) Successful in 51s
CI / coverage (pull_request) Has been skipped
CI / docker (pull_request) Has been skipped
CI / status-check (pull_request) Failing after 9s
2026-06-18 11:01:32 -04:00
CleverAgents Bot fbd08db0a5 ci: stop master workflow on PR updates
CI / lint (pull_request) Has been cancelled
CI / typecheck (pull_request) Has been cancelled
CI / security (pull_request) Has been cancelled
CI / quality (pull_request) Has been cancelled
CI / unit_tests (pull_request) Has been cancelled
CI / integration_tests (pull_request) Has been cancelled
CI / e2e_tests (pull_request) Has been cancelled
CI / coverage (pull_request) Has been cancelled
CI / build (pull_request) Has been cancelled
CI / docker (pull_request) Has been cancelled
CI / helm (pull_request) Has been cancelled
CI / push-validation (pull_request) Has been cancelled
CI / status-check (pull_request) Has been cancelled
Remove the stale pull_request trigger from master.yml so PR branch commits do not launch the master workflow.

Maintenance patch for PR #10992.
2026-06-10 20:21:02 -04:00
HAL9000 ca974236d0 fix(testing): correct check_domain_title_keywords logic and remove type: ignore
CI / lint (pull_request) Successful in 52s
CI / quality (pull_request) Successful in 51s
CI / typecheck (pull_request) Successful in 59s
CI / security (pull_request) Successful in 1m16s
CI / push-validation (pull_request) Successful in 33s
CI / helm (pull_request) Successful in 40s
CI / build (pull_request) Successful in 44s
CI / integration_tests (pull_request) Failing after 2m54s
CI / e2e_tests (pull_request) Failing after 3m41s
CI / unit_tests (pull_request) Failing after 4m54s
CI / coverage (pull_request) Has been skipped
CI / docker (pull_request) Has been skipped
CI / status-check (pull_request) Failing after 3s
CI / benchmark-publish (pull_request) Has been cancelled
CI / benchmark-regression (pull_request) Has been cancelled
- Remove unused MagicMock import from bdd_tag_enforcement_steps.py (lint)
- Fix validate_domain_tags: replace ternary-None comprehension with typed
  filter, eliminating the # type: ignore[list-item] suppression
- Fix check_domain_title_keywords: same type fix, plus replace .search()
  with .finditer() so all keyword matches are found (not just the first),
  and fix the inverted tag_missing boolean (was returning early when the
  tag was absent, warning when present — exactly backwards)
- Fix BDD scenario title at line 72 to avoid incidental "session" keyword
  that triggered a false-positive warning under multi-keyword detection

ISSUES CLOSED: #10992
2026-06-10 07:21:51 -04:00
HAL9000 42186d649b test-infra: Harden BDD scenario tagging rules (strict @a2a/@session/@cli enforcement) added validate_domain_tags() and check_domain_title_keywords() to enforce strict one-tag-per-domain for @a2a, @session, @cli tags in Behave tests. The only allowed cross-domain combination is @session + @cli. Soft warnings for missing domain tags when scenario titles contain keywords. Full BDD coverage in features/testing/bdd_tag_enforcement.feature with 18 scenarios. ISSUES CLOSED: #10992
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Failing after 1m50s
CI / quality (pull_request) Successful in 2m6s
CI / benchmark-regression (pull_request) Failing after 2m5s
CI / helm (pull_request) Successful in 56s
CI / push-validation (pull_request) Successful in 55s
CI / security (pull_request) Successful in 2m27s
CI / build (pull_request) Successful in 1m10s
CI / typecheck (pull_request) Successful in 2m39s
CI / integration_tests (pull_request) Successful in 5m2s
CI / e2e_tests (pull_request) Successful in 4m43s
CI / unit_tests (pull_request) Failing after 8m57s
CI / coverage (pull_request) Has been skipped
CI / docker (pull_request) Has been skipped
CI / status-check (pull_request) Failing after 3s
2026-05-09 14:14:53 +00:00