cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(plan_executor): preserve strategy_decisions_json and report actual actor mode #10951

Closed
HAL9000 wants to merge 4 commits from fix/10934-preserve-strategy-decisions-json into master
pull from: fix/10934-preserve-strategy-decisions-json
merge into: cleveragents:master
Conversation 11 Commits 4 Files Changed 6
+42 -25

4 Commits

Author SHA1 Message Date
CleverAgents Bot 16eb6eb818 ci: stop master workflow on PR updates
CI / lint (pull_request) Has been cancelled
Details
CI / typecheck (pull_request) Has been cancelled
Details
CI / security (pull_request) Has been cancelled
Details
CI / quality (pull_request) Has been cancelled
Details
CI / unit_tests (pull_request) Has been cancelled
Details
CI / integration_tests (pull_request) Has been cancelled
Details
CI / e2e_tests (pull_request) Has been cancelled
Details
CI / coverage (pull_request) Has been cancelled
Details
CI / build (pull_request) Has been cancelled
Details
CI / docker (pull_request) Has been cancelled
Details
CI / helm (pull_request) Has been cancelled
Details
CI / push-validation (pull_request) Has been cancelled
Details
CI / status-check (pull_request) Has been cancelled
Details 
Remove the stale pull_request trigger from master.yml so PR branch commits do not launch the master workflow.

Maintenance patch for PR #10951.
 2026-06-10 20:21:41 -04:00
HAL9000 ba6f2116ad fix(plan_executor): preserve strategy_decisions_json and report actual actor mode
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Failing after 1m1s
Details
CI / build (pull_request) Successful in 59s
Details
CI / helm (pull_request) Successful in 36s
Details
CI / quality (pull_request) Successful in 1m15s
Details
CI / push-validation (pull_request) Successful in 40s
Details
CI / typecheck (pull_request) Successful in 1m40s
Details
CI / security (pull_request) Successful in 2m4s
Details
CI / integration_tests (pull_request) Successful in 4m24s
Details
CI / e2e_tests (pull_request) Successful in 5m17s
Details
CI / unit_tests (pull_request) Successful in 6m33s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 5s
Details 
This commit completes the fix initiated in the prior commits by replacing the remaining
instance of dynamic type(self._execute_actor).__name__ with the literal "stub" value
in all four actor-mode locations (_run_execute_with_actor):
- Actor success path error_details mode field (lines 1074)
- Actor success path logger mode keyword argument (line 1101)
- Actor error on_error checkpoint mode field (line 1143)
- Actor final error_details update mode field (line 1156)

All four locations already had the strategy_decisions_json pop→update→re-insert
preservation pattern from prior commits. This ensures consistent reporting of the
actual execution mode ("stub" for stub executor, "runtime" for runtime executor).

ISSUES CLOSED: #10934
 2026-05-09 13:34:00 +00:00
HAL9000 accfc6f37f fix(plan_executor): preserve strategy_decisions_json and report actual actor mode
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 56s
Details
CI / helm (pull_request) Successful in 34s
Details
CI / quality (pull_request) Successful in 1m25s
Details
CI / build (pull_request) Successful in 42s
Details
CI / typecheck (pull_request) Successful in 1m27s
Details
CI / security (pull_request) Successful in 1m28s
Details
CI / push-validation (pull_request) Successful in 20s
Details
CI / e2e_tests (pull_request) Successful in 4m3s
Details
CI / integration_tests (pull_request) Successful in 6m52s
Details
CI / unit_tests (pull_request) Successful in 8m19s
Details
CI / docker (pull_request) Failing after 1s
Details
CI / coverage (pull_request) Successful in 11m36s
Details
CI / status-check (pull_request) Failing after 5s
Details 
- Add missing strategy_decisions_json re-insertion on _run_execute_with_runtime success path
- Use type(self._execute_actor).__name__ instead of hardcoded "stub" in _run_execute_with_actor

Fixes failing executor_error_details BDD tests that verify:
1. strategy_decisions_json is preserved on execute success path
2. mode field reflects actual actor class name, not hardcoded "stub"
 2026-05-04 19:47:40 +00:00
HAL9000 be7d4c2dc2 fix(plan_executor): preserve strategy_decisions_json and report actual actor mode
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / push-validation (pull_request) Successful in 40s
Details
CI / helm (pull_request) Successful in 48s
Details
CI / build (pull_request) Successful in 53s
Details
CI / lint (pull_request) Successful in 1m25s
Details
CI / typecheck (pull_request) Successful in 1m31s
Details
CI / security (pull_request) Successful in 1m30s
Details
CI / quality (pull_request) Successful in 1m29s
Details
CI / e2e_tests (pull_request) Successful in 3m53s
Details
CI / integration_tests (pull_request) Successful in 5m14s
Details
CI / unit_tests (pull_request) Failing after 6m6s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 3s
Details 
- Preserve strategy_decisions_json in error_details during plan execution
  so that the strategy hierarchy is maintained across execute phase
- Report actual actor mode ('runtime' or 'stub') instead of actor class name
  for accurate execution mode tracking in error_details

Fixes #10934
 2026-05-01 14:28:52 +00:00