- Apply error_details merge pattern to _run_execute_with_runtime for
consistency with _run_execute_with_actor (preserves strategy_decisions_json
in runtime mode too)
- Expand _run_execute_with_actor docstring to clarify retry is controlled
by ErrorRecoveryService.max_retries
Addresses remaining review findings from PR #10945.
Address CoreRasurae's review comments:
1. Narrow exception scope in _build_decisions (line 846) to catch only
json.JSONDecodeError and ValidationError instead of bare Exception.
This prevents swallowing unintended errors like memory issues.
2. Update feature file section header and scenario titles from
_run_execute_with_stub to _run_execute_with_actor for consistency.
3. Add spec to MagicMock in failing execute scenario (line 138) to
match the pattern used in succeeding scenario (line 119).
Note: Master feature entry point - Behave auto-discovers all .feature
files, no explicit entry point needed. Tests run successfully.
ISSUES CLOSED: #10874
Merge error_details instead of replacing them in _run_execute_with_actor
(formerly _run_execute_with_stub), preserving strategy_decisions_json
stored by run_strategize. On execute retry, _build_decisions now finds
the full decision hierarchy instead of falling back to definition_of_done
parsing.
- Merge error_details on both success and failure paths
- Report type(self._execute_actor).__name__ instead of hardcoded 'stub'
- Rename _run_execute_with_stub to _run_execute_with_actor
- Add 4 Behave scenarios verifying preservation and mode reporting
ISSUES CLOSED: #10874
HAL9001
hamza.khyari