cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(events): add close() method to ReactiveEventBus to complete RxPY subject #10937

Closed
HAL9000 wants to merge 3 commits from feature/pr-10916-close-reactive-event-bus into master
pull from: feature/pr-10916-close-reactive-event-bus
merge into: cleveragents:master
Conversation 7 Commits 3 Files Changed 6
+153 -2

3 Commits

Author SHA1 Message Date
CleverAgents Bot fd6280cdc7 ci: stop master workflow on PR updates
CI / lint (pull_request) Has been cancelled
Details
CI / typecheck (pull_request) Has been cancelled
Details
CI / security (pull_request) Has been cancelled
Details
CI / quality (pull_request) Has been cancelled
Details
CI / unit_tests (pull_request) Has been cancelled
Details
CI / integration_tests (pull_request) Has been cancelled
Details
CI / e2e_tests (pull_request) Has been cancelled
Details
CI / coverage (pull_request) Has been cancelled
Details
CI / build (pull_request) Has been cancelled
Details
CI / docker (pull_request) Has been cancelled
Details
CI / helm (pull_request) Has been cancelled
Details
CI / push-validation (pull_request) Has been cancelled
Details
CI / status-check (pull_request) Has been cancelled
Details 
Remove the stale pull_request trigger from master.yml so PR branch commits do not launch the master workflow.

Maintenance patch for PR #10937.
 2026-06-10 20:21:53 -04:00
HAL9000 69c283c5a4 fix(events): add close() method to ReactiveEventBus to complete RxPY subject
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / helm (pull_request) Successful in 41s
Details
CI / push-validation (pull_request) Successful in 36s
Details
CI / lint (pull_request) Failing after 1m34s
Details
CI / build (pull_request) Successful in 1m4s
Details
CI / typecheck (pull_request) Successful in 1m43s
Details
CI / security (pull_request) Successful in 1m49s
Details
CI / quality (pull_request) Successful in 1m53s
Details
CI / e2e_tests (pull_request) Successful in 4m9s
Details
CI / unit_tests (pull_request) Failing after 4m18s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / integration_tests (pull_request) Successful in 4m51s
Details
CI / status-check (pull_request) Failing after 3s
Details 
Address all blocking reviewer feedback on PR #10937:
- Remove accidentally committed add_close_steps.py patch script
- Fix single-quote style in step decorators (ruff format compliance)
- Add _closed flag and is_closed public property to ReactiveEventBus
- Guard emit() against calls after close() - raises RuntimeError
- Add __enter__/__exit__ context manager protocol for automatic cleanup
- Add BDD scenarios: emit-after-close raises RuntimeError, context manager
- Fix step_subscriptions_cleared to use public is_closed property
- Add changelog entry for all changes

ISSUES CLOSED: #10916
 2026-05-04 19:57:37 +00:00
HAL9000 b31794b95d feat(events): add close() tests for ReactiveEventBus to complete RxPY subject lifecycle
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / push-validation (pull_request) Successful in 24s
Details
CI / helm (pull_request) Successful in 34s
Details
CI / lint (pull_request) Failing after 1m0s
Details
CI / build (pull_request) Successful in 1m6s
Details
CI / typecheck (pull_request) Successful in 1m26s
Details
CI / quality (pull_request) Successful in 1m29s
Details
CI / security (pull_request) Successful in 1m33s
Details
CI / unit_tests (pull_request) Failing after 3m4s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / integration_tests (pull_request) Successful in 4m47s
Details
CI / e2e_tests (pull_request) Successful in 6m9s
Details
CI / status-check (pull_request) Failing after 4s
Details 
This adds BDD scenario tests for the ReactiveEventBus.close() method
which was recently introduced to complete the RxPY Subject lifecycle.

Tests covered:
- close() terminates the reactive stream and clears subscriptions
- close() clears the in-memory audit log

Also includes:
- @when('I close the ReactiveEventBus') step definition
- @then('the subscribed handler should have received') step for post-close verification
- @then('the subscriptions should be cleared') assertion step
- @then('the audit log should be empty') assertion step

Closes #10916
ISSUES CLOSED: #10916
 2026-04-29 22:09:54 +00:00