fix(plan): preserve strategy_decisions_json in error_details during execute and report actual actor mode #10931

Closed
hamza.khyari wants to merge 2 commits from bugfix/executor-error-details-overwrite-mini-max into master

2 Commits

Author SHA1 Message Date
HAL9001 12a2892bc2 Merge remote-tracking branch 'origin/bugfix/executor-error-details-overwrite-mini-max' into bugfix/executor-error-details-overwrite-mini-max
CI / benchmark-publish (pull_request) Has been skipped
CI / push-validation (pull_request) Successful in 27s
CI / build (pull_request) Successful in 55s
CI / helm (pull_request) Successful in 56s
CI / lint (pull_request) Failing after 1m1s
CI / quality (pull_request) Successful in 1m4s
CI / typecheck (pull_request) Successful in 1m41s
CI / security (pull_request) Successful in 1m51s
CI / integration_tests (pull_request) Successful in 3m37s
CI / e2e_tests (pull_request) Successful in 4m13s
CI / unit_tests (pull_request) Successful in 7m44s
CI / coverage (pull_request) Has been skipped
CI / docker (pull_request) Has been skipped
CI / status-check (pull_request) Failing after 3s
2026-04-30 04:02:12 +00:00
hamza.khyari 4e2e8b7ceb fix(plan): preserve strategy_decisions_json in error_details during execute and report actual actor mode
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Failing after 1m9s
CI / quality (pull_request) Successful in 1m17s
CI / typecheck (pull_request) Successful in 1m21s
CI / build (pull_request) Successful in 37s
CI / security (pull_request) Successful in 1m39s
CI / helm (pull_request) Successful in 27s
CI / integration_tests (pull_request) Successful in 3m36s
CI / e2e_tests (pull_request) Successful in 3m47s
CI / unit_tests (pull_request) Successful in 5m3s
CI / coverage (pull_request) Has been skipped
CI / docker (pull_request) Has been skipped
CI / push-validation (pull_request) Successful in 22s
CI / status-check (pull_request) Failing after 3s
Fixed three bugs in _run_execute_with_actor (formerly _run_execute_with_stub):

1. Merged error_details instead of replacing - preserves
   strategy_decisions_json stored by run_strategize() so retry plans
   retain the full decision hierarchy (Forgejo #10874).

2. Used type(self._execute_actor).__name__ instead of hardcoded "stub"
   at all three locations (success, on_error checkpoint, fail) so the
   mode field reflects the actual actor type (Forgejo #10874).

3. Renamed method from _run_execute_with_stub to
   _run_execute_with_actor since it accepts any configured actor
   (stub or LLM), not just ExecuteStubActor.

Updated test step comments and docs.

ISSUES CLOSED: #10874
2026-04-29 14:08:46 +00:00