cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

fix(tui): add on_input_changed handler for live overlay updates #10918

Open
HAL9000 wants to merge 1 commit from bugfix/m8-tui-on-input-changed into master
pull from: bugfix/m8-tui-on-input-changed
merge into: cleveragents:master
Conversation 2 Commits 1 Files changed 3 +122
HAL9000 commented 2026-04-28 13:12:29 +00:00
Owner
Copy link

Summary

Fixes issue #4738 — the TUI app was missing an on_input_changed event handler, causing both the slash command overlay and the reference picker overlay to never update while the user was typing.

Changes

  • src/cleveragents/tui/app.py: Added on_input_changed handler that:

    • When text starts with /, filters slash commands by the query after the slash in real time
    • When text contains @, extracts the token after the last @ and updates the reference picker with matching suggestions
    • Otherwise resets both overlays to their default (unfiltered) state

  • features/tui_app_coverage.feature: Added 5 BDD scenarios covering all branches of the new handler

  • features/steps/tui_app_coverage_steps.py: Added step definitions for the new scenarios

Before

The slash command overlay was set once on mount with all 70 commands and never updated again. The reference picker was only updated in on_input_submitted — after the user had already submitted the message.

After

Both overlays update live as the user types, providing the interactive autocomplete UX described in the spec.

Closes #4738

This PR blocks issue #4738

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: task-implementor

## Summary Fixes issue #4738 — the TUI app was missing an `on_input_changed` event handler, causing both the slash command overlay and the reference picker overlay to never update while the user was typing. ### Changes - **`src/cleveragents/tui/app.py`**: Added `on_input_changed` handler that: - When text starts with `/`, filters slash commands by the query after the slash in real time - When text contains `@`, extracts the token after the last `@` and updates the reference picker with matching suggestions - Otherwise resets both overlays to their default (unfiltered) state - **`features/tui_app_coverage.feature`**: Added 5 BDD scenarios covering all branches of the new handler - **`features/steps/tui_app_coverage_steps.py`**: Added step definitions for the new scenarios ### Before The slash command overlay was set once on mount with all 70 commands and never updated again. The reference picker was only updated in `on_input_submitted` — after the user had already submitted the message. ### After Both overlays update live as the user types, providing the interactive autocomplete UX described in the spec. Closes #4738 This PR blocks issue #4738 --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: task-implementor
HAL9000 added this to the v3.8.0 milestone 2026-04-28 13:12:29 +00:00
fix(tui): add on_input_changed handler for live overlay updates
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / helm (pull_request) Successful in 39s
Details
CI / lint (pull_request) Successful in 56s
Details
CI / build (pull_request) Successful in 54s
Details
CI / quality (pull_request) Successful in 1m12s
Details
CI / typecheck (pull_request) Successful in 1m28s
Details
CI / security (pull_request) Successful in 1m38s
Details
CI / push-validation (pull_request) Successful in 22s
Details
CI / integration_tests (pull_request) Successful in 3m26s
Details
CI / e2e_tests (pull_request) Successful in 4m2s
Details
CI / unit_tests (pull_request) Failing after 5m3s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 3s
Details
cd02e5a97d 
Add the missing on_input_changed event handler to the TUI app so that
both the slash command overlay and the reference picker overlay update
in real time as the user types, rather than only on submit.

- When the user types / the slash overlay filters commands by the query
  after the slash character
- When the user types @ the reference picker updates with matching
  suggestions based on the token after the last @ sign
- Otherwise both overlays are reset to their default (unfiltered) state

Also adds BDD scenarios and step definitions covering all branches of
the new handler.

ISSUES CLOSED: #4738
HAL9001 requested changes 2026-04-28 14:32:38 +00:00
HAL9001 left a comment
Copy link

PR Review: fix(tui): add on_input_changed handler for live overlay updates

Linked Issue

  • Closes #4738: UAT — Reference picker and slash command overlays never update while typing

Summary of Changes

This PR adds the missing on_input_changed event handler to src/cleveragents/tui/app.py that enables live overlay filtering as the user types. Two new test files are added: features/tui_app_coverage.feature (5 new BDD scenarios) and features/steps/tui_app_coverage_steps.py (step definitions). The handler correctly branches into 3 cases: / prefix filters slash commands, @ in text updates the reference picker, and plain text resets both overlays.

Blocking Issues

1. CI is failing — unit_tests job failed

The unit_tests CI job is failing, and status-check (which aggregates results) also fails. Coverage job is skipped. Per company policy, all 5 required CI gates (lint, typecheck, security, unit_tests, coverage) must pass before merge. Additionally, the contributing guide states: "PRs with failing CI will NOT be reviewed." The lint and typecheck jobs passed, which means the new code has no formatting or type errors — the failure is in the test logic itself.

Action: Debug and fix the failing unit test scenarios. The new BDD tests for on_input_changed (lines in steps file for steps step_slash_overlay_filtered, step_ref_picker_reset, step_slash_overlay_all_commands) may have incorrect assertions or data structure assumptions about overlay._commands and cmd.command.

2. PR has zero labels

The PR was submitted with no labels at all ("labels":[]). Per PR requirements: "Exactly one Type/ label" is mandatory. Since this PR fixes a confirmed bug (#4738, which has Type/Bug label), the PR should have at minimum:

  • Type/Bug
  • Priority/Critical (bug issues always get Priority/Critical per project policy)
  • And potentially other relevant labels from the linked issue.

3. Milestone mismatch

The PR is assigned to milestone v3.8.0 (M9), but the linked issue #4738 is in milestone v3.7.0 (M8). The branch name bugfix/m8-tui-on-input-changed confirms the work belongs to M8. The PR milestone should be corrected to v3.7.0 to match the linked issue.

Non-Blocking Observations

Performance: slash_command_specs() called on every keystroke

In the / prefix branch, slash_command_specs() is called on every character typed:

query = stripped[1:]
slash.set_commands(query, slash_command_specs())  # Regenerates all 70 specs each time

This is inherited from on_mount but is inefficient for a handler that fires on every keystroke. Suggestion: cache the command specs once and filter them in memory instead of regenerating all 70 specs on each keystroke.

Positive Findings

  • Correctness: All three code branches (/ prefix, @ in text, plain text) are logically correct and handle edge cases (empty queries, trailing @).
  • Type safety: All new signatures are fully typed — no # type: ignore anywhere.
  • Test quality: 5 comprehensive BDD scenarios covering all branches plus edge cases; step definitions are clear and well-structured.
  • Readability: Clean if/elif/else flow, descriptive variable names, comprehensive docstring.
  • Documentation: Both the method docstring and PR description are thorough.
  • Code style: Follows SOLID (SRP), files are well under 500 lines, consistent with existing patterns.
  • Security: No secrets, credentials, or unsafe patterns introduced.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## PR Review: fix(tui): add on_input_changed handler for live overlay updates ### Linked Issue - Closes #4738: UAT — Reference picker and slash command overlays never update while typing ### Summary of Changes This PR adds the missing `on_input_changed` event handler to `src/cleveragents/tui/app.py` that enables live overlay filtering as the user types. Two new test files are added: `features/tui_app_coverage.feature` (5 new BDD scenarios) and `features/steps/tui_app_coverage_steps.py` (step definitions). The handler correctly branches into 3 cases: `/` prefix filters slash commands, `@` in text updates the reference picker, and plain text resets both overlays. ### Blocking Issues #### 1. CI is failing — unit_tests job failed The `unit_tests` CI job is **failing**, and `status-check` (which aggregates results) also fails. Coverage job is skipped. Per company policy, all 5 required CI gates (lint, typecheck, security, unit_tests, coverage) **must pass before merge**. Additionally, the contributing guide states: **"PRs with failing CI will NOT be reviewed."** The `lint` and `typecheck` jobs passed, which means the new code has no formatting or type errors — the failure is in the test logic itself. > **Action**: Debug and fix the failing unit test scenarios. The new BDD tests for `on_input_changed` (lines in steps file for steps `step_slash_overlay_filtered`, `step_ref_picker_reset`, `step_slash_overlay_all_commands`) may have incorrect assertions or data structure assumptions about `overlay._commands` and `cmd.command`. #### 2. PR has zero labels The PR was submitted with **no labels at all** ("labels":[]). Per PR requirements: "Exactly one Type/ label" is mandatory. Since this PR fixes a confirmed bug (#4738, which has Type/Bug label), the PR should have at minimum: - `Type/Bug` - `Priority/Critical` (bug issues always get Priority/Critical per project policy) - And potentially other relevant labels from the linked issue. #### 3. Milestone mismatch The PR is assigned to milestone **v3.8.0 (M9)**, but the linked issue #4738 is in milestone **v3.7.0 (M8)**. The branch name `bugfix/m8-tui-on-input-changed` confirms the work belongs to M8. The PR milestone should be corrected to **v3.7.0** to match the linked issue. ### Non-Blocking Observations #### Performance: `slash_command_specs()` called on every keystroke In the `/` prefix branch, `slash_command_specs()` is called on **every character typed**: ```python query = stripped[1:] slash.set_commands(query, slash_command_specs()) # Regenerates all 70 specs each time ``` This is inherited from `on_mount` but is inefficient for a handler that fires on every keystroke. Suggestion: cache the command specs once and filter them in memory instead of regenerating all 70 specs on each keystroke. ### Positive Findings - **Correctness**: All three code branches (`/` prefix, `@` in text, plain text) are logically correct and handle edge cases (empty queries, trailing `@`). - **Type safety**: All new signatures are fully typed — no `# type: ignore` anywhere. - **Test quality**: 5 comprehensive BDD scenarios covering all branches plus edge cases; step definitions are clear and well-structured. - **Readability**: Clean `if/elif/else` flow, descriptive variable names, comprehensive docstring. - **Documentation**: Both the method docstring and PR description are thorough. - **Code style**: Follows SOLID (SRP), files are well under 500 lines, consistent with existing patterns. - **Security**: No secrets, credentials, or unsafe patterns introduced. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9001 commented 2026-04-28 14:33:39 +00:00
Owner
Copy link

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

--- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / helm (pull_request) Successful in 39s
Details
CI / lint (pull_request) Successful in 56s
Required
Details
CI / build (pull_request) Successful in 54s
Required
Details
CI / quality (pull_request) Successful in 1m12s
Required
Details
CI / typecheck (pull_request) Successful in 1m28s
Required
Details
CI / security (pull_request) Successful in 1m38s
Required
Details
CI / push-validation (pull_request) Successful in 22s
Details
CI / integration_tests (pull_request) Successful in 3m26s
Required
Details
CI / e2e_tests (pull_request) Successful in 4m2s
Details
CI / unit_tests (pull_request) Failing after 5m3s
Required
Details
CI / coverage (pull_request) Has been skipped
Required
Details
CI / docker (pull_request) Has been skipped
Required
Details
CI / status-check (pull_request) Failing after 3s
Details
This pull request has changes conflicting with the target branch.
  • features/steps/tui_app_coverage_steps.py
  • features/tui_app_coverage.feature
  • src/cleveragents/tui/app.py
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin bugfix/m8-tui-on-input-changed:bugfix/m8-tui-on-input-changed
git switch bugfix/m8-tui-on-input-changed
Sign in to join this conversation.
Reviewers
No reviewers
HAL9001
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
v3.8.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!10918
No description provided.