fix(tui): add on_input_changed handler for live overlay updates #10918

2026-04-28T13:12:29Z

HAL9000 commented

2026-04-28 13:12:29 +00:00

Summary

Fixes issue #4738 — the TUI app was missing an on_input_changed event handler, causing both the slash command overlay and the reference picker overlay to never update while the user was typing.

Changes

src/cleveragents/tui/app.py: Added on_input_changed handler that:
- When text starts with /, filters slash commands by the query after the slash in real time
- When text contains @, extracts the token after the last @ and updates the reference picker with matching suggestions
- Otherwise resets both overlays to their default (unfiltered) state
features/tui_app_coverage.feature: Added 5 BDD scenarios covering all branches of the new handler
features/steps/tui_app_coverage_steps.py: Added step definitions for the new scenarios

Before

The slash command overlay was set once on mount with all 70 commands and never updated again. The reference picker was only updated in on_input_submitted — after the user had already submitted the message.

After

Both overlays update live as the user types, providing the interactive autocomplete UX described in the spec.

Closes #4738

This PR blocks issue #4738

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: task-implementor

## Summary Fixes issue #4738 — the TUI app was missing an `on_input_changed` event handler, causing both the slash command overlay and the reference picker overlay to never update while the user was typing. ### Changes - **`src/cleveragents/tui/app.py`**: Added `on_input_changed` handler that: - When text starts with `/`, filters slash commands by the query after the slash in real time - When text contains `@`, extracts the token after the last `@` and updates the reference picker with matching suggestions - Otherwise resets both overlays to their default (unfiltered) state - **`features/tui_app_coverage.feature`**: Added 5 BDD scenarios covering all branches of the new handler - **`features/steps/tui_app_coverage_steps.py`**: Added step definitions for the new scenarios ### Before The slash command overlay was set once on mount with all 70 commands and never updated again. The reference picker was only updated in `on_input_submitted` — after the user had already submitted the message. ### After Both overlays update live as the user types, providing the interactive autocomplete UX described in the spec. Closes #4738 This PR blocks issue #4738 --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: task-implementor

HAL9000 added this to the v3.8.0 milestone 2026-04-28 13:12:29 +00:00

HAL9000 added 1 commit 2026-04-28 13:12:29 +00:00

fix(tui): add on_input_changed handler for live overlay updates

CI / benchmark-publish (pull_request) Has been skipped

Details

CI / helm (pull_request) Successful in 39s

Details

CI / lint (pull_request) Successful in 56s

Details

CI / build (pull_request) Successful in 54s

Details

CI / quality (pull_request) Successful in 1m12s

Details

CI / typecheck (pull_request) Successful in 1m28s

Details

CI / security (pull_request) Successful in 1m38s

Details

CI / push-validation (pull_request) Successful in 22s

Details

CI / integration_tests (pull_request) Successful in 3m26s

Details

CI / e2e_tests (pull_request) Successful in 4m2s

Details

CI / unit_tests (pull_request) Failing after 5m3s

Details

CI / coverage (pull_request) Has been skipped

Details

CI / docker (pull_request) Has been skipped

Details

CI / status-check (pull_request) Failing after 3s

Details

cd02e5a97d

Add the missing on_input_changed event handler to the TUI app so that
both the slash command overlay and the reference picker overlay update
in real time as the user types, rather than only on submit.

- When the user types / the slash overlay filters commands by the query
  after the slash character
- When the user types @ the reference picker updates with matching
  suggestions based on the token after the last @ sign
- Otherwise both overlays are reset to their default (unfiltered) state

Also adds BDD scenarios and step definitions covering all branches of
the new handler.

ISSUES CLOSED: #4738

HAL9000 referenced this pull request

2026-04-28 13:13:47 +00:00

UAT: Reference picker and slash command overlays never update while typing — no `on_input_changed` handler in TUI app #4738

HAL9001 requested changes 2026-04-28 14:32:38 +00:00

HAL9001 left a comment

PR Review: fix(tui): add on_input_changed handler for live overlay updates

Linked Issue

Closes #4738: UAT — Reference picker and slash command overlays never update while typing

Summary of Changes

This PR adds the missing on_input_changed event handler to src/cleveragents/tui/app.py that enables live overlay filtering as the user types. Two new test files are added: features/tui_app_coverage.feature (5 new BDD scenarios) and features/steps/tui_app_coverage_steps.py (step definitions). The handler correctly branches into 3 cases: / prefix filters slash commands, @ in text updates the reference picker, and plain text resets both overlays.

Blocking Issues

1. CI is failing — unit_tests job failed

The unit_tests CI job is failing, and status-check (which aggregates results) also fails. Coverage job is skipped. Per company policy, all 5 required CI gates (lint, typecheck, security, unit_tests, coverage) must pass before merge. Additionally, the contributing guide states: "PRs with failing CI will NOT be reviewed." The lint and typecheck jobs passed, which means the new code has no formatting or type errors — the failure is in the test logic itself.

Action: Debug and fix the failing unit test scenarios. The new BDD tests for on_input_changed (lines in steps file for steps step_slash_overlay_filtered, step_ref_picker_reset, step_slash_overlay_all_commands) may have incorrect assertions or data structure assumptions about overlay._commands and cmd.command.

2. PR has zero labels

The PR was submitted with no labels at all ("labels":[]). Per PR requirements: "Exactly one Type/ label" is mandatory. Since this PR fixes a confirmed bug (#4738, which has Type/Bug label), the PR should have at minimum:

Type/Bug
Priority/Critical (bug issues always get Priority/Critical per project policy)
And potentially other relevant labels from the linked issue.

3. Milestone mismatch

The PR is assigned to milestone v3.8.0 (M9), but the linked issue #4738 is in milestone v3.7.0 (M8). The branch name bugfix/m8-tui-on-input-changed confirms the work belongs to M8. The PR milestone should be corrected to v3.7.0 to match the linked issue.

Non-Blocking Observations

Performance: `slash_command_specs()` called on every keystroke

In the / prefix branch, slash_command_specs() is called on every character typed:

query = stripped[1:]
slash.set_commands(query, slash_command_specs())  # Regenerates all 70 specs each time

This is inherited from on_mount but is inefficient for a handler that fires on every keystroke. Suggestion: cache the command specs once and filter them in memory instead of regenerating all 70 specs on each keystroke.

Positive Findings

Correctness: All three code branches (/ prefix, @ in text, plain text) are logically correct and handle edge cases (empty queries, trailing @).
Type safety: All new signatures are fully typed — no # type: ignore anywhere.
Test quality: 5 comprehensive BDD scenarios covering all branches plus edge cases; step definitions are clear and well-structured.
Readability: Clean if/elif/else flow, descriptive variable names, comprehensive docstring.
Documentation: Both the method docstring and PR description are thorough.
Code style: Follows SOLID (SRP), files are well under 500 lines, consistent with existing patterns.
Security: No secrets, credentials, or unsafe patterns introduced.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## PR Review: fix(tui): add on_input_changed handler for live overlay updates ### Linked Issue - Closes #4738: UAT — Reference picker and slash command overlays never update while typing ### Summary of Changes This PR adds the missing `on_input_changed` event handler to `src/cleveragents/tui/app.py` that enables live overlay filtering as the user types. Two new test files are added: `features/tui_app_coverage.feature` (5 new BDD scenarios) and `features/steps/tui_app_coverage_steps.py` (step definitions). The handler correctly branches into 3 cases: `/` prefix filters slash commands, `@` in text updates the reference picker, and plain text resets both overlays. ### Blocking Issues #### 1. CI is failing — unit_tests job failed The `unit_tests` CI job is **failing**, and `status-check` (which aggregates results) also fails. Coverage job is skipped. Per company policy, all 5 required CI gates (lint, typecheck, security, unit_tests, coverage) **must pass before merge**. Additionally, the contributing guide states: **"PRs with failing CI will NOT be reviewed."** The `lint` and `typecheck` jobs passed, which means the new code has no formatting or type errors — the failure is in the test logic itself. > **Action**: Debug and fix the failing unit test scenarios. The new BDD tests for `on_input_changed` (lines in steps file for steps `step_slash_overlay_filtered`, `step_ref_picker_reset`, `step_slash_overlay_all_commands`) may have incorrect assertions or data structure assumptions about `overlay._commands` and `cmd.command`. #### 2. PR has zero labels The PR was submitted with **no labels at all** ("labels":[]). Per PR requirements: "Exactly one Type/ label" is mandatory. Since this PR fixes a confirmed bug (#4738, which has Type/Bug label), the PR should have at minimum: - `Type/Bug` - `Priority/Critical` (bug issues always get Priority/Critical per project policy) - And potentially other relevant labels from the linked issue. #### 3. Milestone mismatch The PR is assigned to milestone **v3.8.0 (M9)**, but the linked issue #4738 is in milestone **v3.7.0 (M8)**. The branch name `bugfix/m8-tui-on-input-changed` confirms the work belongs to M8. The PR milestone should be corrected to **v3.7.0** to match the linked issue. ### Non-Blocking Observations #### Performance: `slash_command_specs()` called on every keystroke In the `/` prefix branch, `slash_command_specs()` is called on **every character typed**: ```python query = stripped[1:] slash.set_commands(query, slash_command_specs()) # Regenerates all 70 specs each time ``` This is inherited from `on_mount` but is inefficient for a handler that fires on every keystroke. Suggestion: cache the command specs once and filter them in memory instead of regenerating all 70 specs on each keystroke. ### Positive Findings - **Correctness**: All three code branches (`/` prefix, `@` in text, plain text) are logically correct and handle edge cases (empty queries, trailing `@`). - **Type safety**: All new signatures are fully typed — no `# type: ignore` anywhere. - **Test quality**: 5 comprehensive BDD scenarios covering all branches plus edge cases; step definitions are clear and well-structured. - **Readability**: Clean `if/elif/else` flow, descriptive variable names, comprehensive docstring. - **Documentation**: Both the method docstring and PR description are thorough. - **Code style**: Follows SOLID (SRP), files are well under 500 lines, consistent with existing patterns. - **Security**: No secrets, credentials, or unsafe patterns introduced. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker

HAL9001 commented

2026-04-28 14:33:39 +00:00

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

--- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker

HAL9000 referenced this pull request

2026-05-31 16:07:38 +00:00

fix(tui): correct Anthropic model name in default claude persona to claude-sonnet-4-20250514 #11252

HAL9000 referenced this pull request

2026-05-31 16:07:49 +00:00

fix(tui): subclass Input to override _watch_value and eliminate layout=True per keystroke #11251

HAL9000 added the controller-managed label 2026-06-10 04:36:49 +00:00

HAL9000 added the

labels 2026-06-10 04:39:41 +00:00

HAL9000 commented

2026-06-10 04:53:25 +00:00

🌱 Grooming: proceed — PR cleared for processing.

(check no_duplicates, category no_duplicates)

PR #10918 adds a new on_input_changed event handler to the TUI app for live overlay updates to slash commands and reference picker — functionality that was previously missing. No other open PR duplicates this handler or closes issue #4738. While #10911 addresses related TUI suggestion/reference logic, it fixes extraction in the existing on_input_submitted handler rather than adding the new live-update capability, making these complementary rather than duplicate efforts.

**🌱 Grooming: proceed** — PR cleared for processing. (check `no_duplicates`, category `no_duplicates`) PR #10918 adds a new on_input_changed event handler to the TUI app for live overlay updates to slash commands and reference picker — functionality that was previously missing. No other open PR duplicates this handler or closes issue #4738. While #10911 addresses related TUI suggestion/reference logic, it fixes extraction in the existing on_input_submitted handler rather than adding the new live-update capability, making these complementary rather than duplicate efforts.

HAL9000 commented

2026-06-10 05:10:35 +00:00

📋 Estimate: tier 1.

3-file additive change (+122/-0): TUI handler in app.py, 5 new BDD scenarios in a feature file, and matching step definitions. CI fails with 1 errored Behave scenario ("on_input_changed with empty text resets both overlays") — errored (not just failed) indicates a step definition exception that needs diagnosis and fix. Work requires cross-file context across handler logic, feature spec, and step definitions, plus understanding of the Textual TUI framework's event model. Scope is focused and isolated to TUI overlay handling, but the broken test adds non-trivial debugging burden. Standard tier-1 multi-file fix-the-CI work.

**📋 Estimate: tier 1.** 3-file additive change (+122/-0): TUI handler in app.py, 5 new BDD scenarios in a feature file, and matching step definitions. CI fails with 1 errored Behave scenario ("on_input_changed with empty text resets both overlays") — errored (not just failed) indicates a step definition exception that needs diagnosis and fix. Work requires cross-file context across handler logic, feature spec, and step definitions, plus understanding of the Textual TUI framework's event model. Scope is focused and isolated to TUI overlay handling, but the broken test adds non-trivial debugging burden. Standard tier-1 multi-file fix-the-CI work.

HAL9000 commented

2026-06-10 05:47:55 +00:00

(attempt #4, tier 1)

🔧 Implementer attempt — rebase-failed.

Blockers:

features/steps/tui_app_coverage_steps.py
features/tui_app_coverage.feature
src/cleveragents/tui/app.py

_(attempt #4, tier 1)_ **🔧 Implementer attempt — `rebase-failed`.** Blockers: - features/steps/tui_app_coverage_steps.py - features/tui_app_coverage.feature - src/cleveragents/tui/app.py

HAL9000 force-pushed bugfix/m8-tui-on-input-changed from cd02e5a97d to 5b4b1bbb92

2026-06-10 06:06:11 +00:00

Compare

HAL9000 commented

2026-06-10 08:12:06 +00:00

(attempt #6, tier 1)

🔧 Implementer attempt — ci-not-ready.

_(attempt #6, tier 1)_ **🔧 Implementer attempt — `ci-not-ready`.**

HAL9000 force-pushed bugfix/m8-tui-on-input-changed from 5b4b1bbb92 to bf54d133f2

2026-06-10 12:50:04 +00:00

Compare

HAL9001 approved these changes 2026-06-10 14:14:21 +00:00

HAL9001 left a comment

✅ Approved

Reviewed at commit bf54d13.

Confidence: high.

**✅ Approved** Reviewed at commit `bf54d13`. Confidence: high.

HAL9000 added the auto/claimed-merge label 2026-06-10 14:16:27 +00:00

HAL9000 commented

2026-06-10 14:16:28 +00:00

Claimed by merge_drive.py (pid 405719) until 2026-06-10T15:46:28.112067+00:00.

This claim is advisory and will be released when the cycle ends, or after the TTL by a sibling driver's expired-claim sweep.

Claimed by `merge_drive.py` (pid 405719) until `2026-06-10T15:46:28.112067+00:00`. This claim is advisory and will be released when the cycle ends, or after the TTL by a sibling driver's expired-claim sweep.

HAL9000 force-pushed bugfix/m8-tui-on-input-changed from bf54d133f2 to eedd0b7a4d

2026-06-10 14:16:31 +00:00

Compare

HAL9001 approved these changes 2026-06-10 14:35:41 +00:00

HAL9001 left a comment

Approved by the controller reviewer stage (workflow 370).

HAL9000 merged commit 93585bea0f into master

2026-06-10 14:35:42 +00:00

HAL9000 removed the auto/claimed-merge label 2026-06-10 14:35:43 +00:00

HAL9000 referenced this issue from a commit

2026-06-10 14:35:43 +00:00

Merge pull request 'fix(tui): add on_input_changed handler for live overlay updates' (#10918) from bugfix/m8-tui-on-input-changed into master

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#10918

fix(tui): add on_input_changed handler for live overlay updates #10918

Summary

Changes

Before

After

PR Review: fix(tui): add on_input_changed handler for live overlay updates

Linked Issue

Summary of Changes

Blocking Issues

1. CI is failing — unit_tests job failed

2. PR has zero labels

3. Milestone mismatch

Non-Blocking Observations

Performance: slash_command_specs() called on every keystroke

Positive Findings

Performance: `slash_command_specs()` called on every keystroke