fix(cli): log suppressed facade dispatch exceptions in session create #10898

Merged
HAL9000 merged 3 commits from bugfix/m6-session-create-suppress-exception-logging into master 2026-05-07 19:37:18 +00:00

3 Commits

Author SHA1 Message Date
HAL9000 d4ebb482e1 style(tests): fix ruff format violation in TDD step file
CI / status-check (push) Blocked by required conditions
CI / benchmark-publish (push) Has started running
CI / benchmark-regression (push) Has been skipped
CI / lint (push) Successful in 1m56s
CI / helm (push) Successful in 57s
CI / push-validation (push) Successful in 1m0s
CI / quality (push) Successful in 2m17s
CI / typecheck (push) Successful in 2m25s
CI / build (push) Successful in 1m34s
CI / security (push) Successful in 2m49s
CI / e2e_tests (push) Successful in 4m29s
CI / integration_tests (push) Successful in 5m20s
CI / unit_tests (push) Successful in 6m0s
CI / docker (push) Successful in 1m32s
CI / coverage (push) Failing after 15m7s
CI / lint (pull_request) Successful in 37s
CI / benchmark-publish (pull_request) Has been skipped
CI / quality (pull_request) Successful in 53s
CI / push-validation (pull_request) Successful in 32s
CI / helm (pull_request) Successful in 40s
CI / typecheck (pull_request) Successful in 1m35s
CI / build (pull_request) Successful in 50s
CI / security (pull_request) Successful in 2m9s
CI / benchmark-regression (pull_request) Failing after 1m17s
CI / integration_tests (pull_request) Successful in 3m9s
CI / e2e_tests (pull_request) Failing after 4m19s
CI / unit_tests (pull_request) Successful in 4m51s
CI / docker (pull_request) Successful in 1m33s
CI / coverage (pull_request) Successful in 10m44s
CI / status-check (pull_request) Failing after 3s
Collapse multi-line @then decorator onto a single line in
tdd_session_create_suppress_exception_steps.py to satisfy
ruff format --check (the CI lint job runs both ruff check
and ruff format --check).
2026-05-07 19:14:53 +00:00
HAL9000 08422b4ded fix(cli): log suppressed facade dispatch exceptions in session create
Replace __import__("datetime") with proper top-level import
per project Python import rules. This resolves the CI lint failure
blocking PR #10898.

Closes #10433

Refs: #10414 #10898
2026-05-07 19:14:53 +00:00
HAL9000 2d519182ca fix(cli): log suppressed facade dispatch exceptions in session create
Replace the silent contextlib.suppress(Exception) block in the session
create command with a try/except that logs at WARNING level with exc_info.

Previously, any exception raised by _facade_dispatch() during session
creation was silently discarded with no logging, making it impossible to
diagnose failures in the facade layer (e.g. A2A bootstrap unavailable,
programming errors, infrastructure issues).

The fix keeps session creation non-fatal (the session is already persisted
before the facade call) while ensuring the exception is visible in logs:

    try:
        _facade_dispatch(session.create, {...})
    except Exception as _exc:
        _log.warning(
            session_create_facade_dispatch_failed,
            extra={"session_id": ..., "error": str(_exc)},
            exc_info=True,
        )

Also includes the TDD regression test from issue #10414 (PR #10749) with
@tdd_expected_fail removed, since the fix is now applied. The test verifies
that a WARNING log entry is emitted when _facade_dispatch() raises and that
session creation still exits 0.

ISSUES CLOSED: #10433
2026-05-07 19:14:53 +00:00