cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(tui): wire ShellSafetyService into run_shell_command replacing legacy looks_dangerous #10890

Open
HAL9000 wants to merge 4 commits from bugfix/m8-shell-safety-service-integration into master
pull from: bugfix/m8-shell-safety-service-integration
merge into: cleveragents:master
Conversation 11 Commits 4 Files Changed 6
+129 -43

4 Commits

Author SHA1 Message Date
controller-ci-rerun c1c1f798cb chore: re-trigger CI [controller]
CI / typecheck (pull_request) Has been cancelled
Details
CI / security (pull_request) Has been cancelled
Details
CI / quality (pull_request) Has been cancelled
Details
CI / unit_tests (pull_request) Has been cancelled
Details
CI / integration_tests (pull_request) Has been cancelled
Details
CI / e2e_tests (pull_request) Has been cancelled
Details
CI / build (pull_request) Has been cancelled
Details
CI / helm (pull_request) Has been cancelled
Details
CI / push-validation (pull_request) Has been cancelled
Details
CI / lint (pull_request) Failing after 57s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 3s
Details
2026-06-18 11:01:25 -04:00
CleverAgents Bot fbcf25ada7 ci: stop master workflow on PR updates
CI / lint (pull_request) Has been cancelled
Details
CI / typecheck (pull_request) Has been cancelled
Details
CI / security (pull_request) Has been cancelled
Details
CI / quality (pull_request) Has been cancelled
Details
CI / unit_tests (pull_request) Has been cancelled
Details
CI / integration_tests (pull_request) Has been cancelled
Details
CI / e2e_tests (pull_request) Has been cancelled
Details
CI / coverage (pull_request) Has been cancelled
Details
CI / build (pull_request) Has been cancelled
Details
CI / docker (pull_request) Has been cancelled
Details
CI / helm (pull_request) Has been cancelled
Details
CI / push-validation (pull_request) Has been cancelled
Details
CI / status-check (pull_request) Has been cancelled
Details 
Remove the stale pull_request trigger from master.yml so PR branch commits do not launch the master workflow.

Maintenance patch for PR #10890.
 2026-06-10 20:22:16 -04:00
HAL9000 730c225298 fix(tui): update tui_input_modes_steps.py to use ShellSafetyService instead of removed looks_dangerous
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / push-validation (pull_request) Successful in 35s
Details
CI / helm (pull_request) Successful in 47s
Details
CI / build (pull_request) Successful in 1m2s
Details
CI / lint (pull_request) Failing after 1m30s
Details
CI / quality (pull_request) Successful in 1m38s
Details
CI / typecheck (pull_request) Successful in 1m56s
Details
CI / security (pull_request) Successful in 1m55s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / integration_tests (pull_request) Successful in 5m2s
Details
CI / e2e_tests (pull_request) Successful in 5m44s
Details
CI / unit_tests (pull_request) Failing after 6m30s
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 3s
Details
2026-04-28 17:54:57 +00:00
HAL9000 393127639e fix(tui): wire ShellSafetyService into run_shell_command replacing legacy looks_dangerous
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / helm (pull_request) Successful in 34s
Details
CI / build (pull_request) Successful in 52s
Details
CI / lint (pull_request) Failing after 1m7s
Details
CI / quality (pull_request) Successful in 1m15s
Details
CI / typecheck (pull_request) Successful in 1m36s
Details
CI / security (pull_request) Successful in 1m38s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / push-validation (pull_request) Successful in 22s
Details
CI / unit_tests (pull_request) Failing after 3m27s
Details
CI / docker (pull_request) Has been skipped
Details
CI / integration_tests (pull_request) Successful in 4m36s
Details
CI / e2e_tests (pull_request) Successful in 5m3s
Details
CI / status-check (pull_request) Failing after 3s
Details 
Replace the inline 5-pattern looks_dangerous() function in shell_exec.py with
the ShellSafetyService (12-pattern registry, 4 severity levels). This fixes a
spec compliance bug where 7 of 12 dangerous patterns were silently bypassed.

Also update repl.py to use ShellSafetyService instead of looks_dangerous().

Add TDD regression tests (@tdd_issue, @tdd_issue_4736) verifying that all
previously-missed patterns (rm -rf wildcard, rm -rf ~/, shred --remove,
chmod 777, sudo rm, wget|sh, curl|bash) are now correctly blocked.

ISSUES CLOSED: #4736
 2026-04-28 08:02:16 +00:00