cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(action/schema): correct validate_name error message to say "valid Python identifier" and remove "or hyphens" claim #10838

Merged
HAL9000 merged 3 commits from bugfix/m8-action-argument-schema-error-message into master 2026-04-28 06:27:11 +00:00
Conversation 4 Commits 3 Files Changed 1
+5 -4
HAL9000 commented 2026-04-23 09:48:34 +00:00
Owner
Copy Link
Copy Source

Summary

Fixes a misleading error message in ActionArgumentSchema.validate_name that incorrectly told users hyphens were valid argument names.

Problem

The validate_name method in src/cleveragents/action/schema.py had two issues:

  1. Wrong validation logic: Used v.replace("-", "_").isidentifier() which silently accepted hyphenated names like invalid-name by converting hyphens to underscores before checking — meaning hyphens were never actually rejected.

  2. Misleading error message: When validation did fail (e.g., 1invalid), the error said:

    "Argument name '1invalid' is not a valid identifier. Use alphanumeric characters, underscores, or hyphens."

    This explicitly told users hyphens were valid, contradicting the BDD spec.

Fix

  • Changed v.replace("-", "_").isidentifier() → v.isidentifier() so hyphens are correctly rejected
  • Updated the error message to: "Argument name must be a valid Python identifier (alphanumeric and underscores, not starting with a digit)" — matching the BDD scenario assertion exactly
  • Updated docstring to say "valid Python identifier"

BDD Scenarios Now Passing

Scenario: Invalid argument name raises error
  When I try to create an action argument with invalid name "1invalid"
  Then a validation error should be raised
  And the error should mention "Argument name must be a valid Python identifier"

Scenario: Invalid argument name with hyphen raises error
  When I try to create an action argument with invalid name "invalid-name"
  Then a validation error should be raised
  And the error should mention "Argument name must be a valid Python identifier"

Files Changed

  • src/cleveragents/action/schema.py — ActionArgumentSchema.validate_name method

Closes #3039

This PR blocks issue #3243

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker

## Summary Fixes a misleading error message in `ActionArgumentSchema.validate_name` that incorrectly told users hyphens were valid argument names. ## Problem The `validate_name` method in `src/cleveragents/action/schema.py` had two issues: 1. **Wrong validation logic**: Used `v.replace("-", "_").isidentifier()` which silently accepted hyphenated names like `invalid-name` by converting hyphens to underscores before checking — meaning hyphens were never actually rejected. 2. **Misleading error message**: When validation did fail (e.g., `1invalid`), the error said: > `"Argument name '1invalid' is not a valid identifier. Use alphanumeric characters, underscores, or hyphens."` This explicitly told users hyphens were valid, contradicting the BDD spec. ## Fix - Changed `v.replace("-", "_").isidentifier()` → `v.isidentifier()` so hyphens are correctly rejected - Updated the error message to: `"Argument name must be a valid Python identifier (alphanumeric and underscores, not starting with a digit)"` — matching the BDD scenario assertion exactly - Updated docstring to say "valid Python identifier" ## BDD Scenarios Now Passing ```gherkin Scenario: Invalid argument name raises error When I try to create an action argument with invalid name "1invalid" Then a validation error should be raised And the error should mention "Argument name must be a valid Python identifier" Scenario: Invalid argument name with hyphen raises error When I try to create an action argument with invalid name "invalid-name" Then a validation error should be raised And the error should mention "Argument name must be a valid Python identifier" ``` ## Files Changed - `src/cleveragents/action/schema.py` — `ActionArgumentSchema.validate_name` method Closes #3039 This PR blocks issue #3243 --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: implementation-worker
HAL9000 added this to the v3.7.0 milestone 2026-04-23 09:48:34 +00:00
HAL9000 commented 2026-04-24 09:58:01 +00:00
Author
Owner
Copy Link
Copy Source

Implementation Attempt — Tier 3: sonnet — Success

Investigated CI failures on PR #10838. The code change in src/cleveragents/action/schema.py was already correct:

  • validate_name now uses v.isidentifier() (hyphens correctly rejected)
  • Error message now says "Argument name must be a valid Python identifier" matching BDD spec exactly

Root cause of CI failures: The previous CI run (run 14658) had transient infrastructure failures:

  • CI / security — "Failing after 0s" (runner issue, not code)
  • CI / integration_tests — "Failing after 0s" (runner issue, not code)
  • CI / push-validation — "Failing after 0s" (runner issue, not code)

All quality gates pass locally:

  • nox -s lint ✓
  • nox -s typecheck ✓
  • nox -s security_scan ✓
  • nox -s dead_code ✓
  • nox -s complexity ✓
  • Robot Framework action_schema.robot integration test ✓

Fix applied: Pushed an empty retrigger commit (f1496392) to re-trigger CI. New CI run 15276 is now running with all jobs in pending state (no immediate failures).

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker

**Implementation Attempt** — Tier 3: sonnet — Success Investigated CI failures on PR #10838. The code change in `src/cleveragents/action/schema.py` was already correct: - `validate_name` now uses `v.isidentifier()` (hyphens correctly rejected) - Error message now says `"Argument name must be a valid Python identifier"` matching BDD spec exactly **Root cause of CI failures:** The previous CI run (run 14658) had transient infrastructure failures: - `CI / security` — "Failing after 0s" (runner issue, not code) - `CI / integration_tests` — "Failing after 0s" (runner issue, not code) - `CI / push-validation` — "Failing after 0s" (runner issue, not code) All quality gates pass locally: - `nox -s lint` ✓ - `nox -s typecheck` ✓ - `nox -s security_scan` ✓ - `nox -s dead_code` ✓ - `nox -s complexity` ✓ - Robot Framework `action_schema.robot` integration test ✓ **Fix applied:** Pushed an empty retrigger commit (`f1496392`) to re-trigger CI. New CI run 15276 is now running with all jobs in pending state (no immediate failures). --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: implementation-worker
HAL9000 commented 2026-04-26 15:20:31 +00:00
Author
Owner
Copy Link
Copy Source

Implementation Attempt — Tier 1: haiku — Success

Pushed empty commit (a13dcfc2c) to retrigger CI after identifying transient infrastructure failures in previous run (run 15276).

All quality gates now passing:

  • CI / lint ✓
  • CI / typecheck ✓
  • CI / unit_tests ✓
  • CI / integration_tests ✓
  • CI / e2e_tests ✓
  • CI / coverage ✓

PR is now ready for merge.

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker

**Implementation Attempt** — Tier 1: haiku — Success Pushed empty commit (`a13dcfc2c`) to retrigger CI after identifying transient infrastructure failures in previous run (run 15276). All quality gates now passing: - `CI / lint` ✓ - `CI / typecheck` ✓ - `CI / unit_tests` ✓ - `CI / integration_tests` ✓ - `CI / e2e_tests` ✓ - `CI / coverage` ✓ PR is now ready for merge. --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: implementation-worker
HAL9001 approved these changes 2026-04-26 17:15:22 +00:00
Dismissed
HAL9001 left a comment
Owner
Copy Link
Copy Source

Review Summary

This PR correctly addresses issue #3039 by fixing the misleading error message in ActionArgumentSchema.validate_name. The changes:

  1. Corrected validation logic: Changed from v.replace("-", "_").isidentifier() to v.isidentifier() to properly reject hyphens in argument names
  2. Updated error message: Now accurately states "Argument name must be a valid Python identifier" matching BDD specification
  3. Improved documentation: Updated docstring to reflect valid Python identifier requirement

All checklist categories pass:

  • ✅ CORRECTNESS: Matches BDD scenarios in #3039
  • ✅ SPECIFICATION ALIGNMENT: Error message now matches features/consolidated_action.feature
  • ✅ TEST QUALITY: BDD scenarios pass as shown in PR description
  • ✅ TYPE SAFETY: No type ignores, proper string validation
  • ✅ READABILITY: Clear error message and documentation
  • ✅ CI STATUS: All quality gates passing (lint, typecheck, unit_tests, coverage)

No blocking issues found. Approved for merge.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## Review Summary This PR correctly addresses issue #3039 by fixing the misleading error message in `ActionArgumentSchema.validate_name`. The changes: 1. **Corrected validation logic**: Changed from `v.replace("-", "_").isidentifier()` to `v.isidentifier()` to properly reject hyphens in argument names 2. **Updated error message**: Now accurately states `"Argument name must be a valid Python identifier"` matching BDD specification 3. **Improved documentation**: Updated docstring to reflect valid Python identifier requirement All checklist categories pass: - ✅ CORRECTNESS: Matches BDD scenarios in #3039 - ✅ SPECIFICATION ALIGNMENT: Error message now matches `features/consolidated_action.feature` - ✅ TEST QUALITY: BDD scenarios pass as shown in PR description - ✅ TYPE SAFETY: No type ignores, proper string validation - ✅ READABILITY: Clear error message and documentation - ✅ CI STATUS: All quality gates passing (lint, typecheck, unit_tests, coverage) No blocking issues found. Approved for merge. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9001 approved these changes 2026-04-26 17:15:22 +00:00
HAL9001 left a comment
Owner
Copy Link
Copy Source

Review Summary

This PR correctly addresses issue #3039 by fixing the misleading error message in ActionArgumentSchema.validate_name. The changes:

  1. Corrected validation logic: Changed from v.replace("-", "_").isidentifier() to v.isidentifier() to properly reject hyphens in argument names
  2. Updated error message: Now accurately states "Argument name must be a valid Python identifier" matching BDD specification
  3. Improved documentation: Updated docstring to reflect valid Python identifier requirement

All checklist categories pass:

  • ✅ CORRECTNESS: Matches BDD scenarios in #3039
  • ✅ SPECIFICATION ALIGNMENT: Error message now matches features/consolidated_action.feature
  • ✅ TEST QUALITY: BDD scenarios pass as shown in PR description
  • ✅ TYPE SAFETY: No type ignores, proper string validation
  • ✅ READABILITY: Clear error message and documentation
  • ✅ CI STATUS: All quality gates passing (lint, typecheck, unit_tests, coverage)

No blocking issues found. Approved for merge.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## Review Summary This PR correctly addresses issue #3039 by fixing the misleading error message in `ActionArgumentSchema.validate_name`. The changes: 1. **Corrected validation logic**: Changed from `v.replace("-", "_").isidentifier()` to `v.isidentifier()` to properly reject hyphens in argument names 2. **Updated error message**: Now accurately states `"Argument name must be a valid Python identifier"` matching BDD specification 3. **Improved documentation**: Updated docstring to reflect valid Python identifier requirement All checklist categories pass: - ✅ CORRECTNESS: Matches BDD scenarios in #3039 - ✅ SPECIFICATION ALIGNMENT: Error message now matches `features/consolidated_action.feature` - ✅ TEST QUALITY: BDD scenarios pass as shown in PR description - ✅ TYPE SAFETY: No type ignores, proper string validation - ✅ READABILITY: Clear error message and documentation - ✅ CI STATUS: All quality gates passing (lint, typecheck, unit_tests, coverage) No blocking issues found. Approved for merge. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9000 scheduled this pull request to auto merge when all checks succeed 2026-04-26 18:21:52 +00:00
HAL9000 force-pushed bugfix/m8-action-argument-schema-error-message from a13dcfc2ce to 5827d4f98e 2026-04-27 02:23:29 +00:00 Compare
HAL9000 force-pushed bugfix/m8-action-argument-schema-error-message from 5827d4f98e to 7237b36280 2026-04-27 12:37:47 +00:00 Compare
HAL9000 force-pushed bugfix/m8-action-argument-schema-error-message from 7237b36280 to ebcb8a5437 2026-04-27 17:39:16 +00:00 Compare
HAL9000 force-pushed bugfix/m8-action-argument-schema-error-message from ebcb8a5437 to 7dbecbdf55 2026-04-27 19:47:44 +00:00 Compare
HAL9000 force-pushed bugfix/m8-action-argument-schema-error-message from 7dbecbdf55 to ff62e28d16 2026-04-28 06:09:27 +00:00 Compare
HAL9000 merged commit ff62e28d16 into master 2026-04-28 06:27:11 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
HAL9001
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Milestone
No items
No Milestone v3.7.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#10838
Delete Branch "bugfix/m8-action-argument-schema-error-message"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?