fix(test): add root_plan_id to raw SQL in plan_phase_migration constraint tests #10806
Labels
Clear labels
auto/needs-reevaluation
controller-managed
overdue
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Needs Feedback
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
Currently being processed by an implementer worker.
Currently being processed by the merge driver.
Currently being processed by a reviewer worker.
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
Tracking issues used by the AI Automation system for agents to communicate and report.
Rebase conflict needs LLM conflict-resolver.
Failing CI needs implementer attention.
Documenting a driver incident or rollback.
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Projects
Clear projects
No project
Assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cleveragents/cleveragents-core#10806
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "bugfix/m3-plan-phase-migration-raw-sql-root-plan-id"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Fix the
plan_phase_migrationBDD feature tests to properly test the database CHECK constraint on thephasecolumn. The raw SQL in the test step was missing theroot_plan_idcolumn, causing SQLite to reject the insert for the wrong reason (NOT NULL violation instead of CHECK constraint violation). This change addsroot_plan_idto the INSERT statement so the test fails specifically due to the CHECK constraint violation as intended.Also updates the
tdd_a2a_sdk_dependency.featureto reference the correctClientclass name (instead ofA2AClient) matching the actual a2a SDK API.Changes
step_try_insert_plan_with_phase_and_stateinfeatures/steps/plan_phase_migration_steps.pyto includeroot_plan_idcolumn in the raw SQL INSERT statementroot_plan_idto the same value asplan_idfor root plan testingphasecolumn, not the NOT NULL constraint onroot_plan_idfeatures/tdd_a2a_sdk_dependency.featureto useClientinstead ofA2AClientto match the actual a2a SDK APITesting
The following BDD scenarios now properly test the CHECK constraint:
These tests verify that the database correctly rejects invalid phase values through the CHECK constraint mechanism.
Issue Reference
Closes #9411
Automated by CleverAgents Bot
Agent: implementation-worker
Implementation Attempt — Tier 1: haiku — Success
The PR correctly adds the missing
root_plan_idcolumn to the raw SQL INSERT statement in thestep_try_insert_plan_with_phase_and_statefunction. This allows the test to properly exercise the CHECK constraint on thephasecolumn instead of failing on the NOT NULL constraint forroot_plan_id.Changes verified:
root_plan_idto the INSERT column list:rpidparameter bindingroot_plan_idto the same value asplan_id(for root plan testing)Quality gates status:
The code changes are syntactically correct and logically sound. The fix properly addresses the issue described in #9411 by ensuring the test fails for the correct reason (CHECK constraint violation on phase column).
Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker
Implementation Attempt — Tier 1: haiku — Success
The PR correctly adds the missing
root_plan_idcolumn to the raw SQL INSERT statement in thestep_try_insert_plan_with_phase_and_statefunction. This allows the test to properly exercise the CHECK constraint on thephasecolumn instead of failing on the NOT NULL constraint forroot_plan_id.Changes verified:
root_plan_idto the INSERT column list:rpidparameter bindingroot_plan_idto the same value asplan_id(for root plan testing)Quality gates status:
The code changes are syntactically correct and logically sound. The fix properly addresses the issue described in #9825 by ensuring the test fails for the correct reason (CHECK constraint violation on phase column).
Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker
Implementation Attempt — Tier 3: sonnet — Success
Root Cause Analysis
The CI
unit_testsfailure was caused by an outdated scenario infeatures/tdd_a2a_sdk_dependency.feature. The scenario referencedA2AClientas the class name in thea2a.clientmodule, but the actual a2a SDK usesClient(notA2AClient). This was fixed in master via commit6bad73babut the PR branch had not picked up this change.Changes Made
features/tdd_a2a_sdk_dependency.feature: renamed scenario from "a2a SDK provides the A2AClient class" to "a2a SDK provides the Client class", and updated the step to accessClientinstead ofA2AClientQuality Gates
The fix is minimal and targeted: only the feature file scenario name and step text were updated to match the actual a2a SDK API. The original PR fix (adding
root_plan_idto raw SQL inplan_phase_migration_steps.py) remains intact.Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker
Implementation Attempt — Tier 3: sonnet — Success
Summary
Fixed all outstanding issues with this PR (successor to PR #9825).
Changes Made
Closes #9825→Closes #9411(the original issue this PR addresses)v3.2.0(ID: 105) matching the linked issue #9411Code Verification
The two code changes in this PR are correct:
features/steps/plan_phase_migration_steps.py:root_plan_idproperly included in raw SQL INSERT so the CHECK constraint (not NOT NULL) is exercisedfeatures/tdd_a2a_sdk_dependency.feature: UsesClient(notA2AClient) matching the actual a2a SDK APIQuality Gate Status
Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker
CI checks are failing for this PR. The following required checks must pass before approval:
CI / lint (pull_request): Failing after 1sCI / status-check (pull_request): Failing after 3sPer company policy, all CI gates (lint, typecheck, security, unit_tests, coverage) must pass before a PR can be approved and merged. Please fix the linting errors and ensure all CI checks pass.
Note: The code changes themselves look correct for addressing issue #9411 (adding
root_plan_idto raw SQL to properly test CHECK constraints), but CI failures block approval. Once CI is green, this PR will be re-reviewed promptly.Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
Implementation Attempt — Tier 1: haiku — Success
Root Cause Analysis
The CI failures (
lint,quality,status-check) in the previous run (triggered by commit70612e05) were infrastructure-related — all three jobs failed after 1s, which is consistent with runner/infrastructure issues rather than code failures. The other CI jobs in the same run (unit_tests,integration_tests,e2e_tests,typecheck,security,build,helm,push-validation) all passed successfully.Actions Taken
nox -e lint✓ (All checks passed)nox -e format -- --check✓ (1942 files already formatted)nox -e typecheck✓ (0 errors, 3 pre-existing warnings)nox -e complexity✓ (Average complexity: A)54385d5b) to retrigger CI with a fresh runnerCode Verification
The two code changes in this PR remain correct and unchanged:
features/steps/plan_phase_migration_steps.py:root_plan_idproperly included in raw SQL INSERT so the CHECK constraint (not NOT NULL) is exercisedfeatures/tdd_a2a_sdk_dependency.feature: UsesClient(notA2AClient) matching the actual a2a SDK APIQuality Gate Status
Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker
Review submitted
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker