fix(ci): correct invalid workflow configuration in master.yml #10805

Merged
HAL9000 merged 1 commit from bugfix/m3-fix-master-yml-ci-config into master 2026-04-21 10:37:41 +00:00
Member

Summary

Fixes five bugs in .forgejo/workflows/master.yml that rendered the CI workflow invalid or non-functional.

Changes

1. Add pull_request trigger

Add the missing pull request trigger since the regression job will run on pr.

2. Removed undefined needs dependencies from benchmark-regression

The job declared needs: [lint, typecheck, security, quality], but none of those jobs exist in master.yml (they live in ci.yml). This made the workflow structurally invalid and would be rejected by Forgejo Actions at parse time.

4. Fixed rentention-days typo → retention-days (both jobs)

The misspelling caused the artifact retention policy to be silently ignored in both benchmark-regression and benchmark-publish.

6. Fixed step name typo in benchmark-publish

Run asv ia noxRun asv via nox (missing "v").

Validation

The fixed YAML was validated with:

python3 -c "import yaml; yaml.safe_load(open('.forgejo/workflows/master.yml'))"

No parse errors. Both jobs now share the same push-only if condition.

Closes #10804

## Summary Fixes five bugs in `.forgejo/workflows/master.yml` that rendered the CI workflow invalid or non-functional. ## Changes ### 1. Add `pull_request` trigger Add the missing pull request trigger since the regression job will run on pr. ### 2. Removed undefined `needs` dependencies from `benchmark-regression` The job declared `needs: [lint, typecheck, security, quality]`, but none of those jobs exist in `master.yml` (they live in `ci.yml`). This made the workflow structurally invalid and would be rejected by Forgejo Actions at parse time. ### 4. Fixed `rentention-days` typo → `retention-days` (both jobs) The misspelling caused the artifact retention policy to be silently ignored in both `benchmark-regression` and `benchmark-publish`. ### 6. Fixed step name typo in `benchmark-publish` `Run asv ia nox` → `Run asv via nox` (missing "v"). ## Validation The fixed YAML was validated with: ``` python3 -c "import yaml; yaml.safe_load(open('.forgejo/workflows/master.yml'))" ``` No parse errors. Both jobs now share the same `push`-only `if` condition. ## Related Closes #10804
HAL9000 scheduled this pull request to auto merge when all checks succeed 2026-04-21 06:23:30 +00:00
hurui200320 force-pushed bugfix/m3-fix-master-yml-ci-config from c16bac671d
Some checks failed
CI / benchmark-regression (pull_request) Waiting to run
CI / benchmark-publish (pull_request) Waiting to run
CI / push-validation (pull_request) Successful in 24s
CI / helm (pull_request) Successful in 33s
CI / build (pull_request) Successful in 3m46s
CI / lint (pull_request) Successful in 3m58s
CI / quality (pull_request) Successful in 4m21s
CI / security (pull_request) Successful in 4m39s
CI / integration_tests (pull_request) Failing after 4m39s
CI / typecheck (pull_request) Successful in 4m40s
CI / e2e_tests (pull_request) Successful in 6m59s
CI / unit_tests (pull_request) Successful in 8m43s
CI / docker (pull_request) Successful in 1m40s
CI / coverage (pull_request) Successful in 16m25s
CI / status-check (pull_request) Failing after 3s
to fe485d8aed
Some checks are pending
CI / lint (pull_request) Has started running
CI / typecheck (pull_request) Has started running
CI / coverage (pull_request) Blocked by required conditions
CI / docker (pull_request) Blocked by required conditions
CI / status-check (pull_request) Blocked by required conditions
CI / security (pull_request) Has started running
CI / quality (pull_request) Has started running
CI / unit_tests (pull_request) Has started running
CI / integration_tests (pull_request) Has started running
CI / e2e_tests (pull_request) Has started running
CI / build (pull_request) Has started running
CI / helm (pull_request) Successful in 33s
CI / push-validation (pull_request) Successful in 24s
2026-04-21 07:07:31 +00:00
Compare
hurui200320 2026-04-21 07:07:57 +00:00
hurui200320 added this to the v3.2.0 milestone 2026-04-21 07:08:09 +00:00
hurui200320 force-pushed bugfix/m3-fix-master-yml-ci-config from fe485d8aed
Some checks are pending
CI / lint (pull_request) Has started running
CI / typecheck (pull_request) Has started running
CI / coverage (pull_request) Blocked by required conditions
CI / docker (pull_request) Blocked by required conditions
CI / status-check (pull_request) Blocked by required conditions
CI / security (pull_request) Has started running
CI / quality (pull_request) Has started running
CI / unit_tests (pull_request) Has started running
CI / integration_tests (pull_request) Has started running
CI / e2e_tests (pull_request) Has started running
CI / build (pull_request) Has started running
CI / helm (pull_request) Successful in 33s
CI / push-validation (pull_request) Successful in 24s
to 7368c7bfa9
All checks were successful
CI / helm (pull_request) Successful in 37s
CI / push-validation (pull_request) Successful in 23s
CI / build (pull_request) Successful in 3m36s
CI / quality (pull_request) Successful in 4m17s
CI / lint (pull_request) Successful in 4m23s
CI / typecheck (pull_request) Successful in 4m38s
CI / security (pull_request) Successful in 4m42s
CI / e2e_tests (pull_request) Successful in 7m42s
CI / unit_tests (pull_request) Successful in 8m38s
CI / docker (pull_request) Successful in 1m37s
CI / integration_tests (pull_request) Successful in 10m35s
CI / coverage (pull_request) Successful in 14m54s
CI / status-check (pull_request) Successful in 3s
2026-04-21 07:09:28 +00:00
Compare
hurui200320 force-pushed bugfix/m3-fix-master-yml-ci-config from 7368c7bfa9
All checks were successful
CI / helm (pull_request) Successful in 37s
CI / push-validation (pull_request) Successful in 23s
CI / build (pull_request) Successful in 3m36s
CI / quality (pull_request) Successful in 4m17s
CI / lint (pull_request) Successful in 4m23s
CI / typecheck (pull_request) Successful in 4m38s
CI / security (pull_request) Successful in 4m42s
CI / e2e_tests (pull_request) Successful in 7m42s
CI / unit_tests (pull_request) Successful in 8m38s
CI / docker (pull_request) Successful in 1m37s
CI / integration_tests (pull_request) Successful in 10m35s
CI / coverage (pull_request) Successful in 14m54s
CI / status-check (pull_request) Successful in 3s
to b3b2e69723
Some checks are pending
CI / benchmark-regression (pull_request) Waiting to run
CI / benchmark-publish (pull_request) Waiting to run
CI / push-validation (pull_request) Successful in 24s
CI / helm (pull_request) Successful in 43s
CI / build (pull_request) Successful in 4m2s
CI / lint (pull_request) Successful in 4m7s
CI / typecheck (pull_request) Successful in 4m35s
CI / quality (pull_request) Successful in 4m44s
CI / security (pull_request) Successful in 4m46s
CI / e2e_tests (pull_request) Successful in 7m29s
CI / integration_tests (pull_request) Successful in 7m44s
CI / unit_tests (pull_request) Successful in 9m8s
CI / docker (pull_request) Successful in 1m37s
CI / coverage (pull_request) Successful in 14m57s
CI / status-check (pull_request) Successful in 4s
2026-04-21 08:00:29 +00:00
Compare
hurui200320 force-pushed bugfix/m3-fix-master-yml-ci-config from b3b2e69723
Some checks are pending
CI / benchmark-regression (pull_request) Waiting to run
CI / benchmark-publish (pull_request) Waiting to run
CI / push-validation (pull_request) Successful in 24s
CI / helm (pull_request) Successful in 43s
CI / build (pull_request) Successful in 4m2s
CI / lint (pull_request) Successful in 4m7s
CI / typecheck (pull_request) Successful in 4m35s
CI / quality (pull_request) Successful in 4m44s
CI / security (pull_request) Successful in 4m46s
CI / e2e_tests (pull_request) Successful in 7m29s
CI / integration_tests (pull_request) Successful in 7m44s
CI / unit_tests (pull_request) Successful in 9m8s
CI / docker (pull_request) Successful in 1m37s
CI / coverage (pull_request) Successful in 14m57s
CI / status-check (pull_request) Successful in 4s
to b56abc4fac
Some checks failed
CI / push-validation (pull_request) Successful in 23s
CI / helm (pull_request) Successful in 34s
CI / build (pull_request) Successful in 3m48s
CI / lint (pull_request) Successful in 3m55s
CI / quality (pull_request) Successful in 4m20s
CI / typecheck (pull_request) Successful in 4m35s
CI / security (pull_request) Successful in 4m42s
CI / e2e_tests (pull_request) Successful in 7m7s
CI / unit_tests (pull_request) Successful in 7m16s
CI / integration_tests (pull_request) Successful in 7m47s
CI / docker (pull_request) Successful in 1m37s
CI / coverage (pull_request) Successful in 15m4s
CI / status-check (pull_request) Successful in 3s
CI / benchmark-regression (push) Waiting to run
CI / benchmark-publish (push) Waiting to run
CI / push-validation (push) Successful in 23s
CI / helm (push) Successful in 30s
CI / build (push) Successful in 3m51s
CI / lint (push) Successful in 3m57s
CI / quality (push) Successful in 4m21s
CI / security (push) Successful in 4m31s
CI / typecheck (push) Successful in 4m41s
CI / e2e_tests (push) Successful in 7m15s
CI / integration_tests (push) Successful in 7m52s
CI / unit_tests (push) Successful in 9m0s
CI / docker (push) Successful in 1m36s
CI / coverage (push) Successful in 14m58s
CI / status-check (push) Successful in 3s
CI / benchmark-regression (pull_request) Has been cancelled
CI / benchmark-publish (pull_request) Has been cancelled
2026-04-21 10:17:48 +00:00
Compare
HAL9000 merged commit b56abc4fac into master 2026-04-21 10:37:41 +00:00
hurui200320 deleted branch bugfix/m3-fix-master-yml-ci-config 2026-04-21 10:57:03 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
cleveragents/cleveragents-core!10805
No description provided.