fix(ci): correct invalid workflow configuration in master.yml #10805

Merged
HAL9000 merged 1 commits from bugfix/m3-fix-master-yml-ci-config into master 2026-04-21 10:37:41 +00:00
Member

Summary

Fixes five bugs in .forgejo/workflows/master.yml that rendered the CI workflow invalid or non-functional.

Changes

1. Add pull_request trigger

Add the missing pull request trigger since the regression job will run on pr.

2. Removed undefined needs dependencies from benchmark-regression

The job declared needs: [lint, typecheck, security, quality], but none of those jobs exist in master.yml (they live in ci.yml). This made the workflow structurally invalid and would be rejected by Forgejo Actions at parse time.

4. Fixed rentention-days typo → retention-days (both jobs)

The misspelling caused the artifact retention policy to be silently ignored in both benchmark-regression and benchmark-publish.

6. Fixed step name typo in benchmark-publish

Run asv ia noxRun asv via nox (missing "v").

Validation

The fixed YAML was validated with:

python3 -c "import yaml; yaml.safe_load(open('.forgejo/workflows/master.yml'))"

No parse errors. Both jobs now share the same push-only if condition.

Related

Closes #10804

## Summary Fixes five bugs in `.forgejo/workflows/master.yml` that rendered the CI workflow invalid or non-functional. ## Changes ### 1. Add `pull_request` trigger Add the missing pull request trigger since the regression job will run on pr. ### 2. Removed undefined `needs` dependencies from `benchmark-regression` The job declared `needs: [lint, typecheck, security, quality]`, but none of those jobs exist in `master.yml` (they live in `ci.yml`). This made the workflow structurally invalid and would be rejected by Forgejo Actions at parse time. ### 4. Fixed `rentention-days` typo → `retention-days` (both jobs) The misspelling caused the artifact retention policy to be silently ignored in both `benchmark-regression` and `benchmark-publish`. ### 6. Fixed step name typo in `benchmark-publish` `Run asv ia nox` → `Run asv via nox` (missing "v"). ## Validation The fixed YAML was validated with: ``` python3 -c "import yaml; yaml.safe_load(open('.forgejo/workflows/master.yml'))" ``` No parse errors. Both jobs now share the same `push`-only `if` condition. ## Related Closes #10804
HAL9000 scheduled this pull request to auto merge when all checks succeed 2026-04-21 06:23:30 +00:00
hurui200320 force-pushed bugfix/m3-fix-master-yml-ci-config from c16bac671d to fe485d8aed 2026-04-21 07:07:31 +00:00 Compare
hurui200320 requested review from HAL9000 2026-04-21 07:07:57 +00:00
hurui200320 requested review from HAL9001 2026-04-21 07:07:58 +00:00
hurui200320 added the
Type
Testing
label 2026-04-21 07:08:06 +00:00
hurui200320 added this to the v3.2.0 milestone 2026-04-21 07:08:09 +00:00
hurui200320 force-pushed bugfix/m3-fix-master-yml-ci-config from fe485d8aed to 7368c7bfa9 2026-04-21 07:09:28 +00:00 Compare
hurui200320 added the
Priority
CI Blocker
label 2026-04-21 07:09:48 +00:00
hurui200320 force-pushed bugfix/m3-fix-master-yml-ci-config from 7368c7bfa9 to b3b2e69723 2026-04-21 08:00:29 +00:00 Compare
hamza.khyari approved these changes 2026-04-21 10:16:41 +00:00
hurui200320 force-pushed bugfix/m3-fix-master-yml-ci-config from b3b2e69723 to b56abc4fac 2026-04-21 10:17:48 +00:00 Compare
HAL9000 merged commit b56abc4fac into master 2026-04-21 10:37:41 +00:00
hurui200320 deleted branch bugfix/m3-fix-master-yml-ci-config 2026-04-21 10:57:03 +00:00
Sign in to join this conversation.
2 Participants
Notifications
Due Date
No due date set.
Reference: cleveragents/cleveragents-core#10805