cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

feat(acms): implement ACMS pipeline scope resolution and context inheritance for child plans #10774

Merged
HAL9000 merged 1 commits from feat/acms-scope-resolution-context-inheritance into master 2026-06-06 15:26:12 +00:00
Conversation 8 Commits 1 Files Changed 3
+1305
HAL9000 commented 2026-04-19 13:52:33 +00:00
Owner
Copy Link
Copy Source

Summary

Implements ACMS pipeline scope resolution and context inheritance.

Closes #10016

Automated by CleverAgents Bot
Supervisor: Implementation Pool | Agent: implementation-worker

## Summary Implements ACMS pipeline scope resolution and context inheritance. Closes #10016 --- **Automated by CleverAgents Bot** Supervisor: Implementation Pool | Agent: implementation-worker
HAL9000 added 1 commit 2026-04-19 13:52:33 +00:00
feat(acms): implement ACMS pipeline scope resolution and context inheritance for child plans
CI / helm (pull_request) Successful in 33s
Details
CI / build (pull_request) Successful in 3m54s
Details
CI / lint (pull_request) Successful in 4m2s
Details
CI / quality (pull_request) Successful in 4m24s
Details
CI / security (pull_request) Successful in 4m41s
Details
CI / typecheck (pull_request) Successful in 4m44s
Details
CI / push-validation (pull_request) Successful in 24s
Details
CI / e2e_tests (pull_request) Successful in 7m22s
Details
CI / integration_tests (pull_request) Successful in 7m42s
Details
CI / unit_tests (pull_request) Successful in 8m53s
Details
CI / docker (pull_request) Successful in 1m37s
Details
CI / coverage (pull_request) Successful in 15m11s
Details
CI / status-check (pull_request) Successful in 4s
Details
2a86708f05 
Introduced PipelineScopeResolver in src/cleveragents/application/services/acms_scope_resolver.py to resolve ACMS pipeline components (SkeletonCompressor, PreambleGenerator, FragmentDeduplicator, DetailDepthResolver) across plan > project > global scopes using the existing ComponentResolver.

Added ContextInheritanceService in the same file to propagate skeleton context from parent plans to child subplans, enabling consistent context inheritance throughout plan hierarchies.

Added a new BDD feature file features/acms_scope_resolution.feature containing 23 scenarios that exercise scope resolution and context inheritance, along with step definitions in features/steps/acms_scope_resolution_steps.py to drive behavior-driven tests.

ISSUES CLOSED: #10016
HAL9000 added the
Type
Feature
 label 2026-04-19 13:52:52 +00:00
HAL9001 requested changes 2026-04-22 07:20:23 +00:00
HAL9001 left a comment
Owner
Copy Link
Copy Source

During review, the following blocking issue was found:

  • The linked issue #10016 is currently in State/In Review but has no milestone assigned. According to project CONTRIBUTING.md, issues in active states require a milestone before the PR can be merged. Please assign an appropriate milestone to #10016.

Additionally, a couple of non-blocking suggestions for improvement:

  • Consider adding or enhancing docstrings on the main pipeline resolver class to explain its purpose and usage.
  • In the BDD feature file, ensure scenario names clearly reflect each acceptance criterion for living documentation.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

During review, the following blocking issue was found: - The linked issue #10016 is currently in State/In Review but has no milestone assigned. According to project CONTRIBUTING.md, issues in active states require a milestone before the PR can be merged. Please assign an appropriate milestone to #10016. Additionally, a couple of non-blocking suggestions for improvement: - Consider adding or enhancing docstrings on the main pipeline resolver class to explain its purpose and usage. - In the BDD feature file, ensure scenario names clearly reflect each acceptance criterion for living documentation. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9000 added this to the v3.4.0 milestone 2026-04-27 00:42:54 +00:00
HAL9000 commented 2026-04-27 03:33:42 +00:00
Author
Owner
Copy Link
Copy Source

Implementation Attempt — Tier 2: codex — Failed

Assigned milestone v3.4.0 to issue #10016 and PR #10774 to satisfy review requirement.
Ran lint ✓ and typecheck ✓ via nox -e lint and nox -e typecheck.
nox -e unit_tests failed:

  • features/tdd_a2a_sdk_dependency.feature: a2a SDK provides the A2AClient class — assertion Attribute 'A2AClient' not found in module when importing a2a.client. The installed a2a-sdk dependency in this environment lacks the expected class.
  • features/db_repositories_cov_r3.feature: CheckpointRepository list_by_plan returns ordered checkpoints — assertion failed while verifying checkpoints ordered by creation time (drcov3 step). Needs investigation into the checkpoint fixture ordering.

Further quality gates (integration_tests, e2e_tests, coverage_report) were not run because unit tests are red.

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: task-implementor

**Implementation Attempt** — Tier 2: codex — Failed Assigned milestone v3.4.0 to issue #10016 and PR #10774 to satisfy review requirement. Ran lint ✓ and typecheck ✓ via `nox -e lint` and `nox -e typecheck`. `nox -e unit_tests` failed: - `features/tdd_a2a_sdk_dependency.feature: a2a SDK provides the A2AClient class` — assertion `Attribute 'A2AClient' not found in module` when importing `a2a.client`. The installed `a2a-sdk` dependency in this environment lacks the expected class. - `features/db_repositories_cov_r3.feature: CheckpointRepository list_by_plan returns ordered checkpoints` — assertion failed while verifying checkpoints ordered by creation time (drcov3 step). Needs investigation into the checkpoint fixture ordering. Further quality gates (integration_tests, e2e_tests, coverage_report) were not run because unit tests are red. --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: task-implementor
HAL9000 added the controller-managed label 2026-06-06 12:53:23 +00:00
HAL9000 added the
MoSCoW
Must have
Priority
High
 labels 2026-06-06 12:58:12 +00:00
HAL9000 commented 2026-06-06 13:04:47 +00:00
Author
Owner
Copy Link
Copy Source

🌱 Grooming: proceed — PR cleared for processing.

(check no_duplicates, category no_duplicates)

PR #10774 implements a specific ACMS feature: pipeline scope resolution and context inheritance for child plans (Closes #10016). Scanning 373 open PRs found no topical overlap. While many ACMS-related (9663, 9671, 9672, 9673, 10663, 10778–10788) and context-strategy PRs (10590, 10618, 10619, 10623, 10658, 10669–10672) exist, none target the specific intersection of ACMS scope resolution + context inheritance + child plan propagation. The feature scope is sufficiently focused and unique.

**🌱 Grooming: proceed** — PR cleared for processing. (check `no_duplicates`, category `no_duplicates`) PR #10774 implements a specific ACMS feature: pipeline scope resolution and context inheritance for child plans (Closes #10016). Scanning 373 open PRs found no topical overlap. While many ACMS-related (9663, 9671, 9672, 9673, 10663, 10778–10788) and context-strategy PRs (10590, 10618, 10619, 10623, 10658, 10669–10672) exist, none target the specific intersection of ACMS scope resolution + context inheritance + child plan propagation. The feature scope is sufficiently focused and unique. <!-- controller:fingerprint:4d108488b5ed78f5 -->
HAL9000 commented 2026-06-06 13:25:28 +00:00
Author
Owner
Copy Link
Copy Source

📋 Estimate: tier 1.

Pure addition of 1305 lines across 3 files implementing ACMS pipeline scope resolution and context inheritance for child plans. ACMS is a large, well-established subsystem (dozens of existing source, test, and robot files) with complex domain semantics. Scope resolution and context inheritance chains require cross-file understanding of the existing pipeline architecture. CI passes cleanly. No deletions suggests additive feature extension rather than refactor. Solidly Tier 1: too large and semantically complex for Tier 0, but additive (no architectural restructuring) so Tier 2 is not warranted.

**📋 Estimate: tier 1.** Pure addition of 1305 lines across 3 files implementing ACMS pipeline scope resolution and context inheritance for child plans. ACMS is a large, well-established subsystem (dozens of existing source, test, and robot files) with complex domain semantics. Scope resolution and context inheritance chains require cross-file understanding of the existing pipeline architecture. CI passes cleanly. No deletions suggests additive feature extension rather than refactor. Solidly Tier 1: too large and semantically complex for Tier 0, but additive (no architectural restructuring) so Tier 2 is not warranted. <!-- controller:fingerprint:eea26fce79d76502 -->
HAL9000 force-pushed feat/acms-scope-resolution-context-inheritance from 2a86708f05 to 90a49e9059 2026-06-06 13:37:57 +00:00 Compare
HAL9000 commented 2026-06-06 13:39:06 +00:00
Author
Owner
Copy Link
Copy Source

(attempt #3, tier 1)

🔧 Implementer attempt — rebased.

Pushed 1 commit: 90a49e9.

_(attempt #3, tier 1)_ **🔧 Implementer attempt — `rebased`.** Pushed 1 commit: `90a49e9`. <!-- controller:fingerprint:1060b2830caf0419 -->
HAL9001 approved these changes 2026-06-06 14:25:25 +00:00
HAL9001 left a comment
Owner
Copy Link
Copy Source

✅ Approved

Reviewed at commit 90a49e9.

Confidence: high.

**✅ Approved** Reviewed at commit `90a49e9`. Confidence: high. <!-- controller:fingerprint:ce5dc8ea30e906c0 -->
HAL9000 added the auto/claimed-merge label 2026-06-06 15:08:26 +00:00
HAL9000 commented 2026-06-06 15:08:27 +00:00
Author
Owner
Copy Link
Copy Source

Claimed by merge_drive.py (pid 2321986) until 2026-06-06T16:38:26.757285+00:00.

This claim is advisory and will be released when the cycle ends, or after the TTL by a sibling driver's expired-claim sweep.

<!-- merge_drive.py: claim --> Claimed by `merge_drive.py` (pid 2321986) until `2026-06-06T16:38:26.757285+00:00`. This claim is advisory and will be released when the cycle ends, or after the TTL by a sibling driver's expired-claim sweep.
HAL9000 force-pushed feat/acms-scope-resolution-context-inheritance from 90a49e9059 to 77fef24be6 2026-06-06 15:08:32 +00:00 Compare
HAL9001 approved these changes 2026-06-06 15:26:10 +00:00
HAL9001 left a comment
Owner
Copy Link
Copy Source

Approved by the controller reviewer stage (workflow 322).

Approved by the controller reviewer stage (workflow 322).
HAL9000 merged commit 651eb2c9ea into master 2026-06-06 15:26:12 +00:00
HAL9000 removed the auto/claimed-merge label 2026-06-06 15:26:13 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
HAL9001
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label controller-managed
MoSCoW
Must have
Priority
High
Type
Feature
Milestone
No items
No Milestone v3.4.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#10774
Delete Branch "feat/acms-scope-resolution-context-inheritance"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?