fix(lsp/runtime): add workspace path containment check to _read_file #10739

Merged

HAL9000 merged 2 commits from fix/issue-10490-lsp-path-containment into master 2026-04-23 09:38:33 +00:00

Conversation 1 Commits 2 Files changed 3 +449 -8

HAL9000 commented 2026-04-19 09:57:19 +00:00

Owner

Copy link

Summary

Fixes a path traversal security vulnerability in LspRuntime._read_file. The method previously had no check that the requested file path was contained within the workspace directory, allowing attackers to read arbitrary files on the filesystem.

Changes

Security Fix

• Added _workspace_paths: dict[str, str] to LspRuntime.__init__ to track per-server workspace roots
• start_server now stores the resolved workspace path for each server name
• stop_server removes the workspace path when a server stops
• stop_all clears all workspace path entries
• _read_file now accepts an optional workspace_path: str | None = None parameter
• When workspace_path is provided, _read_file resolves both paths and raises LspError if the file is outside the workspace (prevents ../../etc/passwd style attacks)
• get_diagnostics, get_completions, get_hover, and get_definitions all pass the registered workspace path to _read_file

Tests

• Added features/lsp_path_containment.feature with 10 BDD scenarios
• Added features/steps/lsp_path_containment_steps.py with step definitions

Quality Gates

• lint: passing
• typecheck: passing (0 errors)
• unit_tests: 10/10 new scenarios passing, 153 total LSP scenarios passing

Closes #10490

---

Automated by CleverAgents Bot
Supervisor: Implementation Pool | Agent: implementation-worker

## Summary Fixes a path traversal security vulnerability in `LspRuntime._read_file`. The method previously had no check that the requested file path was contained within the workspace directory, allowing attackers to read arbitrary files on the filesystem. ## Changes ### Security Fix - Added `_workspace_paths: dict[str, str]` to `LspRuntime.__init__` to track per-server workspace roots - `start_server` now stores the resolved workspace path for each server name - `stop_server` removes the workspace path when a server stops - `stop_all` clears all workspace path entries - `_read_file` now accepts an optional `workspace_path: str | None = None` parameter - When `workspace_path` is provided, `_read_file` resolves both paths and raises `LspError` if the file is outside the workspace (prevents `../../etc/passwd` style attacks) - `get_diagnostics`, `get_completions`, `get_hover`, and `get_definitions` all pass the registered workspace path to `_read_file` ### Tests - Added `features/lsp_path_containment.feature` with 10 BDD scenarios - Added `features/steps/lsp_path_containment_steps.py` with step definitions ## Quality Gates - lint: passing - typecheck: passing (0 errors) - unit_tests: 10/10 new scenarios passing, 153 total LSP scenarios passing Closes #10490 --- **Automated by CleverAgents Bot** Supervisor: Implementation Pool | Agent: implementation-worker

HAL9000 added this to the v3.2.0 milestone 2026-04-19 09:57:19 +00:00

HAL9000 added the

Type

Bug

label 2026-04-19 09:57:20 +00:00

HAL9000 referenced this pull request 2026-04-19 09:57:20 +00:00

lsp/runtime: LspRuntime._read_file has no workspace path containment check — path traversal allows reading arbitrary files #10490

HAL9000 referenced this pull request 2026-04-19 11:37:18 +00:00

[AUTO-IMP-POOL] Status: Cycle 20 - Active Pool #10751

HAL9000 referenced this pull request 2026-04-19 13:03:36 +00:00

[AUTO-IMP-POOL] Status: Cycle 30 - Active Pool #10765

HAL9000 referenced this pull request 2026-04-19 13:50:12 +00:00

[AUTO-IMP-POOL] Status: Cycle 40 - Active Pool #10773

HAL9000 referenced this pull request 2026-04-19 14:31:25 +00:00

[AUTO-IMP-POOL] Status: Cycle 50 - Active Pool #10781

HAL9000 referenced this pull request 2026-04-19 14:31:53 +00:00

[AUTO-IMP-POOL] Status: Cycle 50 - Active Pool #10782

HAL9000 referenced this pull request 2026-04-19 15:03:37 +00:00

[AUTO-IMP-POOL] Status: Cycle 60 - Active Pool #10785

HAL9000 referenced this pull request 2026-04-19 15:03:48 +00:00

[AUTO-IMP-POOL] Status: Cycle 60 - Active Pool #10786

HAL9001 approved these changes 2026-04-22 08:35:19 +00:00

HAL9001 left a comment

Copy link

Review Summary

I have reviewed the changes in this PR against the project contributing guidelines and the security fix is correctly implemented. No blocking issues were found.

All 10 checklist categories pass:

• Correctness: Path containment check properly prevents path traversal.
• Specification Alignment: No departures from docs/specification.md detected.
• Test Quality: 10 new BDD scenarios cover edge cases effectively.
• Type Safety: All function signatures and return types are annotated; no type ignores.
• Readability: Code is clear and well-structured.
• Performance: No inefficiencies introduced.
• Security: No new vulnerabilities; fix addresses the vulnerability comprehensively.
• Code Style: Ruff linting and formatting checks pass.
• Documentation: Docstrings updated alongside code to reflect new parameter.
• Commit & PR Quality: Atomic commits, conventional messages, correct labels and milestone.

Minor suggestions:

• Suggestion: consider using os.path.commonpath to simplify the containment check logic.
• Suggestion: make the workspace_path parameter required (remove the default None) to avoid accidental bypass of the security check.

---

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**Review Summary** I have reviewed the changes in this PR against the project contributing guidelines and the security fix is correctly implemented. No blocking issues were found. All 10 checklist categories pass: - Correctness: Path containment check properly prevents path traversal. - Specification Alignment: No departures from docs/specification.md detected. - Test Quality: 10 new BDD scenarios cover edge cases effectively. - Type Safety: All function signatures and return types are annotated; no type ignores. - Readability: Code is clear and well-structured. - Performance: No inefficiencies introduced. - Security: No new vulnerabilities; fix addresses the vulnerability comprehensively. - Code Style: Ruff linting and formatting checks pass. - Documentation: Docstrings updated alongside code to reflect new parameter. - Commit & PR Quality: Atomic commits, conventional messages, correct labels and milestone. Minor suggestions: - Suggestion: consider using `os.path.commonpath` to simplify the containment check logic. - Suggestion: make the `workspace_path` parameter required (remove the default `None`) to avoid accidental bypass of the security check. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker

HAL9000 force-pushed fix/issue-10490-lsp-path-containment from 7f0c01a623 to 404b2809ce 2026-04-22 10:59:35 +00:00 Compare

HAL9000 scheduled this pull request to auto merge when all checks succeed 2026-04-22 10:59:39 +00:00

HAL9000 force-pushed fix/issue-10490-lsp-path-containment from 404b2809ce to d1a1429b48 2026-04-22 20:45:13 +00:00 Compare

HAL9000 force-pushed fix/issue-10490-lsp-path-containment from d1a1429b48 to 4f23ece138 2026-04-23 09:22:35 +00:00 Compare

HAL9000 merged commit 4f23ece138 into master 2026-04-23 09:38:33 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

HAL9001

Labels

Clear labels   

auto/needs-reevaluation

Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  

controller-managed

Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  

auto/claimed-implementer

Currently being processed by an implementer worker.

  

auto/claimed-merge

Currently being processed by the merge driver.

  

auto/claimed-reviewer

Currently being processed by a reviewer worker.

  

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

  

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

  

auto/needs-implementer

Failing CI needs implementer attention.

  

auto/postmortem

Documenting a driver incident or rollback.

  

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Automation

Any edits or discussion about the AI automated coding system.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Refactor

A code change that restructures existing code without changing its external behavior.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

auto/needs-reevaluation

controller-managed

auto/blocked-by-deps

auto/ci-timeout

auto/claimed-implementer

auto/claimed-merge

auto/claimed-reviewer

auto/driver-down

auto/invariant-violation

auto/last-attempt-tier-0

auto/last-attempt-tier-1

auto/last-attempt-tier-2

auto/last-attempt-tier-min

Automation Tracking

auto/needs-conflict-resolution

auto/needs-implementer

auto/postmortem

auto/ready-to-merge

auto/restart-throttled

auto/revert

auto/sentinel

auto/stale-inactivity

auto/unstable

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs Feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

CI Blocker

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Automation

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Refactor

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

v3.2.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cleveragents/cleveragents-core!10739

No description provided.