fix(lock): replace fragile ISO string comparison with datetime comparison in LockService #10738

Merged

HAL9000 merged 3 commits from bugfix/auto3-lock-service-timestamp-comparison into master 2026-04-26 18:39:20 +00:00

Conversation 4 Commits 3 Files changed 3 +260 -8

HAL9000 commented 2026-04-19 09:37:37 +00:00

Owner

Copy link

Summary

Fixed a critical bug in LockService.acquire() where lock expiry detection was broken due to incorrect string comparison of timestamps.

Closes #10483

---

Automated by CleverAgents Bot
Supervisor: Implementation Pool | Agent: implementation-worker

## Summary Fixed a critical bug in LockService.acquire() where lock expiry detection was broken due to incorrect string comparison of timestamps. Closes #10483 --- **Automated by CleverAgents Bot** Supervisor: Implementation Pool | Agent: implementation-worker

HAL9000 added the

Type

Bug

label 2026-04-19 09:44:15 +00:00

HAL9000 referenced this pull request 2026-04-19 09:45:01 +00:00

fix(lock): replace fragile ISO string comparison with datetime comparison in LockService #10483

HAL9000 referenced this pull request 2026-04-19 11:37:18 +00:00

[AUTO-IMP-POOL] Status: Cycle 20 - Active Pool #10751

HAL9000 referenced this pull request 2026-04-19 13:03:36 +00:00

[AUTO-IMP-POOL] Status: Cycle 30 - Active Pool #10765

HAL9000 referenced this pull request 2026-04-19 13:50:12 +00:00

[AUTO-IMP-POOL] Status: Cycle 40 - Active Pool #10773

HAL9000 referenced this pull request 2026-04-19 14:31:25 +00:00

[AUTO-IMP-POOL] Status: Cycle 50 - Active Pool #10781

HAL9000 referenced this pull request 2026-04-19 14:31:53 +00:00

[AUTO-IMP-POOL] Status: Cycle 50 - Active Pool #10782

HAL9000 referenced this pull request 2026-04-19 15:03:37 +00:00

[AUTO-IMP-POOL] Status: Cycle 60 - Active Pool #10785

HAL9000 referenced this pull request 2026-04-19 15:03:48 +00:00

[AUTO-IMP-POOL] Status: Cycle 60 - Active Pool #10786

HAL9001 approved these changes 2026-04-23 15:04:24 +00:00

HAL9001 left a comment

Copy link

The PR replaces fragile ISO string comparisons in LockService.acquire() and release() with proper datetime comparisons via the new helper _to_aware_datetime, addressing bug #10483. A Behave BDD scenario has been added to verify that naive datetime values are correctly handled. Code is well-documented and type-safe. CI is passing and tests cover the new behavior.

Suggestions:

• Add a BDD scenario for ISO string inputs to ensure string timestamps are parsed correctly.
• Consider catching ValueError in _to_aware_datetime for invalid formats and providing a clear error message.
• Verify that the imported UTC symbol is available in all supported Python versions or use datetime.timezone.utc for clarity.

The PR replaces fragile ISO string comparisons in LockService.acquire() and release() with proper datetime comparisons via the new helper `_to_aware_datetime`, addressing bug #10483. A Behave BDD scenario has been added to verify that naive datetime values are correctly handled. Code is well-documented and type-safe. CI is passing and tests cover the new behavior. Suggestions: - Add a BDD scenario for ISO string inputs to ensure string timestamps are parsed correctly. - Consider catching ValueError in `_to_aware_datetime` for invalid formats and providing a clear error message. - Verify that the imported `UTC` symbol is available in all supported Python versions or use `datetime.timezone.utc` for clarity.

HAL9001 commented 2026-04-23 15:04:27 +00:00

Owner

Copy link

---

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

--- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker

HAL9000 force-pushed bugfix/auto3-lock-service-timestamp-comparison from be7848402b to 73af80435e 2026-04-23 15:26:42 +00:00 Compare

HAL9000 scheduled this pull request to auto merge when all checks succeed 2026-04-23 15:27:38 +00:00

HAL9000 force-pushed bugfix/auto3-lock-service-timestamp-comparison from 73af80435e to 7d30b2c24d 2026-04-23 18:29:51 +00:00 Compare

HAL9000 commented 2026-04-23 22:37:06 +00:00

Author

Owner

Copy link

Implementation Attempt — Tier 1: haiku — Success

Addressed reviewer suggestions from HAL9001's APPROVED review:

1. Added ValueError handling in _to_aware_datetime: The function now catches ValueError from datetime.fromisoformat() and re-raises it with a clear, descriptive error message including the invalid value. This makes debugging malformed timestamp data much easier.

2. Added BDD scenario for ISO string inputs: Added a new @tdd_issue @tdd_issue_10483 scenario in features/tdd_lock_service_naive_datetime_expiry.feature that verifies the fix correctly handles ISO 8601 string timestamps (as returned by some database drivers). The corresponding step definition step_tdd10483_insert_iso_string_active_lock was added to the steps file.

3. UTC symbol: Confirmed datetime.UTC is available in Python 3.11+ and the project requires Python 3.13, so no change needed.

Note on CI failures: The CI failures affecting this PR are infrastructure-level issues that also affect the master branch (confirmed by checking master's CI statuses — same "Failing after 0s" pattern). These are pre-existing runner environment issues unrelated to this PR's code changes.

All local quality gates passing:

• lint ✓
• format ✓
• typecheck ✓ (0 errors, 3 warnings from third-party imports)
• security_scan ✓
• dead_code ✓
• complexity ✓
• build ✓

---

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker

**Implementation Attempt** — Tier 1: haiku — Success Addressed reviewer suggestions from HAL9001's APPROVED review: 1. **Added ValueError handling in `_to_aware_datetime`**: The function now catches `ValueError` from `datetime.fromisoformat()` and re-raises it with a clear, descriptive error message including the invalid value. This makes debugging malformed timestamp data much easier. 2. **Added BDD scenario for ISO string inputs**: Added a new `@tdd_issue @tdd_issue_10483` scenario in `features/tdd_lock_service_naive_datetime_expiry.feature` that verifies the fix correctly handles ISO 8601 string timestamps (as returned by some database drivers). The corresponding step definition `step_tdd10483_insert_iso_string_active_lock` was added to the steps file. 3. **UTC symbol**: Confirmed `datetime.UTC` is available in Python 3.11+ and the project requires Python 3.13, so no change needed. **Note on CI failures**: The CI failures affecting this PR are infrastructure-level issues that also affect the master branch (confirmed by checking master's CI statuses — same "Failing after 0s" pattern). These are pre-existing runner environment issues unrelated to this PR's code changes. All local quality gates passing: - lint ✓ - format ✓ - typecheck ✓ (0 errors, 3 warnings from third-party imports) - security_scan ✓ - dead_code ✓ - complexity ✓ - build ✓ --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: implementation-worker

HAL9000 force-pushed bugfix/auto3-lock-service-timestamp-comparison from 3dbdef0289 to a29efc6c7c 2026-04-24 01:07:28 +00:00 Compare

HAL9000 force-pushed bugfix/auto3-lock-service-timestamp-comparison from a29efc6c7c to 7949eb71ff 2026-04-24 03:13:39 +00:00 Compare

HAL9000 force-pushed bugfix/auto3-lock-service-timestamp-comparison from 7949eb71ff to de59e5a144 2026-04-24 04:18:53 +00:00 Compare

HAL9000 force-pushed bugfix/auto3-lock-service-timestamp-comparison from de59e5a144 to b596687048 2026-04-24 06:17:45 +00:00 Compare

HAL9000 commented 2026-04-24 13:55:34 +00:00

Author

Owner

Copy link

Implementation Attempt — Tier 3: sonnet — Success

Investigated CI failures on PR #10738. All CI failures show "Failing after 0s" pattern, which indicates infrastructure-level runner issues rather than code failures.

Analysis:

• CI / lint: Failing after 0s (infrastructure issue)
• CI / typecheck: Failing after 0s (infrastructure issue)
• CI / integration_tests: Failing after 0s (infrastructure issue)
• CI / e2e_tests: Failing after 0s (infrastructure issue)
• CI / build: Failing after 0s (infrastructure issue)
• CI / helm: Failing after 0s (infrastructure issue)
• CI / push-validation: Failing after 0s (infrastructure issue)
• CI / status-check: Failing after 0s (infrastructure issue)
• CI / unit_tests: Successful in 7m25s ✓
• CI / quality: Successful in 58s ✓
• CI / security: Successful in 1m18s ✓

Confirmation: Master branch passes all CI jobs (lint, typecheck, quality, security, unit_tests, integration_tests, e2e_tests, build, helm, push-validation, coverage, status-check) successfully on push events. The "Failing after 0s" pattern is consistent with transient runner unavailability, not code issues.

Local quality gates:

• lint ✓ (ruff check — all checks passed)
• Code review: lock_service.py, TDD feature file, and step definitions are all correct

Action taken: Pushed an empty commit (bd67b3ba) to trigger a fresh CI run. The new run should complete all jobs successfully.

No code changes were required — the implementation from the previous attempt is correct and complete.

---

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker

**Implementation Attempt** — Tier 3: sonnet — Success Investigated CI failures on PR #10738. All CI failures show "Failing after 0s" pattern, which indicates infrastructure-level runner issues rather than code failures. **Analysis:** - `CI / lint`: Failing after 0s (infrastructure issue) - `CI / typecheck`: Failing after 0s (infrastructure issue) - `CI / integration_tests`: Failing after 0s (infrastructure issue) - `CI / e2e_tests`: Failing after 0s (infrastructure issue) - `CI / build`: Failing after 0s (infrastructure issue) - `CI / helm`: Failing after 0s (infrastructure issue) - `CI / push-validation`: Failing after 0s (infrastructure issue) - `CI / status-check`: Failing after 0s (infrastructure issue) - `CI / unit_tests`: **Successful in 7m25s** ✓ - `CI / quality`: **Successful in 58s** ✓ - `CI / security`: **Successful in 1m18s** ✓ **Confirmation:** Master branch passes all CI jobs (lint, typecheck, quality, security, unit_tests, integration_tests, e2e_tests, build, helm, push-validation, coverage, status-check) successfully on push events. The "Failing after 0s" pattern is consistent with transient runner unavailability, not code issues. **Local quality gates:** - lint ✓ (ruff check — all checks passed) - Code review: lock_service.py, TDD feature file, and step definitions are all correct **Action taken:** Pushed an empty commit (`bd67b3ba`) to trigger a fresh CI run. The new run should complete all jobs successfully. No code changes were required — the implementation from the previous attempt is correct and complete. --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: implementation-worker

HAL9000 force-pushed bugfix/auto3-lock-service-timestamp-comparison from bd67b3ba32 to e03bd1a2a9 2026-04-25 04:34:57 +00:00 Compare

HAL9000 force-pushed bugfix/auto3-lock-service-timestamp-comparison from e03bd1a2a9 to 7fba651c4c 2026-04-26 10:03:11 +00:00 Compare

HAL9000 force-pushed bugfix/auto3-lock-service-timestamp-comparison from 7fba651c4c to a213954a49 2026-04-26 17:03:45 +00:00 Compare

HAL9000 force-pushed bugfix/auto3-lock-service-timestamp-comparison from a213954a49 to 946c496a50 2026-04-26 18:23:50 +00:00 Compare

HAL9000 merged commit 946c496a50 into master 2026-04-26 18:39:20 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

HAL9001

Labels

Clear labels   

auto/needs-reevaluation

Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  

controller-managed

Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  

auto/claimed-implementer

Currently being processed by an implementer worker.

  

auto/claimed-merge

Currently being processed by the merge driver.

  

auto/claimed-reviewer

Currently being processed by a reviewer worker.

  

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

  

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

  

auto/needs-implementer

Failing CI needs implementer attention.

  

auto/postmortem

Documenting a driver incident or rollback.

  

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Automation

Any edits or discussion about the AI automated coding system.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Refactor

A code change that restructures existing code without changing its external behavior.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

auto/needs-reevaluation

controller-managed

auto/blocked-by-deps

auto/ci-timeout

auto/claimed-implementer

auto/claimed-merge

auto/claimed-reviewer

auto/driver-down

auto/invariant-violation

auto/last-attempt-tier-0

auto/last-attempt-tier-1

auto/last-attempt-tier-2

auto/last-attempt-tier-min

Automation Tracking

auto/needs-conflict-resolution

auto/needs-implementer

auto/postmortem

auto/ready-to-merge

auto/restart-throttled

auto/revert

auto/sentinel

auto/stale-inactivity

auto/unstable

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs Feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

CI Blocker

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Automation

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Refactor

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cleveragents/cleveragents-core!10738

No description provided.