lsp/runtime: add failing test proving LspRuntime._read_file has no workspace path containment check #10736

Merged
HAL9000 merged 3 commits from test/issue-10489-lsp-path-containment-tdd into master 2026-04-26 12:32:43 +00:00

3 Commits

Author SHA1 Message Date
HAL9000 446f447c03 style(test): apply ruff format to tdd_lsp_path_containment_steps.py
CI / push-validation (pull_request) Successful in 24s
CI / helm (pull_request) Successful in 31s
CI / build (pull_request) Successful in 49s
CI / lint (pull_request) Successful in 59s
CI / typecheck (pull_request) Successful in 1m21s
CI / quality (pull_request) Successful in 1m23s
CI / security (pull_request) Successful in 1m43s
CI / e2e_tests (pull_request) Successful in 3m59s
CI / integration_tests (pull_request) Successful in 5m54s
CI / unit_tests (pull_request) Successful in 7m44s
CI / docker (pull_request) Successful in 1m21s
CI / coverage (pull_request) Successful in 11m19s
CI / status-check (pull_request) Successful in 2s
CI / status-check (push) Blocked by required conditions
CI / benchmark-regression (push) Waiting to run
CI / benchmark-publish (push) Waiting to run
CI / lint (push) Successful in 59s
CI / helm (push) Successful in 26s
CI / build (push) Successful in 48s
CI / quality (push) Successful in 1m21s
CI / typecheck (push) Successful in 1m34s
CI / security (push) Successful in 1m34s
CI / push-validation (push) Successful in 21s
CI / coverage (push) Has started running
CI / integration_tests (push) Successful in 3m26s
CI / e2e_tests (push) Successful in 4m21s
CI / unit_tests (push) Successful in 5m10s
CI / docker (push) Successful in 1m29s
CI / benchmark-publish (pull_request) Has been skipped
CI / benchmark-regression (pull_request) Successful in 1h4m13s
2026-04-26 12:19:34 +00:00
HAL9000 e619c1be58 test(lsp/runtime): fix TDD tag to reference bug issue #10490 and add safe-file scenario
Corrected @tdd_issue_10489 → @tdd_issue_10490 so the tag references the
actual bug issue (path traversal vulnerability) rather than the TDD issue
itself.  Added a positive scenario verifying _read_file can still read
files inside the workspace, as suggested in review.

ISSUES CLOSED: #10489
2026-04-26 12:19:34 +00:00
HAL9000 b5110761c2 lsp/runtime: add failing test proving LspRuntime._read_file has no workspace path containment check
Added features/tdd_lsp_path_containment.feature: Introduces a TDD Behave feature with a @tdd_expected_fail scenario to demonstrate that LspRuntime._read_file() does not enforce workspace path containment, guiding a fix.
Added features/steps/tdd_lsp_path_containment_steps.py: Provides step definitions for executing the new test.

ISSUES CLOSED: #10489
2026-04-26 12:19:34 +00:00