fix(error-handling): log exceptions in _compute_actor_impact instead of silently swallowing #10675

Merged
HAL9000 merged 4 commits from fix/v360/compute-actor-impact-exceptions into master 2026-06-06 08:35:28 +00:00

4 Commits

Author SHA1 Message Date
HAL9000 eb454d8421 style(test): apply ruff format to actor_compute_impact_error_handling_steps.py
CI / lint (pull_request) Successful in 53s
CI / typecheck (pull_request) Successful in 1m13s
CI / security (pull_request) Successful in 1m17s
CI / quality (pull_request) Successful in 1m27s
CI / build (pull_request) Successful in 41s
CI / helm (pull_request) Successful in 1m6s
CI / push-validation (pull_request) Successful in 30s
CI / unit_tests (pull_request) Successful in 5m27s
CI / docker (pull_request) Successful in 2m3s
CI / integration_tests (pull_request) Successful in 17m21s
CI / coverage (pull_request) Successful in 11m50s
CI / status-check (pull_request) Successful in 4s
2026-06-06 04:15:16 -04:00
HAL9000 86c6d5e40e fix(error-handling): log exceptions in _compute_actor_impact instead of silently swallowing 2026-06-06 04:15:16 -04:00
Test User 341d912c9a fix(test): add missing 'an actor CLI runner' step definition
The actor_compute_impact_error_handling.feature file references the
'Given an actor CLI runner' step in its Background section, but the
step definition was missing from the step file. This caused the tests
to fail with an undefined step error.

Added the missing step definition that initializes a CliRunner context
for testing. Also removed the unused noqa comment from the CliRunner
import since the import is now used in the step definition.
2026-06-06 04:15:16 -04:00
Test User 67b282bd23 fix(error-handling): log exceptions in _compute_actor_impact instead of silently swallowing
Replace three bare 'except Exception: pass' blocks in _compute_actor_impact()
with proper exception handling that logs at WARNING level with exception type
and message for diagnostics. The function still returns (0, 0, 0) on failure
(graceful degradation) but failures are now visible in logs.

Also adds BDD scenarios covering the error paths (DB unavailable -> warning
logged, counts return 0) and removes the pragma: no cover annotations from
the exception handlers.

ISSUES CLOSED: #8434
2026-06-06 04:15:16 -04:00