fix(tui): use ShellSafetyService regex patterns in looks_dangerous() #10642

Open
HAL9000 wants to merge 4 commits from fix/v370/shell-safety-regex into master

4 Commits

Author SHA1 Message Date
CleverAgents Bot 29c5a2edfa fix(tui): align shell safety regex execution
CI / push-validation (pull_request) Successful in 30s
CI / load-versions (pull_request) Failing after 13m31s
CI / lint (pull_request) Has been cancelled
CI / typecheck (pull_request) Has been cancelled
CI / security (pull_request) Has been cancelled
CI / quality (pull_request) Has been cancelled
CI / unit_tests (pull_request) Has been cancelled
CI / integration_tests (pull_request) Has been cancelled
CI / coverage (pull_request) Has been cancelled
CI / build (pull_request) Has been cancelled
CI / docker (pull_request) Has been cancelled
CI / helm (pull_request) Has been cancelled
CI / status-check (pull_request) Has been cancelled
2026-06-18 06:49:56 -04:00
controller-ci-rerun 8ce8133d2a chore: re-trigger CI [controller]
CI / load-versions (pull_request) Successful in 25s
CI / push-validation (pull_request) Successful in 22s
CI / lint (pull_request) Successful in 37s
CI / typecheck (pull_request) Failing after 1m6s
CI / quality (pull_request) Successful in 58s
CI / security (pull_request) Successful in 1m19s
CI / build (pull_request) Successful in 45s
CI / helm (pull_request) Successful in 48s
CI / unit_tests (pull_request) Failing after 5m36s
CI / coverage (pull_request) Has been skipped
CI / docker (pull_request) Has been skipped
CI / integration_tests (pull_request) Successful in 9m34s
CI / status-check (pull_request) Failing after 3s
2026-06-17 13:53:24 -04:00
controller-ci-rerun 831bace36e chore: re-trigger CI [controller] 2026-06-17 13:53:24 -04:00
HAL9000 fffc04190f fix(tui): use ShellSafetyService regex patterns in looks_dangerous()
Replace naive substring matching in shell_exec.looks_dangerous() with
regex-based ShellSafetyService to prevent bypass via spacing variations.

- Use ShellSafetyService for danger detection instead of looks_dangerous()
- Update confirm_dangerous callback to receive DangerousCommandWarning
- Add BDD scenarios for spacing-variant dangerous commands
- Deprecate looks_dangerous() function for backward compatibility

Closes #8466
2026-06-17 13:53:24 -04:00