feat(resource): add fs-mount and fs-file resource types #1062

Closed
hamza.khyari wants to merge 1 commit from feature/fs-mount-file-types into master
Member

Summary

Registers fs-mount and fs-file in BUILTIN_TYPES bootstrap. Both types were defined in BUILTIN_NAMES and had YAML configs but were never registered.

Types

  • fs-mount -- Top-level mount point (user-addable, copy_on_write, auto-discovery scan_depth: 1)
  • fs-file -- Leaf file node (auto-discovered from fs-directory, content hash for equivalence)

Changes

  • Added type dicts to _resource_registry_data.py:_GIT_FS_CONTAINER_TYPES
  • Updated fs-directory.parent_types to include fs-mount
  • 12 Behave scenarios + 3 Robot tests
  • Updated service docstring, CHANGELOG

ISSUES CLOSED: #833

## Summary Registers `fs-mount` and `fs-file` in `BUILTIN_TYPES` bootstrap. Both types were defined in `BUILTIN_NAMES` and had YAML configs but were never registered. ## Types - `fs-mount` -- Top-level mount point (user-addable, `copy_on_write`, auto-discovery `scan_depth: 1`) - `fs-file` -- Leaf file node (auto-discovered from `fs-directory`, content hash for equivalence) ## Changes - Added type dicts to `_resource_registry_data.py:_GIT_FS_CONTAINER_TYPES` - Updated `fs-directory.parent_types` to include `fs-mount` - 12 Behave scenarios + 3 Robot tests - Updated service docstring, CHANGELOG ISSUES CLOSED: #833
feat(resource): add fs-mount and fs-file resource types
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 17s
CI / build (pull_request) Successful in 29s
CI / quality (pull_request) Successful in 38s
CI / typecheck (pull_request) Successful in 42s
CI / security (pull_request) Successful in 44s
CI / unit_tests (pull_request) Successful in 3m10s
CI / integration_tests (pull_request) Successful in 3m48s
CI / docker (pull_request) Successful in 1m0s
CI / e2e_tests (pull_request) Successful in 4m54s
CI / coverage (pull_request) Successful in 7m52s
CI / benchmark-regression (pull_request) Successful in 37m29s
b00e12d741
Register fs-mount and fs-file in BUILTIN_TYPES bootstrap. Both types
were defined in BUILTIN_NAMES and had YAML configs but were never
registered, causing them to be absent from the resource registry.

- fs-mount: top-level mount point, user-addable, copy_on_write sandbox,
  auto-discovery with scan_depth=1, children: fs-directory
- fs-file: leaf file node, auto-discovered from fs-directory, not
  user-addable, copy_on_write sandbox, content hash for equivalence
- Updated fs-directory parent_types to include fs-mount
- 12 Behave BDD scenarios, 3 Robot integration tests

ISSUES CLOSED: #833
freemo added this to the v3.6.0 milestone 2026-03-19 05:28:20 +00:00
Owner

Planning review (Day 42):

  • Missing Type/ label: No Type/ label is set. Based on the title prefix feat(resource), this should have Type/Feature.
  • Merge conflict: This PR is currently not mergeable. Please rebase or resolve conflicts.

Otherwise looks good: milestone set (v3.6.0), closes #833, 2 reviewers assigned (freemo + brent.edwards).

**Planning review (Day 42):** - **Missing Type/ label**: No `Type/` label is set. Based on the title prefix `feat(resource)`, this should have `Type/Feature`. - **Merge conflict**: This PR is currently not mergeable. Please rebase or resolve conflicts. Otherwise looks good: milestone set (v3.6.0), closes #833, 2 reviewers assigned (freemo + brent.edwards).
Owner

Day 43 Review — Rebase Required

This PR has merge conflicts with master and cannot be merged in its current state. This is one of 9 Hamza PRs in the resource/LSP domain (v3.5.0-v3.6.0) that all have conflicts. These PRs likely share a common dependency chain and should be rebased sequentially.

@hamza.khyari: Please rebase onto current master. If multiple PRs depend on each other, start with the base PR in the chain and work upward.

Rebase priority: HIGH — these PRs represent significant feature work that is blocked by merge conflicts. Every day they remain conflicted is a day they cannot be reviewed or merged.

**Day 43 Review — Rebase Required** This PR has merge conflicts with `master` and cannot be merged in its current state. This is one of 9 Hamza PRs in the resource/LSP domain (v3.5.0-v3.6.0) that all have conflicts. These PRs likely share a common dependency chain and should be rebased sequentially. @hamza.khyari: Please rebase onto current `master`. If multiple PRs depend on each other, start with the base PR in the chain and work upward. **Rebase priority**: HIGH — these PRs represent significant feature work that is blocked by merge conflicts. Every day they remain conflicted is a day they cannot be reviewed or merged.
freemo self-assigned this 2026-04-02 06:15:20 +00:00
Owner

🤖 Backlog Groomer (groomer-1): Closing as duplicate of #833.

Issue #833 (feat(resource): add fs-mount and fs-file resource types) is the canonical version with full labels (MoSCoW/Should have, Priority/Medium, State/In Review, Type/Feature) and milestone v3.6.0. This issue is an exact title duplicate.

🤖 **Backlog Groomer (groomer-1):** Closing as duplicate of #833. Issue #833 (`feat(resource): add fs-mount and fs-file resource types`) is the canonical version with full labels (`MoSCoW/Should have`, `Priority/Medium`, `State/In Review`, `Type/Feature`) and milestone `v3.6.0`. This issue is an exact title duplicate.
freemo closed this pull request 2026-04-02 17:31:10 +00:00
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 17s
Required
Details
CI / build (pull_request) Successful in 29s
Required
Details
CI / quality (pull_request) Successful in 38s
Required
Details
CI / typecheck (pull_request) Successful in 42s
Required
Details
CI / security (pull_request) Successful in 44s
Required
Details
CI / unit_tests (pull_request) Successful in 3m10s
Required
Details
CI / integration_tests (pull_request) Successful in 3m48s
Required
Details
CI / docker (pull_request) Successful in 1m0s
Required
Details
CI / e2e_tests (pull_request) Successful in 4m54s
CI / coverage (pull_request) Successful in 7m52s
Required
Details
CI / benchmark-regression (pull_request) Successful in 37m29s

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!1062
No description provided.