feat(context): implement ContextStrategy protocol and plugin registration system #10590

Merged
HAL9000 merged 5 commits from feat/v3.6.0-context-strategy-protocol into master 2026-06-14 11:50:01 +00:00

5 Commits

Author SHA1 Message Date
HAL9000 65a01544bc fix(changelog): merge duplicate ### Added sections in [Unreleased]
CI / lint (pull_request) Successful in 43s
CI / build (pull_request) Successful in 41s
CI / helm (pull_request) Successful in 47s
CI / typecheck (pull_request) Successful in 59s
CI / push-validation (pull_request) Successful in 29s
CI / quality (pull_request) Successful in 1m1s
CI / security (pull_request) Successful in 1m21s
CI / unit_tests (pull_request) Successful in 4m56s
CI / docker (pull_request) Successful in 1m32s
CI / integration_tests (pull_request) Successful in 10m0s
CI / coverage (pull_request) Successful in 9m16s
CI / status-check (pull_request) Successful in 3s
2026-06-14 07:35:03 -04:00
HAL9000 c2c7e75205 fix(context): resolve PR #10590 review blockers and compliance items
- Remove unused TYPE_CHECKING imports (DomainContextStrategy, StrategyCapabilities) from acms_service.py — they are only referenced in docstrings, not type annotations, causing F401 lint errors. This resolves the lint failure that was introduced by the prior commit b5b08e25's attempt to move them into the TYPE_CHECKING block.
- Fix line-length violation (E501) on StrategyCapabilities docstring — shortened :mod: directive reference to fit 88-char limit.

ISSUES CLOSED: #10590
2026-06-14 07:35:03 -04:00
HAL9000 2172344440 fix(context): resolve PR #10590 review blockers and compliance items
- Move DomainContextStrategy / DomainStrategyCapabilities to TYPE_CHECKING block in acms_service.py (lint F401)
- Deduplicate CHANGELOG.md ### Added sections under [Unreleased]
- Remove duplicate CONTRIBUTORS.md entry for ContextStrategy feature
- Ensure security scan compatibility

ISSUES CLOSED: #8616, #10590
2026-06-14 07:35:03 -04:00
HAL9000 414e3622ad docs: add CHANGELOG and CONTRIBUTORS entries for ContextStrategy system (PR #10590)
- Add CHANGELOG entry under [Unreleased] Added section documenting the
  ContextStrategy protocol, six built-in strategies, StrategyRegistry,
  and 77 Behave test scenarios.
- Update CONTRIBUTORS.md with HAL 9000's contribution for PR #10590.

ISSUES CLOSED: #10590
2026-06-14 07:35:03 -04:00
HAL9000 fd3c075c10 fix(context): finalize PR #10590 compliance checklist items
Implement all missing compliance requirements for PR #10590 (ContextStrategy
protocol and StrategyRegistry plugin registration system) as required by the
implementation-pool-supervisor mandatory PR compliance checklist:

[ ] 1. CHANGELOG.md — add entry under [Unreleased] section: DONE
[✓] Added changelog entry documenting ContextStrategy protocol, StrategyRegistry,
    six built-in strategies, and BDD test coverage (#8616, Epic #8505)

[ ] 2. CONTRIBUTORS.md — add or update contribution entry: DONE
[✓] Added HAL 9000 contribution note for the full ContextStrategy feature impl

[ ] 3. Commit footer — include ISSUES CLOSED reference: DONE
[✓] Footer includes ISSUES CLOSED: #8616

[ ] 4. CI passes — all quality gates and tests green before requesting review: PARTIAL
[✓] Added timeout-minutes (30/45min) to unit_tests and integration_tests jobs
    to prevent OOM timeouts that were blocking CI

[ ] 5. BDD/Behave tests — added or updated for the changed behaviour: DONE (pre-existing)
[✓] Comprehensive test suite in features/context_strategy_registry.feature
    (589 lines, 60+ scenarios covering protocol, registry, backends, thread safety)

[✓] 6. Epic reference — PR description references parent Epic issue number: PRE-EXISTING
[✓] PR body and commit message both reference Epic #8505

[ ] 7. Labels — applied via forgejo-label-manager: DONE (pre-existing)
[✓] State/In Review, Priority/High, MoSCoW/Must have, Type/Feature

[ ] 8. Milestone — PR assigned to earliest open matching milestone: PRE-EXISTING
[✓] v3.6.0 (M7): Advanced Concepts & Deferred Features

Additionally addresses the protocol API mismatch blocking review findings:
- Import and document DomainContextStrategy alongside pipeline-compatible Protocol
- Add backward-compat re-exports for existing code importing from acms_service

ISSUES CLOSED: #8616
2026-06-14 07:35:01 -04:00